58143 2011-04-08 08:54:22 -0700 PerformanceTiming returns inconsistent values when timing is null. 2011-04-11 13:46:00 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 vsevik webkit-unassigned caseq commit-queue eric jamesr pfeldman simonjam tonyg oldest_to_newest 382261 0 vsevik 2011-04-08 08:54:22 -0700 PerformanceTiming returns inconsistent values when timing is null. 382573 1 88876 vsevik 2011-04-08 14:53:28 -0700 Created attachment 88876 Patch 382945 2 88876 eric 2011-04-10 15:42:48 -0700 Comment on attachment 88876 Patch How do we test this? 382971 3 vsevik 2011-04-10 17:20:02 -0700 This is tested in fast/dom/webtiming*.html layout tests. After landing of http://codereview.chromium.org/6823006/ these tests would fail, unless this patch is also landed. 382974 4 eric 2011-04-10 17:35:12 -0700 (In reply to comment #3) > This is tested in fast/dom/webtiming*.html layout tests. > After landing of http://codereview.chromium.org/6823006/ these tests would fail, unless this patch is also landed. Ideally the ChagneLog would contain this information. :) 383036 5 88876 pfeldman 2011-04-10 23:04:33 -0700 Comment on attachment 88876 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88876&action=review > Source/WebCore/page/PerformanceTiming.cpp:264 > + return requestStart(); You probably should do the same for the secureConnection timers above and for the responseEnd below. 383249 6 88876 vsevik 2011-04-11 10:33:59 -0700 Comment on attachment 88876 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88876&action=review >> Source/WebCore/page/PerformanceTiming.cpp:264 >> + return requestStart(); > > You probably should do the same for the secureConnection timers above and for the responseEnd below. secureConnection: "If this attribute is available but HTTPS is not used, this attribute must return zero.", so zero is correct. respondEnd is filled from documentLoadTiming, not resourceLoadTiming, so its value is correct as well. 383268 7 tonyg 2011-04-11 10:46:23 -0700 Thanks for taking care of this. 383453 8 commit-queue 2011-04-11 13:43:15 -0700 The commit-queue encountered the following flaky tests while processing attachment 88876: fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org) The commit-queue is continuing to process your patch. 383458 9 88876 commit-queue 2011-04-11 13:45:55 -0700 Comment on attachment 88876 Patch Clearing flags on attachment: 88876 Committed r83491: <http://trac.webkit.org/changeset/83491> 383460 10 commit-queue 2011-04-11 13:46:00 -0700 All reviewed patches have been landed. Closing bug. 88876 2011-04-08 14:53:28 -0700 2011-04-11 13:45:55 -0700 Patch timing text/plain 3986 vsevik ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjODI0YzAzLi5hMmNhYmFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTEtMDQtMDggIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGVyZm9ybWFu Y2VUaW1pbmcgcmV0dXJucyBpbmNvbnNpc3RlbnQgdmFsdWVzIHdoZW4gdGltaW5nIGlzIG51bGwu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODE0Mwor CisgICAgICAgIE1hZGUgUGVyZm9ybWFuY2VUaW1pbmcgcmV0dXJuZWQgdmFsdWVzIGNvbnNpc3Rl bnQgd2hlbiB0aGVyZSBpcyBubyB0aW1pbmcgb2JqZWN0LgorCisgICAgICAgICogcGFnZS9QZXJm b3JtYW5jZVRpbWluZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQZXJmb3JtYW5jZVRpbWluZzo6 ZG9tYWluTG9va3VwU3RhcnQpOgorICAgICAgICAoV2ViQ29yZTo6UGVyZm9ybWFuY2VUaW1pbmc6 OmRvbWFpbkxvb2t1cEVuZCk6CisgICAgICAgIChXZWJDb3JlOjpQZXJmb3JtYW5jZVRpbWluZzo6 Y29ubmVjdFN0YXJ0KToKKyAgICAgICAgKFdlYkNvcmU6OlBlcmZvcm1hbmNlVGltaW5nOjpjb25u ZWN0RW5kKToKKyAgICAgICAgKFdlYkNvcmU6OlBlcmZvcm1hbmNlVGltaW5nOjpyZXF1ZXN0U3Rh cnQpOgorICAgICAgICAoV2ViQ29yZTo6UGVyZm9ybWFuY2VUaW1pbmc6OnJlc3BvbnNlU3RhcnQp OgorICAgICAgICAoV2ViQ29yZTo6UGVyZm9ybWFuY2VUaW1pbmc6OmRvbUxvYWRpbmcpOgorCiAy MDExLTA0LTA2ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGFnZS9QZXJmb3JtYW5jZVRpbWluZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1Bl cmZvcm1hbmNlVGltaW5nLmNwcAppbmRleCA1NmQ2YWE5Li5mMTdlNzcxIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlVGltaW5nLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL1BlcmZvcm1hbmNlVGltaW5nLmNwcApAQCAtMTYxLDcgKzE2MSw3IEBAIHVuc2ln bmVkIGxvbmcgbG9uZyBQZXJmb3JtYW5jZVRpbWluZzo6ZG9tYWluTG9va3VwU3RhcnQoKSBjb25z dAogewogICAgIFJlc291cmNlTG9hZFRpbWluZyogdGltaW5nID0gcmVzb3VyY2VMb2FkVGltaW5n KCk7CiAgICAgaWYgKCF0aW1pbmcpCi0gICAgICAgIHJldHVybiAwOworICAgICAgICByZXR1cm4g ZmV0Y2hTdGFydCgpOwogCiAgICAgLy8gVGhpcyB3aWxsIGJlIC0xIHdoZW4gYSBETlMgcmVxdWVz dCBpcyBub3QgcGVyZm9ybWVkLgogICAgIC8vIFJhdGhlciB0aGFuIGV4cG9zaW5nIGEgc3BlY2lh bCB2YWx1ZSB0aGF0IGluZGljYXRlcyBubyBETlMsIHdlICJiYWNrZmlsbCIgd2l0aCBmZXRjaFN0 YXJ0LgpAQCAtMTc2LDcgKzE3Niw3IEBAIHVuc2lnbmVkIGxvbmcgbG9uZyBQZXJmb3JtYW5jZVRp bWluZzo6ZG9tYWluTG9va3VwRW5kKCkgY29uc3QKIHsKICAgICBSZXNvdXJjZUxvYWRUaW1pbmcq IHRpbWluZyA9IHJlc291cmNlTG9hZFRpbWluZygpOwogICAgIGlmICghdGltaW5nKQotICAgICAg ICByZXR1cm4gMDsKKyAgICAgICAgcmV0dXJuIGRvbWFpbkxvb2t1cFN0YXJ0KCk7CiAKICAgICAv LyBUaGlzIHdpbGwgYmUgLTEgd2hlbiBhIEROUyByZXF1ZXN0IGlzIG5vdCBwZXJmb3JtZWQuCiAg ICAgLy8gUmF0aGVyIHRoYW4gZXhwb3NpbmcgYSBzcGVjaWFsIHZhbHVlIHRoYXQgaW5kaWNhdGVz IG5vIEROUywgd2UgImJhY2tmaWxsIiB3aXRoIGRvbWFpbkxvb2t1cFN0YXJ0LgpAQCAtMTkxLDEx ICsxOTEsMTEgQEAgdW5zaWduZWQgbG9uZyBsb25nIFBlcmZvcm1hbmNlVGltaW5nOjpjb25uZWN0 U3RhcnQoKSBjb25zdAogewogICAgIERvY3VtZW50TG9hZGVyKiBsb2FkZXIgPSBkb2N1bWVudExv YWRlcigpOwogICAgIGlmICghbG9hZGVyKQotICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgcmV0 dXJuIGRvbWFpbkxvb2t1cEVuZCgpOwogCiAgICAgUmVzb3VyY2VMb2FkVGltaW5nKiB0aW1pbmcg PSBsb2FkZXItPnJlc3BvbnNlKCkucmVzb3VyY2VMb2FkVGltaW5nKCk7CiAgICAgaWYgKCF0aW1p bmcpCi0gICAgICAgIHJldHVybiAwOworICAgICAgICByZXR1cm4gZG9tYWluTG9va3VwRW5kKCk7 CiAKICAgICAvLyBjb25uZWN0U3RhcnQgd2lsbCBiZSAtMSB3aGVuIGEgbmV0d29yayByZXF1ZXN0 IGlzIG5vdCBtYWRlLgogICAgIC8vIFJhdGhlciB0aGFuIGV4cG9zaW5nIGEgc3BlY2lhbCB2YWx1 ZSB0aGF0IGluZGljYXRlcyBubyBuZXcgY29ubmVjdGlvbiwgd2UgImJhY2tmaWxsIiB3aXRoIGRv bWFpbkxvb2t1cEVuZC4KQEAgLTIxNSwxMSArMjE1LDExIEBAIHVuc2lnbmVkIGxvbmcgbG9uZyBQ ZXJmb3JtYW5jZVRpbWluZzo6Y29ubmVjdEVuZCgpIGNvbnN0CiB7CiAgICAgRG9jdW1lbnRMb2Fk ZXIqIGxvYWRlciA9IGRvY3VtZW50TG9hZGVyKCk7CiAgICAgaWYgKCFsb2FkZXIpCi0gICAgICAg IHJldHVybiAwOworICAgICAgICByZXR1cm4gY29ubmVjdFN0YXJ0KCk7CiAKICAgICBSZXNvdXJj ZUxvYWRUaW1pbmcqIHRpbWluZyA9IGxvYWRlci0+cmVzcG9uc2UoKS5yZXNvdXJjZUxvYWRUaW1p bmcoKTsKICAgICBpZiAoIXRpbWluZykKLSAgICAgICAgcmV0dXJuIDA7CisgICAgICAgIHJldHVy biBjb25uZWN0U3RhcnQoKTsKIAogICAgIC8vIGNvbm5lY3RFbmQgd2lsbCBiZSAtMSB3aGVuIGEg bmV0d29yayByZXF1ZXN0IGlzIG5vdCBtYWRlLgogICAgIC8vIFJhdGhlciB0aGFuIGV4cG9zaW5n IGEgc3BlY2lhbCB2YWx1ZSB0aGF0IGluZGljYXRlcyBubyBuZXcgY29ubmVjdGlvbiwgd2UgImJh Y2tmaWxsIiB3aXRoIGNvbm5lY3RTdGFydC4KQEAgLTI1MSw3ICsyNTEsNyBAQCB1bnNpZ25lZCBs b25nIGxvbmcgUGVyZm9ybWFuY2VUaW1pbmc6OnJlcXVlc3RTdGFydCgpIGNvbnN0CiB7CiAgICAg UmVzb3VyY2VMb2FkVGltaW5nKiB0aW1pbmcgPSByZXNvdXJjZUxvYWRUaW1pbmcoKTsKICAgICBp ZiAoIXRpbWluZykKLSAgICAgICAgcmV0dXJuIDA7CisgICAgICAgIHJldHVybiBjb25uZWN0RW5k KCk7CiAKICAgICBBU1NFUlQodGltaW5nLT5zZW5kU3RhcnQgPj0gMCk7CiAgICAgcmV0dXJuIHJl c291cmNlTG9hZFRpbWVSZWxhdGl2ZVRvQWJzb2x1dGUodGltaW5nLT5zZW5kU3RhcnQpOwpAQCAt MjYxLDcgKzI2MSw3IEBAIHVuc2lnbmVkIGxvbmcgbG9uZyBQZXJmb3JtYW5jZVRpbWluZzo6cmVz cG9uc2VTdGFydCgpIGNvbnN0CiB7CiAgICAgUmVzb3VyY2VMb2FkVGltaW5nKiB0aW1pbmcgPSBy ZXNvdXJjZUxvYWRUaW1pbmcoKTsKICAgICBpZiAoIXRpbWluZykKLSAgICAgICAgcmV0dXJuIDA7 CisgICAgICAgIHJldHVybiByZXF1ZXN0U3RhcnQoKTsKIAogICAgIC8vIEZJWE1FOiBSZXNwb25z ZSBzdGFydCBuZWVkcyB0byBiZSB0aGUgdGltZSBvZiB0aGUgZmlyc3QgcmVjZWl2ZWQgYnl0ZS4K ICAgICAvLyBIb3dldmVyLCB0aGUgUmVzb3VyY2VMb2FkVGltaW5nIEFQSSBjdXJyZW50bHkgb25s eSBzdXBwb3J0cyB0aGUgdGltZQpAQCAtMjg2LDcgKzI4Niw3IEBAIHVuc2lnbmVkIGxvbmcgbG9u ZyBQZXJmb3JtYW5jZVRpbWluZzo6ZG9tTG9hZGluZygpIGNvbnN0CiB7CiAgICAgY29uc3QgRG9j dW1lbnRUaW1pbmcqIHRpbWluZyA9IGRvY3VtZW50VGltaW5nKCk7CiAgICAgaWYgKCF0aW1pbmcp Ci0gICAgICAgIHJldHVybiAwOworICAgICAgICByZXR1cm4gZmV0Y2hTdGFydCgpOwogCiAgICAg cmV0dXJuIHRvSW50ZWdlck1pbGxpc2Vjb25kcyh0aW1pbmctPmRvbUxvYWRpbmcpOwogfQo=