58030 2011-04-07 05:07:08 -0700 [WK2][Qt][GTK] Introduce common use flag for the shared UNIX domain socket IPC implementation 2011-04-08 10:53:24 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 49791 1 kbalazs webkit-unassigned abarth abecsi benjamin eric kenneth webkit.review.bot zoltan oldest_to_newest 381239 0 kbalazs 2011-04-07 05:07:08 -0700 A common flag would be more readable then using "PLATFORM(QT) || PLATFORM(GTK)" everywhere in the IPC code. Furthermore it would be useful if a new platform would like to use the infrastructure. 381240 1 benjamin 2011-04-07 05:09:27 -0700 I like the idea. The keyword "Unix" is not gonna do the trick since Mac OS X is also Unix. :( So maybe a keyword by the type of IPC used? 381243 2 kenneth 2011-04-07 05:15:44 -0700 Mac is Unix, and doesn't this work for Mac as well? Mac is just a specialization of Unix which has another more platform close implementation 381247 3 zoltan 2011-04-07 05:27:20 -0700 Does it make sense to use OS(LINUX)? 381254 4 kbalazs 2011-04-07 05:45:38 -0700 (In reply to comment #3) > Does it make sense to use OS(LINUX)? It's too restrictive. I think it works on most of the OS-s that is in the group of OS(UNIX) (in Platform.h) - at least on Linux+*BSD+Mac. 381257 5 88613 kbalazs 2011-04-07 05:54:53 -0700 Created attachment 88613 Patch Note: the define has been placed in Platform.h instead of WebKit2/config.h because in the final build step the include order is broken and we pick up WebCore's config.h even for the WebKit2 API files. Annoying bug but I do not see any solution for that. 381269 6 88613 kenneth 2011-04-07 06:12:00 -0700 Comment on attachment 88613 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88613&action=review > Source/JavaScriptCore/wtf/Platform.h:1199 > +// This one is for WebKit2. Strange comment; I would just remove it 381271 7 abecsi 2011-04-07 06:12:33 -0700 (In reply to comment #5) > Note: the define has been placed in Platform.h instead of WebKit2/config.h because in the final build step the include order is broken and we pick up WebCore's config.h even for the WebKit2 API files. Annoying bug but I do not see any solution for that. One solution would be to change the config.h includes to WebKit2/config.h and WebCore/config.h respectively. 381376 8 kbalazs 2011-04-07 08:49:23 -0700 (In reply to comment #7) > (In reply to comment #5) > > Note: the define has been placed in Platform.h instead of WebKit2/config.h because in the final build step the include order is broken and we pick up WebCore's config.h even for the WebKit2 API files. Annoying bug but I do not see any solution for that. > > One solution would be to change the config.h includes to WebKit2/config.h and WebCore/config.h respectively. Or rename each config.h to represent the component that it belongs to. (i.e. WebCoreConfig.h, WebKit2Config.h, ...). The problem is that it would require a huge change and furthermore I guess not everybody would like that style. 381380 9 kbalazs 2011-04-07 08:53:08 -0700 (In reply to comment #6) > (From update of attachment 88613 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=88613&action=review > > > Source/JavaScriptCore/wtf/Platform.h:1199 > > +// This one is for WebKit2. > > Strange comment; I would just remove it I will do it on commit. However I forget to set the dependency. We need to wait for the GTK SharedMemory patch to be landed first. 381853 10 88613 mrobinson 2011-04-07 16:58:13 -0700 Comment on attachment 88613 Patch Thanks for cleaning this up! 382326 11 kbalazs 2011-04-08 10:05:26 -0700 Committed r83307: <http://trac.webkit.org/changeset/83307> 382379 12 webkit.review.bot 2011-04-08 10:53:24 -0700 http://trac.webkit.org/changeset/83307 might have broken Qt Linux Release The following tests are not passing: editing/selection/5354455-1.html editing/selection/5354455-2.html editing/selection/button-right-click.html editing/selection/context-menu-on-text.html editing/selection/context-menu-text-selection.html editing/selection/empty-cell-right-click.html fast/events/context-onmousedown-event.html fast/events/contextmenu-scrolled-page-with-frame.html fast/events/right-click-focus.html svg/custom/use-events-crash.svg 88613 2011-04-07 05:54:53 -0700 2011-04-08 10:09:05 -0700 Patch bug-58030-20110407125451.patch text/plain 5781 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogODMwMzgKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDFi MzhkODllMGRlNzY3OWI3ODM0ZDdmY2VhNTIyYWJkOWUyMWE0ZjAuLjIzODBmM2ZmMzYyNWNlMWU2 NzM5MmIzMTc3MTcyOTcxMjk1YTliOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDExLTA0LTA3ICBCYWxhenMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbV0sy XVtRdF1bR1RLXSBJbnRyb2R1Y2UgY29tbW9uIHVzZSBmbGFnIGZvciB0aGUgc2hhcmVkIFVOSVgg ZG9tYWluIHNvY2tldCBJUEMgaW1wbGVtZW50YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4MDMwCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0u aDogSW50cm9kdWNlIFVTRShVTklYX0RPTUFJTl9TT0NLRVRTKSBmb3IgV2ViS2l0Mi4KKwogMjAx MS0wNC0wNSAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFRy eSB0byBmaXggdGhlIFdpbmRvd3MgYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvd3RmL1BsYXRmb3JtLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3Jt LmgKaW5kZXggZTQwYjFhNmRmMzkzNTIzNTViYWQ1YzE2OTg5ZjZhNGEwYWViOTFlYS4uYzQ5NTg3 MmRhNzgzMzQwYjRkNThmZjJmZWRmZDg4ZGE1YjE0OTAwMiAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93 dGYvUGxhdGZvcm0uaApAQCAtMTE5Niw0ICsxMTk2LDkgQEAKICAgIGJyZWFrYWdlcyBvbmUgcG9y dCBhdCBhIHRpbWUuICovCiAjZGVmaW5lIFdURl9VU0VfRVhQT1JUX01BQ1JPUyAwCiAKKy8vIFRo aXMgb25lIGlzIGZvciBXZWJLaXQyLgorI2lmIFBMQVRGT1JNKFFUKSB8fCBQTEFURk9STShHVEsp CisjZGVmaW5lIFdURl9VU0VfVU5JWF9ET01BSU5fU09DS0VUUyAxCisjZW5kaWYKKwogI2VuZGlm IC8qIFdURl9QbGF0Zm9ybV9oICovCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzRmMjU5NmEyYTMxMzE1NGRlZjVl ZDIyM2ZmN2U2OWE5OTkyYzgxZi4uODBiMDBlZWY4MzQyNDVlZTFjMDhkNzhlNjEwZDcyMDNmZGJi ZTFhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDExLTA0LTA3ICBCYWxhenMgS2Vs ZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbV0syXVtRdF1bR1RLXSBJbnRyb2R1Y2UgY29tbW9uIHVzZSBm bGFnIGZvciB0aGUgc2hhcmVkIFVOSVggZG9tYWluIHNvY2tldCBJUEMgaW1wbGVtZW50YXRpb24K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4MDMwCisK KyAgICAgICAgUmVwbGFjZSAiUExBVEZPUk0oUVQpIHx8IFBMQVRGT1JNKEdUSykiIGNvbmRpdGlv bnMgaW4gSVBDIGNvZGUgd2l0aAorICAgICAgICBVU0UoVU5JWF9ET01BSU5fU09DS0VUUykuCisK KyAgICAgICAgKiBQbGF0Zm9ybS9Db3JlSVBDL0F0dGFjaG1lbnQuaDoKKyAgICAgICAgKiBQbGF0 Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uaDoKKyAgICAgICAgKiBQbGF0Zm9ybS9TaGFyZWRNZW1v cnkuaDoKKwogMjAxMS0wNC0wNiAgIEFtcnV0aCBSYWogIDxhbXJ1dGhyYWpAbW90b3JvbGEuY29t PiBhbmQgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0F0dGFjaG1lbnQuaCBiL1NvdXJjZS9XZWJLaXQy L1BsYXRmb3JtL0NvcmVJUEMvQXR0YWNobWVudC5oCmluZGV4IDAyZWQyMTk1M2Y3MzJlZmUwZGEx Njg3OTJkZmIxYmRkMWMzYmExODAuLjgwNjBjNjRhNzZhNTU1MWM0M2E5YTJjZTQzOTg4N2Q1OTlm YmQ2ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQXR0YWNo bWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQXR0YWNobWVudC5o CkBAIC0zOSw4ICszOSw4IEBAIHB1YmxpYzoKICAgICAgICAgVW5pbml0aWFsaXplZCwKICNpZiBQ TEFURk9STShNQUMpCiAgICAgICAgIE1hY2hQb3J0VHlwZSwKLSAgICAgICAgTWFjaE9PTE1lbW9y eVR5cGUKLSNlbGlmIFBMQVRGT1JNKFFUKSB8fCBQTEFURk9STShHVEspCisgICAgICAgIE1hY2hP T0xNZW1vcnlUeXBlLAorI2VsaWYgVVNFKFVOSVhfRE9NQUlOX1NPQ0tFVFMpCiAgICAgICAgIE1h cHBlZE1lbW9yeQogI2VuZGlmCiAgICAgfTsKQEAgLTQ4LDcgKzQ4LDcgQEAgcHVibGljOgogI2lm IFBMQVRGT1JNKE1BQykKICAgICBBdHRhY2htZW50KG1hY2hfcG9ydF9uYW1lX3QgcG9ydCwgbWFj aF9tc2dfdHlwZV9uYW1lX3QgZGlzcG9zaXRpb24pOwogICAgIEF0dGFjaG1lbnQodm9pZCogYWRk cmVzcywgbWFjaF9tc2dfc2l6ZV90IHNpemUsIG1hY2hfbXNnX2NvcHlfb3B0aW9uc190IGNvcHlP cHRpb25zLCBib29sIGRlYWxsb2NhdGUpOwotI2VsaWYgUExBVEZPUk0oUVQpIHx8IFBMQVRGT1JN KEdUSykKKyNlbGlmIFVTRShVTklYX0RPTUFJTl9TT0NLRVRTKQogICAgIEF0dGFjaG1lbnQoaW50 IGZpbGVEZXNjcmlwdG9yLCBzaXplX3QpOwogI2VuZGlmCiAKQEAgLTY2LDcgKzY2LDcgQEAgcHVi bGljOgogICAgIG1hY2hfbXNnX3NpemVfdCBzaXplKCkgY29uc3QgeyBBU1NFUlQobV90eXBlID09 IE1hY2hPT0xNZW1vcnlUeXBlKTsgcmV0dXJuIG1fb29sTWVtb3J5LnNpemU7IH0KICAgICBtYWNo X21zZ19jb3B5X29wdGlvbnNfdCBjb3B5T3B0aW9ucygpIGNvbnN0IHsgQVNTRVJUKG1fdHlwZSA9 PSBNYWNoT09MTWVtb3J5VHlwZSk7IHJldHVybiBtX29vbE1lbW9yeS5jb3B5T3B0aW9uczsgfQog ICAgIGJvb2wgZGVhbGxvY2F0ZSgpIGNvbnN0IHsgQVNTRVJUKG1fdHlwZSA9PSBNYWNoT09MTWVt b3J5VHlwZSk7IHJldHVybiBtX29vbE1lbW9yeS5kZWFsbG9jYXRlOyB9Ci0jZWxpZiBQTEFURk9S TShRVCkgfHwgUExBVEZPUk0oR1RLKQorI2VsaWYgVVNFKFVOSVhfRE9NQUlOX1NPQ0tFVFMpCiAg ICAgc2l6ZV90IHNpemUoKSBjb25zdCB7IHJldHVybiBtX3NpemU7IH0KIAogICAgIGludCByZWxl YXNlRmlsZURlc2NyaXB0b3IoKSB7IGludCB0ZW1wID0gbV9maWxlRGVzY3JpcHRvcjsgbV9maWxl RGVzY3JpcHRvciA9IC0xOyByZXR1cm4gdGVtcDsgfQpAQCAtOTQsNyArOTQsNyBAQCBwcml2YXRl OgogICAgICAgICAgICAgYm9vbCBkZWFsbG9jYXRlOwogICAgICAgICB9IG1fb29sTWVtb3J5Owog ICAgIH07Ci0jZWxpZiBQTEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RLKQorI2VsaWYgVVNFKFVO SVhfRE9NQUlOX1NPQ0tFVFMpCiAgICAgaW50IG1fZmlsZURlc2NyaXB0b3I7CiAgICAgc2l6ZV90 IG1fc2l6ZTsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29y ZUlQQy9Db25uZWN0aW9uLmggYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5l Y3Rpb24uaAppbmRleCA4M2EyODc3MGJiZTQxNjY5YWNlMTg5ZDk5MzBjOTViMDM5MWRiYWQzLi45 ZWFkZjdlOWIxNmRkYjAwZDk2NzZkMmE1MDM0NzdlNDQ0MjMyYjc0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uaAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uaApAQCAtOTgsOSArOTgsNyBAQCBwdWJs aWM6CiAjZWxpZiBQTEFURk9STShXSU4pCiAgICAgdHlwZWRlZiBIQU5ETEUgSWRlbnRpZmllcjsK ICAgICBzdGF0aWMgYm9vbCBjcmVhdGVTZXJ2ZXJBbmRDbGllbnRJZGVudGlmaWVycyhJZGVudGlm aWVyJiBzZXJ2ZXJJZGVudGlmaWVyLCBJZGVudGlmaWVyJiBjbGllbnRJZGVudGlmaWVyKTsKLSNl bGlmIFBMQVRGT1JNKFFUKQotICAgIHR5cGVkZWYgaW50IElkZW50aWZpZXI7Ci0jZWxpZiBQTEFU Rk9STShHVEspCisjZWxpZiBVU0UoVU5JWF9ET01BSU5fU09DS0VUUykKICAgICB0eXBlZGVmIGlu dCBJZGVudGlmaWVyOwogI2VuZGlmCiAKQEAgLTMwNSw3ICszMDMsNyBAQCBwcml2YXRlOgogICAg IE93blB0cjxBcmd1bWVudEVuY29kZXI+IG1fcGVuZGluZ1dyaXRlQXJndW1lbnRzOwogICAgIE9W RVJMQVBQRUQgbV93cml0ZVN0YXRlOwogICAgIEhBTkRMRSBtX2Nvbm5lY3Rpb25QaXBlOwotI2Vs aWYgUExBVEZPUk0oUVQpIHx8IFBMQVRGT1JNKEdUSykKKyNlbGlmIFVTRShVTklYX0RPTUFJTl9T T0NLRVRTKQogICAgIC8vIENhbGxlZCBvbiB0aGUgY29ubmVjdGlvbiBxdWV1ZS4KICAgICB2b2lk IHJlYWR5UmVhZEhhbmRsZXIoKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZv cm0vU2hhcmVkTWVtb3J5LmggYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9TaGFyZWRNZW1vcnku aAppbmRleCAyM2IzMzExNDIwN2UzMzAwZWUwYjhmODI0ZjM3MWI0YzQxMjVkZTJhLi5iMjQyYjli ZmVlY2QzMzFmYmM0NjY1MzZkNjBjOWI0ZjAwNWNkNGYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9QbGF0Zm9ybS9TaGFyZWRNZW1vcnkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9y bS9TaGFyZWRNZW1vcnkuaApAQCAtNjAsNyArNjAsNyBAQCBwdWJsaWM6CiAgICAgICAgIHZvaWQg ZW5jb2RlKENvcmVJUEM6OkFyZ3VtZW50RW5jb2RlciopIGNvbnN0OwogICAgICAgICBzdGF0aWMg Ym9vbCBkZWNvZGUoQ29yZUlQQzo6QXJndW1lbnREZWNvZGVyKiwgSGFuZGxlJik7CiAKLSNpZiBQ TEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RLKQorI2lmIFVTRShVTklYX0RPTUFJTl9TT0NLRVRT KQogICAgICAgICBDb3JlSVBDOjpBdHRhY2htZW50IHJlbGVhc2VUb0F0dGFjaG1lbnQoKSBjb25z dDsKICAgICAgICAgdm9pZCBhZG9wdEZyb21BdHRhY2htZW50KGludCBmaWxlRGVzY3JpcHRvciwg c2l6ZV90KTsKICNlbmRpZgpAQCAtNzAsNyArNzAsNyBAQCBwdWJsaWM6CiAgICAgICAgIG11dGFi bGUgbWFjaF9wb3J0X3QgbV9wb3J0OwogI2VsaWYgUExBVEZPUk0oV0lOKQogICAgICAgICBtdXRh YmxlIEhBTkRMRSBtX2hhbmRsZTsKLSNlbGlmIFBMQVRGT1JNKFFUKSB8fCBQTEFURk9STShHVEsp CisjZWxpZiBVU0UoVU5JWF9ET01BSU5fU09DS0VUUykKICAgICAgICAgbXV0YWJsZSBpbnQgbV9m aWxlRGVzY3JpcHRvcjsKICNlbmRpZgogICAgICAgICBzaXplX3QgbV9zaXplOwpAQCAtMTAzLDcg KzEwMyw3IEBAIHByaXZhdGU6CiAgICAgbWFjaF9wb3J0X3QgbV9wb3J0OwogI2VsaWYgUExBVEZP Uk0oV0lOKQogICAgIEhBTkRMRSBtX2hhbmRsZTsKLSNlbGlmIFBMQVRGT1JNKFFUKSB8fCBQTEFU Rk9STShHVEspCisjZWxpZiBVU0UoVU5JWF9ET01BSU5fU09DS0VUUykKICAgICBpbnQgbV9maWxl RGVzY3JpcHRvcjsKICNlbmRpZgogfTsK