57952 2011-04-06 08:27:47 -0700 ClipboardWin has unused variables "ExceptionCode ec" 2011-04-06 10:19:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Windows XP RESOLVED FIXED P5 Enhancement --- 1 benjamin webkit-unassigned commit-queue oldest_to_newest 380393 0 benjamin 2011-04-06 08:27:47 -0700 While lookint at 19385 I noticed ExceptionCode ec = 0; is never used in the function... 380396 1 88430 benjamin 2011-04-06 08:29:21 -0700 Created attachment 88430 Patch 380397 2 88430 kling 2011-04-06 08:32:03 -0700 Comment on attachment 88430 Patch There are more functions in that file doing this. :3 380401 3 88431 benjamin 2011-04-06 08:35:53 -0700 Created attachment 88431 Patch 380402 4 88432 benjamin 2011-04-06 08:36:46 -0700 Created attachment 88432 Patch Better with a changelog :) 380544 5 commit-queue 2011-04-06 10:16:49 -0700 The commit-queue encountered the following flaky tests while processing attachment 88432: http/tests/loading/basic-credentials-sent-automatically.html bug 57961 (author: beidson@apple.com) The commit-queue is continuing to process your patch. 380549 6 88432 commit-queue 2011-04-06 10:19:50 -0700 Comment on attachment 88432 Patch Clearing flags on attachment: 88432 Committed r83067: <http://trac.webkit.org/changeset/83067> 380550 7 commit-queue 2011-04-06 10:19:54 -0700 All reviewed patches have been landed. Closing bug. 88430 2011-04-06 08:29:21 -0700 2011-04-06 08:35:53 -0700 Patch 57952.diff text/plain 1177 benjamin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlMTQ2Y2QxLi43NjE5YTQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDQtMDYgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lh LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD bGlwYm9hcmRXaW46OmRlY2xhcmVBbmRXcml0ZURyYWdJbWFnZSgpIGFzIGFuIHVudXNlZCB2YXJp YWJsZSBlYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTc5NTIKKworICAgICAgICBSZW1vdmUgdGhlIHVudXNlZCB2YXJpYWJsZS4KKworICAgICAgICAq IHBsYXRmb3JtL3dpbi9DbGlwYm9hcmRXaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2xpcGJv YXJkV2luOjpkZWNsYXJlQW5kV3JpdGVEcmFnSW1hZ2UpOgorCiAyMDExLTA0LTA2ICBQYXZlbCBQ b2Rpdmlsb3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93 aW4vQ2xpcGJvYXJkV2luLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9DbGlwYm9h cmRXaW4uY3BwCmluZGV4IDc5MWVjODYuLmM1MDQzNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3dpbi9DbGlwYm9hcmRXaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL3dpbi9DbGlwYm9hcmRXaW4uY3BwCkBAIC03MDMsNyArNzAzLDYgQEAgdm9pZCBDbGlw Ym9hcmRXaW46OmRlY2xhcmVBbmRXcml0ZURyYWdJbWFnZShFbGVtZW50KiBlbGVtZW50LCBjb25z dCBLVVJMJiB1cmwsIGMKICAgICAgICAgcmV0dXJuOwogICAgIFNUR01FRElVTSBtZWRpdW0gPSB7 MH07CiAgICAgbWVkaXVtLnR5bWVkID0gVFlNRURfSEdMT0JBTDsKLSAgICBFeGNlcHRpb25Db2Rl IGVjID0gMDsKIAogICAgIC8vIFB1dCBpbWcgdGFnIG9uIHRoZSBjbGlwYm9hcmQgcmVmZXJlbmNp bmcgdGhlIGltYWdlCiAgICAgVmVjdG9yPGNoYXI+IGRhdGE7Cg== 88431 2011-04-06 08:35:53 -0700 2011-04-06 08:36:46 -0700 Patch 57952.diff text/plain 1460 benjamin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlMTQ2Y2QxLi5hZTRkMDM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDQtMDYgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lh LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD bGlwYm9hcmRXaW4gaGFzIHVudXNlZCB2YXJpYWJsZXMgIkV4Y2VwdGlvbkNvZGUgZWMiCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Nzk1MgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vd2luL0NsaXBi b2FyZFdpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDbGlwYm9hcmRXaW46OmRlY2xhcmVBbmRX cml0ZURyYWdJbWFnZSk6CisgICAgICAgIChXZWJDb3JlOjpDbGlwYm9hcmRXaW46OndyaXRlUGxh aW5UZXh0KToKKwogMjAxMS0wNC0wNiAgUGF2ZWwgUG9kaXZpbG92ICA8cG9kaXZpbG92QGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0NsaXBib2FyZFdpbi5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ2xpcGJvYXJkV2luLmNwcAppbmRleCA3OTFlYzg2Li4w YjVhM2QzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ2xpcGJvYXJk V2luLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ2xpcGJvYXJkV2luLmNw cApAQCAtNzAzLDcgKzcwMyw2IEBAIHZvaWQgQ2xpcGJvYXJkV2luOjpkZWNsYXJlQW5kV3JpdGVE cmFnSW1hZ2UoRWxlbWVudCogZWxlbWVudCwgY29uc3QgS1VSTCYgdXJsLCBjCiAgICAgICAgIHJl dHVybjsKICAgICBTVEdNRURJVU0gbWVkaXVtID0gezB9OwogICAgIG1lZGl1bS50eW1lZCA9IFRZ TUVEX0hHTE9CQUw7Ci0gICAgRXhjZXB0aW9uQ29kZSBlYyA9IDA7CiAKICAgICAvLyBQdXQgaW1n IHRhZyBvbiB0aGUgY2xpcGJvYXJkIHJlZmVyZW5jaW5nIHRoZSBpbWFnZQogICAgIFZlY3Rvcjxj aGFyPiBkYXRhOwpAQCAtNzkxLDcgKzc5MCw2IEBAIHZvaWQgQ2xpcGJvYXJkV2luOjp3cml0ZVBs YWluVGV4dChjb25zdCBTdHJpbmcmIHRleHQpCiAgICAgCiAgICAgU1RHTUVESVVNIG1lZGl1bSA9 IHswfTsKICAgICBtZWRpdW0udHltZWQgPSBUWU1FRF9IR0xPQkFMOwotICAgIEV4Y2VwdGlvbkNv ZGUgZWMgPSAwOwogICAgIAogICAgIFN0cmluZyBzdHIgPSB0ZXh0OwogICAgIHJlcGxhY2VOZXds aW5lc1dpdGhXaW5kb3dzU3R5bGVOZXdsaW5lcyhzdHIpOwo= 88432 2011-04-06 08:36:46 -0700 2011-04-06 10:19:50 -0700 Patch 57952.diff text/plain 1466 benjamin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlMTQ2Y2QxLi5lMDg0MjMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDQtMDYgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lh LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD bGlwYm9hcmRXaW4gaGFzIHVudXNlZCB2YXJpYWJsZXMgIkV4Y2VwdGlvbkNvZGUgZWMiCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Nzk1MgorCisgICAg ICAgIFJlbW92ZSB0aGUgdW51c2VkIHZhcmlhYmxlLgorCisgICAgICAgICogcGxhdGZvcm0vd2lu L0NsaXBib2FyZFdpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDbGlwYm9hcmRXaW46OmRlY2xh cmVBbmRXcml0ZURyYWdJbWFnZSk6CisgICAgICAgIChXZWJDb3JlOjpDbGlwYm9hcmRXaW46Ondy aXRlUGxhaW5UZXh0KToKKwogMjAxMS0wNC0wNiAgUGF2ZWwgUG9kaXZpbG92ICA8cG9kaXZpbG92 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5Lgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0NsaXBib2FyZFdpbi5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ2xpcGJvYXJkV2luLmNwcAppbmRleCA3OTFl Yzg2Li4wYjVhM2QzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ2xp cGJvYXJkV2luLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ2xpcGJvYXJk V2luLmNwcApAQCAtNzAzLDcgKzcwMyw2IEBAIHZvaWQgQ2xpcGJvYXJkV2luOjpkZWNsYXJlQW5k V3JpdGVEcmFnSW1hZ2UoRWxlbWVudCogZWxlbWVudCwgY29uc3QgS1VSTCYgdXJsLCBjCiAgICAg ICAgIHJldHVybjsKICAgICBTVEdNRURJVU0gbWVkaXVtID0gezB9OwogICAgIG1lZGl1bS50eW1l ZCA9IFRZTUVEX0hHTE9CQUw7Ci0gICAgRXhjZXB0aW9uQ29kZSBlYyA9IDA7CiAKICAgICAvLyBQ dXQgaW1nIHRhZyBvbiB0aGUgY2xpcGJvYXJkIHJlZmVyZW5jaW5nIHRoZSBpbWFnZQogICAgIFZl Y3RvcjxjaGFyPiBkYXRhOwpAQCAtNzkxLDcgKzc5MCw2IEBAIHZvaWQgQ2xpcGJvYXJkV2luOjp3 cml0ZVBsYWluVGV4dChjb25zdCBTdHJpbmcmIHRleHQpCiAgICAgCiAgICAgU1RHTUVESVVNIG1l ZGl1bSA9IHswfTsKICAgICBtZWRpdW0udHltZWQgPSBUWU1FRF9IR0xPQkFMOwotICAgIEV4Y2Vw dGlvbkNvZGUgZWMgPSAwOwogICAgIAogICAgIFN0cmluZyBzdHIgPSB0ZXh0OwogICAgIHJlcGxh Y2VOZXdsaW5lc1dpdGhXaW5kb3dzU3R5bGVOZXdsaW5lcyhzdHIpOwo=