57906 2011-04-05 17:02:21 -0700 Reload after document.write in new window loads wrong page 2011-04-06 17:21:50 -0700 1 1 1 Unclassified WebKit History 528+ (Nightly build) PC OS X 10.5 RESOLVED WONTFIX P2 Normal --- 50331 1 creis webkit-unassigned abarth ap creis darin fishd mihaip oldest_to_newest 379970 0 creis 2011-04-05 17:02:21 -0700 Repro steps: w = window.open(any_url) w.document.write(1) w.location.reload() The reload() results in the *opener's* url being loaded into the child window, instead of any_url. Layout test attached. Note that in debug builds, it also hits the ASSERT in HistoryController::restoreScrollPositionAndViewState, which is being discussed in bug 50331. 380096 1 ap 2011-04-05 21:06:13 -0700 At the moment, there is no test case attached. 380445 2 88439 creis 2011-04-06 09:07:08 -0700 Created attachment 88439 Layout test for window.open, document.write, location.reload 380710 3 creis 2011-04-06 12:10:10 -0700 I've tracked it down to Document::write, which calls Document::open using the ownerDocument it got from V8HTMLDocument::writeCallback. In this case, ownerDocument is the opener document, rather than the new window's document. All of that code seems pretty intentional, though. Is this intended behavior? I found it pretty surprising to have the opener's page show up in the new window... 380768 4 creis 2011-04-06 13:27:46 -0700 Adam Barth points out that this is actually intentional. The opener page is overwriting the child page with document.write, so its security context takes over. WebKit's behavior still differs from Firefox and IE (which simply reload the "1" from the document.write), but at least Firefox replaces the URL of the new window with the opener's URL. I'll mark it won't fix. 380843 5 ap 2011-04-06 14:32:34 -0700 Is there a regression test for this? Also, a comment would be better than code that just looks intentional :) 380871 6 abarth 2011-04-06 15:01:50 -0700 > Is there a regression test for this? Yes. The test was added when I added this code. > Also, a comment would be better than code that just looks intentional :) Comments are good. There isn't a test for the root issue Charlie is investigating because the underlying problem is that the embedder isn't properly handling messages its getting from WebKit. 380966 7 darin 2011-04-06 16:39:58 -0700 Did this come up on a real world website? 380988 8 creis 2011-04-06 17:21:50 -0700 (In reply to comment #7) > Did this come up on a real world website? No, it's from a toy example page showing incorrect URL bar behavior in Chrome (not Safari). As Adam mentions, it's likely an issue in the embedder logic. 88439 2011-04-06 09:07:08 -0700 2011-04-06 09:07:08 -0700 Layout test for window.open, document.write, location.reload layout-test.zip application/zip 1816 creis UEsDBAoAAAAAAJGGhT4AAAAAAAAAAAAAAAAMABwAbGF5b3V0LXRlc3QvVVQJAANBq5tNQaubTXV4 CwABBDIgAQAEiBMAAFBLAwQUAAAACACAhoU+7ZV/CIIAAADJAAAAMQAcAGxheW91dC10ZXN0L3dp bmRvdy1vcGVuLXdyaXRlLXJlbG9hZC1leHBlY3RlZC50eHRVVAkAAyCrm00gq5tNdXgLAAEEMiAB AASIEwAAdcwxDsIwEAXR3qf4J0hHQbrIMjRAkMwFLHtDVphd5Bh8fUCiQYJ+3tjx4Medw955P2xd j8xCWPfYcFkqHrxwRVXEmXNCY0naOmN/qlUPT1El/WMnei0nLSiUNSSWMwKE2idAmCoVJI33K0nt WuFKnTE2c7xgpkLvpd5Ivpg5Dt6bJ1BLAwQUAAAACADFhoU+cGrLWusBAAAkBQAAKQAcAGxheW91 dC10ZXN0L3dpbmRvdy1vcGVuLXdyaXRlLXJlbG9hZC5odG1sVVQJAAOhq5tNIKubTXV4CwABBDIg AQAEiBMAAJ1UTW/bMAy951cQvtTBFgfbcU0GZOmGFcjQYkmRsyfRsTBZNGQ6XjD0v0+ynMUumrSb LrbJx8cPPXpWCatK/jgCd/apBZErLbfKSGquR7Pp0T0rA2SDFUNGFixqSqUyO0jBYANNGwJpxmhB kqgLNJw0VjEmjseFz37UzGRAyXkUXiMgI7QSP+dRLy3MO7KESjTxlcWKaiuwmgbzxJsnLfMkVDHp 8DkX+mochUqXnhhytAhM4GMGlbqaQhG+t7Yml6fW7KJDtf3BqAziLodOD1SzH8OSDFvSGu0Yfrcw f57zJ7IuykW1wV8cj68vQ5tU8YNhpW/I4IvoCnmZmjvXXJhdFbOt8TVRmir8jkWqjLvDLnibo1lS UWpkfEr090p3yJ81+tdPh1sZH8c2TpQxaH2P7gKjL4vb1YegFqkkGGIQHXN0IvWC61QxP5+hE0uv GNw75xqNdM0UVFf4jfa4oTggE8oy1+J9aj1b+FhhxvAGBoDnbFslOYcpvH8L58k2VLq4ISDYBqav qHY5e7JLpd9QY+JLgIfy6H4ctY+sNoKVm1m7NCu3ACjvjHBqad0nLfaWKhmuZPyul7EP0yRSz52E zXpF5k2jXkgtvNb6Lf7DOv2H9O4X63VPY2e3wGlSZYena/Z47Pf07/sDUEsDBAoAAAAAAJGGhT4A AAAAAAAAAAAAAAAWABwAbGF5b3V0LXRlc3QvcmVzb3VyY2VzL1VUCQADQaubTa+rm011eAsAAQQy IAEABIgTAABQSwMEFAAAAAgAioaFPjmXH3WpAAAAbQEAADoAHABsYXlvdXQtdGVzdC9yZXNvdXJj ZXMvd2luZG93LW9wZW4td3JpdGUtcmVsb2FkLXdpbmRvdy5odG1sVVQJAAMzq5tNM6ubTXV4CwAB BDIgAQAEiBMAAI2QvQ7CMAyE9zyF1SldygNQGJmQGMoLRIlbLEVxlbjtgPruBCg/CxW3Wbo7f7o6 2Ui97BUHz8bBDtohWCEOulRXBVnUgp4oOJ4qz9b4RjiaDqskJgq6Ep62uyyHxB6zr9NFg/l0MFIi AWGwF/IOlqai3L5TDj0KwsqPj5d7DBirR9cxA6M7T2RRL3UzoE/4i+hAMckfQCskeSCJA64BncIX j5pVvXltfANQSwECHgMKAAAAAACRhoU+AAAAAAAAAAAAAAAADAAYAAAAAAAAABAA6EEAAAAAbGF5 b3V0LXRlc3QvVVQFAANBq5tNdXgLAAEEMiABAASIEwAAUEsBAh4DFAAAAAgAgIaFPu2VfwiCAAAA yQAAADEAGAAAAAAAAQAAAKCBRgAAAGxheW91dC10ZXN0L3dpbmRvdy1vcGVuLXdyaXRlLXJlbG9h ZC1leHBlY3RlZC50eHRVVAUAAyCrm011eAsAAQQyIAEABIgTAABQSwECHgMUAAAACADFhoU+cGrL WusBAAAkBQAAKQAYAAAAAAABAAAAoIEzAQAAbGF5b3V0LXRlc3Qvd2luZG93LW9wZW4td3JpdGUt cmVsb2FkLmh0bWxVVAUAA6Grm011eAsAAQQyIAEABIgTAABQSwECHgMKAAAAAACRhoU+AAAAAAAA AAAAAAAAFgAYAAAAAAAAABAA6EGBAwAAbGF5b3V0LXRlc3QvcmVzb3VyY2VzL1VUBQADQaubTXV4 CwABBDIgAQAEiBMAAFBLAQIeAxQAAAAIAIqGhT45lx91qQAAAG0BAAA6ABgAAAAAAAEAAACggdED AABsYXlvdXQtdGVzdC9yZXNvdXJjZXMvd2luZG93LW9wZW4td3JpdGUtcmVsb2FkLXdpbmRvdy5o dG1sVVQFAAMzq5tNdXgLAAEEMiABAASIEwAAUEsFBgAAAAAFAAUAFAIAAO4EAAAAAA==