57457 2011-03-30 08:01:12 -0700 Add support for parsing unicode-bidi:plaintext 2011-03-30 12:02:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 57482 50949 0 ofri webkit-unassigned commit-queue eric webkit.review.bot oldest_to_newest 376322 0 ofri 2011-03-30 08:01:12 -0700 Add support for parsing unicode-bidi:plaintext 376329 1 87538 ofri 2011-03-30 08:06:27 -0700 Created attachment 87538 Patch 376332 2 webkit.review.bot 2011-03-30 08:09:55 -0700 Attachment 87538 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3..." exit_code: 1 Source/WebCore/rendering/style/RenderStyle.h:258: _unicodeBidi is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style. 376341 3 87538 eric 2011-03-30 08:23:36 -0700 Comment on attachment 87538 Patch LGTM. 376437 4 87538 commit-queue 2011-03-30 10:20:42 -0700 Comment on attachment 87538 Patch Clearing flags on attachment: 87538 Committed r82463: <http://trac.webkit.org/changeset/82463> 376438 5 commit-queue 2011-03-30 10:20:48 -0700 All reviewed patches have been landed. Closing bug. 376529 6 eric 2011-03-30 11:41:40 -0700 I suspect this is hitting an ASSERT in the BidiResolver code which I ran across today. Ofri and I can look into it tomorrow. 376565 7 eric 2011-03-30 12:02:18 -0700 Hmm... the backtrac was not as expected: http://build.webkit.org/results/Leopard%20Intel%20Debug%20%28Tests%29/r82463%20(28266)/editing/deleting/5408255-crash-log.txt 87538 2011-03-30 08:06:27 -0700 2011-03-30 10:20:42 -0700 Patch bug-57457-20110330170624.patch text/plain 6552 ofri U3VidmVyc2lvbiBSZXZpc2lvbjogODI0MjAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkNTc0YjI5YzE1YTYyOGEyMzkwMWM0 ZWJkYTljODBiZThiOTEwMjIzLi4wMDcwYzI4MmEzYmNkZGMzNzIwNmM1MzVmYzkxMmRlZWI5NmJh OWZjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMzAgIE9mcmkgV29sZnVzICA8b2Zy aUBkaGNwLTE3Mi0yOC00MC0xNzgudGx2LmNvcnAuZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgc3VwcG9ydCBmb3IgcGFyc2lu ZyB1bmljb2RlLWJpZGk6IC13ZWJraXQtcGxhaW50ZXh0LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc0NTcKKworICAgICAgICAqIGNzczMvdW5pY29k ZS1iaWRpLXBsYWludGV4dC1wYXJzZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGNz czMvdW5pY29kZS1iaWRpLXBsYWludGV4dC1wYXJzZS5odG1sOiBBZGRlZC4KKwogMjAxMS0wMy0z MCAgWWFlbCBBaGFyb24gIDx5YWVsLmFoYXJvbkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jc3MzL3VuaWNvZGUt YmlkaS1wbGFpbnRleHQtcGFyc2UtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvY3NzMy91bmlj b2RlLWJpZGktcGxhaW50ZXh0LXBhcnNlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jMDgyZTYx Y2UwNGVlYmNkYzcwMjNiMTA1YTQ1YmNmOGY4MDI1ZWVhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvY3NzMy91bmljb2RlLWJpZGktcGxhaW50ZXh0LXBhcnNlLWV4cGVjdGVkLnR4dApA QCAtMCwwICsxLDEwIEBACitCYXNpYyB0ZXN0IGZvciB1bmljb2RlLWJpZGk6IHBsYWludGV4dCBw YXJzaW5nLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1l c3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyB0ZXN0RGl2LnN0 eWxlLnVuaWNvZGVCaWRpIGlzICItd2Via2l0LXBsYWludGV4dCIKK1BBU1Mgc3VjY2Vzc2Z1bGx5 UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9jc3MzL3VuaWNvZGUtYmlkaS1wbGFpbnRleHQtcGFyc2UuaHRtbCBiL0xheW91dFRlc3RzL2Nz czMvdW5pY29kZS1iaWRpLXBsYWludGV4dC1wYXJzZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmJjZTEzZTFm OGExOTkzOTcwZmE0YTRkZTYyYTI5NjQ3NTcwNGJlNzIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9jc3MzL3VuaWNvZGUtYmlkaS1wbGFpbnRleHQtcGFyc2UuaHRtbApAQCAtMCwwICsx LDEyIEBACis8IURPQ1RZUEUgSFRNTD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4v ZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9Ii4uL2Zh c3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxwIGlkPSJkZXNjcmlw dGlvbiI+PC9wPjxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdD4KK2Rlc2NyaXB0aW9u KCJCYXNpYyB0ZXN0IGZvciB1bmljb2RlLWJpZGk6IHBsYWludGV4dCBwYXJzaW5nLiIpCit2YXIg dGVzdERpdiA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwordGVzdERpdi5zdHlsZS5j c3NUZXh0ID0gInVuaWNvZGUtYmlkaTogLXdlYmtpdC1wbGFpbnRleHQiOworc2hvdWxkQmVFcXVh bFRvU3RyaW5nKCJ0ZXN0RGl2LnN0eWxlLnVuaWNvZGVCaWRpIiwgIi13ZWJraXQtcGxhaW50ZXh0 Iik7CitzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0i Li4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCA0YmZkOTgxODE5ZWNhMTA0MGIyZDBiZjBiYjliMTA1ZTU3NjljYTI2Li5mMjRmZjI4NTI3 NTA2NWNhN2QxY2Q4MDc3YWNmOTYwZDdmYzNiNzExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTEtMDMtMzAgIE9mcmkgV29sZnVzICA8b2ZyaUBkaGNwLTE3Mi0yOC00MC0xNzgudGx2 LmNvcnAuZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgc3VwcG9ydCBmb3IgcGFyc2luZyB1bmljb2RlLWJpZGk6IC13ZWJraXQt cGxhaW50ZXh0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTc0NTcKKworICAgICAgICBUZXN0OiBjc3MzL3VuaWNvZGUtYmlkaS1wbGFpbnRleHQtcGFy c2UuaHRtbAorCisgICAgICAgICogY3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpDU1NQYXJzZXI6OnBhcnNlVmFsdWUpOgorICAgICAgICAqIGNzcy9DU1NQcmltaXRpdmVWYWx1 ZU1hcHBpbmdzLmg6CisgICAgICAgIChXZWJDb3JlOjpDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTUHJp bWl0aXZlVmFsdWUpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUHJpbWl0aXZlVmFsdWU6Om9wZXJh dG9yIEVVbmljb2RlQmlkaSk6CisgICAgICAgICogY3NzL0NTU1ZhbHVlS2V5d29yZHMuaW46Cisg ICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmg6CisgICAgICAgICogcmVuZGVy aW5nL3N0eWxlL1JlbmRlclN0eWxlQ29uc3RhbnRzLmg6CisKIDIwMTEtMDMtMzAgIFBhdmVsIEZl bGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm90IHJldmlld2VkOiBm aXhpbmcgdHlwbyBpbiB0aGUgaW5zcGVjdG9yIGZyb250LWVuZC4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNl ci5jcHAKaW5kZXggMzIyMTU4ZGYzYjRmYzJmOTI0MjhjMTExYmJlMzFlZTc0NTEzMDQ1Ni4uMjli NjA0MDU0MDU3YjhkNzE0MDNkMmQ1NWVkMDY1ZmMzNzNhYWIyMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1Bh cnNlci5jcHAKQEAgLTY0NywxMSArNjQ3LDEyIEBAIGJvb2wgQ1NTUGFyc2VyOjpwYXJzZVZhbHVl KGludCBwcm9wSWQsIGJvb2wgaW1wb3J0YW50KQogICAgICAgICBlbHNlCiAgICAgICAgICAgICBy ZXR1cm4gcGFyc2VRdW90ZXMocHJvcElkLCBpbXBvcnRhbnQpOwogICAgICAgICBicmVhazsKLSAg ICBjYXNlIENTU1Byb3BlcnR5VW5pY29kZUJpZGk6IC8vIG5vcm1hbCB8IGVtYmVkIHwgYmlkaS1v dmVycmlkZSB8IGlzb2xhdGUgfCBpbmhlcml0CisgICAgY2FzZSBDU1NQcm9wZXJ0eVVuaWNvZGVC aWRpOiAvLyBub3JtYWwgfCBlbWJlZCB8IGJpZGktb3ZlcnJpZGUgfCBpc29sYXRlIHwgcGxhaW50 ZXh0IHwgaW5oZXJpdAogICAgICAgICBpZiAoaWQgPT0gQ1NTVmFsdWVOb3JtYWwKICAgICAgICAg ICAgIHx8IGlkID09IENTU1ZhbHVlRW1iZWQKICAgICAgICAgICAgIHx8IGlkID09IENTU1ZhbHVl QmlkaU92ZXJyaWRlCi0gICAgICAgICAgICB8fCBpZCA9PSBDU1NWYWx1ZVdlYmtpdElzb2xhdGUp CisgICAgICAgICAgICB8fCBpZCA9PSBDU1NWYWx1ZVdlYmtpdElzb2xhdGUKKyAgICAgICAgICAg IHx8IGlkID09IENTU1ZhbHVlV2Via2l0UGxhaW50ZXh0KQogICAgICAgICAgICAgdmFsaWRQcmlt aXRpdmUgPSB0cnVlOwogICAgICAgICBicmVhazsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3MuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdzLmgKaW5kZXggMTY0MTJhZDZmNWUxZGQ0NzdlZGJkNzY1 MWI5MWE3MzJlZGFiOWM3ZS4uYzhlYzlhNzQzZDIzNDk4NGFjZWYwYmYxNmVkN2Y1MzUwYTdmZmNj NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlTWFwcGlu Z3MuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWVNYXBwaW5ncy5o CkBAIC0xNzUyLDYgKzE3NTIsMTAgQEAgdGVtcGxhdGU8PiBpbmxpbmUgQ1NTUHJpbWl0aXZlVmFs dWU6OkNTU1ByaW1pdGl2ZVZhbHVlKEVVbmljb2RlQmlkaSBlKQogICAgICAgICBicmVhazsKICAg ICBjYXNlIElzb2xhdGU6CiAgICAgICAgIG1fdmFsdWUuaWRlbnQgPSBDU1NWYWx1ZVdlYmtpdElz b2xhdGU7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgUGxhaW5UZXh0OgorICAgICAgICBtX3Zh bHVlLmlkZW50ID0gQ1NTVmFsdWVXZWJraXRQbGFpbnRleHQ7CisgICAgICAgIGJyZWFrOwogICAg IH0KIH0KIApAQCAtMTc2Niw2ICsxNzcwLDggQEAgdGVtcGxhdGU8PiBpbmxpbmUgQ1NTUHJpbWl0 aXZlVmFsdWU6Om9wZXJhdG9yIEVVbmljb2RlQmlkaSgpIGNvbnN0CiAgICAgICAgIHJldHVybiBP dmVycmlkZTsKICAgICBjYXNlIENTU1ZhbHVlV2Via2l0SXNvbGF0ZToKICAgICAgICAgcmV0dXJu IElzb2xhdGU7CisgICAgY2FzZSBDU1NWYWx1ZVdlYmtpdFBsYWludGV4dDoKKyAgICAgICAgcmV0 dXJuIFBsYWluVGV4dDsKICAgICBkZWZhdWx0OgogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQo KTsKICAgICAgICAgcmV0dXJuIFVCTm9ybWFsOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Y3NzL0NTU1ZhbHVlS2V5d29yZHMuaW4gYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWVLZXl3 b3Jkcy5pbgppbmRleCA2ZGFjMDZmY2NiYzkyYmI5ODNhMzQ3NDcwNWQ4YTQzOTY4YzAxZjVjLi4z NTk2NjYzMzc3MzMzNmE5N2NlYjllNTUyNGM1MjAwMjY2ODljYzgxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWVLZXl3b3Jkcy5pbgorKysgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTVmFsdWVLZXl3b3Jkcy5pbgpAQCAtNDI1LDYgKzQyNSw3IEBAIG5vd3JhcAogb3Blbi1x dW90ZQogb3ZlcmxheQogb3ZlcmxpbmUKKy13ZWJraXQtcGxhaW50ZXh0CiBwb3J0cmFpdAogcHJl CiBwcmUtbGluZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1Jl bmRlclN0eWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUu aAppbmRleCBkOGM3ZTIwYTE4ZTNhMGQ0OTdiYzYwY2E2ZjYwOGQ2YTM2NjUwMjllLi5iYzcwZWQw YThkYzAyNDZhYTljNjYwZjA2NDI1MTRjNTY5NzVjYmFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaApAQCAtMjU1LDcgKzI1NSw3IEBAIHByb3RlY3Rl ZDoKICAgICAgICAgYm9vbCBfYWZmZWN0ZWRCeUFjdGl2ZSA6IDE7CiAgICAgICAgIGJvb2wgX2Fm ZmVjdGVkQnlEcmFnIDogMTsKICAgICAgICAgdW5zaWduZWQgX3BzZXVkb0JpdHMgOiA3OwotICAg ICAgICB1bnNpZ25lZCBfdW5pY29kZUJpZGkgOiAyOyAvLyBFVW5pY29kZUJpZGkKKyAgICAgICAg dW5zaWduZWQgX3VuaWNvZGVCaWRpIDogMzsgLy8gRVVuaWNvZGVCaWRpCiAgICAgICAgIGJvb2wg X2lzTGluayA6IDE7CiAgICAgICAgIC8vIDUwIGJpdHMKICAgICB9IG5vbmluaGVyaXRlZF9mbGFn czsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHls ZUNvbnN0YW50cy5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxl Q29uc3RhbnRzLmgKaW5kZXggMDhmMmMxNTcwMWJhYzI3OWI3NDcwYzNlODJmOTc1ODIxYmIzNjcx NC4uNjY3MDliYTlhYTY0NTg0YjAyNmQ2ODMzNmMxZjVkMGU2NjNhZjIyYSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlQ29uc3RhbnRzLmgKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlQ29uc3RhbnRzLmgK QEAgLTEyMSw3ICsxMjEsNyBAQCBlbnVtIEVUYWJsZUxheW91dCB7CiB9OwogCiBlbnVtIEVVbmlj b2RlQmlkaSB7Ci0gICAgVUJOb3JtYWwsIEVtYmVkLCBPdmVycmlkZSwgSXNvbGF0ZQorICAgIFVC Tm9ybWFsLCBFbWJlZCwgT3ZlcnJpZGUsIElzb2xhdGUsIFBsYWluVGV4dAogfTsKIAogLy8gQ1NT IFRleHQgTGF5b3V0IE1vZHVsZSBMZXZlbCAzOiBWZXJ0aWNhbCB3cml0aW5nIHN1cHBvcnQK