57437 2011-03-30 02:56:47 -0700 cmake fixes to build efl port under macosx too 2011-10-26 06:30:04 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC OS X 10.5 RESOLVED DUPLICATE 70914 P2 Normal --- 0 o.gorter webkit-unassigned rakuco oldest_to_newest 376156 0 87490 o.gorter 2011-03-30 02:56:47 -0700 Created attachment 87490 cmake patch to allow building under macosx there are a few issues that prevent the efl port to build under macosx, this fixes most of them, though manually fixing up wtf/Platform.h is likely required ... two independed patches: one to fix the cmake files to behave a bit bitter, should work and be useful under linux too one to fix (temporary) weird layering issue in wtf vs jsc on IdentifierTable, likely fixed in the future already, only needed when compiling with shared core 376157 1 87491 o.gorter 2011-03-30 02:58:14 -0700 Created attachment 87491 move public destructor to wtf or wtf by itself won't link 376262 2 o.gorter 2011-03-30 06:36:50 -0700 actually, you can only build webkit with ICU on a case sensitive file system! Because JavaScriptCore/wtf/unicode/UTF8.h and <unicode/utf8.h> from ICU will be ambiguous. (Don't make the whole macosx harddrive case sensitive, this will break certain programs, instead create a disk image with a case sensitive partition.) to make the rest work, in wtf/Platform.h: #define WTF_PLATFORM_MAC 0 #define ENABLE_PURGEABLE_MEMORY 0 or (haven't tried) add WebCore/platform/mac/PurgeableBufferMac.cpp to WebCore/CMakeLists.txt will update cmake patch 376276 3 87526 o.gorter 2011-03-30 06:55:49 -0700 Created attachment 87526 cmake macosx build fix (Efl port) 411589 4 rakuco 2011-05-27 11:40:16 -0700 Hi there. Please attach only one patch per bug, so that when it is committed the bug can be automatically closed. You should add some people to the CC list for it to be reviewed (it's easier if you use the webkit-patch script in Tools/Scripts). You also need to mark you patch for review and commit-queue (by clicking in the "Details" link) so that it is tested against various ports. Can you then create more bug reports if needed and check if your patches build against the latest SVN revision? 490796 5 o.gorter 2011-10-26 06:30:04 -0700 filed a newer updated bug, the patches there applies cleanly to trunk *** This bug has been marked as a duplicate of bug 70914 *** 87490 2011-03-30 02:56:47 -0700 2011-03-30 06:56:04 -0700 cmake patch to allow building under macosx 0002-fix-some-cmake-issues-under-macosx.patch text/plain 2499 o.gorter RnJvbSAwNzljMjg3MjQyNGRkNGUwMTJhZTVjZTU5MzE2YzFjMjJmODliNDI5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBPbm5lIDxvbm5lQG9ubmx1Y2t5LmNvbT4KRGF0ZTogV2VkLCAz MCBNYXIgMjAxMSAxMTo0MzoxOCArMDIwMApTdWJqZWN0OiBbUEFUQ0ggMi8yXSBmaXggc29tZSBj bWFrZSBpc3N1ZXMgdW5kZXIgbWFjb3N4CgpsZXQgRGFyd2luIGJlIGEga25vd24gc3lzdGVtIG5h bWUKYWRkIElDVV9JMThOIGxpYnJhcmllcyB0byB3dGYgKHJlcXVpcmVkIGlmIGJ1aWxkaW5nIHNo YXJlZCkKYWRkIFBORyBhbmQgSlBHIGxpYnJhcmllcyB0byBXZWJDb3JlIChyZXF1aXJlZCBpZiBi dWlsZGluZyBzaGFyZWQpCgpyZW1vdmUgd3RmL3VuaWNvZGUgYXMgaW5jbHVkZSBkaXJlY3Rvcnkg b2Ygd2ViY29yZTsgd2ViY29yZSBhbHdheXMgaW5jbHVkZXMgdXNpbmcgPHd0Zi91bmljb2RlLy4u Lj4gYW5kIG9uIGNhc2UgaW5zZW5zaXRpdmUgZmlsZSBzeXN0ZW0gd3RmL3VuaWNvZGUvVVRGOC5o IG1hc2tzIElDVS9pbmNsdWRlL3VuaWNvZGUvdXRmOC5oCi0tLQogU291cmNlL0NNYWtlTGlzdHMu dHh0ICAgICAgICAgICAgICAgICAgICAgICB8ICAgIDMgKysrCiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvd3RmL0NNYWtlTGlzdHNFZmwudHh0IHwgICAgMSArCiBTb3VyY2UvV2ViQ29yZS9DTWFrZUxp c3RzLnR4dCAgICAgICAgICAgICAgIHwgICAgMSAtCiBTb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3Rz RWZsLnR4dCAgICAgICAgICAgIHwgICAgMiArKwogNCBmaWxlcyBjaGFuZ2VkLCA2IGluc2VydGlv bnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL0NNYWtlTGlzdHMudHh0 IGIvU291cmNlL0NNYWtlTGlzdHMudHh0CmluZGV4IGQ2MzY4YzAuLjU3MmVkNjUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvQ01ha2VMaXN0cy50eHQKQEAg LTYzLDYgKzYzLDkgQEAgSUYgKENNQUtFX1NZU1RFTV9OQU1FIE1BVENIRVMgIkxpbnV4IikKICAg ICBJRiAoQVBQTEUpCiAgICAgICAgIFNFVChXVEZfT1NfTUFDX09TX1ggMSkKICAgICBFTkRJRiAo KQorRUxTRUlGIChDTUFLRV9TWVNURU1fTkFNRSBNQVRDSEVTICJEYXJ3aW4iKQorICAgIFNFVChX VEZfT1NfVU5JWCAxKQorICAgIFNFVChXVEZfT1NfTUFDX09TX1ggMSkKIEVMU0VJRiAoQ01BS0Vf U1lTVEVNX05BTUUgTUFUQ0hFUyAiV2luZG93cyIpCiAgICAgU0VUKFdURl9PU19XSU5ET1dTIDEp CiBFTFNFICgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0NNYWtlTGlz dHNFZmwudHh0IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9DTWFrZUxpc3RzRWZsLnR4dApp bmRleCBlNWQ4YmQ3Li4xOTAxZmNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv d3RmL0NNYWtlTGlzdHNFZmwudHh0CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvQ01h a2VMaXN0c0VmbC50eHQKQEAgLTM0LDYgKzM0LDcgQEAgRU5ESUYgKCkKIExJU1QoQVBQRU5EIFdU Rl9MSUJSQVJJRVMKICAgICBwdGhyZWFkCiAgICAgJHtJQ1VfTElCUkFSSUVTfQorICAgICR7SUNV X0kxOE5fTElCUkFSSUVTfQogKQogCiBMSVNUKEFQUEVORCBXVEZfTElOS19GTEFHUwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29yZS9DTWFr ZUxpc3RzLnR4dAppbmRleCAyMjY1NzJkLi5lMWMyNGRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dApA QCAtNzMsNyArNzMsNiBAQCBTRVQoV2ViQ29yZV9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgIiR7 SkFWQVNDUklQVENPUkVfRElSfS9wcm9maWxlciIKICAgICAiJHtKQVZBU0NSSVBUQ09SRV9ESVJ9 L3J1bnRpbWUiCiAgICAgIiR7SkFWQVNDUklQVENPUkVfRElSfS93dGYiCi0gICAgIiR7SkFWQVND UklQVENPUkVfRElSfS93dGYvdW5pY29kZSIKICAgICAiJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L3lh cnIiCiAgICAgIiR7REVSSVZFRF9TT1VSQ0VTX0RJUn0iCiAgICAgIiR7Q01BS0VfU09VUkNFX0RJ Un0iCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzRWZsLnR4dCBiL1NvdXJj ZS9XZWJDb3JlL0NNYWtlTGlzdHNFZmwudHh0CmluZGV4IDhjMTljMTkuLjE4ZmM3MmQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHNFZmwudHh0CisrKyBiL1NvdXJjZS9XZWJD b3JlL0NNYWtlTGlzdHNFZmwudHh0CkBAIC0yMDAsNiArMjAwLDggQEAgTElTVChBUFBFTkQgV2Vi Q29yZV9MSUJSQVJJRVMKICAgJHtMSUJYTUwyX0xJQlJBUklFU30KICAgJHtMSUJYU0xUX0xJQlJB UklFU30KICAgJHtTUUxJVEVfTElCUkFSSUVTfQorICAke1BOR19MSUJSQVJJRVN9CisgICR7SlBF R19MSUJSQVJJRVN9CiApCiAKIElGIChXVEZfVVNFX1NPVVApCi0tIAoxLjcuMgoK 87491 2011-03-30 02:58:14 -0700 2011-03-30 02:58:14 -0700 move public destructor to wtf or wtf by itself won't link 0001-move-destructor-for-IdentifierTable-into-wtf.patch text/plain 1877 o.gorter RnJvbSBhMWUyMTJiYjI1MWFlMDhjMjgzNTljZGI4NWRhNTU1ZjhhY2MxODRjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBPbm5lIDxvbm5lQG9ubmx1Y2t5LmNvbT4KRGF0ZTogV2VkLCAz MCBNYXIgMjAxMSAxMTozNTozMSArMDIwMApTdWJqZWN0OiBbUEFUQ0ggMS8yXSBtb3ZlIGRlc3Ry dWN0b3IgZm9yIElkZW50aWZpZXJUYWJsZSBpbnRvIHd0ZgoKLS0tCiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9JZGVudGlmaWVyLmNwcCB8ICAgIDYgLS0tLS0tCiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvd3RmL1dURlRocmVhZERhdGEuaCAgICB8ICAgIDYgKysrKystCiAyIGZpbGVzIGNo YW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JZGVudGlmaWVyLmNwcCBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0lkZW50aWZpZXIuY3BwCmluZGV4IDRhOTliMTkuLmNhZDhlNjcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0lkZW50aWZpZXIuY3BwCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0lkZW50aWZpZXIuY3BwCkBAIC0zNywx MiArMzcsNiBAQCB1c2luZyBXVEY6OlRocmVhZFNwZWNpZmljOwogCiBuYW1lc3BhY2UgSlNDIHsK IAotSWRlbnRpZmllclRhYmxlOjp+SWRlbnRpZmllclRhYmxlKCkKLXsKLSAgICBIYXNoU2V0PFN0 cmluZ0ltcGwqPjo6aXRlcmF0b3IgZW5kID0gbV90YWJsZS5lbmQoKTsKLSAgICBmb3IgKEhhc2hT ZXQ8U3RyaW5nSW1wbCo+OjppdGVyYXRvciBpdGVyID0gbV90YWJsZS5iZWdpbigpOyBpdGVyICE9 IGVuZDsgKytpdGVyKQotICAgICAgICAoKml0ZXIpLT5zZXRJc0lkZW50aWZpZXIoZmFsc2UpOwot fQogc3RkOjpwYWlyPEhhc2hTZXQ8U3RyaW5nSW1wbCo+OjppdGVyYXRvciwgYm9vbD4gSWRlbnRp ZmllclRhYmxlOjphZGQoU3RyaW5nSW1wbCogdmFsdWUpCiB7CiAgICAgc3RkOjpwYWlyPEhhc2hT ZXQ8U3RyaW5nSW1wbCo+OjppdGVyYXRvciwgYm9vbD4gcmVzdWx0ID0gbV90YWJsZS5hZGQodmFs dWUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9XVEZUaHJlYWREYXRh LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1dURlRocmVhZERhdGEuaAppbmRleCAyNDNh YTkxLi5kYjMzNDk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1dURlRo cmVhZERhdGEuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1dURlRocmVhZERhdGEu aApAQCAtNTUsNyArNTUsMTEgQEAgdHlwZWRlZiBIYXNoTWFwPGNvbnN0IGNoYXIqLCBSZWZQdHI8 U3RyaW5nSW1wbD4sIFB0ckhhc2g8Y29uc3QgY2hhcio+ID4gTGl0ZXJhbEkKIGNsYXNzIElkZW50 aWZpZXJUYWJsZSB7CiAgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6Ci0gICAg fklkZW50aWZpZXJUYWJsZSgpOworICAgIElkZW50aWZpZXJUYWJsZTo6fklkZW50aWZpZXJUYWJs ZSgpIHsKKyAgICAgICAgSGFzaFNldDxTdHJpbmdJbXBsKj46Oml0ZXJhdG9yIGVuZCA9IG1fdGFi bGUuZW5kKCk7CisgICAgICAgIGZvciAoSGFzaFNldDxTdHJpbmdJbXBsKj46Oml0ZXJhdG9yIGl0 ZXIgPSBtX3RhYmxlLmJlZ2luKCk7IGl0ZXIgIT0gZW5kOyArK2l0ZXIpCisgICAgICAgICAgICAo Kml0ZXIpLT5zZXRJc0lkZW50aWZpZXIoZmFsc2UpOworICAgIH0KIAogICAgIHN0ZDo6cGFpcjxI YXNoU2V0PFN0cmluZ0ltcGwqPjo6aXRlcmF0b3IsIGJvb2w+IGFkZChTdHJpbmdJbXBsKiB2YWx1 ZSk7CiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVSwgdHlwZW5hbWUgVj4KLS0gCjEuNy4yCgo= 87526 2011-03-30 06:55:49 -0700 2011-03-30 06:55:49 -0700 cmake macosx build fix (Efl port) 0002-fix-some-cmake-issues-under-macosx.patch text/plain 2433 o.gorter RnJvbSAxYjYxMWYyYTRhZjNiYzAxZjdjYjRjY2I4NjZhZDBiYTExZDk4NzA5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBPbm5lIDxvbm5lQG9ubmx1Y2t5LmNvbT4KRGF0ZTogV2VkLCAz MCBNYXIgMjAxMSAxMTo0MzoxOCArMDIwMApTdWJqZWN0OiBbUEFUQ0ggMi8yXSBmaXggc29tZSBj bWFrZSBpc3N1ZXMgdW5kZXIgbWFjb3N4CgpXaWxsIG9ubHkgYnVpbGQgb24gYSBjYXNlIHNlbnNp dGl2ZSBmaWxlIHN5c3RlbSEKCmxldCBEYXJ3aW4gYmUgYSBrbm93biBzeXN0ZW0gbmFtZQphZGQg SUNVX0kxOE4gbGlicmFyaWVzIHRvIHd0ZiAocmVxdWlyZWQgaWYgYnVpbGRpbmcgc2hhcmVkKQph ZGQgUE5HIGFuZCBKUEcgbGlicmFyaWVzIHRvIFdlYkNvcmUgKHJlcXVpcmVkIGlmIGJ1aWxkaW5n IHNoYXJlZCkKYWRkIDx1bmljb2RlL3V0Zjg+IHRvIHd0Zi91bmljb2RlL2ljdS9Vbmljb2RlSWN1 LmggZm9yIFU4X01BWF9MRU5HVEggYW5kIG90aGVycwotLS0KIFNvdXJjZS9DTWFrZUxpc3RzLnR4 dCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgMyArKysKIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS93dGYvQ01ha2VMaXN0c0VmbC50eHQgICAgICAgIHwgICAgMSArCiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvd3RmL3VuaWNvZGUvaWN1L1VuaWNvZGVJY3UuaCB8ICAgIDEgKwogU291cmNl L1dlYkNvcmUvQ01ha2VMaXN0c0VmbC50eHQgICAgICAgICAgICAgICAgICAgfCAgICAyICsrCiA0 IGZpbGVzIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9Tb3VyY2UvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvQ01ha2VMaXN0cy50eHQKaW5kZXgg ZDYzNjhjMC4uNTcyZWQ2NSAxMDA2NDQKLS0tIGEvU291cmNlL0NNYWtlTGlzdHMudHh0CisrKyBi L1NvdXJjZS9DTWFrZUxpc3RzLnR4dApAQCAtNjMsNiArNjMsOSBAQCBJRiAoQ01BS0VfU1lTVEVN X05BTUUgTUFUQ0hFUyAiTGludXgiKQogICAgIElGIChBUFBMRSkKICAgICAgICAgU0VUKFdURl9P U19NQUNfT1NfWCAxKQogICAgIEVORElGICgpCitFTFNFSUYgKENNQUtFX1NZU1RFTV9OQU1FIE1B VENIRVMgIkRhcndpbiIpCisgICAgU0VUKFdURl9PU19VTklYIDEpCisgICAgU0VUKFdURl9PU19N QUNfT1NfWCAxKQogRUxTRUlGIChDTUFLRV9TWVNURU1fTkFNRSBNQVRDSEVTICJXaW5kb3dzIikK ICAgICBTRVQoV1RGX09TX1dJTkRPV1MgMSkKIEVMU0UgKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS93dGYvQ01ha2VMaXN0c0VmbC50eHQgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvd3RmL0NNYWtlTGlzdHNFZmwudHh0CmluZGV4IGU1ZDhiZDcuLjE5MDFmY2UgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvQ01ha2VMaXN0c0VmbC50eHQKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9DTWFrZUxpc3RzRWZsLnR4dApAQCAtMzQsNiArMzQsNyBA QCBFTkRJRiAoKQogTElTVChBUFBFTkQgV1RGX0xJQlJBUklFUwogICAgIHB0aHJlYWQKICAgICAk e0lDVV9MSUJSQVJJRVN9CisgICAgJHtJQ1VfSTE4Tl9MSUJSQVJJRVN9CiApCiAKIExJU1QoQVBQ RU5EIFdURl9MSU5LX0ZMQUdTCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3Rm L3VuaWNvZGUvaWN1L1VuaWNvZGVJY3UuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdW5p Y29kZS9pY3UvVW5pY29kZUljdS5oCmluZGV4IGEyYTVjMGEuLjliYWMxZTQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdW5pY29kZS9pY3UvVW5pY29kZUljdS5oCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdW5pY29kZS9pY3UvVW5pY29kZUljdS5oCkBAIC0y Nyw2ICsyNyw3IEBACiAjaW5jbHVkZSA8dW5pY29kZS91Y2hhci5oPgogI2luY2x1ZGUgPHVuaWNv ZGUvdXN0cmluZy5oPgogI2luY2x1ZGUgPHVuaWNvZGUvdXRmMTYuaD4KKyNpbmNsdWRlIDx1bmlj b2RlL3V0ZjguaD4KIAogbmFtZXNwYWNlIFdURiB7CiBuYW1lc3BhY2UgVW5pY29kZSB7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzRWZsLnR4dCBiL1NvdXJjZS9XZWJDb3Jl L0NNYWtlTGlzdHNFZmwudHh0CmluZGV4IDhjMTljMTkuLjE4ZmM3MmQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0NNYWtlTGlzdHNFZmwudHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NNYWtl TGlzdHNFZmwudHh0CkBAIC0yMDAsNiArMjAwLDggQEAgTElTVChBUFBFTkQgV2ViQ29yZV9MSUJS QVJJRVMKICAgJHtMSUJYTUwyX0xJQlJBUklFU30KICAgJHtMSUJYU0xUX0xJQlJBUklFU30KICAg JHtTUUxJVEVfTElCUkFSSUVTfQorICAke1BOR19MSUJSQVJJRVN9CisgICR7SlBFR19MSUJSQVJJ RVN9CiApCiAKIElGIChXVEZfVVNFX1NPVVApCi0tIAoxLjcuMgoK