57156 2011-03-26 11:31:13 -0700 RenderMedia should obey the view's flattening bit. 2011-03-26 17:32:04 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue oldest_to_newest 373922 0 jer.noble 2011-03-26 11:31:13 -0700 RenderMedia currently does not paint when the RenderView is drawing in flattening mode. 373923 1 jer.noble 2011-03-26 11:31:26 -0700 <rdar://problem/9028914> 373924 2 jer.noble 2011-03-26 11:35:54 -0700 Sorry, the FrameView (not the RenderView). 373936 3 87034 jer.noble 2011-03-26 12:08:10 -0700 Created attachment 87034 Patch 373937 4 87034 mitz 2011-03-26 12:13:08 -0700 Comment on attachment 87034 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87034&action=review > Source/WebCore/rendering/RenderVideo.cpp:205 > + else if (document()->view() && document()->view()->paintBehavior() == PaintBehaviorFlattenCompositingLayers) paintBehavior() is a bitmask, so you should check for (paintBehavior() & PaintBehaviorFlattenCompositingLayers) 373939 5 jer.noble 2011-03-26 12:18:19 -0700 (In reply to comment #4) > (From update of attachment 87034 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=87034&action=review > > > Source/WebCore/rendering/RenderVideo.cpp:205 > > + else if (document()->view() && document()->view()->paintBehavior() == PaintBehaviorFlattenCompositingLayers) > > paintBehavior() is a bitmask, so you should check for (paintBehavior() & PaintBehaviorFlattenCompositingLayers) Good point. Changed. 373940 6 87034 mitz 2011-03-26 12:20:14 -0700 Comment on attachment 87034 Patch r+ with the change 373946 7 87038 jer.noble 2011-03-26 12:32:15 -0700 Created attachment 87038 Patch 373949 8 jer.noble 2011-03-26 12:33:17 -0700 (In reply to comment #6) > (From update of attachment 87034 [details]) > r+ with the change Whoops, uploaded a new patch. Undoing. :) 373950 9 jer.noble 2011-03-26 12:34:02 -0700 TIL: obseleting a patch clears its flags. Would you mind r+'ing the new one? 374008 10 87038 jer.noble 2011-03-26 16:22:28 -0700 Comment on attachment 87038 Patch Clearing c+; preparing to commit manually. 374011 11 jer.noble 2011-03-26 16:47:27 -0700 Committed r82051: <http://trac.webkit.org/changeset/82051> 374016 12 commit-queue 2011-03-26 17:32:04 -0700 The commit-queue encountered the following flaky tests while processing attachment 87038: http/tests/websocket/tests/httponly-cookie.pl bug 54097 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 87034 2011-03-26 12:08:10 -0700 2011-03-26 12:32:12 -0700 Patch bug-57156-20110326120808.patch text/plain 1539 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODIwMjUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzOGQzYzdjYzQ2YmY1ZjAy MTQzMjI3MTNjZmE5NjgzMjU4MmUzYTg5Li44NWZlZDlhNGY2NDRmZjM1ODA3NzYzY2MxNmU3MDI1 MmJiNzc4MWIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTkgQEAKIAogICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBSZW5kZXJNZWRpYSBzaG91bGQgb2JleSB0 aGUgdmlldydzIGZsYXR0ZW5pbmcgYml0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTcxNTYKKworICAgICAgICBQYWludCB0aGUgY3VycmVudCBmcmFt ZSBpbiBzb2Z0d2FyZSB3aGVuIHRoZSBhc3NvY2lhdGVkIEZyYW1lVmlldworICAgICAgICBoYXMg aXRzIGZsYXR0ZW5pbmcgYml0IHNldC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJWaWRl by5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJWaWRlbzo6cGFpbnRSZXBsYWNlZCk6CisK KzIwMTEtMDMtMjYgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgRnVsbCBTY3JlZW46IGRpc2Fi bGUga2V5Ym9hcmQgYWNjZXNzIGJ5IGRlZmF1bHQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU2Njg0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJWaWRlby5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVmlkZW8uY3BwCmluZGV4IDFhZTczNmJkZDNjMWI5NWQ2ZjY3YjlhZDY5YWVjZGRlODFlMTdl NGYuLmIxYWRiZmJkZmExNDY5OGI0Mjg2MTllY2Y1MTcxOTE1MGYwOWU1ZjQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWRlby5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZGVvLmNwcApAQCAtMjAyLDYgKzIwMiw4IEBAIHZvaWQg UmVuZGVyVmlkZW86OnBhaW50UmVwbGFjZWQoUGFpbnRJbmZvJiBwYWludEluZm8sIGludCB0eCwg aW50IHR5KQogCiAgICAgaWYgKGRpc3BsYXlpbmdQb3N0ZXIpCiAgICAgICAgIHBhaW50SW50b1Jl Y3QocGFpbnRJbmZvLmNvbnRleHQsIHJlY3QpOworICAgIGVsc2UgaWYgKGRvY3VtZW50KCktPnZp ZXcoKSAmJiBkb2N1bWVudCgpLT52aWV3KCktPnBhaW50QmVoYXZpb3IoKSA9PSBQYWludEJlaGF2 aW9yRmxhdHRlbkNvbXBvc2l0aW5nTGF5ZXJzKQorICAgICAgICBtZWRpYVBsYXllci0+cGFpbnRD dXJyZW50RnJhbWVJbkNvbnRleHQocGFpbnRJbmZvLmNvbnRleHQsIHJlY3QpOwogICAgIGVsc2UK ICAgICAgICAgbWVkaWFQbGF5ZXItPnBhaW50KHBhaW50SW5mby5jb250ZXh0LCByZWN0KTsKIH0K 87038 2011-03-26 12:32:15 -0700 2011-03-26 16:22:27 -0700 Patch bug-57156-20110326123213.patch text/plain 1538 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODIwMjUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzOGQzYzdjYzQ2YmY1ZjAy MTQzMjI3MTNjZmE5NjgzMjU4MmUzYTg5Li44NWZlZDlhNGY2NDRmZjM1ODA3NzYzY2MxNmU3MDI1 MmJiNzc4MWIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTkgQEAKIAogICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBSZW5kZXJNZWRpYSBzaG91bGQgb2JleSB0 aGUgdmlldydzIGZsYXR0ZW5pbmcgYml0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTcxNTYKKworICAgICAgICBQYWludCB0aGUgY3VycmVudCBmcmFt ZSBpbiBzb2Z0d2FyZSB3aGVuIHRoZSBhc3NvY2lhdGVkIEZyYW1lVmlldworICAgICAgICBoYXMg aXRzIGZsYXR0ZW5pbmcgYml0IHNldC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJWaWRl by5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJWaWRlbzo6cGFpbnRSZXBsYWNlZCk6CisK KzIwMTEtMDMtMjYgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgRnVsbCBTY3JlZW46IGRpc2Fi bGUga2V5Ym9hcmQgYWNjZXNzIGJ5IGRlZmF1bHQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU2Njg0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJWaWRlby5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVmlkZW8uY3BwCmluZGV4IDFhZTczNmJkZDNjMWI5NWQ2ZjY3YjlhZDY5YWVjZGRlODFlMTdl NGYuLjNhOTZlZjg4MzI4NzJmZGE1NDI0MDNmZWU0ZmQzMTQ3MmQzOWM5NDAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWRlby5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZGVvLmNwcApAQCAtMjAyLDYgKzIwMiw4IEBAIHZvaWQg UmVuZGVyVmlkZW86OnBhaW50UmVwbGFjZWQoUGFpbnRJbmZvJiBwYWludEluZm8sIGludCB0eCwg aW50IHR5KQogCiAgICAgaWYgKGRpc3BsYXlpbmdQb3N0ZXIpCiAgICAgICAgIHBhaW50SW50b1Jl Y3QocGFpbnRJbmZvLmNvbnRleHQsIHJlY3QpOworICAgIGVsc2UgaWYgKGRvY3VtZW50KCktPnZp ZXcoKSAmJiBkb2N1bWVudCgpLT52aWV3KCktPnBhaW50QmVoYXZpb3IoKSAmIFBhaW50QmVoYXZp b3JGbGF0dGVuQ29tcG9zaXRpbmdMYXllcnMpCisgICAgICAgIG1lZGlhUGxheWVyLT5wYWludEN1 cnJlbnRGcmFtZUluQ29udGV4dChwYWludEluZm8uY29udGV4dCwgcmVjdCk7CiAgICAgZWxzZQog ICAgICAgICBtZWRpYVBsYXllci0+cGFpbnQocGFpbnRJbmZvLmNvbnRleHQsIHJlY3QpOwogfQo=