57108 2011-03-25 11:28:57 -0700 [Qt][Symbian] Fix Api test failure -- microFocusCoordinates 2011-05-17 06:16:12 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) S60 Hardware All RESOLVED FIXED P2 Normal --- 50925 1 max.hong.shen max.hong.shen abarth ademar commit-queue eric laszlo.gombos oldest_to_newest 373626 0 max.hong.shen 2011-03-25 11:28:57 -0700 The tst_QWebView::microFocusCoordinates failed because its test page content is incorrect -- canvas tag is not self-closing tag. See the problem code below, page->mainFrame()->setHtml("<html><body>" \ "<input type='text' id='input1' style='font--family: serif' value='' maxlength='20'/><br>" \ "<canvas id='canvas1' width='500' height='500'/>" \ "<input type='password'/><br>" \ "<canvas id='canvas2' width='500' height='500'/>" \ "</body></html>"); Will provide a patch soon. 373628 1 max.hong.shen 2011-03-25 11:30:03 -0700 The same problem for tst_QGraphicsWebView::microFocusCoordinates() 373635 2 86965 max.hong.shen 2011-03-25 11:39:17 -0700 Created attachment 86965 first try 374082 3 eric 2011-03-27 01:11:21 -0700 <canvas isn't self closing? I forget these things. 374101 4 86965 kling 2011-03-27 04:00:20 -0700 Comment on attachment 86965 first try Good catch. :3 374185 5 commit-queue 2011-03-27 11:23:32 -0700 The commit-queue encountered the following flaky tests while processing attachment 86965: http/tests/navigation/forward-and-cancel.html bug 57187 The commit-queue is continuing to process your patch. 374186 6 86965 commit-queue 2011-03-27 11:26:31 -0700 Comment on attachment 86965 first try Clearing flags on attachment: 86965 Committed r82074: <http://trac.webkit.org/changeset/82074> 374187 7 commit-queue 2011-03-27 11:26:35 -0700 All reviewed patches have been landed. Closing bug. 86965 2011-03-25 11:39:17 -0700 2011-03-27 11:26:31 -0700 first try 57108.patch text/plain 2531 max.hong.shen SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiA4MTk3MikKKysrIFNvdXJjZS9XZWJLaXQvcXQv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDMtMjUgIFlp IFNoZW4gIDx5aS40LnNoZW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bU3ltYmlhbl0gRml4IEFwaSB0ZXN0IGZhaWx1cmUg LS0gbWljcm9Gb2N1c0Nvb3JkaW5hdGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01NzEwOAorCisgICAgICAgIFNpbmNlIHRoZSBjYW52YXMgaXMgbm90 IHNlbGYtY2xvc2luZyB0YWcsIHdlIG5lZWQgdG8gYWRkICc8L2NhbnZhcz4nLiAKKworICAgICAg ICAqIHRlc3RzL3FncmFwaGljc3dlYnZpZXcvdHN0X3FncmFwaGljc3dlYnZpZXcuY3BwOgorICAg ICAgICAodHN0X1FHcmFwaGljc1dlYlZpZXc6Om1pY3JvRm9jdXNDb29yZGluYXRlcyk6CisgICAg ICAgICogdGVzdHMvcXdlYnZpZXcvdHN0X3F3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHRzdF9RV2Vi Vmlldzo6bWljcm9Gb2N1c0Nvb3JkaW5hdGVzKToKKwogMjAxMS0wMy0yNSAgQ2hhbmcgU2h1ICA8 Y3NodUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4KSW5k ZXg6IFNvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcWdyYXBoaWNzd2Vidmlldy90c3RfcWdyYXBoaWNz d2Vidmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9xdC90ZXN0cy9xZ3JhcGhp Y3N3ZWJ2aWV3L3RzdF9xZ3JhcGhpY3N3ZWJ2aWV3LmNwcAkocmV2aXNpb24gODE5NjIpCisrKyBT b3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3FncmFwaGljc3dlYnZpZXcvdHN0X3FncmFwaGljc3dlYnZp ZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDQsOSArMjA0LDkgQEAgdm9pZCB0c3RfUUdyYXBo aWNzV2ViVmlldzo6bWljcm9Gb2N1c0NvbwogCiAgICAgcGFnZS0+bWFpbkZyYW1lKCktPnNldEh0 bWwoIjxodG1sPjxib2R5PiIgXAogICAgICAgICAiPGlucHV0IHR5cGU9J3RleHQnIGlkPSdpbnB1 dDEnIHN0eWxlPSdmb250LS1mYW1pbHk6IHNlcmlmJyB2YWx1ZT0nJyBtYXhsZW5ndGg9JzIwJy8+ PGJyPiIgXAotICAgICAgICAiPGNhbnZhcyBpZD0nY2FudmFzMScgd2lkdGg9JzUwMCcgaGVpZ2h0 PSc1MDAnLz4iIFwKKyAgICAgICAgIjxjYW52YXMgaWQ9J2NhbnZhczEnIHdpZHRoPSc1MDAnIGhl aWdodD0nNTAwJz48L2NhbnZhcz4iIFwKICAgICAgICAgIjxpbnB1dCB0eXBlPSdwYXNzd29yZCcv Pjxicj4iIFwKLSAgICAgICAgIjxjYW52YXMgaWQ9J2NhbnZhczInIHdpZHRoPSc1MDAnIGhlaWdo dD0nNTAwJy8+IiBcCisgICAgICAgICI8Y2FudmFzIGlkPSdjYW52YXMyJyB3aWR0aD0nNTAwJyBo ZWlnaHQ9JzUwMCc+PC9jYW52YXM+IiBcCiAgICAgICAgICI8L2JvZHk+PC9odG1sPiIpOwogCiAg ICAgcGFnZS0+bWFpbkZyYW1lKCktPnNldEZvY3VzKCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0L3F0 L3Rlc3RzL3F3ZWJ2aWV3L3RzdF9xd2Vidmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9xdC90ZXN0cy9xd2Vidmlldy90c3RfcXdlYnZpZXcuY3BwCShyZXZpc2lvbiA4MTk2MikK KysrIFNvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYnZpZXcvdHN0X3F3ZWJ2aWV3LmNwcAkod29y a2luZyBjb3B5KQpAQCAtMjA4LDkgKzIwOCw5IEBAIHZvaWQgdHN0X1FXZWJWaWV3OjptaWNyb0Zv Y3VzQ29vcmRpbmF0ZXMKIAogICAgIHBhZ2UtPm1haW5GcmFtZSgpLT5zZXRIdG1sKCI8aHRtbD48 Ym9keT4iIFwKICAgICAgICAgIjxpbnB1dCB0eXBlPSd0ZXh0JyBpZD0naW5wdXQxJyBzdHlsZT0n Zm9udC0tZmFtaWx5OiBzZXJpZicgdmFsdWU9JycgbWF4bGVuZ3RoPScyMCcvPjxicj4iIFwKLSAg ICAgICAgIjxjYW52YXMgaWQ9J2NhbnZhczEnIHdpZHRoPSc1MDAnIGhlaWdodD0nNTAwJy8+IiBc CisgICAgICAgICI8Y2FudmFzIGlkPSdjYW52YXMxJyB3aWR0aD0nNTAwJyBoZWlnaHQ9JzUwMCc+ PC9jYW52YXM+IiBcCiAgICAgICAgICI8aW5wdXQgdHlwZT0ncGFzc3dvcmQnLz48YnI+IiBcCi0g ICAgICAgICI8Y2FudmFzIGlkPSdjYW52YXMyJyB3aWR0aD0nNTAwJyBoZWlnaHQ9JzUwMCcvPiIg XAorICAgICAgICAiPGNhbnZhcyBpZD0nY2FudmFzMicgd2lkdGg9JzUwMCcgaGVpZ2h0PSc1MDAn PjwvY2FudmFzPiIgXAogICAgICAgICAiPC9ib2R5PjwvaHRtbD4iKTsKIAogICAgIHBhZ2UtPm1h aW5GcmFtZSgpLT5zZXRGb2N1cygpOwo=