57048 2011-03-24 13:12:16 -0700 http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html crashed once on Windows XP Debug (Tests) 2016-05-18 21:14:13 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) PC Windows XP RESOLVED FIXED http://build.webkit.org/results/Windows%20XP%20Debug%20%28Tests%29/r81880%20(26710)/http/tests/websocket/tests/workers/worker-handshake-challenge-randomness-crash-log.txt InRadar, LayoutTestFailure, PlatformOnly P2 Normal --- 55579 1 aroben ukai ap bfulgham levin tkent toyoshim ukai yurys yutak oldest_to_newest 373028 0 aroben 2011-03-24 13:12:16 -0700 http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html crashed once on Windows XP Debug (Tests). See the URL for the crash log. It looks like the same CFSocket is being modified on multiple threads concurrently. 373030 1 aroben 2011-03-24 13:13:06 -0700 Seems related to bug 56625. 373034 2 aroben 2011-03-24 13:14:52 -0700 <rdar://problem/9183661> 373035 3 levin 2011-03-24 13:15:25 -0700 + ukai due to websocket issue. 373678 4 aroben 2011-03-25 12:36:35 -0700 This test is now being skipped (see bug 55579). 406130 5 ap 2011-05-18 17:19:22 -0700 This is a fairly obvious object lifetime bug, and it's probably reasonably easy to fix, but I couldn't figure it out in the time I had for this so far. 406169 6 ukai 2011-05-18 18:21:39 -0700 (In reply to comment #5) > This is a fairly obvious object lifetime bug, and it's probably reasonably easy to fix, but I couldn't figure it out in the time I had for this so far. I don't know much about CoreFoundation, but it seems it schedules read/write stream on loaderRunLoop() on PLATFORM(WIN) in scheduleStreams(), but it tries to unschedule stream on CFRunLoopGetCurrent(), which is used in scheduling stream on other platform than WIN. So, I think this can be fixed to use loaderRunLoop() on PLATFORM(WIN) in platformClose(). I'll create a patch. 406196 7 94029 ukai 2011-05-18 19:14:28 -0700 Created attachment 94029 Patch 406199 8 94030 ukai 2011-05-18 19:21:32 -0700 Created attachment 94030 Patch 406216 9 94030 yutak 2011-05-18 20:01:02 -0700 Comment on attachment 94030 Patch Looks good to me. (I'm not a reviewer, so I can't r+ this.) 406253 10 94030 ap 2011-05-18 23:18:02 -0700 Comment on attachment 94030 Patch Heh, this is a good catch! I'm not sure if it takes care of the whole problem - do you have a Windows setup to run the tests? 406256 11 94030 ap 2011-05-18 23:23:06 -0700 Comment on attachment 94030 Patch I'm going to say r+, since this is clearly an improvement, but the bug may need to remain open until someone can test on Windows, and until the skipped tests are re-enabled. See also: <http://trac.webkit.org/changeset/81111> (where I unsuccessfully tried to fix the crashes). 406259 12 ukai 2011-05-18 23:40:31 -0700 Committed r86822: <http://trac.webkit.org/changeset/86822> 406261 13 ukai 2011-05-18 23:43:20 -0700 I just landed the patch (id=94030). I don't have windows, so please someone test whether it fixes problems. I leave this bug open for now. 1194611 14 bfulgham 2016-05-18 21:14:13 -0700 This code was landed five years ago. I think we can close it. 94029 2011-05-18 19:14:28 -0700 2011-05-18 19:21:25 -0700 Patch bug-57048-20110519111426.patch text/plain 1819 ukai U3VidmVyc2lvbiBSZXZpc2lvbjogODY4MTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0ODAzMDliMTU5ODAxYTdh MTJlZjQ5ZjY0ODE3MTQ0ZDdkZDcxMDk5Li5jYjdkZWFhMzQzZDAxMTE3YzNjOTUzMjFjZGY4ZmEy OWQ0MWViNjdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDUtMTggIEZ1bWl0 b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvd29ya2Vy cy93b3JrZXItaGFuZHNoYWtlLWNoYWxsZW5nZS1yYW5kb21uZXNzLmh0bWwgY3Jhc2hlZCBvbmNl IG9uIFdpbmRvd3MgWFAgRGVidWcgKFRlc3RzKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTcwNDgKKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsv Y2YvU29ja2V0U3RyZWFtSGFuZGxlQ0ZOZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U29ja2V0 U3RyZWFtSGFuZGxlOjpwbGF0Zm9ybUNsb3NlKTogdXNlIGxvYWRlclJ1bkxvb3AgdG8gc2NoZWR1 bGUgc3RyZWFtcyBvbiBwbGF0Zm9ybSBXSU4KKwogMjAxMS0wNS0xNyAgTU9SSVRBIEhhamltZSAg PG1vcnJpdGFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9Tb2NrZXRTdHJl YW1IYW5kbGVDRk5ldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Nv Y2tldFN0cmVhbUhhbmRsZUNGTmV0LmNwcAppbmRleCAzYmI3OWVmNTZkNjJkMTA0N2MzMTliMDJl YzczNjQxYmRkNDNmMGU2Li4xMGVlOTQ2YjhiZWEzZjA0ZmMzYjk5YjRjZjFhZWEwOTNkMTRlOWI0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1NvY2tldFN0 cmVhbUhhbmRsZUNGTmV0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2NmL1NvY2tldFN0cmVhbUhhbmRsZUNGTmV0LmNwcApAQCAtNTcyLDggKzU3MiwxMyBAQCB2b2lk IFNvY2tldFN0cmVhbUhhbmRsZTo6cGxhdGZvcm1DbG9zZSgpCiAgICAgaWYgKCFtX3JlYWRTdHJl YW0pCiAgICAgICAgIHJldHVybjsKIAorI2lmIFBMQVRGT1JNKFdJTikKKyAgICBDRlJlYWRTdHJl YW1VbnNjaGVkdWxlRnJvbVJ1bkxvb3AobV9yZWFkU3RyZWFtLmdldCgpLCBsb2FkZXJSdW5Mb29w KCksIGtDRlJ1bkxvb3BDb21tb25Nb2Rlcyk7CisgICAgQ0ZXcml0ZVN0cmVhbVVuc2NoZWR1bGVG cm9tUnVuTG9vcChtX3dyaXRlU3RyZWFtLmdldCgpLCBsb2FkZXJSdW5Mb29wKCksIGtDRlJ1bkxv b3BDb21tb25Nb2Rlcyk7CisjZWxzZQogICAgIENGUmVhZFN0cmVhbVVuc2NoZWR1bGVGcm9tUnVu TG9vcChtX3JlYWRTdHJlYW0uZ2V0KCksIENGUnVuTG9vcEdldEN1cnJlbnQoKSwga0NGUnVuTG9v cENvbW1vbk1vZGVzKTsKICAgICBDRldyaXRlU3RyZWFtVW5zY2hlZHVsZUZyb21SdW5Mb29wKG1f d3JpdGVTdHJlYW0uZ2V0KCksIENGUnVuTG9vcEdldEN1cnJlbnQoKSwga0NGUnVuTG9vcENvbW1v bk1vZGVzKTsKKyNlbmRpZgogCiAgICAgQ0ZSZWFkU3RyZWFtQ2xvc2UobV9yZWFkU3RyZWFtLmdl dCgpKTsKICAgICBDRldyaXRlU3RyZWFtQ2xvc2UobV93cml0ZVN0cmVhbS5nZXQoKSk7Cg== 94030 2011-05-18 19:21:32 -0700 2011-05-18 23:23:06 -0700 Patch bug-57048-20110519112131.patch text/plain 1819 ukai U3VidmVyc2lvbiBSZXZpc2lvbjogODY4MTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0ODAzMDliMTU5ODAxYTdh MTJlZjQ5ZjY0ODE3MTQ0ZDdkZDcxMDk5Li5jYjdkZWFhMzQzZDAxMTE3YzNjOTUzMjFjZGY4ZmEy OWQ0MWViNjdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDUtMTggIEZ1bWl0 b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvd29ya2Vy cy93b3JrZXItaGFuZHNoYWtlLWNoYWxsZW5nZS1yYW5kb21uZXNzLmh0bWwgY3Jhc2hlZCBvbmNl IG9uIFdpbmRvd3MgWFAgRGVidWcgKFRlc3RzKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTcwNDgKKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsv Y2YvU29ja2V0U3RyZWFtSGFuZGxlQ0ZOZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U29ja2V0 U3RyZWFtSGFuZGxlOjpwbGF0Zm9ybUNsb3NlKTogdXNlIGxvYWRlclJ1bkxvb3AgdG8gc2NoZWR1 bGUgc3RyZWFtcyBvbiBwbGF0Zm9ybSBXSU4KKwogMjAxMS0wNS0xNyAgTU9SSVRBIEhhamltZSAg PG1vcnJpdGFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9Tb2NrZXRTdHJl YW1IYW5kbGVDRk5ldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Nv Y2tldFN0cmVhbUhhbmRsZUNGTmV0LmNwcAppbmRleCAzYmI3OWVmNTZkNjJkMTA0N2MzMTliMDJl YzczNjQxYmRkNDNmMGU2Li4yMDlmNDQ4Y2JhZTE2NDQ1M2I5NzBjODhlMzg0N2U3ZTQ1NzExNjNh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1NvY2tldFN0 cmVhbUhhbmRsZUNGTmV0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2NmL1NvY2tldFN0cmVhbUhhbmRsZUNGTmV0LmNwcApAQCAtNTcyLDggKzU3MiwxMyBAQCB2b2lk IFNvY2tldFN0cmVhbUhhbmRsZTo6cGxhdGZvcm1DbG9zZSgpCiAgICAgaWYgKCFtX3JlYWRTdHJl YW0pCiAgICAgICAgIHJldHVybjsKIAorI2lmIFBMQVRGT1JNKFdJTikKKyAgICBDRlJlYWRTdHJl YW1VbnNjaGVkdWxlRnJvbVJ1bkxvb3AobV9yZWFkU3RyZWFtLmdldCgpLCBsb2FkZXJSdW5Mb29w KCksIGtDRlJ1bkxvb3BEZWZhdWx0TW9kZSk7CisgICAgQ0ZXcml0ZVN0cmVhbVVuc2NoZWR1bGVG cm9tUnVuTG9vcChtX3dyaXRlU3RyZWFtLmdldCgpLCBsb2FkZXJSdW5Mb29wKCksIGtDRlJ1bkxv b3BEZWZhdWx0TW9kZSk7CisjZWxzZQogICAgIENGUmVhZFN0cmVhbVVuc2NoZWR1bGVGcm9tUnVu TG9vcChtX3JlYWRTdHJlYW0uZ2V0KCksIENGUnVuTG9vcEdldEN1cnJlbnQoKSwga0NGUnVuTG9v cENvbW1vbk1vZGVzKTsKICAgICBDRldyaXRlU3RyZWFtVW5zY2hlZHVsZUZyb21SdW5Mb29wKG1f d3JpdGVTdHJlYW0uZ2V0KCksIENGUnVuTG9vcEdldEN1cnJlbnQoKSwga0NGUnVuTG9vcENvbW1v bk1vZGVzKTsKKyNlbmRpZgogCiAgICAgQ0ZSZWFkU3RyZWFtQ2xvc2UobV9yZWFkU3RyZWFtLmdl dCgpKTsKICAgICBDRldyaXRlU3RyZWFtQ2xvc2UobV93cml0ZVN0cmVhbS5nZXQoKSk7Cg==