57018 2011-03-24 08:33:42 -0700 [Qt] Remove modular references after support for the flag was removed. 2011-04-08 13:41:09 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 1 kristian.amlie webkit-unassigned abecsi benjamin commit-queue ossy robert oldest_to_newest 372824 0 kristian.amlie 2011-03-24 08:33:42 -0700 Support was removed because the Qt Modularization project decided we don't need it. It's better to base decisions on the available information, as demonstrated in the patch by checking QT.phonon.includes. In addition, remove the reference to uitools. It has been moved to QtKernel now, and therefore is always available. 372825 1 86779 kristian.amlie 2011-03-24 08:36:11 -0700 Created attachment 86779 Removed-modular-references-after-support-for-the-flag-was-removed 375198 2 commit-queue 2011-03-29 04:58:58 -0700 The commit-queue encountered the following flaky tests while processing attachment 86779: security/block-test-no-port.html bug 52164 (author: pam@chromium.org) The commit-queue is continuing to process your patch. 375199 3 86779 commit-queue 2011-03-29 05:01:57 -0700 Comment on attachment 86779 Removed-modular-references-after-support-for-the-flag-was-removed Clearing flags on attachment: 86779 Committed r82232: <http://trac.webkit.org/changeset/82232> 375200 4 commit-queue 2011-03-29 05:02:02 -0700 All reviewed patches have been landed. Closing bug. 376725 5 robert 2011-03-30 15:17:50 -0700 This broke: platform/qt/plugins/qt-qwidget-plugin.html plugins/application-plugin-plugins-disabled.html http://trac.webkit.org/changeset/82489 prompted it to start failing the two tests by touching DumpRendertreeQt.cpp: The problem seems to be here: http://trac.webkit.org/changeset/82240/trunk/Source/WebKit.pri DRT is now getting built with QT_NO_UITOOLS inherited from WebKit.pri - as a result createPlugins() doesn't create the QtPlugins in the failing tests. 376897 6 ossy 2011-03-30 20:24:09 -0700 Reopen, becaue I rolled out the patch and the Symbian buildfix before go to bed at 5:22 am : http://trac.webkit.org/changeset/82539 We can check it after sleeping. 377019 7 abecsi 2011-03-31 02:54:47 -0700 (In reply to comment #0) > In addition, remove the reference to uitools. It has been moved to QtKernel now, and therefore is always available. Does that mean that QtKernel now depends on uitools internally? Because I checked Qt master ToT now and uitools is still in tools/designer/src/uitools. If UiLoader is always available, some more changes might be needed in: Tools/DumpRenderTree/qt/DumpRenderTree.pro Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp Tools/QtTestBrowser/QtTestBrowser.pro Tools/QtTestBrowser/launcherwindow.h Tools/QtTestBrowser/webpage.cpp However this would probably cause the Symbian and minimal builds to break. We definetely need more information on this. 377027 8 ossy 2011-03-31 03:16:47 -0700 I chekced it on the buildbot. contains(QT_CONFIG, modular) - false !contains(QT_CONFIG, uitools) - true disable_uitools - false Accordingly the original "contains(QT_CONFIG, modular):!contains(QT_CONFIG, uitools)|disable_uitools" is false, but my Symbian buildfix: "!contains(QT_CONFIG, uitools)|disable_uitools" is true. It is absolutely incorrect, because with Qt 4.7.2, I have working uitools, but don't have modular in my QT_CONFIG and don't have uitools in my QT_CONFIG. I'm going to check how can we make Qt 4.7.2 and Qt trunk users happy. 377188 9 kristian.amlie 2011-03-31 08:57:11 -0700 Yes, I think maybe that part about uitools must be brought back. I didn't think about the case where a certain platform leaves out uitools. For Linux it's always compiled. I'll get a new patch up first thing tomorrow morning. 377676 10 87833 kristian.amlie 2011-04-01 01:27:28 -0700 Created attachment 87833 Removed-modular-references-after-support-for-the-flag-was-removed-v2 Updated version, now with the check for uitools kept intact. 381594 11 87833 menard 2011-04-07 12:56:04 -0700 Comment on attachment 87833 Removed-modular-references-after-support-for-the-flag-was-removed-v2 View in context: https://bugs.webkit.org/attachment.cgi?id=87833&action=review > ChangeLog:13 > + https://bugs.webkit.org/show_bug.cgi?id=57018 This should be on the top : look this example changelog entry http://trac.webkit.org/changeset/43259 . 382057 12 88780 kristian.amlie 2011-04-08 00:33:02 -0700 Created attachment 88780 Removed-modular-references-after-support-for-the-flag-was-removed-v3 382189 13 kristian.amlie 2011-04-08 06:04:24 -0700 FYI, I will be away for the next two weeks, so I will not respond during that time. 382396 14 88780 kling 2011-04-08 11:11:27 -0700 Comment on attachment 88780 Removed-modular-references-after-support-for-the-flag-was-removed-v3 rs=me 382517 15 commit-queue 2011-04-08 13:37:48 -0700 The commit-queue encountered the following flaky tests while processing attachment 88780: java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 382519 16 88780 commit-queue 2011-04-08 13:41:05 -0700 Comment on attachment 88780 Removed-modular-references-after-support-for-the-flag-was-removed-v3 Clearing flags on attachment: 88780 Committed r83340: <http://trac.webkit.org/changeset/83340> 382520 17 commit-queue 2011-04-08 13:41:09 -0700 All reviewed patches have been landed. Closing bug. 86779 2011-03-24 08:36:11 -0700 2011-04-01 01:27:28 -0700 Removed-modular-references-after-support-for-the-flag-was-removed 0001-Removed-modular-references-after-support-for-the-fla.patch text/plain 2092 kristian.amlie RnJvbSAzNWYwZGIzZjJiOGQ2OTU4MTc0NzNiOWFlZWVkYzQ4YjVmNTY4N2FmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLcmlzdGlhbiBBbWxpZSA8a3Jpc3RpYW4uYW1saWVAbm9raWEu Y29tPgpEYXRlOiBNb24sIDcgTWFyIDIwMTEgMTY6MTQ6MzkgKzAxMDAKU3ViamVjdDogW1BBVENI XSBSZW1vdmVkIG1vZHVsYXIgcmVmZXJlbmNlcyBhZnRlciBzdXBwb3J0IGZvciB0aGUgZmxhZyB3 YXMgcmVtb3ZlZC4KClN1cHBvcnQgd2FzIHJlbW92ZWQgYmVjYXVzZSB0aGUgUXQgTW9kdWxhcml6 YXRpb24gcHJvamVjdCBkZWNpZGVkIHdlCmRvbid0IG5lZWQgaXQuIEl0J3MgYmV0dGVyIHRvIGJh c2UgZGVjaXNpb25zIG9uIHRoZSBhdmFpbGFibGUKaW5mb3JtYXRpb24sIGFzIGRlbW9uc3RyYXRl ZCBpbiB0aGUgcGF0Y2ggYnkgY2hlY2tpbmcKUVQucGhvbm9uLmluY2x1ZGVzLgoKSW4gYWRkaXRp b24sIHJlbW92ZSB0aGUgcmVmZXJlbmNlIHRvIHVpdG9vbHMuIEl0IGhhcyBiZWVuIG1vdmVkIHRv ClF0S2VybmVsIG5vdywgYW5kIHRoZXJlZm9yZSBpcyBhbHdheXMgYXZhaWxhYmxlLgotLS0KIENo YW5nZUxvZyAgICAgICAgIHwgICAxOSArKysrKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViS2l0 LnByaSB8ICAgIDQgKy0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAzIGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBmOGMx NmE4Li5lYWFhOWY5IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjIgQEAKKzIwMTEtMDMtMjQgIEtyaXN0aWFuIEFtbGllICA8a3Jpc3RpYW4uYW1saWVA bm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlbW92ZWQgbW9kdWxhciByZWZlcmVuY2VzIGFmdGVyIHN1cHBvcnQgZm9yIHRoZSBmbGFn IHdhcyByZW1vdmVkLgorCisgICAgICAgIFN1cHBvcnQgd2FzIHJlbW92ZWQgYmVjYXVzZSB0aGUg UXQgTW9kdWxhcml6YXRpb24gcHJvamVjdCBkZWNpZGVkIHdlCisgICAgICAgIGRvbid0IG5lZWQg aXQuIEl0J3MgYmV0dGVyIHRvIGJhc2UgZGVjaXNpb25zIG9uIHRoZSBhdmFpbGFibGUKKyAgICAg ICAgaW5mb3JtYXRpb24sIGFzIGRlbW9uc3RyYXRlZCBpbiB0aGUgcGF0Y2ggYnkgY2hlY2tpbmcK KyAgICAgICAgUVQucGhvbm9uLmluY2x1ZGVzLgorCisgICAgICAgIEluIGFkZGl0aW9uLCByZW1v dmUgdGhlIHJlZmVyZW5jZSB0byB1aXRvb2xzLiBJdCBoYXMgYmVlbiBtb3ZlZCB0bworICAgICAg ICBRdEtlcm5lbCBub3csIGFuZCB0aGVyZWZvcmUgaXMgYWx3YXlzIGF2YWlsYWJsZS4KKworICAg ICAgICBbUXRdIFJlbW92ZSBtb2R1bGFyIHJlZmVyZW5jZXMgYWZ0ZXIgc3VwcG9ydCBmb3IgdGhl IGZsYWcgd2FzIHJlbW92ZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01NzAxOAorCisgICAgICAgICogU291cmNlL1dlYktpdC5wcmk6CisKIDIwMTEt MDMtMjQgIFByYXNhbnRoIFVsbGF0dGlsICA8cHJhc2FudGgudWxsYXR0aWxAbm9raWEuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC5wcmkgYi9Tb3VyY2UvV2ViS2l0LnByaQppbmRleCA5ODk3N2U4Li5jNjk2NjkxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0LnByaQorKysgYi9Tb3VyY2UvV2ViS2l0LnByaQpAQCAt MTMxLDkgKzEzMSw3IEBAIHN5bWJpYW58bWFlbW81fG1hZW1vNiB7CiAKICMjIyMKIAotY29udGFp bnMoUVRfQ09ORklHLCBtb2R1bGFyKTohY29udGFpbnMoUVRfQ09ORklHLCB1aXRvb2xzKXxkaXNh YmxlX3VpdG9vbHM6IERFRklORVMgKj0gUVRfTk9fVUlUT09MUwotCi0hY29udGFpbnMoUVRfQ09O RklHLCBtb2R1bGFyKSB7Citpc0VtcHR5KFFULnBob25vbi5pbmNsdWRlcykgewogICAgIFFULnBo b25vbi5pbmNsdWRlcyA9ICQkUU1BS0VfSU5DRElSX1FUL3Bob25vbgogICAgIFFULnBob25vbi5s aWJzID0gJCRRTUFLRV9MSUJESVJfUVQKIH0KLS0gCjEuNy4zLjQKCg== 87833 2011-04-01 01:27:28 -0700 2011-04-08 00:33:02 -0700 Removed-modular-references-after-support-for-the-flag-was-removed-v2 0001-Removed-modular-references-after-support-for-the-fla.patch text/plain 1892 kristian.amlie RnJvbSBmOTE3ODg1YmQ1Y2JiYzdmZDM4MzcxOWE4MGRmNzA2YzgwNTM3NWUyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLcmlzdGlhbiBBbWxpZSA8a3Jpc3RpYW4uYW1saWVAbm9raWEu Y29tPgpEYXRlOiBNb24sIDcgTWFyIDIwMTEgMTY6MTQ6MzkgKzAxMDAKU3ViamVjdDogW1BBVENI XSBSZW1vdmVkIG1vZHVsYXIgcmVmZXJlbmNlcyBhZnRlciBzdXBwb3J0IGZvciB0aGUgZmxhZyB3 YXMgcmVtb3ZlZC4KClN1cHBvcnQgd2FzIHJlbW92ZWQgYmVjYXVzZSB0aGUgUXQgTW9kdWxhcml6 YXRpb24gcHJvamVjdCBkZWNpZGVkIHdlCmRvbid0IG5lZWQgaXQuIEl0J3MgYmV0dGVyIHRvIGJh c2UgZGVjaXNpb25zIG9uIHRoZSBhdmFpbGFibGUKaW5mb3JtYXRpb24sIGFzIGRlbW9uc3RyYXRl ZCBpbiB0aGUgcGF0Y2ggYnkgY2hlY2tpbmcKUVQucGhvbm9uLmluY2x1ZGVzLgotLS0KIENoYW5n ZUxvZyAgICAgICAgIHwgICAxNiArKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViS2l0LnByaSB8 ICAgIDQgKystLQogMiBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzMjE0NWFiLi5j NTk0NDliIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTkgQEAKKzIwMTEtMDQtMDEgIEtyaXN0aWFuIEFtbGllICA8a3Jpc3RpYW4uYW1saWVAbm9raWEu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl bW92ZWQgbW9kdWxhciByZWZlcmVuY2VzIGFmdGVyIHN1cHBvcnQgZm9yIHRoZSBmbGFnIHdhcyBy ZW1vdmVkLgorCisgICAgICAgIFN1cHBvcnQgd2FzIHJlbW92ZWQgYmVjYXVzZSB0aGUgUXQgTW9k dWxhcml6YXRpb24gcHJvamVjdCBkZWNpZGVkIHdlCisgICAgICAgIGRvbid0IG5lZWQgaXQuIEl0 J3MgYmV0dGVyIHRvIGJhc2UgZGVjaXNpb25zIG9uIHRoZSBhdmFpbGFibGUKKyAgICAgICAgaW5m b3JtYXRpb24sIGFzIGRlbW9uc3RyYXRlZCBpbiB0aGUgcGF0Y2ggYnkgY2hlY2tpbmcKKyAgICAg ICAgUVQucGhvbm9uLmluY2x1ZGVzLgorCisgICAgICAgIFtRdF0gUmVtb3ZlIG1vZHVsYXIgcmVm ZXJlbmNlcyBhZnRlciBzdXBwb3J0IGZvciB0aGUgZmxhZyB3YXMgcmVtb3ZlZC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3MDE4CisKKyAgICAgICAg KiBTb3VyY2UvV2ViS2l0LnByaToKKwogMjAxMS0wMy0zMSAgWGFuIExvcGV6ICA8eGxvcGV6QGln YWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC5wcmkgYi9Tb3VyY2UvV2ViS2l0LnByaQppbmRleCAxNWY4M2Nh Li5jNzYwNjZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0LnByaQorKysgYi9Tb3VyY2UvV2Vi S2l0LnByaQpAQCAtMTM0LDkgKzEzNCw5IEBAIHN5bWJpYW58bWFlbW81fG1hZW1vNiB7CiAKICMj IyMKIAotY29udGFpbnMoUVRfQ09ORklHLCBtb2R1bGFyKTohY29udGFpbnMoUVRfQ09ORklHLCB1 aXRvb2xzKXxkaXNhYmxlX3VpdG9vbHM6IERFRklORVMgKj0gUVRfTk9fVUlUT09MUworIWNvbnRh aW5zKFFUX0NPTkZJRywgdWl0b29scyl8ZGlzYWJsZV91aXRvb2xzOiBERUZJTkVTICo9IFFUX05P X1VJVE9PTFMKIAotIWNvbnRhaW5zKFFUX0NPTkZJRywgbW9kdWxhcikgeworaXNFbXB0eShRVC5w aG9ub24uaW5jbHVkZXMpIHsKICAgICBRVC5waG9ub24uaW5jbHVkZXMgPSAkJFFNQUtFX0lOQ0RJ Ul9RVC9waG9ub24KICAgICBRVC5waG9ub24ubGlicyA9ICQkUU1BS0VfTElCRElSX1FUCiB9Ci0t IAoxLjcuMy40Cgo= 88780 2011-04-08 00:33:02 -0700 2011-04-08 13:41:05 -0700 Removed-modular-references-after-support-for-the-flag-was-removed-v3 0001-Removed-modular-references-after-support-for-the-flag-was-removed.patch text/plain 1892 kristian.amlie RnJvbSBmOTE3ODg1YmQ1Y2JiYzdmZDM4MzcxOWE4MGRmNzA2YzgwNTM3NWUyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLcmlzdGlhbiBBbWxpZSA8a3Jpc3RpYW4uYW1saWVAbm9raWEu Y29tPgpEYXRlOiBNb24sIDcgTWFyIDIwMTEgMTY6MTQ6MzkgKzAxMDAKU3ViamVjdDogW1BBVENI XSBSZW1vdmVkIG1vZHVsYXIgcmVmZXJlbmNlcyBhZnRlciBzdXBwb3J0IGZvciB0aGUgZmxhZyB3 YXMgcmVtb3ZlZC4KClN1cHBvcnQgd2FzIHJlbW92ZWQgYmVjYXVzZSB0aGUgUXQgTW9kdWxhcml6 YXRpb24gcHJvamVjdCBkZWNpZGVkIHdlCmRvbid0IG5lZWQgaXQuIEl0J3MgYmV0dGVyIHRvIGJh c2UgZGVjaXNpb25zIG9uIHRoZSBhdmFpbGFibGUKaW5mb3JtYXRpb24sIGFzIGRlbW9uc3RyYXRl ZCBpbiB0aGUgcGF0Y2ggYnkgY2hlY2tpbmcKUVQucGhvbm9uLmluY2x1ZGVzLgotLS0KIENoYW5n ZUxvZyAgICAgICAgIHwgICAxNiArKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViS2l0LnByaSB8 ICAgIDQgKystLQogMiBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzMjE0NWFiLi5j NTk0NDliIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTkgQEAKKzIwMTEtMDQtMDEgIEtyaXN0aWFuIEFtbGllICA8a3Jpc3RpYW4uYW1saWVAbm9raWEu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtR dF0gUmVtb3ZlIG1vZHVsYXIgcmVmZXJlbmNlcyBhZnRlciBzdXBwb3J0IGZvciB0aGUgZmxhZyB3 YXMgcmVtb3ZlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU3MDE4CisKKyAgICAgICAgUmVtb3ZlZCBtb2R1bGFyIHJlZmVyZW5jZXMgYWZ0ZXIgc3Vw cG9ydCBmb3IgdGhlIGZsYWcgd2FzIHJlbW92ZWQuCisKKyAgICAgICAgU3VwcG9ydCB3YXMgcmVt b3ZlZCBiZWNhdXNlIHRoZSBRdCBNb2R1bGFyaXphdGlvbiBwcm9qZWN0IGRlY2lkZWQgd2UKKyAg ICAgICAgZG9uJ3QgbmVlZCBpdC4gSXQncyBiZXR0ZXIgdG8gYmFzZSBkZWNpc2lvbnMgb24gdGhl IGF2YWlsYWJsZQorICAgICAgICBpbmZvcm1hdGlvbiwgYXMgZGVtb25zdHJhdGVkIGluIHRoZSBw YXRjaCBieSBjaGVja2luZworICAgICAgICBRVC5waG9ub24uaW5jbHVkZXMuCisKKyAgICAgICAg KiBTb3VyY2UvV2ViS2l0LnByaToKKwogMjAxMS0wMy0zMSAgWGFuIExvcGV6ICA8eGxvcGV6QGln YWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC5wcmkgYi9Tb3VyY2UvV2ViS2l0LnByaQppbmRleCAxNWY4M2Nh Li5jNzYwNjZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0LnByaQorKysgYi9Tb3VyY2UvV2Vi S2l0LnByaQpAQCAtMTM0LDkgKzEzNCw5IEBAIHN5bWJpYW58bWFlbW81fG1hZW1vNiB7CiAKICMj IyMKIAotY29udGFpbnMoUVRfQ09ORklHLCBtb2R1bGFyKTohY29udGFpbnMoUVRfQ09ORklHLCB1 aXRvb2xzKXxkaXNhYmxlX3VpdG9vbHM6IERFRklORVMgKj0gUVRfTk9fVUlUT09MUworIWNvbnRh aW5zKFFUX0NPTkZJRywgdWl0b29scyl8ZGlzYWJsZV91aXRvb2xzOiBERUZJTkVTICo9IFFUX05P X1VJVE9PTFMKIAotIWNvbnRhaW5zKFFUX0NPTkZJRywgbW9kdWxhcikgeworaXNFbXB0eShRVC5w aG9ub24uaW5jbHVkZXMpIHsKICAgICBRVC5waG9ub24uaW5jbHVkZXMgPSAkJFFNQUtFX0lOQ0RJ Ul9RVC9waG9ub24KICAgICBRVC5waG9ub24ubGlicyA9ICQkUU1BS0VfTElCRElSX1FUCiB9Ci0t IAoxLjcuMy40Cgo=