57016 2011-03-24 08:14:26 -0700 [Qt] Avoid ASCII-cast warnings for WebKit. 2011-03-25 02:37:55 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 57087 0 kristian.amlie webkit-unassigned abarth benjamin commit-queue eric webkit.review.bot oldest_to_newest 372815 0 kristian.amlie 2011-03-24 08:14:26 -0700 Normally they won't be enabled anyway, but if you build webkit from within the Qt mother repository it will pick up Qt's default build settings, which do enable it. We need to disable them because warnings are treated as errors and there are way too many of them in the WebKit code. 372816 1 86774 kristian.amlie 2011-03-24 08:16:45 -0700 Created attachment 86774 Avoided-ASCII-cast-warnings-for-WebKit 372896 2 86774 benjamin 2011-03-24 10:23:19 -0700 Comment on attachment 86774 Avoided-ASCII-cast-warnings-for-WebKit How many error do you get? Could you create a task about removing that line? 372922 3 86774 commit-queue 2011-03-24 10:48:02 -0700 Comment on attachment 86774 Avoided-ASCII-cast-warnings-for-WebKit Clearing flags on attachment: 86774 Committed r81876: <http://trac.webkit.org/changeset/81876> 372923 4 commit-queue 2011-03-24 10:48:07 -0700 All reviewed patches have been landed. Closing bug. 373021 5 webkit.review.bot 2011-03-24 13:06:58 -0700 http://trac.webkit.org/changeset/81876 might have broken GTK Linux 32-bit Debug The following tests are not passing: svg/W3C-SVG-1.1/animate-elem-46-t.svg svg/W3C-SVG-1.1/animate-elem-82-t.svg 373370 6 kristian.amlie 2011-03-25 00:21:04 -0700 (In reply to comment #2) > (From update of attachment 86774 [details]) > How many error do you get? I didn't count exactly, since it causes the build to fail. But in a parallel build, it stacked up quite a few. > Could you create a task about removing that line? https://bugs.webkit.org/show_bug.cgi?id=57087 (In reply to comment #5) > http://trac.webkit.org/changeset/81876 might have broken GTK Linux 32-bit Debug > The following tests are not passing: > svg/W3C-SVG-1.1/animate-elem-46-t.svg > svg/W3C-SVG-1.1/animate-elem-82-t.svg I don't see how the submitted patch can have any effect on GTK. It doesn't even use qmake to build, does it? 373415 7 benjamin 2011-03-25 02:37:55 -0700 (In reply to comment #6) > > Could you create a task about removing that line? > > https://bugs.webkit.org/show_bug.cgi?id=57087 Thanks. > (In reply to comment #5) > > http://trac.webkit.org/changeset/81876 might have broken GTK Linux 32-bit Debug > > The following tests are not passing: > > svg/W3C-SVG-1.1/animate-elem-46-t.svg > > svg/W3C-SVG-1.1/animate-elem-82-t.svg > > I don't see how the submitted patch can have any effect on GTK. It doesn't even use qmake to build, does it? Don't worry about that. The bot just send the alert for all the changes since the last successful testing. 86774 2011-03-24 08:16:45 -0700 2011-03-24 10:48:02 -0700 Avoided-ASCII-cast-warnings-for-WebKit 0001-Avoided-ASCII-cast-warnings-for-WebKit.patch text/plain 2079 kristian.amlie RnJvbSAwOTZjYzBiNTMyZDYwNmY4MmVkNDQyMDc4ZDIzZTI3ZTc0MjlmNDE5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLcmlzdGlhbiBBbWxpZSA8a3Jpc3RpYW4uYW1saWVAbm9raWEu Y29tPgpEYXRlOiBUaHUsIDE3IEZlYiAyMDExIDE1OjIxOjA3ICswMTAwClN1YmplY3Q6IFtQQVRD SF0gQXZvaWRlZCBBU0NJSS1jYXN0IHdhcm5pbmdzIGZvciBXZWJLaXQuCgpOb3JtYWxseSB0aGV5 IHdvbid0IGJlIGVuYWJsZWQgYW55d2F5LCBidXQgaWYgeW91IGJ1aWxkIHdlYmtpdCBmcm9tCndp dGhpbiB0aGUgUXQgbW90aGVyIHJlcG9zaXRvcnkgaXQgd2lsbCBwaWNrIHVwIFF0J3MgZGVmYXVs dCBidWlsZApzZXR0aW5ncywgd2hpY2ggZG8gZW5hYmxlIGl0LiBXZSBuZWVkIHRvIGRpc2FibGUg dGhlbSBiZWNhdXNlCndhcm5pbmdzIGFyZSB0cmVhdGVkIGFzIGVycm9ycyBhbmQgdGhlcmUgYXJl IHdheSB0b28gbWFueSBvZiB0aGVtIGluCnRoZSBXZWJLaXQgY29kZS4KLS0tCiBTb3VyY2UvV2Vi S2l0L3F0L0NoYW5nZUxvZyAgICB8ICAgMTcgKysrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJL aXQvcXQvUXRXZWJLaXQucHJvIHwgICAgMyArKysKIDIgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0 aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDcyY2JlNWEuLjFkODk4 YWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDMtMjQgIEtyaXN0aWFu IEFtbGllICA8a3Jpc3RpYW4uYW1saWVAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEF2b2lkZWQgQVNDSUktY2FzdCB3YXJuaW5ncyBm b3IgV2ViS2l0LgorCisgICAgICAgIE5vcm1hbGx5IHRoZXkgd29uJ3QgYmUgZW5hYmxlZCBhbnl3 YXksIGJ1dCBpZiB5b3UgYnVpbGQgd2Via2l0IGZyb20KKyAgICAgICAgd2l0aGluIHRoZSBRdCBt b3RoZXIgcmVwb3NpdG9yeSBpdCB3aWxsIHBpY2sgdXAgUXQncyBkZWZhdWx0IGJ1aWxkCisgICAg ICAgIHNldHRpbmdzLCB3aGljaCBkbyBlbmFibGUgaXQuIFdlIG5lZWQgdG8gZGlzYWJsZSB0aGVt IGJlY2F1c2UKKyAgICAgICAgd2FybmluZ3MgYXJlIHRyZWF0ZWQgYXMgZXJyb3JzIGFuZCB0aGVy ZSBhcmUgd2F5IHRvbyBtYW55IG9mIHRoZW0gaW4KKyAgICAgICAgdGhlIFdlYktpdCBjb2RlLgor CisgICAgICAgIFtRdF0gQXZvaWQgQVNDSUktY2FzdCB3YXJuaW5ncyBmb3IgV2ViS2l0LgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTcwMTYKKworICAg ICAgICAqIFF0V2ViS2l0LnBybzoKKwogMjAxMS0wMy0yNCAgUHJhc2FudGggVWxsYXR0aWwgIDxw cmFzYW50aC51bGxhdHRpbEBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L1F0V2ViS2l0LnBybyBiL1Nv dXJjZS9XZWJLaXQvcXQvUXRXZWJLaXQucHJvCmluZGV4IDRiN2JiMDUuLjE2NTE4ZTAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvUXRXZWJLaXQucHJvCisrKyBiL1NvdXJjZS9XZWJLaXQv cXQvUXRXZWJLaXQucHJvCkBAIC04Miw2ICs4Miw5IEBAIENPTkZJRyhRVERJUl9idWlsZCkgewog ICAgIHN5bWJpYW46IFRBUkdFVCA9JCRUQVJHRVQkJHtRVF9MSUJJTkZJWH0KIH0KIAorIyBBdm9p ZCBBU0NJSS1jYXN0IHdhcm5pbmdzIGJlY2F1c2UgUXQgdXNlIHRoZW0gYSBsb3QgYW5kIHdhcm5p bmdzIGFyZSB0cmVhdGVkIGFzIGVycm9ycy4KK0RFRklORVMgLT0gUVRfQVNDSUlfQ0FTVF9XQVJO SU5HUworCiBzeW1iaWFuIHsKICAgICBUQVJHRVQuRVBPQ0FMTE9XRExMREFUQT0xCiAgICAgIyBE Uk0gYW5kIEFsbGZpbGVzIGNhcGFiaWxpdGVzIG5lZWQgdG8gYmUgYXVkaXRlZCB0byBiZSBzaWdu ZWQgb24gU3ltYmlhbgotLSAKMS43LjMuNAoK