5699 2005-11-10 07:23:09 -0800 REGRESSION: incomplete repaint 2005-12-27 22:33:15 -0800 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 VERIFIED FIXED P1 Normal --- 1 mitz hyatt webkit-bugs oldest_to_newest 23900 0 mitz 2005-11-10 07:23:09 -0800 Repaint following layout changes is incomplete. To reproduce: open the testcase. Click "Test!". A copy of "Lorem ipsum" is left behind as it moves down. Selecting all text or otherwise triggering repaint of that area clears it. 23901 1 4658 mitz 2005-11-10 07:24:37 -0800 Created attachment 4658 Testcase 26629 2 5279 mitz 2005-12-25 11:36:26 -0800 Created attachment 5279 Possible fix 26630 3 5279 mitz 2005-12-25 11:37:50 -0800 Comment on attachment 5279 Possible fix RenderObject::repaintAfterLayoutIfNeeded was lying about whether it did a full repaint. This patch makes it return the truth. The return value is only used in RenderBlock::layoutBlock. An alternative approach (perhaps better performance-wise) is to let repaintAfterLayoutIfNeeded take an extra "must repaint" rect as an argument and assure that it was repainted as well (if it returned true). If/when the code change is approved, I'll submit a more commit-friendly patch. I don't think there can be an automatic test for such a rendering bug. 26639 4 mjs 2005-12-25 16:40:29 -0800 I think a pixel test could catch this. You'd have to defer dumping, and programmatically do the equivalent of the button click from a timer or something. Would that work? 26643 5 5279 hyatt 2005-12-25 22:42:55 -0800 Comment on attachment 5279 Possible fix Nice one. I do not feel bad missing this one at all heh. 26658 6 5283 mitz 2005-12-26 10:14:41 -0800 Created attachment 5283 Complete patch w/ChangeLog entry and manual test 4658 2005-11-10 07:24:37 -0800 2005-11-10 07:24:37 -0800 Testcase repaintRegression.html text/html 299 mitz PGh0bWw+CjxoZWFkPgogICAgPHRpdGxlPlJlcGFpbnQgcmVncmVzc2lvbjwvdGl0bGU+CjwvaGVh ZD4KPGJvZHk+CiAgICAgICAgTG9yZW0gPGRpdiBpZD0iaW0iIHN0eWxlPSJ3aWR0aDoxMHB4OyBo ZWlnaHQ6MTBweDsgZGlzcGxheTppbmxpbmUtYmxvY2s7IGJhY2tncm91bmQ6cmVkOyI+PC9kaXY+ PGJyLz4KICAgICAgICBpcHN1bS4KICAgIDxwPjxhIGhyZWY9ImphdmFzY3JpcHQ6ZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoJ2ltJykuc3R5bGUuaGVpZ2h0ID0gMjAwOyI+VGVzdCE8L2E+PC9wPgo8 L2JvZHk+CjwvaHRtbD4= 5279 2005-12-25 11:36:26 -0800 2005-12-25 22:42:55 -0800 Possible fix 5699_r1.patch text/plain 795 mitz SW5kZXg6IFdlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9vYmplY3QuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfb2Jq ZWN0LmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4yMzEKZGlmZiAtcCAtdSAtcjEuMjMxIFdl YkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9vYmplY3QuY3BwCi0tLSBXZWJDb3JlL2todG1s L3JlbmRlcmluZy9yZW5kZXJfb2JqZWN0LmNwcAkyMSBEZWMgMjAwNSAyMjo1MToxMSAtMDAwMAkx LjIzMQorKysgV2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX29iamVjdC5jcHAJMjUgRGVj IDIwMDUgMTk6MzU6MjkgLTAwMDAKQEAgLTE0NTIsNiArMTQ1Miw3IEBAIGJvb2wgUmVuZGVyT2Jq ZWN0OjpyZXBhaW50QWZ0ZXJMYXlvdXRJZk4KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGtNaW4obmV3Qm91bmRzLnkoKSArIG5ld0JvdW5kcy5oZWlnaHQoKSwgb2xk Qm91bmRzLnkoKSArIG9sZEJvdW5kcy5oZWlnaHQoKSksCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBrTWF4KG5ld0JvdW5kcy53aWR0aCgpLCBvbGRCb3VuZHMud2lk dGgoKSksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBoZWlnaHQp KTsKKyAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KICAgICByZXR1cm4gdHJ1ZTsKIH0K 5283 2005-12-26 10:14:41 -0800 2005-12-26 10:14:41 -0800 Complete patch w/ChangeLog entry and manual test 5699_r2.patch text/plain 2824 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9X ZWJDb3JlL0NoYW5nZUxvZyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS40MQpkaWZmIC1wIC11IC1y MS40MSBXZWJDb3JlL0NoYW5nZUxvZwotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJMjUgRGVjIDIwMDUg MTg6Mjg6MjIgLTAwMDAJMS40MQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJMjYgRGVjIDIwMDUgMTg6 MjA6MzcgLTAwMDAKQEAgLTEsMyArMSwxNSBAQAorMjAwNS0xMi0jIyAgTWl0eiBQZXR0ZWwgIDxv cGVuZGFyd2luLm9yZ0BtaXR6cGV0dGVsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIC0gZml4IGh0dHA6Ly9idWd6aWxsYS5vcGVu ZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTY5OQorICAgICAgICAgIFJFR1JFU1NJT046IGlu Y29tcGxldGUgcmVwYWludAorCisgICAgICAgICoga2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9vYmpl Y3QuY3BwOgorICAgICAgICAoUmVuZGVyT2JqZWN0OjpyZXBhaW50QWZ0ZXJMYXlvdXRJZk5lZWRl ZCk6IFJldHVybiBmYWxzZSBpZiBvbmx5IHRoZQorICAgICAgICBzaXplIGNoYW5nZWQgYW5kIG5v dCBldmVyeXRoaW5nIHdhcyByZXBhaW50ZWQuCisgICAgICAgICogbWFudWFsLXRlc3RzL2J1Z3pp bGxhLTU2OTkuaHRtbDogQWRkZWQuCisKIDIwMDUtMTItMjQgIE1pdHogUGV0dGVsICA8b3BlbmRh cndpbi5vcmdAbWl0enBldHRlbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgZXNlaWRlbC4K SW5kZXg6IFdlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9vYmplY3QuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfb2Jq ZWN0LmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4yMzEKZGlmZiAtcCAtdSAtcjEuMjMxIFdl YkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9vYmplY3QuY3BwCi0tLSBXZWJDb3JlL2todG1s L3JlbmRlcmluZy9yZW5kZXJfb2JqZWN0LmNwcAkyMSBEZWMgMjAwNSAyMjo1MToxMSAtMDAwMAkx LjIzMQorKysgV2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX29iamVjdC5jcHAJMjYgRGVj IDIwMDUgMTg6MjA6NTYgLTAwMDAKQEAgLTE0NTIsNiArMTQ1Miw3IEBAIGJvb2wgUmVuZGVyT2Jq ZWN0OjpyZXBhaW50QWZ0ZXJMYXlvdXRJZk4KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGtNaW4obmV3Qm91bmRzLnkoKSArIG5ld0JvdW5kcy5oZWlnaHQoKSwgb2xk Qm91bmRzLnkoKSArIG9sZEJvdW5kcy5oZWlnaHQoKSksCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBrTWF4KG5ld0JvdW5kcy53aWR0aCgpLCBvbGRCb3VuZHMud2lk dGgoKSksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBoZWlnaHQp KTsKKyAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KICAgICByZXR1cm4gdHJ1ZTsKIH0KSW5k ZXg6IFdlYkNvcmUvbWFudWFsLXRlc3RzL2J1Z3ppbGxhLTU2OTkuaHRtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09CmRp ZmYgLU5wdSBXZWJDb3JlL21hbnVhbC10ZXN0cy9idWd6aWxsYS01Njk5Lmh0bWwKLS0tIFdlYkNv cmUvbWFudWFsLXRlc3RzL2J1Z3ppbGxhLTU2OTkuaHRtbAkxIEphbiAxOTcwIDAwOjAwOjAwIC0w MDAwCisrKyBXZWJDb3JlL21hbnVhbC10ZXN0cy9idWd6aWxsYS01Njk5Lmh0bWwJMjYgRGVjIDIw MDUgMTg6MDQ6NTAgLTAwMDAKQEAgLTAsMCArMSwyNyBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElD ICItLy9XM0MvL0RURCBIVE1MIDQuMDEvL0VOIgorICAgICAgICAiaHR0cDovL3d3dy53My5vcmcv VFIvaHRtbDQvc3RyaWN0LmR0ZCI+Cis8aHRtbCBsYW5nPSJlbiI+Cis8aGVhZD4KKzwvaGVhZD4K Kzxib2R5PgorPHA+PGI+QlVHIElEOjwvYj4gPGEgaHJlZj0iaHR0cDovL2J1Z3ppbGxhLm9wZW5k YXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD01Njk5Ij5CdWd6aWxsYSBidWcgNTY5OTwvYT4gUkVH UkVTU0lPTjogaW5jb21wbGV0ZSByZXBhaW50PC9wPgorCis8cCBpZD0idGVzdCIgc3R5bGU9ImJh Y2tncm91bmQtY29sb3I6c2t5Ymx1ZTsgcGFkZGluZzozcHg7Ij48Yj5TVEVQUyBUTyBURVNUOjwv Yj4gCitDbGljayB0aGUgVGVzdCBidXR0b24gYmVsb3cuCis8L3A+CisKKzxwIGlkPSJzdWNjZXNz IiBzdHlsZT0iYmFja2dyb3VuZC1jb2xvcjpwYWxlZ3JlZW47IHBhZGRpbmc6M3B4OyI+PGI+VEVT VCBQQVNTOjwvYj4gCitUaGUgd29yZCAmbGRxdW87SGVsbG8mcmRxdW87IHdpbGwgbW92ZSBkb3du LgorPC9wPgorCis8cCBpZD0iZmFpbHVyZSIgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6I0ZGMzMw MDsgcGFkZGluZzozcHg7Ij48Yj5URVNUIEZBSUw6PC9iPiAgCitBbm90aGVyIGNvcHkgb2YgdGhl IHdvcmQgJmxkcXVvO0hlbGxvJnJkcXVvOyB3aWxsIGFwcGVhci4KKzwvcD4KKworPGJ1dHRvbiBv bmNsaWNrPSJkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZCcpLnN0eWxlLmxpbmVIZWlnaHQgPSAz Ij5UZXN0PC9idXR0b24+Cis8cD4KKzxzcGFuIGlkPSJkIj4mbmJzcDs8L3NwYW4+PGJyPgorSGVs bG88YnI+Cis8L3A+Cis8L2JvZHk+Cis8L2h0bWw+Cg==