56881 2011-03-22 16:56:51 -0700 Teach update-webkit about gyp 2011-03-22 18:52:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 55018 1 eric eric abarth commit-queue dglazkov oldest_to_newest 371821 0 eric 2011-03-22 16:56:51 -0700 Teach update-webkit about gyp 371832 1 86547 eric 2011-03-22 17:02:32 -0700 Created attachment 86547 Patch 371834 2 86547 abarth 2011-03-22 17:03:42 -0700 Comment on attachment 86547 Patch ok. 371877 3 86547 abarth 2011-03-22 18:08:19 -0700 Comment on attachment 86547 Patch Clearing flags on attachment: 86547 Committed r81735: <http://trac.webkit.org/changeset/81735> 371878 4 abarth 2011-03-22 18:08:23 -0700 All reviewed patches have been landed. Closing bug. 371900 5 86547 mrowe 2011-03-22 18:47:03 -0700 Comment on attachment 86547 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86547&action=review > Tools/Scripts/generate-project-files:37 > +# This allows building from Source without a copy of Tools (as Apple's internal builds do). Note that this doesn’t help our builds at all since the builds in question check out using “svn export”, not using any WebKit scripts. 371902 6 mrowe 2011-03-22 18:48:05 -0700 In other words, that part of the comment is misleading as-is so I’m not sure why it’s present. 371905 7 abarth 2011-03-22 18:52:31 -0700 (In reply to comment #5) > (From update of attachment 86547 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86547&action=review > > > Tools/Scripts/generate-project-files:37 > > +# This allows building from Source without a copy of Tools (as Apple's internal builds do). > > Note that this doesn’t help our builds at all since the builds in question check out using “svn export”, not using any WebKit scripts. > > In other words, that part of the comment is misleading as-is so I’m not sure why it’s present. You obviously know more about the Apple internal build system than I do. The comment is meant to explain that we have two scripts in order to make Source buildable without Tools. As an example of such a situation, Tools is not an input into Apple's internal build system. We can certainly update the comment to explain this more clearly. 86547 2011-03-22 17:02:32 -0700 2011-03-22 18:47:03 -0700 Patch bug-56881-20110322170231.patch text/plain 5075 eric U3VidmVyc2lvbiBSZXZpc2lvbjogODE3MjIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwZjc2MDEwZDI0N2ZhZDE2ZmE5MzA5ZDBkY2EwMDA3ZTdh NzY0YzM0Li5jOTFjNDhhOTAwZTBhZmFiYjUxODhkYzcxYTdmMzlmNzIwMWY0YmU0IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQg QEAKIDIwMTEtMDMtMjIgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlYWNoIHVwZGF0ZS13ZWJr aXQgYWJvdXQgZ3lwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD01Njg4MQorCisgICAgICAgIFRoaXMgbWFrZXMgaXQgcG9zc2libGUgZm9yIHNvbWVvbmUg d2hvIGJ1aWxkcyBmcm9tIFhjb2RlCisgICAgICAgIHRvIGp1c3QgcnVuIHVwZGF0ZS13ZWJraXQg LS1neXAgYW5kIGhhdmUgdGhlIHByb2plY3QgZmlsZXMKKyAgICAgICAgZ2VuZXJhdGVkIGFmdGVy IHVwZGF0ZSBhdXRvbWF0aWNhbGx5LgorCisgICAgICAgIEkgYWxzbyBhZGRlZCBhIHN0YW5kLWFs b25lICJnZW5lcmF0ZS1wcm9qZWN0LWZpbGVzIiBzY3JpcHQKKyAgICAgICAgd3JhcHBpbmcgU291 cmNlL2d5cC9jb25maWd1cmUuICBUaGlzIG1ha2VzIHJ1bm5pbmcgZ3lwIHNpbXBsZXIKKyAgICAg ICAgc2luY2UgbW9zdCBwZW9wbGUgd2lsbCBub3QgaGF2ZSBneXAgb3IgU291cmNlL2d5cCBpbiB0 aGVpciBwYXRoLgorCisgICAgICAgICogU2NyaXB0cy9idWlsZC13ZWJraXQ6CisgICAgICAgICog U2NyaXB0cy9nZW5lcmF0ZS1wcm9qZWN0LWZpbGVzOiBBZGRlZC4KKyAgICAgICAgKiBTY3JpcHRz L3VwZGF0ZS13ZWJraXQ6CisKKzIwMTEtMDMtMjIgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQu b3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCiAKICAgICAgICAgQWRkIHN1 cHBvcnQgdG8gYnVpbGQtd2Via2l0IGZvciBidWlsZGluZyB3aXRoIGd5cC1nZW5lcmF0ZWQgcHJv amVjdCBmaWxlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQgYi9Ub29s cy9TY3JpcHRzL2J1aWxkLXdlYmtpdAppbmRleCAwZjE0MTQ3ZmRjMGM5MGQzNDg2Yjg5MmYxZTAz MmQ0MTI4OWYzMTJmLi41NWJlMTA5ZGIyZDg5ZWU1YzFmN2E0ZTUyYzI2YzBmOGRkYWE1MjNhIDEw MDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAorKysgYi9Ub29scy9TY3JpcHRz L2J1aWxkLXdlYmtpdApAQCAtNDIzLDcgKzQyMyw3IEBAIGZvciBteSAkZGlyIChAcHJvamVjdHMs IEBvdGhlckRpcnMpIHsKIAogIyBHZW5lcmF0ZSB0aGUgZ2VuZXJhdGUgcHJvamVjdCBmaWxlcyBm cm9tIC5neXAgZmlsZXMKIGlmICgkdXNlR1lQKSB7Ci0gICAgc3lzdGVtKCJweXRob24iLCAiU291 cmNlL2d5cC9jb25maWd1cmUiKSA9PSAwIG9yIGRpZSAiRmFpbGVkIHRvIHJ1biBTb3VyY2UvZ3lw L2NvbmZpZ3VyZSI7CisgICAgc3lzdGVtKCJwZXJsIiwgIlRvb2xzL1NjcmlwdHMvZ2VuZXJhdGUt cHJvamVjdC1maWxlcyIpID09IDAgb3IgZGllICJGYWlsZWQgdG8gcnVuIGdlbmVyYXRlLXByb2pl Y3QtZmlsZXMiOwogfQogCiBteSBAb3B0aW9ucyA9ICgpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy9nZW5lcmF0ZS1wcm9qZWN0LWZpbGVzIGIvVG9vbHMvU2NyaXB0cy9nZW5lcmF0ZS1wcm9q ZWN0LWZpbGVzCm5ldyBmaWxlIG1vZGUgMTAwNzU1CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjYwYTMyZTE5MTdlNDE0ZWYwMTdhNWJjMmUwYWM1ZWE0Njdk OThjODAKLS0tIC9kZXYvbnVsbAorKysgYi9Ub29scy9TY3JpcHRzL2dlbmVyYXRlLXByb2plY3Qt ZmlsZXMKQEAgLTAsMCArMSwzOCBAQAorIyEvdXNyL2Jpbi9wZXJsIC13CisKKyMgQ29weXJpZ2h0 IChDKSAyMDExIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjCisjIFJlZGlzdHJp YnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91 dAorIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93 aW5nIGNvbmRpdGlvbnMKKyMgYXJlIG1ldDoKKyMKKyMgMS4gIFJlZGlzdHJpYnV0aW9ucyBvZiBz b3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisjICAgICBub3RpY2Us IHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuIAor IyAyLiAgUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBh Ym92ZSBjb3B5cmlnaHQKKyMgICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5k IHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyMgICAgIGRvY3VtZW50YXRpb24gYW5k L29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uIAorIyAz LiAgTmVpdGhlciB0aGUgbmFtZSBvZiBBcHBsZSBDb21wdXRlciwgSW5jLiAoIkFwcGxlIikgbm9y IHRoZSBuYW1lcyBvZgorIyAgICAgaXRzIGNvbnRyaWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBlbmRv cnNlIG9yIHByb21vdGUgcHJvZHVjdHMgZGVyaXZlZAorIyAgICAgZnJvbSB0aGlzIHNvZnR3YXJl IHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLiAKKyMKKyMgVEhJUyBT T0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBBTkQgSVRTIENPTlRSSUJVVE9SUyAiQVMgSVMi IEFORCBBTlkKKyMgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVU IE5PVCBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRAorIyBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJ TElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFCisjIERJU0NMQUlN RUQuIElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIE9SIElUUyBDT05UUklCVVRPUlMgQkUgTElBQkxF IEZPUiBBTlkKKyMgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwgRVhFTVBM QVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMKKyMgKElOQ0xVRElORywgQlVUIE5PVCBMSU1J VEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOworIyBM T1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBI T1dFVkVSIENBVVNFRCBBTkQKKyMgT04gQU5ZIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIg SU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyMgKElOQ0xVRElORyBORUdM SUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9G CisjIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0Yg U1VDSCBEQU1BR0UuCisKK3VzZSBzdHJpY3Q7Cit1c2UgRmluZEJpbjsKK3VzZSBsaWIgJEZpbmRC aW46OkJpbjsKK3VzZSB3ZWJraXRkaXJzOworCitjaGRpcldlYktpdCgpOworCisjIFRoaXMgc2lt cGxlIHdyYXBwZXIgZXhpc3RzIHNvIHRoYXQgdGhlIGNvbmZpZ3VyZSBsb2dpYyBjYW4gbGl2ZSBp biB0aGUgU291cmNlIGRpcmVjdG9yeS4KKyMgVGhpcyBhbGxvd3MgYnVpbGRpbmcgZnJvbSBTb3Vy Y2Ugd2l0aG91dCBhIGNvcHkgb2YgVG9vbHMgKGFzIEFwcGxlJ3MgaW50ZXJuYWwgYnVpbGRzIGRv KS4KK3N5c3RlbSgicHl0aG9uIiwgIlNvdXJjZS9neXAvY29uZmlndXJlIiwgQEFSR1YpID09IDAg b3IgZGllICJGYWlsZWQgdG8gcnVuIFNvdXJjZS9neXAvY29uZmlndXJlIjsKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdCBiL1Rvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtp dAppbmRleCBjNmU1NGYzMzkzYTQzMzkzY2M2MjkxMGJiZDFiNTM1YzlhZjkzODkxLi41YzEzMmFl M2NjYjBmMzIxNzJkMDdiYzVhOGM0MjJhMGE1MTE4NjdhIDEwMDc1NQotLS0gYS9Ub29scy9TY3Jp cHRzL3VwZGF0ZS13ZWJraXQKKysrIGIvVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0CkBAIC00 NSw2ICs0NSw3IEBAIHN1YiBydW5HaXRVcGRhdGUoKTsKICMgSGFuZGxlIG9wdGlvbnMKIG15ICRx dWlldCA9ICcnOwogbXkgJHNob3dIZWxwOworbXkgJHVzZUdZUCA9IDA7CiAKIGRldGVybWluZUlz Q2hyb21pdW0oKTsKIApAQCAtNTMsNiArNTQsNyBAQCBjaGRpcldlYktpdCgpOwogbXkgJGdldE9w dGlvbnNSZXN1bHQgPSBHZXRPcHRpb25zKAogICAgICdofGhlbHAnICA9PiBcJHNob3dIZWxwLAog ICAgICdxfHF1aWV0JyA9PiBcJHF1aWV0LAorICAgICdneXAnID0+IFwkdXNlR1lQLAogKTsgCiAK IGlmICghJGdldE9wdGlvbnNSZXN1bHQgfHwgJHNob3dIZWxwKSB7CkBAIC02MSw2ICs2Myw3IEBA IFVzYWdlOiBAe1sgYmFzZW5hbWUoJDApIF19IFtvcHRpb25zXQogICAtLWNocm9taXVtICBhbHNv IHVwZGF0ZSBkZXBlbmRlbmNpZXMgb2YgdGhlIGNocm9taXVtIHBvcnQKICAgLWh8LS1oZWxwICAg c2hvdyB0aGUgaGVscCBtZXNzYWdlCiAgIC1xfC0tcXVpZXQgIHBhc3MgLXEgdG8gc3ZuIHVwZGF0 ZSBmb3IgcXVpZXQgdXBkYXRlcworICAtLWd5cCAgICAgICBnZW5lcmF0ZSBwcm9qZWN0IGZpbGVz IGZyb20gZ3lwIGFmdGVyIHVwZGF0ZQogX19FTkRfXwogICAgIGV4aXQgMTsKIH0KQEAgLTk3LDYg KzEwMCwxMSBAQCBpZiAoLWQgIi4uL0ludGVybmFsIikgewogCiBzZXR1cEFwcGxlV2luRW52KCkg aWYgaXNBcHBsZVdpbldlYktpdCgpOwogCitpZiAoJHVzZUdZUCkgeworICAgIHByaW50ICJHZW5l cmF0aW5nIFByb2plY3QgRmlsZXNcbiI7CisgICAgc3lzdGVtKCJwZXJsIiwgIlRvb2xzL1Njcmlw dHMvZ2VuZXJhdGUtcHJvamVjdC1maWxlcyIpID09IDAgb3IgZGllICJGYWlsZWQgdG8gcnVuIGdl bmVyYXRlLXByb2plY3QtZmlsZXMiOworfQorCiBleGl0IDA7CiAKIHN1YiBydW5Tdm5VcGRhdGUo KQo=