56868 2011-03-22 15:05:58 -0700 [chromium] Make WebClipboard::isFormatAvailable() be able to check for plain text 2011-06-18 19:58:32 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 viettrungluu webkit-unassigned commit-queue dcheng dimich eric tony oldest_to_newest 371690 0 viettrungluu 2011-03-22 15:05:58 -0700 Basically, in WebKit, we just need to add an entry to the WebClipboard::Format enum. I have a patch.... 371707 1 86518 viettrungluu 2011-03-22 15:19:25 -0700 Created attachment 86518 proposed patch 371716 2 viettrungluu 2011-03-22 15:28:38 -0700 Chromium-side CL containing corresponding changes in Chromium (and more): http://codereview.chromium.org/6724010/ 371771 3 viettrungluu 2011-03-22 16:11:25 -0700 Could I get a cq+ for this? Thanks in advance. 371874 4 86518 commit-queue 2011-03-22 17:57:37 -0700 Comment on attachment 86518 proposed patch Rejecting attachment 86518 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 2 Last 500 characters of output: r81731 = f40b03778352d945ee70aef9aa78b6ae6c6958fd (refs/remotes/trunk) M Source/WebKit/mac/Plugins/WebBasePluginPackage.mm M Source/WebKit/mac/ChangeLog M Source/WebKit2/ChangeLog M Source/WebKit2/Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm M Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp r81732 = 5099c56863c375e4089a7ad0c8e41ab88e201bbc (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/8228493 372221 5 86636 viettrungluu 2011-03-23 10:02:20 -0700 Created attachment 86636 take 2 (same patch, updated) 372223 6 viettrungluu 2011-03-23 10:03:03 -0700 Could we try again? (I thought the commit-queue was supposed to take care of ChangeLog conflicts?) 372320 7 commit-queue 2011-03-23 12:09:41 -0700 The commit-queue encountered the following flaky tests while processing attachment 86636: http/tests/websocket/tests/send.html bug 56945 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 372326 8 86636 commit-queue 2011-03-23 12:13:29 -0700 Comment on attachment 86636 take 2 (same patch, updated) Clearing flags on attachment: 86636 Committed r81792: <http://trac.webkit.org/changeset/81792> 372361 9 commit-queue 2011-03-23 12:36:39 -0700 The commit-queue encountered the following flaky tests while processing attachment 86636: media/invalid-media-url-crash.html bug 51138 (authors: inferno@chromium.org and jamesr@chromium.org) The commit-queue is continuing to process your patch. 423312 10 eric 2011-06-18 19:58:32 -0700 Looks like this was landed. 86518 2011-03-22 15:19:25 -0700 2011-03-22 17:57:37 -0700 proposed patch wk-patch text/plain 3267 viettrungluu SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxNzA2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMjIgIFZpZXQtVHJ1 bmcgTHV1ICA8dmlldHRydW5nbHV1QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIEFkZCBGb3JtYXRQbGFpblRl eHQgdG8gV2ViQ2xpcGJvYXJkOjpGb3JtYXQgZW51bWVyYXRpb24uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Njg2OAorCisgICAgICAgIENocm9taXVt J3MgV2ViQ2xpcGJvYXJkOjppc0Zvcm1hdEF2YWlsYWJsZSgpIHdpbGwgYmUgY29ycmVzcG9uZGlu Z2x5CisgICAgICAgIGV4dGVuZGVkLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vUGFz dGVib2FyZFByaXZhdGUuaDogQWRkIGNvcnJlc3BvbmRpbmcgZW51bSBlbnRyeS4KKyAgICAgICAg ICAgIFRoaXMgcGFydCBvZiB0aGUgY2hhbmdlIGlzIGluZXJ0IGFuZCBzaG91bGQgaGF2ZSBubyBl ZmZlY3QuCisKIDIwMTEtMDMtMjIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2Nocm9taXVtL1Bhc3RlYm9hcmRQcml2YXRlLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUGFzdGVib2FyZFByaXZhdGUuaAkocmV2aXNpb24g ODE3MDApCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QYXN0ZWJvYXJkUHJp dmF0ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw2ICszNiw3IEBAIG5hbWVzcGFjZSBXZWJDb3Jl IHsKICAgICBjbGFzcyBQYXN0ZWJvYXJkUHJpdmF0ZSB7CiAgICAgcHVibGljOgogICAgICAgICBl bnVtIENsaXBib2FyZEZvcm1hdCB7CisgICAgICAgICAgICBQbGFpblRleHRGb3JtYXQsCiAgICAg ICAgICAgICBIVE1MRm9ybWF0LAogICAgICAgICAgICAgQm9va21hcmtGb3JtYXQsCiAgICAgICAg ICAgICBXZWJTbWFydFBhc3RlRm9ybWF0LApJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJ KHJldmlzaW9uIDgxNzA2KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0wMy0yMiAgVmlldC1UcnVuZyBMdXUg IDx2aWV0dHJ1bmdsdXVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIEZvcm1hdFBsYWluVGV4dCB0byBX ZWJDbGlwYm9hcmQ6OkZvcm1hdCBlbnVtZXJhdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2ODY4CisKKyAgICAgICAgQ2hyb21pdW0ncyBXZWJD bGlwYm9hcmQ6OmlzRm9ybWF0QXZhaWxhYmxlKCkgd2lsbCBiZSBjb3JyZXNwb25kaW5nbHkKKyAg ICAgICAgZXh0ZW5kZWQuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViQ2xpcGJvYXJkLmg6CisgICAg ICAgICogc3JjL0Fzc2VydE1hdGNoaW5nRW51bXMuY3BwOgorCiAyMDExLTAzLTIyICBKYXkgQ2l2 ZWxsaSAgPGpjaXZlbGxpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZp ZCBMZXZpbi4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNsaXBib2Fy ZC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNsaXBi b2FyZC5oCShyZXZpc2lvbiA4MTcwMCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYkNsaXBib2FyZC5oCSh3b3JraW5nIGNvcHkpCkBAIC00NSw2ICs0NSw3IEBAIGNsYXNzIFdl YlVSTDsKIGNsYXNzIFdlYkNsaXBib2FyZCB7CiBwdWJsaWM6CiAgICAgZW51bSBGb3JtYXQgewor ICAgICAgICBGb3JtYXRQbGFpblRleHQsCiAgICAgICAgIEZvcm1hdEhUTUwsCiAgICAgICAgIEZv cm1hdEJvb2ttYXJrLAogICAgICAgICBGb3JtYXRTbWFydFBhc3RlCkluZGV4OiBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9Bc3NlcnRNYXRjaGluZ0VudW1zLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Bc3NlcnRNYXRjaGluZ0VudW1zLmNwcAkocmV2aXNp b24gODE3MDApCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Bc3NlcnRNYXRjaGluZ0Vu dW1zLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjExLDYgKzIxMSw3IEBAIENPTVBJTEVfQVNTRVJU X01BVENISU5HX0VOVU0oV2ViQXBwbGljYXQKIENPTVBJTEVfQVNTRVJUX01BVENISU5HX0VOVU0o V2ViQXBwbGljYXRpb25DYWNoZUhvc3Q6Ok9ic29sZXRlRXZlbnQsIEFwcGxpY2F0aW9uQ2FjaGVI b3N0OjpPQlNPTEVURV9FVkVOVCk7CiAjZW5kaWYKIAorQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdf RU5VTShXZWJDbGlwYm9hcmQ6OkZvcm1hdFBsYWluVGV4dCwgUGFzdGVib2FyZFByaXZhdGU6OlBs YWluVGV4dEZvcm1hdCk7CiBDT01QSUxFX0FTU0VSVF9NQVRDSElOR19FTlVNKFdlYkNsaXBib2Fy ZDo6Rm9ybWF0SFRNTCwgUGFzdGVib2FyZFByaXZhdGU6OkhUTUxGb3JtYXQpOwogQ09NUElMRV9B U1NFUlRfTUFUQ0hJTkdfRU5VTShXZWJDbGlwYm9hcmQ6OkZvcm1hdEJvb2ttYXJrLCBQYXN0ZWJv YXJkUHJpdmF0ZTo6Qm9va21hcmtGb3JtYXQpOwogQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5V TShXZWJDbGlwYm9hcmQ6OkZvcm1hdFNtYXJ0UGFzdGUsIFBhc3RlYm9hcmRQcml2YXRlOjpXZWJT bWFydFBhc3RlRm9ybWF0KTsK 86636 2011-03-23 10:02:20 -0700 2011-03-23 12:13:29 -0700 take 2 (same patch, updated) wk-patch-2 text/plain 3286 viettrungluu SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxNzgwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMjIgIFZpZXQtVHJ1 bmcgTHV1ICA8dmlldHRydW5nbHV1QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIEFkZCBGb3JtYXRQbGFpblRl eHQgdG8gV2ViQ2xpcGJvYXJkOjpGb3JtYXQgZW51bWVyYXRpb24uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Njg2OAorCisgICAgICAgIENocm9taXVt J3MgV2ViQ2xpcGJvYXJkOjppc0Zvcm1hdEF2YWlsYWJsZSgpIHdpbGwgYmUgY29ycmVzcG9uZGlu Z2x5CisgICAgICAgIGV4dGVuZGVkLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vUGFz dGVib2FyZFByaXZhdGUuaDogQWRkIGNvcnJlc3BvbmRpbmcgZW51bSBlbnRyeS4KKyAgICAgICAg ICAgIFRoaXMgcGFydCBvZiB0aGUgY2hhbmdlIGlzIGluZXJ0IGFuZCBzaG91bGQgaGF2ZSBubyBl ZmZlY3QuCisKIDIwMTEtMDMtMjEgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Bhc3RlYm9hcmRQcml2YXRlLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUGFzdGVib2FyZFByaXZh dGUuaAkocmV2aXNpb24gODE3ODApCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1 bS9QYXN0ZWJvYXJkUHJpdmF0ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw2ICszNiw3IEBAIG5h bWVzcGFjZSBXZWJDb3JlIHsKICAgICBjbGFzcyBQYXN0ZWJvYXJkUHJpdmF0ZSB7CiAgICAgcHVi bGljOgogICAgICAgICBlbnVtIENsaXBib2FyZEZvcm1hdCB7CisgICAgICAgICAgICBQbGFpblRl eHRGb3JtYXQsCiAgICAgICAgICAgICBIVE1MRm9ybWF0LAogICAgICAgICAgICAgQm9va21hcmtG b3JtYXQsCiAgICAgICAgICAgICBXZWJTbWFydFBhc3RlRm9ybWF0LApJbmRleDogU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxNzgwKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1 bS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0wMy0yMiAg VmlldC1UcnVuZyBMdXUgIDx2aWV0dHJ1bmdsdXVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIEZvcm1h dFBsYWluVGV4dCB0byBXZWJDbGlwYm9hcmQ6OkZvcm1hdCBlbnVtZXJhdGlvbi4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2ODY4CisKKyAgICAgICAg Q2hyb21pdW0ncyBXZWJDbGlwYm9hcmQ6OmlzRm9ybWF0QXZhaWxhYmxlKCkgd2lsbCBiZSBjb3Jy ZXNwb25kaW5nbHkKKyAgICAgICAgZXh0ZW5kZWQuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViQ2xp cGJvYXJkLmg6CisgICAgICAgICogc3JjL0Fzc2VydE1hdGNoaW5nRW51bXMuY3BwOgorCiAyMDEx LTAzLTIzICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJDbGlwYm9hcmQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJDbGlwYm9hcmQuaAkocmV2aXNpb24gODE3ODApCisrKyBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJDbGlwYm9hcmQuaAkod29ya2luZyBjb3B5KQpAQCAtNDUs NiArNDUsNyBAQCBjbGFzcyBXZWJVUkw7CiBjbGFzcyBXZWJDbGlwYm9hcmQgewogcHVibGljOgog ICAgIGVudW0gRm9ybWF0IHsKKyAgICAgICAgRm9ybWF0UGxhaW5UZXh0LAogICAgICAgICBGb3Jt YXRIVE1MLAogICAgICAgICBGb3JtYXRCb29rbWFyaywKICAgICAgICAgRm9ybWF0U21hcnRQYXN0 ZQpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXNzZXJ0TWF0Y2hpbmdFbnVtcy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXNzZXJ0TWF0Y2hp bmdFbnVtcy5jcHAJKHJldmlzaW9uIDgxNzgwKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvQXNzZXJ0TWF0Y2hpbmdFbnVtcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIxMSw2ICsyMTEs NyBAQCBDT01QSUxFX0FTU0VSVF9NQVRDSElOR19FTlVNKFdlYkFwcGxpY2F0CiBDT01QSUxFX0FT U0VSVF9NQVRDSElOR19FTlVNKFdlYkFwcGxpY2F0aW9uQ2FjaGVIb3N0OjpPYnNvbGV0ZUV2ZW50 LCBBcHBsaWNhdGlvbkNhY2hlSG9zdDo6T0JTT0xFVEVfRVZFTlQpOwogI2VuZGlmCiAKK0NPTVBJ TEVfQVNTRVJUX01BVENISU5HX0VOVU0oV2ViQ2xpcGJvYXJkOjpGb3JtYXRQbGFpblRleHQsIFBh c3RlYm9hcmRQcml2YXRlOjpQbGFpblRleHRGb3JtYXQpOwogQ09NUElMRV9BU1NFUlRfTUFUQ0hJ TkdfRU5VTShXZWJDbGlwYm9hcmQ6OkZvcm1hdEhUTUwsIFBhc3RlYm9hcmRQcml2YXRlOjpIVE1M Rm9ybWF0KTsKIENPTVBJTEVfQVNTRVJUX01BVENISU5HX0VOVU0oV2ViQ2xpcGJvYXJkOjpGb3Jt YXRCb29rbWFyaywgUGFzdGVib2FyZFByaXZhdGU6OkJvb2ttYXJrRm9ybWF0KTsKIENPTVBJTEVf QVNTRVJUX01BVENISU5HX0VOVU0oV2ViQ2xpcGJvYXJkOjpGb3JtYXRTbWFydFBhc3RlLCBQYXN0 ZWJvYXJkUHJpdmF0ZTo6V2ViU21hcnRQYXN0ZUZvcm1hdCk7Cg==