56864 2011-03-22 14:41:09 -0700 Add the remaining steps to WebCore GYP build 2011-03-22 14:52:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 55018 1 abarth abarth dglazkov eric oldest_to_newest 371661 0 abarth 2011-03-22 14:41:09 -0700 Add the remaining steps to WebCore GYP build 371664 1 86510 abarth 2011-03-22 14:44:39 -0700 Created attachment 86510 Patch 371670 2 86510 eric 2011-03-22 14:47:47 -0700 Comment on attachment 86510 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86510&action=review > Source/WebCore/gyp/copy-inspector-resources.sh:8 > +rm -f "${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector/WebKit.qrc" Seems ${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector wants to be a local variable. :) 371672 3 abarth 2011-03-22 14:48:56 -0700 (In reply to comment #2) > (From update of attachment 86510 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86510&action=review > > > Source/WebCore/gyp/copy-inspector-resources.sh:8 > > +rm -f "${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector/WebKit.qrc" > > Seems ${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector wants to be a local variable. :) True. I didn't write this script. (It's hard-coded into the xcodeproj.) I suspect once we have this stuff "out in the open", there are lots of things we can improve. 371675 4 86510 abarth 2011-03-22 14:52:14 -0700 Comment on attachment 86510 Patch Clearing flags on attachment: 86510 Committed r81706: <http://trac.webkit.org/changeset/81706> 371676 5 abarth 2011-03-22 14:52:18 -0700 All reviewed patches have been landed. Closing bug. 86510 2011-03-22 14:44:39 -0700 2011-03-22 14:52:14 -0700 Patch bug-56864-20110322144437.patch text/plain 5190 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogODE2OTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlMzYzMjI3ZTc3ODEzZGM2 MmQ4ZTg2MjY4MWIzZDJiYmNjYWU5YmU2Li5kMjYwMjJkOWRjZjRmNmJlZmJmZGEwNTliMzZhNmVm NTlkNmQzMTkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTEtMDMtMjIgIEFkYW0g QmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgdGhlIHJlbWFpbmluZyBzdGVwcyB0byBXZWJDb3JlIEdZ UCBidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTY4NjQKKworICAgICAgICBUaGVzZSBzdGVwcyBtYXRjaCB0aGUgbm9ybWFsIGJ1aWxkLiAgQWZ0 ZXIgdGhpcyBwYXRjaCwgSSBiZWxpZXZlIHRoZQorICAgICAgICBXZWJDb3JlIEdZUCBidWlsZCBp cyBjb21wbGV0ZS4KKworICAgICAgICAqIFdlYkNvcmUuZ3lwaToKKyAgICAgICAgKiBneXAvV2Vi Q29yZS5neXA6CisgICAgICAgICogZ3lwL2NvcHktaW5zcGVjdG9yLXJlc291cmNlcy5zaDogQWRk ZWQuCisKKzIwMTEtMDMtMjIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwogICAg ICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KIAogICAgICAgICBXZWJDb3JlIEdZUCBidWls ZCBzaG91bGQgYnVpbGQgd2l0aG91dCBoZWxwIGZyb20gbm9ybWFsIFdlYkNvcmUgYnVpbGQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwaSBiL1NvdXJjZS9XZWJDb3JlL1dl YkNvcmUuZ3lwaQppbmRleCAyZTg2MWYxMzU5OWI0MmZhNDBmZGNlNjBkZWE5YzM3Njc5ZGI3Zjg3 Li44ZjljYzQ3NmIyNmEwYTdkN2U4Y2NjZmRkYjVhY2RhMmI2NzgwM2UxIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cGkKKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5n eXBpCkBAIC02MjQ2LDggKzYyNDYsNDQgQEAKICAgICAgICAgICAgICd4bWwvWFNMVFVuaWNvZGVT b3J0LmNwcCcsCiAgICAgICAgICAgICAneG1sL1hTTFRVbmljb2RlU29ydC5oJywKICAgICAgICAg XSwKKyAgICAgICAgJ3dlYmNvcmVfcmVzb3VyY2VfZmlsZXMnOiBbCisgICAgICAgICAgICAnRW5n bGlzaC5scHJvai9Mb2NhbGl6YWJsZS5zdHJpbmdzJywKKyAgICAgICAgICAgICdFbmdsaXNoLmxw cm9qL2xvY2FsaXplZFN0cmluZ3MuanMnLAorICAgICAgICAgICAgJ1Jlc291cmNlcy9hbGlhc0N1 cnNvci5wbmcnLAorICAgICAgICAgICAgJ1Jlc291cmNlcy9jZWxsQ3Vyc29yLnBuZycsCisgICAg ICAgICAgICAnUmVzb3VyY2VzL2NvbnRleHRNZW51Q3Vyc29yLnBuZycsCisgICAgICAgICAgICAn UmVzb3VyY2VzL2NvcHlDdXJzb3IucG5nJywKKyAgICAgICAgICAgICdSZXNvdXJjZXMvY3Jvc3NI YWlyQ3Vyc29yLnBuZycsCisgICAgICAgICAgICAnUmVzb3VyY2VzL2RlbGV0ZUJ1dHRvbi50aWZm JywKKyAgICAgICAgICAgICdSZXNvdXJjZXMvZGVsZXRlQnV0dG9uUHJlc3NlZC50aWZmJywKKyAg ICAgICAgICAgICdSZXNvdXJjZXMvZWFzdFJlc2l6ZUN1cnNvci5wbmcnLAorICAgICAgICAgICAg J1Jlc291cmNlcy9lYXN0V2VzdFJlc2l6ZUN1cnNvci5wbmcnLAorICAgICAgICAgICAgJ1Jlc291 cmNlcy9oZWxwQ3Vyc29yLnBuZycsCisgICAgICAgICAgICAnUmVzb3VyY2VzL2lucHV0U3BlZWNo LnRpZmYnLAorICAgICAgICAgICAgJ1Jlc291cmNlcy9saW5rQ3Vyc29yLnBuZycsCisgICAgICAg ICAgICAnUmVzb3VyY2VzL21pc3NpbmdJbWFnZS50aWZmJywKKyAgICAgICAgICAgICdSZXNvdXJj ZXMvbW92ZUN1cnNvci5wbmcnLAorICAgICAgICAgICAgJ1Jlc291cmNlcy9ub0Ryb3BDdXJzb3Iu cG5nJywKKyAgICAgICAgICAgICdSZXNvdXJjZXMvbm9uZUN1cnNvci5wbmcnLAorICAgICAgICAg ICAgJ1Jlc291cmNlcy9ub3J0aEVhc3RSZXNpemVDdXJzb3IucG5nJywKKyAgICAgICAgICAgICdS ZXNvdXJjZXMvbm9ydGhFYXN0U291dGhXZXN0UmVzaXplQ3Vyc29yLnBuZycsCisgICAgICAgICAg ICAnUmVzb3VyY2VzL25vcnRoUmVzaXplQ3Vyc29yLnBuZycsCisgICAgICAgICAgICAnUmVzb3Vy Y2VzL25vcnRoU291dGhSZXNpemVDdXJzb3IucG5nJywKKyAgICAgICAgICAgICdSZXNvdXJjZXMv bm9ydGhXZXN0UmVzaXplQ3Vyc29yLnBuZycsCisgICAgICAgICAgICAnUmVzb3VyY2VzL25vcnRo V2VzdFNvdXRoRWFzdFJlc2l6ZUN1cnNvci5wbmcnLAorICAgICAgICAgICAgJ1Jlc291cmNlcy9u b3RBbGxvd2VkQ3Vyc29yLnBuZycsCisgICAgICAgICAgICAnUmVzb3VyY2VzL3Byb2dyZXNzQ3Vy c29yLnBuZycsCisgICAgICAgICAgICAnUmVzb3VyY2VzL3NvdXRoRWFzdFJlc2l6ZUN1cnNvci5w bmcnLAorICAgICAgICAgICAgJ1Jlc291cmNlcy9zb3V0aFJlc2l6ZUN1cnNvci5wbmcnLAorICAg ICAgICAgICAgJ1Jlc291cmNlcy9zb3V0aFdlc3RSZXNpemVDdXJzb3IucG5nJywKKyAgICAgICAg ICAgICdSZXNvdXJjZXMvdGV4dEFyZWFSZXNpemVDb3JuZXIudGlmZicsCisgICAgICAgICAgICAn UmVzb3VyY2VzL3ZlcnRpY2FsVGV4dEN1cnNvci5wbmcnLAorICAgICAgICAgICAgJ1Jlc291cmNl cy93YWl0Q3Vyc29yLnBuZycsCisgICAgICAgICAgICAnUmVzb3VyY2VzL3dlc3RSZXNpemVDdXJz b3IucG5nJywKKyAgICAgICAgICAgICdSZXNvdXJjZXMvem9vbUluQ3Vyc29yLnBuZycsCisgICAg ICAgICAgICAnUmVzb3VyY2VzL3pvb21PdXRDdXJzb3IucG5nJywKKyAgICAgICAgXSwKICAgICAg ICAgJ3dlYmluc3BlY3Rvcl9maWxlcyc6IFsKLQogICAgICAgICAgICAgJ2luc3BlY3Rvci9mcm9u dC1lbmQvaW5zcGVjdG9yLmh0bWwnLAogICAgICAgICAgICAgJ2luc3BlY3Rvci9mcm9udC1lbmQv QXBwbGljYXRpb25DYWNoZUl0ZW1zVmlldy5qcycsCiAgICAgICAgICAgICAnaW5zcGVjdG9yL2Zy b250LWVuZC9BdWRpdENhdGVnb3JpZXMuanMnLApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Z3lwL1dlYkNvcmUuZ3lwIGIvU291cmNlL1dlYkNvcmUvZ3lwL1dlYkNvcmUuZ3lwCmluZGV4IDdi MWExNGQxM2RkMDkxNDJiODkzZjQzMzExZGJkMzJlNTVkNzkwOGEuLjY2MjY0YjkxMDIzY2Q4NTNl YjEyNDBlOGE4OWNkN2YwMmE4ZWVlZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2d5cC9X ZWJDb3JlLmd5cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9neXAvV2ViQ29yZS5neXAKQEAgLTEzNCw2 ICsxMzQsOSBAQAogICAgICAgJ21hY19mcmFtZXdvcmtfcHJpdmF0ZV9oZWFkZXJzJzogWwogICAg ICAgICAnPEAod2ViY29yZV9wcml2YXRlaGVhZGVyX2ZpbGVzKScsCiAgICAgICBdLAorICAgICAg J21hY19idW5kbGVfcmVzb3VyY2VzJzogWworICAgICAgICAnPEAod2ViY29yZV9yZXNvdXJjZV9m aWxlcyknLAorICAgICAgXSwKICAgICAgICd4Y29kZV9jb25maWdfZmlsZSc6ICc8KHByb2plY3Rf ZGlyKS9Db25maWd1cmF0aW9ucy9XZWJDb3JlLnhjY29uZmlnJywKICAgICAgICdhY3Rpb25zJzog WwogICAgICAgICB7CkBAIC0xNDUsNiArMTQ4LDE0IEBACiAgICAgICAgICAgXSwKICAgICAgICAg fSwKICAgICAgICAgeworICAgICAgICAgICdhY3Rpb25fbmFtZSc6ICdDb3B5IEluc3BlY3RvciBS ZXNvdXJjZXMnLAorICAgICAgICAgICdpbnB1dHMnOiBbXSwKKyAgICAgICAgICAnb3V0cHV0cyc6 IFtdLAorICAgICAgICAgICdhY3Rpb24nOiBbCisgICAgICAgICAgICAnc2gnLCAnPChwcm9qZWN0 X2RpcikvZ3lwL2NvcHktaW5zcGVjdG9yLXJlc291cmNlcy5zaCcKKyAgICAgICAgICBdLAorICAg ICAgICB9LAorICAgICAgICB7CiAgICAgICAgICAgJ2FjdGlvbl9uYW1lJzogJ1N0cmVhbWxpbmUg SW5zcGVjdG9yIFNvdXJjZScsCiAgICAgICAgICAgJ2lucHV0cyc6IFtdLAogICAgICAgICAgICdv dXRwdXRzJzogW10sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9neXAvY29weS1pbnNwZWN0 b3ItcmVzb3VyY2VzLnNoIGIvU291cmNlL1dlYkNvcmUvZ3lwL2NvcHktaW5zcGVjdG9yLXJlc291 cmNlcy5zaApuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi45Nzk1NjI0NWE0ZjYzMjE0Mjg3ZTcxZGUyY2RjZTUxNzc2OWUx YmM1Ci0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dlYkNvcmUvZ3lwL2NvcHktaW5zcGVjdG9y LXJlc291cmNlcy5zaApAQCAtMCwwICsxLDE0IEBACisjIS9iaW4vc2gKKworIyBDb3B5IGFsbCB0 aGUgSW5zcGVjdG9yIGZyb250LWVuZCByZXNvdXJjZXMuCitkaXR0byAiJHtTUkNST09UfS8uLi9p bnNwZWN0b3IvZnJvbnQtZW5kIiAiJHtUQVJHRVRfQlVJTERfRElSfS8ke1VOTE9DQUxJWkVEX1JF U09VUkNFU19GT0xERVJfUEFUSH0vaW5zcGVjdG9yIgorZGl0dG8gIiR7QlVJTFRfUFJPRFVDVFNf RElSfS9EZXJpdmVkU291cmNlcy9XZWJDb3JlL0luc3BlY3RvckJhY2tlbmRTdHViLmpzIiAiJHtU QVJHRVRfQlVJTERfRElSfS8ke1VOTE9DQUxJWkVEX1JFU09VUkNFU19GT0xERVJfUEFUSH0vaW5z cGVjdG9yIgorCisjIFJlbW92ZSB0aGUgV2ViS2l0LnFyYyBmaWxlIHNpbmNlIGl0IGlzIG5vdCB1 c2VkIG9uIHRoZSBNYWMgKHRoaXMgZmlsZSBpcyBmb3IgUXQpLgorcm0gLWYgIiR7VEFSR0VUX0JV SUxEX0RJUn0vJHtVTkxPQ0FMSVpFRF9SRVNPVVJDRVNfRk9MREVSX1BBVEh9L2luc3BlY3Rvci9X ZWJLaXQucXJjIgorCisjIFJlbW92ZSAqLnJlMmpzIGZpbGVzLCB0aGV5IGFyZSBvbmx5IHVzZWQg dG8gZ2VuZXJhdGUgc29tZSAuanMgZmlsZXMuCitybSAtZiAiJHtUQVJHRVRfQlVJTERfRElSfS8k e1VOTE9DQUxJWkVEX1JFU09VUkNFU19GT0xERVJfUEFUSH0vaW5zcGVjdG9yLyIqLnJlMmpzCisK KyMgUmVtb3ZlIGFueSAuc3ZuIGRpcmVjdG9yaWVzIHRoYXQgbWF5IGhhdmUgYmVlbiBjb3BpZWQg b3Zlci4KK2ZpbmQgIiR7VEFSR0VUX0JVSUxEX0RJUn0vJHtVTkxPQ0FMSVpFRF9SRVNPVVJDRVNf Rk9MREVSX1BBVEh9L2luc3BlY3RvciIgLW5hbWUgIi5zdm4iIC10eXBlIGQgfCB4YXJncyBybSAt cmYK