56862 2011-03-22 14:18:26 -0700 Add Profiling Configuration to JavaScriptCore gyp build 2011-03-22 14:54:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 55018 1 eric eric abarth barraclough dglazkov mrowe oldest_to_newest 371633 0 eric 2011-03-22 14:18:26 -0700 Add Profiling Configuration to JavaScriptCore gyp build 371634 1 86504 eric 2011-03-22 14:19:34 -0700 Created attachment 86504 Patch 371635 2 eric 2011-03-22 14:20:10 -0700 If there is a difference between Release and Profiling (other than name) and I failed to correctly replicate that difference in the gyp build, please let me know and I'll be happy to fix it! 371643 3 eric 2011-03-22 14:29:10 -0700 Committed r81701: <http://trac.webkit.org/changeset/81701> 371645 4 eric 2011-03-22 14:30:53 -0700 I see support for --profiling in build-webkit (via webkitdirs.pm): if ($opt =~ /^--profil(e|ing)$/i) { splice(@ARGV, $i, 1); $passedConfiguration = "Profiling"; $passedConfiguration .= "_Cairo_CFLite" if ($isWinCairo && isCygwin()); return; } But no other references in the project as far as I can tell. 371648 5 eric 2011-03-22 14:32:48 -0700 This was added as part of the SFX write. I suspect it is now vestigial: http://trac.webkit.org/changeset/36244 371649 6 mrowe 2011-03-22 14:33:10 -0700 It’s not. The differences are in the .xcconfig files. 371656 7 eric 2011-03-22 14:36:32 -0700 Yes, "Profiling" was added by mrowe back in: http://trac.webkit.org/changeset/36136 and was different from Release at that time. I no longer believe it's different since we no longer explicitly set -fomit-frame-pointer in any configuration that I can tell. (at least not via the pbxproj file). 371658 8 eric 2011-03-22 14:38:06 -0700 (In reply to comment #6) > It’s not. The differences are in the .xcconfig files. I'll just trust you on that one. :) I don't see them, but that doesn't mean they're not there. Can you confirm that I set up Profiling correctly in the GYP build? I've verified that the generated project.pbxproj looks the same (at least as far as this is concerned). 371677 9 mrowe 2011-03-22 14:52:36 -0700 (In reply to comment #7) > Yes, "Profiling" was added by mrowe back in: > http://trac.webkit.org/changeset/36136 > and was different from Release at that time. > I no longer believe it's different since we no longer explicitly set -fomit-frame-pointer in any configuration that I can tell. (at least not via the pbxproj file). OTHER_CFLAGS = $(OTHER_CFLAGS_$(CONFIGURATION)_$(CURRENT_VARIANT)); OTHER_CFLAGS_Release_normal = $(OTHER_CFLAGS_normal_$(TARGET_GCC_VERSION)); OTHER_CFLAGS_Production_normal = $(OTHER_CFLAGS_normal_$(TARGET_GCC_VERSION)); OTHER_CFLAGS_normal_GCC_42 = -fomit-frame-pointer -funwind-tables; OTHER_CFLAGS_normal_LLVM_GCC_42 = $(OTHER_CFLAGS_normal_GCC_42); “grep” clearly shows that we DO set -fomit-frame-pointer. 371679 10 eric 2011-03-22 14:54:31 -0700 (In reply to comment #9) > (In reply to comment #7) > > Yes, "Profiling" was added by mrowe back in: > > http://trac.webkit.org/changeset/36136 > > and was different from Release at that time. > > I no longer believe it's different since we no longer explicitly set -fomit-frame-pointer in any configuration that I can tell. (at least not via the pbxproj file). > > OTHER_CFLAGS = $(OTHER_CFLAGS_$(CONFIGURATION)_$(CURRENT_VARIANT)); > OTHER_CFLAGS_Release_normal = $(OTHER_CFLAGS_normal_$(TARGET_GCC_VERSION)); > OTHER_CFLAGS_Production_normal = $(OTHER_CFLAGS_normal_$(TARGET_GCC_VERSION)); > OTHER_CFLAGS_normal_GCC_42 = -fomit-frame-pointer -funwind-tables; > OTHER_CFLAGS_normal_LLVM_GCC_42 = $(OTHER_CFLAGS_normal_GCC_42); > > “grep” clearly shows that we DO set -fomit-frame-pointer. Interesting. Thank you for the information. 86504 2011-03-22 14:19:34 -0700 2011-03-22 14:27:22 -0700 Patch bug-56862-20110322141933.patch text/plain 2111 eric U3VidmVyc2lvbiBSZXZpc2lvbjogODE2OTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDhl MDI0NjI3YjhiZmY5ZDFiYmMzZWQzNzEwOWJlYWJiZmY1MjlhMTMuLjY5MTlmZDJkYmFjM2E2YTA0 YjAwNDk2ODI1ODQ4MDJhZjMwOWQ5YWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDExLTAzLTIyICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgUHJvZmls aW5nIENvbmZpZ3VyYXRpb24gdG8gSmF2YVNjcmlwdENvcmUgZ3lwIGJ1aWxkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Njg2MgorCisgICAgICAgIEl0 IGFwcGVhcnMgdGhpcyBpcyBpZGVudGljYWwgdG8gUmVsZWFzZSwgYnV0IEkgc3VzcGVjdAorICAg ICAgICB0aGVyZSBpcyBzb21lb25lL3RoaW5nIHdobyB1c2VzIHRoZSBQcm9maWxpbmcgdGFyZ2V0 CisgICAgICAgIHNvIHdlJ3JlIGFkZGluZyBpdCBmb3IgY29tcGxldGVuZXNzLgorCisgICAgICAg ICogZ3lwL0phdmFTY3JpcHRDb3JlLmd5cDoKKwogMjAxMS0wMy0yMiAgQWRhbSBCYXJ0aCAgPGFi YXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2d5cC9KYXZhU2NyaXB0Q29yZS5neXAgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZ3lwL0phdmFTY3JpcHRDb3JlLmd5cAppbmRleCA5NmMyNGFl YTdjMDYzYTAwOTE3YmZhOWM2NThjODlmNTNjZGEwMmYzLi45NDVjMWRiYzEyZGM2NjUwZjMwODEy MGQ0MjE4NmVjNDJiNzk2OWJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZ3lw L0phdmFTY3JpcHRDb3JlLmd5cAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZ3lwL0phdmFT Y3JpcHRDb3JlLmd5cApAQCAtNyw2ICs3LDEyIEBACiAgICAgJ1Byb2R1Y3Rpb24nOiB7CiAgICAg ICAneGNvZGVfY29uZmlnX2ZpbGUnOiAnPChwcm9qZWN0X2RpcikvQ29uZmlndXJhdGlvbnMvQmFz ZS54Y2NvbmZpZycsCiAgICAgfSwKKyAgICAnUHJvZmlsaW5nJzogeworICAgICAgJ3hjb2RlX2Nv bmZpZ19maWxlJzogJzwocHJvamVjdF9kaXIpL0NvbmZpZ3VyYXRpb25zL0RlYnVnUmVsZWFzZS54 Y2NvbmZpZycsCisgICAgICAneGNvZGVfc2V0dGluZ3MnOiB7CisgICAgICAgICdTVFJJUF9JTlNU QUxMRURfUFJPRFVDVCc6ICdOTycsCisgICAgICB9LAorICAgIH0sCiAgICAgJ1JlbGVhc2UnOiB7 CiAgICAgICAneGNvZGVfY29uZmlnX2ZpbGUnOiAnPChwcm9qZWN0X2RpcikvQ29uZmlndXJhdGlv bnMvRGVidWdSZWxlYXNlLnhjY29uZmlnJywKICAgICAgICd4Y29kZV9zZXR0aW5ncyc6IHsKQEAg LTI5LDYgKzM1LDExIEBACiAgICAgICAnPChwcm9qZWN0X2RpcikvaWN1JywKICAgICBdLAogICB9 LAorICAndGFyZ2V0X2RlZmF1bHRzJzogeworICAgICdjb25maWd1cmF0aW9ucyc6IHsKKyAgICAg ICdQcm9maWxpbmcnOiB7fSwKKyAgICB9LAorICB9LAogICAndGFyZ2V0cyc6IFsKICAgICB7CiAg ICAgICAndGFyZ2V0X25hbWUnOiAnSmF2YVNjcmlwdENvcmUnLApAQCAtNDEsNiArNTIsMTEgQEAK ICAgICAgICAgJzxAKGphdmFzY3JpcHRjb3JlX2luY2x1ZGVfZGlycyknLAogICAgICAgICAnPChQ Uk9EVUNUX0RJUikvRGVyaXZlZFNvdXJjZXMvSmF2YVNjcmlwdENvcmUnLAogICAgICAgXSwKKyAg ICAgICdjb25maWd1cmF0aW9ucyc6IHsKKyAgICAgICAgJ1Byb2R1Y3Rpb24nOiB7CisgICAgICAg ICAgJ0lOU1RBTExfUEFUSCc6ICckKEJVSUxUX1BST0RVQ1RTX0RJUiknLAorICAgICAgICB9LAor ICAgICAgfSwKICAgICAgICdzb3VyY2VzJzogWwogICAgICAgICAnPEAoamF2YXNjcmlwdGNvcmVf ZmlsZXMpJywKICAgICAgICAgJzxAKGphdmFzY3JpcHRjb3JlX3B1YmxpY2hlYWRlcl9maWxlcykn LAo=