56849 2011-03-22 11:21:38 -0700 REGRESSION: WK2: AX: PDF in Safari no longer accessible. 2011-03-23 00:22:05 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach bdakin commit-queue oldest_to_newest 371501 0 cfleizach 2011-03-22 11:21:38 -0700 1) Open a page in Safari containing a PDF document. 2) Using VoiceOver, navigate to the scroll area. 3) Find that there appears to be nothing there. 371504 1 86484 cfleizach 2011-03-22 11:27:22 -0700 Created attachment 86484 patch 371879 2 86484 darin 2011-03-22 18:09:54 -0700 Comment on attachment 86484 patch View in context: https://bugs.webkit.org/attachment.cgi?id=86484&action=review review- because of the bad cast; otherwise looks good > Source/WebKit2/UIProcess/API/mac/WKView.mm:1611 > + return [NSArray arrayWithObjects:child, nil]; This will return an empty array instead of nil in cases where the old code returned nil. How about calling [NSArray arrayWithObject:] explicitly in both cases above instead of using a local variable? > Source/WebKit2/UIProcess/API/mac/PDFViewController.h:55 > + WKView* pdfView() const { return static_cast<WKView*>(m_wkPDFView.get()); } This is a bad cast, and incorrect. This function should be not be inline. I should be in the .mm file where the compiler can see the WKPDFView class. And the return type should be NSView *. 371891 3 86554 cfleizach 2011-03-22 18:27:25 -0700 Created attachment 86554 patch 371989 4 commit-queue 2011-03-23 00:19:39 -0700 The commit-queue encountered the following flaky tests while processing attachment 86554: inspector/debugger/debug-inlined-scripts.html bug 56900 (author: podivilov@chromium.org) The commit-queue is continuing to process your patch. 371991 5 86554 commit-queue 2011-03-23 00:22:00 -0700 Comment on attachment 86554 patch Clearing flags on attachment: 86554 Committed r81755: <http://trac.webkit.org/changeset/81755> 371992 6 commit-queue 2011-03-23 00:22:05 -0700 All reviewed patches have been landed. Closing bug. 86484 2011-03-22 11:27:22 -0700 2011-03-22 18:27:25 -0700 patch patch.txt text/plain 3076 cfleizach SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxNjc4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDMtMjIgIENocmlzIEZs ZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OOiBXSzI6IEFYOiBQREYgaW4gU2FmYXJp IG5vIGxvbmdlciBhY2Nlc3NpYmxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTY4NDkKKworICAgICAgICBUaGUgV0tWaWV3IG5lZWRzIHRvIGtub3cg d2hlbiB0byByZXR1cm4gdGhlIFdLUERGVmlldyBhbmQgd2hlbiB0byByZXR1cm4KKyAgICAgICAg dGhlIHJlbW90ZSB3ZWIgcHJvY2VzcyBjb25uZWN0aW9uLgorCisgICAgICAgICogVUlQcm9jZXNz L0FQSS9tYWMvUERGVmlld0NvbnRyb2xsZXIuaDoKKyAgICAgICAgKFdlYktpdDo6UERGVmlld0Nv bnRyb2xsZXI6OnBkZlZpZXcpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5t bToKKyAgICAgICAgKC1bV0tWaWV3IGFjY2Vzc2liaWxpdHlGb2N1c2VkVUlFbGVtZW50XSk6Cisg ICAgICAgICgtW1dLVmlldyBhY2Nlc3NpYmlsaXR5SGl0VGVzdDpdKToKKyAgICAgICAgKC1bV0tW aWV3IGFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVWYWx1ZTpdKToKKwogMjAxMS0wMy0yMSAgQnJhZHkg RWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IE1hYyByZWxlYXNlIGJ1 aWxkcyBhZnRlciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTY3ODMK SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHJldmlz aW9uIDgxNjcxKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1t CSh3b3JraW5nIGNvcHkpCkBAIC0xNTc5LDYgKzE1NzksOSBAQAogCiAtIChpZClhY2Nlc3NpYmls aXR5Rm9jdXNlZFVJRWxlbWVudAogeworICAgIGlmIChfZGF0YS0+X3BkZlZpZXdDb250cm9sbGVy KQorICAgICAgICByZXR1cm4gTlNBY2Nlc3NpYmlsaXR5VW5pZ25vcmVkRGVzY2VuZGFudChfZGF0 YS0+X3BkZlZpZXdDb250cm9sbGVyLT5wZGZWaWV3KCkpOworCiAgICAgcmV0dXJuIF9kYXRhLT5f cmVtb3RlQWNjZXNzaWJpbGl0eUNoaWxkLmdldCgpOwogfQogCkBAIC0xNTg5LDE1ICsxNTkyLDIz IEBACiAKIC0gKGlkKWFjY2Vzc2liaWxpdHlIaXRUZXN0OihOU1BvaW50KXBvaW50CiB7CisgICAg aWYgKF9kYXRhLT5fcGRmVmlld0NvbnRyb2xsZXIpCisgICAgICAgIHJldHVybiBbX2RhdGEtPl9w ZGZWaWV3Q29udHJvbGxlci0+cGRmVmlldygpIGFjY2Vzc2liaWxpdHlIaXRUZXN0OnBvaW50XTsK KyAgICAKICAgICByZXR1cm4gX2RhdGEtPl9yZW1vdGVBY2Nlc3NpYmlsaXR5Q2hpbGQuZ2V0KCk7 CiB9CiAKIC0gKGlkKWFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVWYWx1ZTooTlNTdHJpbmcqKWF0dHJp YnV0ZQogewogICAgIGlmIChbYXR0cmlidXRlIGlzRXF1YWxUb1N0cmluZzpOU0FjY2Vzc2liaWxp dHlDaGlsZHJlbkF0dHJpYnV0ZV0pIHsKLSAgICAgICAgaWYgKCFfZGF0YS0+X3JlbW90ZUFjY2Vz c2liaWxpdHlDaGlsZCkKLSAgICAgICAgICAgIHJldHVybiBuaWw7Ci0gICAgICAgIHJldHVybiBb TlNBcnJheSBhcnJheVdpdGhPYmplY3Q6X2RhdGEtPl9yZW1vdGVBY2Nlc3NpYmlsaXR5Q2hpbGQu Z2V0KCldOworCisgICAgICAgIGlkIGNoaWxkID0gbmlsOworICAgICAgICBpZiAoX2RhdGEtPl9w ZGZWaWV3Q29udHJvbGxlcikKKyAgICAgICAgICAgIGNoaWxkID0gTlNBY2Nlc3NpYmlsaXR5VW5p Z25vcmVkRGVzY2VuZGFudChfZGF0YS0+X3BkZlZpZXdDb250cm9sbGVyLT5wZGZWaWV3KCkpOwor ICAgICAgICBlbHNlIGlmIChfZGF0YS0+X3JlbW90ZUFjY2Vzc2liaWxpdHlDaGlsZCkKKyAgICAg ICAgICAgIGNoaWxkID0gX2RhdGEtPl9yZW1vdGVBY2Nlc3NpYmlsaXR5Q2hpbGQuZ2V0KCk7Cisg ICAgICAgIAorICAgICAgICByZXR1cm4gW05TQXJyYXkgYXJyYXlXaXRoT2JqZWN0czpjaGlsZCwg bmlsXTsKICAgICB9CiAgICAgaWYgKFthdHRyaWJ1dGUgaXNFcXVhbFRvU3RyaW5nOk5TQWNjZXNz aWJpbGl0eVJvbGVBdHRyaWJ1dGVdKQogICAgICAgICByZXR1cm4gTlNBY2Nlc3NpYmlsaXR5R3Jv dXBSb2xlOwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvUERGVmlld0Nv bnRyb2xsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21h Yy9QREZWaWV3Q29udHJvbGxlci5oCShyZXZpc2lvbiA4MTY3MSkKKysrIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvbWFjL1BERlZpZXdDb250cm9sbGVyLmgJKHdvcmtpbmcgY29weSkKQEAg LTUyLDcgKzUyLDggQEAKIAogICAgIFdLVmlldyogd2tWaWV3KCkgY29uc3QgeyByZXR1cm4gbV93 a1ZpZXc7IH0KICAgICBXZWJQYWdlUHJveHkqIHBhZ2UoKSBjb25zdDsKLQorICAgIFdLVmlldyog cGRmVmlldygpIGNvbnN0IHsgcmV0dXJuIHN0YXRpY19jYXN0PFdLVmlldyo+KG1fd2tQREZWaWV3 LmdldCgpKTsgfQorICAgIAogICAgIHZvaWQgc2V0UERGRG9jdW1lbnREYXRhKGNvbnN0IFN0cmlu ZyYgbWltZVR5cGUsIGNvbnN0IFN0cmluZyYgc3VnZ2VzdGVkRmlsZW5hbWUsIGNvbnN0IENvcmVJ UEM6OkRhdGFSZWZlcmVuY2UmKTsKIAogICAgIGRvdWJsZSB6b29tRmFjdG9yKCkgY29uc3Q7Cg== 86554 2011-03-22 18:27:25 -0700 2011-03-23 00:22:00 -0700 patch patch.txt text/plain 3636 cfleizach SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxNjc4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDMtMjIgIENocmlzIEZs ZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OOiBXSzI6IEFYOiBQREYgaW4gU2FmYXJp IG5vIGxvbmdlciBhY2Nlc3NpYmxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTY4NDkKKworICAgICAgICBUaGUgV0tWaWV3IG5lZWRzIHRvIGtub3cg d2hlbiB0byByZXR1cm4gdGhlIFdLUERGVmlldyBhbmQgd2hlbiB0byByZXR1cm4KKyAgICAgICAg dGhlIHJlbW90ZSB3ZWIgcHJvY2VzcyBjb25uZWN0aW9uLgorCisgICAgICAgICogVUlQcm9jZXNz L0FQSS9tYWMvUERGVmlld0NvbnRyb2xsZXIuaDoKKyAgICAgICAgKFdlYktpdDo6UERGVmlld0Nv bnRyb2xsZXI6OnBkZlZpZXcpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5t bToKKyAgICAgICAgKC1bV0tWaWV3IGFjY2Vzc2liaWxpdHlGb2N1c2VkVUlFbGVtZW50XSk6Cisg ICAgICAgICgtW1dLVmlldyBhY2Nlc3NpYmlsaXR5SGl0VGVzdDpdKToKKyAgICAgICAgKC1bV0tW aWV3IGFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVWYWx1ZTpdKToKKwogMjAxMS0wMy0yMSAgQnJhZHkg RWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IE1hYyByZWxlYXNlIGJ1 aWxkcyBhZnRlciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTY3ODMK SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1BERlZpZXdDb250cm9sbGVy Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1BERlZp ZXdDb250cm9sbGVyLm1tCShyZXZpc2lvbiA4MTY3MSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvbWFjL1BERlZpZXdDb250cm9sbGVyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMjMs NiArMjIzLDExIEBACiAgICAgcmV0dXJuIHRvSW1wbChbbV93a1ZpZXcgcGFnZVJlZl0pOwogfQog CitOU1ZpZXcqIFBERlZpZXdDb250cm9sbGVyOjpwZGZWaWV3KCkgY29uc3QKK3sgCisgICAgcmV0 dXJuIG1fd2tQREZWaWV3LmdldCgpOyAKK30KKyAgICAKIHN0YXRpYyBSZXRhaW5QdHI8Q0ZEYXRh UmVmPiBjb252ZXJ0UG9zdFNjcmlwdERhdGFTb3VyY2VUb1BERihjb25zdCBDb3JlSVBDOjpEYXRh UmVmZXJlbmNlJiBkYXRhUmVmZXJlbmNlKQogewogICAgIC8vIENvbnZlcnQgUG9zdFNjcmlwdCB0 byBQREYgdXNpbmcgUXVhcnR6IDJEIEFQSQpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9tYWMvV0tWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvbWFjL1dLVmlldy5tbQkocmV2aXNpb24gODE2NzEpCisrKyBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTE1NzksNiArMTU3 OSw5IEBACiAKIC0gKGlkKWFjY2Vzc2liaWxpdHlGb2N1c2VkVUlFbGVtZW50CiB7CisgICAgaWYg KF9kYXRhLT5fcGRmVmlld0NvbnRyb2xsZXIpCisgICAgICAgIHJldHVybiBOU0FjY2Vzc2liaWxp dHlVbmlnbm9yZWREZXNjZW5kYW50KF9kYXRhLT5fcGRmVmlld0NvbnRyb2xsZXItPnBkZlZpZXco KSk7CisKICAgICByZXR1cm4gX2RhdGEtPl9yZW1vdGVBY2Nlc3NpYmlsaXR5Q2hpbGQuZ2V0KCk7 CiB9CiAKQEAgLTE1ODksMTUgKzE1OTIsMjUgQEAKIAogLSAoaWQpYWNjZXNzaWJpbGl0eUhpdFRl c3Q6KE5TUG9pbnQpcG9pbnQKIHsKKyAgICBpZiAoX2RhdGEtPl9wZGZWaWV3Q29udHJvbGxlcikK KyAgICAgICAgcmV0dXJuIFtfZGF0YS0+X3BkZlZpZXdDb250cm9sbGVyLT5wZGZWaWV3KCkgYWNj ZXNzaWJpbGl0eUhpdFRlc3Q6cG9pbnRdOworICAgIAogICAgIHJldHVybiBfZGF0YS0+X3JlbW90 ZUFjY2Vzc2liaWxpdHlDaGlsZC5nZXQoKTsKIH0KIAogLSAoaWQpYWNjZXNzaWJpbGl0eUF0dHJp YnV0ZVZhbHVlOihOU1N0cmluZyopYXR0cmlidXRlCiB7CiAgICAgaWYgKFthdHRyaWJ1dGUgaXNF cXVhbFRvU3RyaW5nOk5TQWNjZXNzaWJpbGl0eUNoaWxkcmVuQXR0cmlidXRlXSkgewotICAgICAg ICBpZiAoIV9kYXRhLT5fcmVtb3RlQWNjZXNzaWJpbGl0eUNoaWxkKQorCisgICAgICAgIGlkIGNo aWxkID0gbmlsOworICAgICAgICBpZiAoX2RhdGEtPl9wZGZWaWV3Q29udHJvbGxlcikKKyAgICAg ICAgICAgIGNoaWxkID0gTlNBY2Nlc3NpYmlsaXR5VW5pZ25vcmVkRGVzY2VuZGFudChfZGF0YS0+ X3BkZlZpZXdDb250cm9sbGVyLT5wZGZWaWV3KCkpOworICAgICAgICBlbHNlIGlmIChfZGF0YS0+ X3JlbW90ZUFjY2Vzc2liaWxpdHlDaGlsZCkKKyAgICAgICAgICAgIGNoaWxkID0gX2RhdGEtPl9y ZW1vdGVBY2Nlc3NpYmlsaXR5Q2hpbGQuZ2V0KCk7CisgICAgICAgIAorICAgICAgICBpZiAoIWNo aWxkKQogICAgICAgICAgICAgcmV0dXJuIG5pbDsKLSAgICAgICAgcmV0dXJuIFtOU0FycmF5IGFy cmF5V2l0aE9iamVjdDpfZGF0YS0+X3JlbW90ZUFjY2Vzc2liaWxpdHlDaGlsZC5nZXQoKV07Cisg ICAgICAgIHJldHVybiBbTlNBcnJheSBhcnJheVdpdGhPYmplY3Q6Y2hpbGRdOwogICAgIH0KICAg ICBpZiAoW2F0dHJpYnV0ZSBpc0VxdWFsVG9TdHJpbmc6TlNBY2Nlc3NpYmlsaXR5Um9sZUF0dHJp YnV0ZV0pCiAgICAgICAgIHJldHVybiBOU0FjY2Vzc2liaWxpdHlHcm91cFJvbGU7CkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9QREZWaWV3Q29udHJvbGxlci5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1BERlZpZXdDb250cm9s bGVyLmgJKHJldmlzaW9uIDgxNjcxKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9t YWMvUERGVmlld0NvbnRyb2xsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNTIsNyArNTIsOCBAQAog CiAgICAgV0tWaWV3KiB3a1ZpZXcoKSBjb25zdCB7IHJldHVybiBtX3drVmlldzsgfQogICAgIFdl YlBhZ2VQcm94eSogcGFnZSgpIGNvbnN0OwotCisgICAgTlNWaWV3KiBwZGZWaWV3KCkgY29uc3Q7 CisgICAgCiAgICAgdm9pZCBzZXRQREZEb2N1bWVudERhdGEoY29uc3QgU3RyaW5nJiBtaW1lVHlw ZSwgY29uc3QgU3RyaW5nJiBzdWdnZXN0ZWRGaWxlbmFtZSwgY29uc3QgQ29yZUlQQzo6RGF0YVJl ZmVyZW5jZSYpOwogCiAgICAgZG91YmxlIHpvb21GYWN0b3IoKSBjb25zdDsK