56788 2011-03-21 17:29:59 -0700 GYP build should not have include paths that point within the source tree 2011-03-21 22:40:13 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 55018 1 abarth webkit-unassigned commit-queue dglazkov eric mrowe oldest_to_newest 371058 0 abarth 2011-03-21 17:29:59 -0700 Sayth Mark: [[ The generated Xcode project explicitly adds header include paths that point within the source tree. ]] I think I fixed this problem for the WebCore build, but I need to go back to the JavaScriptCore build and fix this issue. 371087 1 86398 abarth 2011-03-21 18:01:35 -0700 Created attachment 86398 Patch 371093 2 86398 eric 2011-03-21 18:03:47 -0700 Comment on attachment 86398 Patch What about for every non-mac port? it seems removing these is premature. 371116 3 abarth 2011-03-21 18:15:28 -0700 > What about for every non-mac port? it seems removing these is premature. I'd say that adding them is premature. :) We'll solve the non-mac port problem when we get there. 371121 4 86398 eric 2011-03-21 18:18:09 -0700 Comment on attachment 86398 Patch I guess. I'm pretty certain you'll want to revert this change the moment you try and build anywhere else, but your reasoning is fair. 371225 5 86398 commit-queue 2011-03-21 22:40:08 -0700 Comment on attachment 86398 Patch Clearing flags on attachment: 86398 Committed r81647: <http://trac.webkit.org/changeset/81647> 371226 6 commit-queue 2011-03-21 22:40:13 -0700 All reviewed patches have been landed. Closing bug. 86398 2011-03-21 18:01:35 -0700 2011-03-21 22:40:08 -0700 Patch bug-56788-20110321180134.patch text/plain 3754 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogODE2MjQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGJj NzlkMDNjM2U5NmE5ODBhYzRkYzQzYmE3MWJjM2U2MWY1ZDZhYTkuLmJjZGMyZmY5ZjE0YTM4YjVj YmZmODNhOGFmODUyMzIyMDI3ODFmNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSw1 ICsxLDIwIEBACiAyMDExLTAzLTIxICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR1lQIGJ1aWxk IHNob3VsZCBub3QgaGF2ZSBpbmNsdWRlIHBhdGhzIHRoYXQgcG9pbnQgd2l0aGluIHRoZSBzb3Vy Y2UgdHJlZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTY3ODgKKworICAgICAgICBUdXJucyBvdXQgd2UgZG9uJ3QgbmVlZCB0aGVzZSBpbmNsdWRlIHBh dGhzIGFueW1vcmUgbm93IHRoYXQgd2UgaGF2ZQorICAgICAgICBoZWFkZXIgbWFwcyB3b3JraW5n IHByb3Blcmx5LgorCisgICAgICAgICogZ3lwL0phdmFTY3JpcHRDb3JlLmd5cDoKKyAgICAgICAg ICAgIC0gQWxzbywgcmVtb3ZlIGpzYy5jcHAgZnJvbSB0aGUgZXhjbHVkZWQgbGlzdCBiZWNhdXNl IGl0J3Mgbm90IHBhcnQKKyAgICAgICAgICAgICAgb2YgdGhlIGpzY19maWxlcyB2YXJpYWJsZSBp bnN0ZWFkIG9mIHRoZSBqYXZhc2NyaXB0Y29yZV9maWxlcworICAgICAgICAgICAgICB2YXJpYWJs ZS4KKworMjAxMS0wMy0yMSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCiAgICAg ICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgogCiAgICAgICAgIFNvbHZlIHRoZSBBc3NlcnRp b25zLmNwcCAvIC1Xbm8tbWlzc2luZy1mb3JtYXQtYXR0cmlidXRlIG15c3RlcnkKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9neXAvSmF2YVNjcmlwdENvcmUuZ3lwIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2d5cC9KYXZhU2NyaXB0Q29yZS5neXAKaW5kZXggNDRmMGZmMzE4NWVl ZDIyYzJhYTE2OTcxM2ZjNzBhZGI4NTU0NGFkNS4uMzU4YmYyNzJlZDU1ODgwZGE3OWZkYmI4NDU3 Y2E1MDY0MzUxNTdkMiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2d5cC9KYXZh U2NyaXB0Q29yZS5neXAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2d5cC9KYXZhU2NyaXB0 Q29yZS5neXAKQEAgLTcsMjQgKzcsOCBAQAogICAndmFyaWFibGVzJzogewogICAgICMgRklYTUU6 IFdlIHNob3VsZCB1c2UgYSBoZWFkZXIgbWFwIGluc3RlYWQgb2YgbGlzdGluZyB0aGVzZSBleHBs aWNpdGx5LgogICAgICdqYXZhc2NyaXB0Y29yZV9pbmNsdWRlX2RpcnMnOiBbCi0gICAgICAnPChE RVBUSCknLCAjIFNvbWUgcGF0aHMgaW4gQVBJIGluY2x1ZGUgSmF2YVNjcmlwdENvcmUvCiAgICAg ICAnPChwcm9qZWN0X2RpciknLAotICAgICAgJzwocHJvamVjdF9kaXIpL0ZvcndhcmRpbmdIZWFk ZXJzJywKLSAgICAgICc8KHByb2plY3RfZGlyKS9BUEknLAotICAgICAgJzwocHJvamVjdF9kaXIp L2Fzc2VtYmxlcicsCi0gICAgICAnPChwcm9qZWN0X2RpcikvY29sbGVjdG9yL2hhbmRsZXMnLAot ICAgICAgJzwocHJvamVjdF9kaXIpL2J5dGVjb2RlJywKLSAgICAgICc8KHByb2plY3RfZGlyKS9i eXRlY29tcGlsZXInLAotICAgICAgJzwocHJvamVjdF9kaXIpL2RlYnVnZ2VyJywKICAgICAgICc8 KHByb2plY3RfZGlyKS9pY3UnLAotICAgICAgJzwocHJvamVjdF9kaXIpL2ludGVycHJldGVyJywK LSAgICAgICc8KHByb2plY3RfZGlyKS9qaXQnLAotICAgICAgJzwocHJvamVjdF9kaXIpL3BhcnNl cicsCi0gICAgICAnPChwcm9qZWN0X2RpcikvcHJvZmlsZXInLAotICAgICAgJzwocHJvamVjdF9k aXIpL3J1bnRpbWUnLAotICAgICAgJzwocHJvamVjdF9kaXIpL3d0ZicsCi0gICAgICAnPChwcm9q ZWN0X2Rpcikvd3RmL3VuaWNvZGUnLAotICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIp JywKICAgICBdLAogICAgICdkZXJpdmVkX3NvdXJjZV9maWxlcyc6IFsKICAgICAgICc8KFNIQVJF RF9JTlRFUk1FRElBVEVfRElSKS9BcnJheVByb3RvdHlwZS5sdXQuaCcsCkBAIC0xMDgsNyArOTIs NiBAQAogICAgICAgICBbJ2V4Y2x1ZGUnLCAnKERlZmF1bHR8R3RrfENocm9taXVtfE5vbmV8UXR8 V2lufFd4fFN5bWJpYW4pXFwuKGNwcHxtbXxoKSQnXSwKICAgICAgICAgWydleGNsdWRlJywgJ0dD QWN0aXZpdHlDYWxsYmFja1wuY3BwJ10sCiAgICAgICAgIFsnZXhjbHVkZScsICcuKkJTVFIuKiQn XSwKLSAgICAgICAgWydleGNsdWRlJywgJ2pzYy5jcHAkJ10sCiAgICAgICBdLAogICAgICAgJ3Bv c3RidWlsZHMnOiBbCiAgICAgICAgIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0R2x1 ZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdEdsdWUvQ2hhbmdlTG9nCmluZGV4IDU1NGVj MjkxMzdhNzdkMzc5NzNlZTNkZDYwM2MzMTMxOGE1N2YwZDMuLmI1Y2EyYTRiZWUxODZiYzA2ZTYw Njc2ODRkYWE1YmZkZjhkMDA5ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0R2x1ZS9D aGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRHbHVlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDExLTAzLTIxICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR1lQIGJ1aWxkIHNo b3VsZCBub3QgaGF2ZSBpbmNsdWRlIHBhdGhzIHRoYXQgcG9pbnQgd2l0aGluIHRoZSBzb3VyY2Ug dHJlZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTY3 ODgKKworICAgICAgICBUdXJucyBvdXQgd2UgZG9uJ3QgbmVlZCB0aGVzZSBpbmNsdWRlIHBhdGhz IGFueW1vcmUgbm93IHRoYXQgd2UgaGF2ZQorICAgICAgICBoZWFkZXIgbWFwcyB3b3JraW5nIHBy b3Blcmx5LgorCisgICAgICAgICogZ3lwL0phdmFTY3JpcHRHbHVlLmd5cDoKKwogMjAxMS0wMy0y MCAgQmlsbCBCdWRnZSAgPGJidWRnZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0R2x1ZS9neXAvSmF2 YVNjcmlwdEdsdWUuZ3lwIGIvU291cmNlL0phdmFTY3JpcHRHbHVlL2d5cC9KYXZhU2NyaXB0R2x1 ZS5neXAKaW5kZXggYzNiYjcxMTk4YWI3OTgyYjcwMjIwYTA2YjJlNzc5OTVlNzMxY2YyNC4uODI1 ZmQ4NjBmMTI5MzA5Mjk4M2VlMTZhMzhjMzE5Y2MwMjIxZDM1NSAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRHbHVlL2d5cC9KYXZhU2NyaXB0R2x1ZS5neXAKKysrIGIvU291cmNlL0phdmFT Y3JpcHRHbHVlL2d5cC9KYXZhU2NyaXB0R2x1ZS5neXAKQEAgLTEyLDcgKzEyLDYgQEAKICAgICAg ICAgJ1VwZGF0ZSBWZXJzaW9uJwogICAgICAgXSwKICAgICAgICdpbmNsdWRlX2RpcnMnOiBbCi0g ICAgICAgICc8KERFUFRIKS9KYXZhU2NyaXB0R2x1ZScsCiAgICAgICAgICc8KERFUFRIKS9KYXZh U2NyaXB0R2x1ZS9Gb3J3YXJkaW5nSGVhZGVycycsCiAgICAgICAgICc8KERFUFRIKS9KYXZhU2Ny aXB0R2x1ZS9pY3UnLAogICAgICAgICAnPChQUk9EVUNUX0RJUikvaW5jbHVkZScsCg==