56575 2011-03-17 11:03:56 -0700 REGRESSION: "Hidden" NPAPI plugin not loaded (conflicts with HTML5 hidden="" attribute) 2022-06-22 13:08:16 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Windows XP RESOLVED WONTFIX P2 Normal --- 44351 45049 1 pere.martir4 webkit-unassigned ahmad.saleem792 andersca ap dglazkov eric ian jamesr japhet mario.bensi mike mjs phil.ames philn pnormand rniwa smoutte tkent webkit.review.bot oldest_to_newest 369162 0 pere.martir4 2011-03-17 11:03:56 -0700 Chrome guys suggested me to report this issue here. The original issue of Chromium: http://code.google.com/p/chromium/issues/detail?id=76351 A "hidden" NPAPI plugin is loaded by the code below: <object type="application/x-my-extension" id="pluginId" hidden="true"> It worked in Chrome 9, but not in Chrome 10. However, if we remove the attribute "hidden", it works in Chrome 10. Is it a bug or by design ? Tested under Chrome 10 * LOADED - <embed type="application/x-my-extension" id="pluginId"> * LOADED - <embed type="application/x-my-extension" id="pluginId" hidden="true"> * LOADED - <embed type="application/x-my-extension" id="pluginId" hidden="false"> * LOADED - <object type="application/x-my-extension" id="pluginId"> * NOT LOADED - <object type="application/x-my-extension" id="pluginId" hidden="true"> * NOT LOADED - <object type="application/x-my-extension" id="pluginId" hidden="false"> 371355 1 pere.martir4 2011-03-22 06:33:48 -0700 I'd like to know that if it's likely that this will be changed in the future ? The comments in the original bug report suggested that the plugin should be loaded, even it's "hidden". We use <object hidden="true"> to load our windowless plugins and it seems that the existence of the attribute "hidden" (no matter it's true of false) now prevents the plugin from being loaded in Chrome 10. I will appreciate if somebody could nicely point me to the related source code file of this problem. I am very new to WebKit source. 374163 2 pnormand 2011-03-27 09:41:20 -0700 Maybe something's wrong in the parsing of the element attributes? Have a look in Source/WebCore/html/HTMLObjectElement.cpp and its parent classes. I'm not very familiar with the NPPlugin code in WebKit though ;) 374501 3 pere.martir4 2011-03-28 08:23:31 -0700 It seems that the changeset 73459 (bug 40511: Implement HTML5 hidden attribute) accidentally affects the OBJECT element. The EMBED element has not been affected because HTMLEmbedElement.cpp handles the "hidden" attribute by setting CSS height and width to zero, while HTMLObjectElement.cpp delegates the parsing to HTMLElement.cpp, which in changeset 73459 maps "hidden" attribute to CSS "display:none" and causes the plugin not loaded, known in bug 27775. The fix has already been planned in bug 45049, but a quick fix will be implementing the same hack of HTMLEmbedElement.cpp in HTMLObjectElement.cpp. Committed r73459: <http://trac.webkit.org/changeset/73459> 378826 4 pere.martir4 2011-04-04 09:21:11 -0700 (In reply to comment #3) > The fix has already been planned in bug 45049, but a quick fix will be implementing the same hack of HTMLEmbedElement.cpp in HTMLObjectElement.cpp. I am working on this "fix" - mapping hidden attribute to CSS width=height=0 instead of mapping to CSS display:none, is this patch likely to be accepted before bug 45049 is implemented ? 378838 5 eric 2011-04-04 09:53:51 -0700 I'm not sure that's a good fix. But maybe it's the right thing to do for the meanwhile. I expect it will be a while before we finish fixing plugin handling. It's not top of my todo list. 383094 6 88988 pere.martir4 2011-04-11 04:16:22 -0700 Created attachment 88988 Patch before plugin loading is moved from renderer to DOM The proposed patch implements what I mentioned in comment #3. 383096 7 webkit.review.bot 2011-04-11 04:18:30 -0700 Attachment 88988 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plug..." exit_code: 1 Source/WebCore/html/HTMLObjectElement.cpp:89: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 383112 8 88992 pere.martir4 2011-04-11 05:05:26 -0700 Created attachment 88992 Tabs removed 383278 9 88992 abarth 2011-04-11 10:59:47 -0700 Comment on attachment 88992 Tabs removed View in context: https://bugs.webkit.org/attachment.cgi?id=88992&action=review > LayoutTests/plugins/hidden-plugin-loaded.html:9 > + function printResults() Is this racy? Does the load event wait for plugins? 383907 10 88992 pere.martir4 2011-04-12 02:29:24 -0700 Comment on attachment 88992 Tabs removed View in context: https://bugs.webkit.org/attachment.cgi?id=88992&action=review >> LayoutTests/plugins/hidden-plugin-loaded.html:9 >> + function printResults() > > Is this racy? Does the load event wait for plugins? I copied it from LayoutTests/plugins/embed-prefers-plugins-for-images.html . In fact many tests under LayoutTests/plugins assume it (the load event waits for plugins) without explicit waits. 387614 11 pere.martir4 2011-04-18 03:37:16 -0700 Is this unit test valid ? What else I should do to improve this patch ? I'd like to know have this patch committed to the trunk before the bug 45049 is fixed. How is the possibility please? 397733 12 eric 2011-05-04 01:17:00 -0700 Do we know what revision changed this behavior? 397734 13 88992 eric 2011-05-04 01:18:34 -0700 Comment on attachment 88992 Tabs removed View in context: https://bugs.webkit.org/attachment.cgi?id=88992&action=review > Source/WebCore/html/HTMLObjectElement.cpp:139 > + // FIXME: Not dynamic, since we add this but don't remove it, but it may be OK for now > + // that this rarely-used attribute won't work properly if you remove it. > + addCSSLength(attr, CSSPropertyWidth, "0"); > + addCSSLength(attr, CSSPropertyHeight, "0"); I'm really not a big fan of this hack. It's not clear to me why this is needed. When did behavior change? Do we know why it changed? It should be relatively trivial to run Tools/Scripts/bisect-builds or git bisect and find the revision at which the bahavior changed in WebKIt. Then we would better understand what change may be necessary to restore old behavior (or if the behavior change was intentional). 397735 14 eric 2011-05-04 01:19:14 -0700 Anders knows all things plugins and may know why this changed and when (or if this is the right behavior at all?) 397752 15 eric 2011-05-04 02:20:58 -0700 http://trac.webkit.org/changeset/73459 seems to be the related change. I take it that hidden=true just didn't used to do anything? In which case, this isn't really a regression. 397774 16 88992 pere.martir4 2011-05-04 03:18:37 -0700 Comment on attachment 88992 Tabs removed View in context: https://bugs.webkit.org/attachment.cgi?id=88992&action=review >> Source/WebCore/html/HTMLObjectElement.cpp:139 >> + addCSSLength(attr, CSSPropertyHeight, "0"); > > I'm really not a big fan of this hack. > > It's not clear to me why this is needed. When did behavior change? Do we know why it changed? It should be relatively trivial to run Tools/Scripts/bisect-builds or git bisect and find the revision at which the bahavior changed in WebKIt. Then we would better understand what change may be necessary to restore old behavior (or if the behavior change was intentional). I've seen that you've found that it was due to changeset 73459, which accidentally broke the behavior of how "hidden" attribute works with OBJECT element. EMBED element has not been affect because HTMLEmbedElement.cpp has this "hack". Since HTML5 says the plugin should be instantiated no matter that it's visible or not, maybe this hack is the correct thing to do now. Related comment of this hack: https://bugs.webkit.org/show_bug.cgi?id=40511#c7 Quotation: "...The selected plugin is instantiated even if the element is hidden with a 'display:none' CSS style." 398860 17 eric 2011-05-05 11:26:57 -0700 My understanding is that this bug was brought to our attention by a company shipping a product affected by this "regression". The proper fix is to fix display: none iframes to still load plugins. But that's likely a lot of work. The simplest solution would be for the company to update their users. But I'm told they can't do that. Sometimes for large websites or applications we add temporary quirks to webkit. I'm not saying that's the right thing to do here, but it's something to consider. What would the url or extension name that we'd be quirking on here? Who's actually affected by this bug? 399451 18 smoutte 2011-05-06 04:15:25 -0700 The application affected by this "regression" is our OfferBox Browser, http://www.offerbox.com/en/about-offerbox/ It implements browser extensions for Chrome, Internet Explorer and Firefox in order to suggest relevant offers to our users. The name of our Chrome extension is "Offerbox" with ID:bjeikeheijdjdfjbmknpefojickbkmom We have a part of our product users base for which our product extension stopped working when Chrome upgraded from version 9 to 10. We have no way to update automatically these users; some of them have already upgraded to a newer version of our product which is not affected by this hidden attribute but some users will probably never download and install the new version so they will just stop using our product or they would decide to uninstall it as it stopped working. We understand that the proper fix for this "regression" represents a lot of work and we would really appreciate if you could integrate this quick fix. Our patch handles the attribute "hidden" in the exact same way than the one which is already implemented for the EMBED element. Thank you for your support. 399547 19 eric 2011-05-06 09:19:45 -0700 I assume that your extension does not use the Chrome extension auto-update system? http://code.google.com/chrome/extensions/autoupdate.html 399549 20 eric 2011-05-06 09:21:21 -0700 Actually, I thought if your extension was published through the Chrome Web Store you got auto-updating built in? 399661 21 smoutte 2011-05-06 11:24:31 -0700 Unfortunately our extension doesn't implement the extension auto-update system :( 401467 22 smoutte 2011-05-10 13:58:56 -0700 Could anyone review our patch or advise us about another way to fix this regression properly ? As the fix proposed is indentical to the implementation done for EMBED element, I though it would be welcome. The patch passed the unit tests. Did we miss something here ? 413751 23 eric 2011-06-01 16:36:27 -0700 It is possible for Chrome to add a quirk for specific extensions, like how WebKit on mac often has to quirk for specific applications on Mac OS X. I have no idea if Chrome folks are interested in quirking for extensions. But that might be another avenue to explore. Looking at: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#the-embed-element and http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#the-object-element It seems that HTML5 says nothing about a hidden attribute for either <object> or <embed>. It's possible our behavior should just be removed. 413756 24 eric 2011-06-01 16:38:47 -0700 Looks like hidden is a global attribute: http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#the-hidden-attribute So our current behavior is correct. 414230 25 smoutte 2011-06-02 10:13:21 -0700 (In reply to comment #23) I can read from http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#the-object-element that object element shouldn't be affected by hidden attribute. "Note:The above algorithm is independent of CSS properties (including 'display', 'overflow', and 'visibility'). For example, it runs even if the element is hidden with a 'display:none' CSS style, and does not run again if the element's visibility changes." Same for EMDED element http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#the-embed-element "Note:The embed element is unaffected by the CSS 'display' property. The selected plugin is instantiated even if the element is hidden with a 'display:none' CSS style." Did I miss something ? 518570 26 eric 2011-12-09 15:17:09 -0800 (In reply to comment #25) > (In reply to comment #23) > > I can read from http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#the-object-element that object element shouldn't be affected by hidden attribute. > "Note:The above algorithm is independent of CSS properties (including 'display', 'overflow', and 'visibility'). For example, it runs even if the element is hidden with a 'display:none' CSS style, and does not run again if the element's visibility changes." > > Same for EMDED element http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#the-embed-element > > "Note:The embed element is unaffected by the CSS 'display' property. The selected plugin is instantiated even if the element is hidden with a 'display:none' CSS style." > > Did I miss something ? Corrrect. The spec currently disagrees with reality. Ian is working on a fix: http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2011-November/033732.html 518577 27 eric 2011-12-09 15:23:38 -0800 I've filed https://www.w3.org/Bugs/Public/show_bug.cgi?id=15133 asking for spec clarification. 546524 28 ian 2012-01-31 14:54:12 -0800 So... is it just this site, or is it multiple sites? Can we break this one site? The only other solution I see is: object[hidden] { display: inline; width: 0; height: 0; overflow: hidden; } ...in the ua.css file. 691007 29 ian 2012-08-08 17:39:07 -0700 What's the status here? Did we decide it was a WONTFIX, did it somehow become WORKSFORME, or is it a known issue that's causing us pain? 1877374 30 ahmad.saleem792 2022-06-22 12:51:49 -0700 NPAPI support is removed from Safari 14 onward and it is not supported in Webkit Builds like WebkitGTK as well. I think this can be marked as "RESOLVED WONTFIX". Thanks! 88988 2011-04-11 04:16:22 -0700 2011-04-11 05:05:26 -0700 Patch before plugin loading is moved from renderer to DOM HiddenAttribPatch.txt text/plain 5366 pere.martir4 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzNDMzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDQtMTEgIFBlcmUgTWFy dGlyICA8cGVyZS5tYXJ0aXI0QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBIYW5kbGluZyBoaWRkZW4gYXR0cmlidXRlIG9mIDxvYmpl Y3Q+IGJ5IHNldHRpbmcgQ1NTIGhlaWdodCBhbmQKKyAgICAgICAgaGVpZ2h0IHRvIHplcm8gYXMg PGVtYmVkPiBkb2VzLiBUaGlzIG1heSBiZSB0aGUgY29ycmVjdCB0aGluZyB0byAKKyAgICAgICAg ZG8gYmVmb3JlIHRoZSBwbHVnaW4gbG9hZGluZyBjb2RlIGlzIG1vdmVkIGZyb20gcmVuZGVycyB0 byBET00uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 NjU3NQorCisgICAgICAgIFRlc3Q6IHBsdWdpbnMvaGlkZGVuLXBsdWdpbi1sb2FkZWQuaHRtbAor CisgICAgICAgICogaHRtbC9IVE1MT2JqZWN0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpIVE1MT2JqZWN0RWxlbWVudDo6bWFwVG9FbnRyeSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1M T2JqZWN0RWxlbWVudDo6cGFyc2VNYXBwZWRBdHRyaWJ1dGUpOgorICAgICAgICAqIGh0bWwvSFRN TE9iamVjdEVsZW1lbnQuaDoKKwogMjAxMS0wNC0xMCAgQ2hhbmdTZW9rIE9oICA8c2hpdmFtaWRv d0BnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxPYmplY3RFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxPYmplY3RFbGVtZW50LmNwcAkocmV2aXNpb24gODMxNzIp CisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxPYmplY3RFbGVtZW50LmNwcAkod29ya2luZyBj b3B5KQpAQCAtNzcsNiArNzcsMTYgQEAgUmVuZGVyV2lkZ2V0KiBIVE1MT2JqZWN0RWxlbWVudDo6 cmVuZGVyVwogICAgIHJldHVybiByZW5kZXJQYXJ0KCk7IC8vIFRoaXMgd2lsbCByZXR1cm4gMCBp ZiB0aGUgcmVuZGVyZXIgaXMgbm90IGEgUmVuZGVyUGFydC4KIH0KIAorYm9vbCBIVE1MT2JqZWN0 RWxlbWVudDo6bWFwVG9FbnRyeShjb25zdCBRdWFsaWZpZWROYW1lJiBhdHRyTmFtZSwgTWFwcGVk QXR0cmlidXRlRW50cnkmIHJlc3VsdCkgY29uc3QKK3sKKyAgICBpZiAoYXR0ck5hbWUgPT0gaGlk ZGVuQXR0cikgeworICAgICAgICByZXN1bHQgPSBlVW5pdmVyc2FsOworICAgICAgICByZXR1cm4g ZmFsc2U7CisgICAgfQorCisgICAgcmV0dXJuIEhUTUxQbHVnSW5JbWFnZUVsZW1lbnQ6Om1hcFRv RW50cnkoYXR0ck5hbWUsIHJlc3VsdCk7Cit9CisJCiB2b2lkIEhUTUxPYmplY3RFbGVtZW50Ojpw YXJzZU1hcHBlZEF0dHJpYnV0ZShBdHRyaWJ1dGUqIGF0dHIpCiB7CiAgICAgaWYgKGF0dHItPm5h bWUoKSA9PSB0eXBlQXR0cikgewpAQCAtMTIwLDYgKzEzMCwxNCBAQCB2b2lkIEhUTUxPYmplY3RF bGVtZW50OjpwYXJzZU1hcHBlZEF0dHJpCiAgICAgICAgIGFkZENTU1Byb3BlcnR5KGF0dHIsIENT U1Byb3BlcnR5Qm9yZGVyUmlnaHRTdHlsZSwgQ1NTVmFsdWVTb2xpZCk7CiAgICAgICAgIGFkZENT U1Byb3BlcnR5KGF0dHIsIENTU1Byb3BlcnR5Qm9yZGVyQm90dG9tU3R5bGUsIENTU1ZhbHVlU29s aWQpOwogICAgICAgICBhZGRDU1NQcm9wZXJ0eShhdHRyLCBDU1NQcm9wZXJ0eUJvcmRlckxlZnRT dHlsZSwgQ1NTVmFsdWVTb2xpZCk7CisgICAgfSBlbHNlIGlmIChhdHRyLT5uYW1lKCkgPT0gaGlk ZGVuQXR0cikgeworICAgICAgICBjb25zdCBBdG9taWNTdHJpbmcmIHZhbHVlID0gYXR0ci0+dmFs dWUoKTsKKyAgICAgICAgaWYgKGVxdWFsSWdub3JpbmdDYXNlKHZhbHVlLnN0cmluZygpLCAieWVz IikgfHwgZXF1YWxJZ25vcmluZ0Nhc2UodmFsdWUuc3RyaW5nKCksICJ0cnVlIikpIHsKKyAgICAg ICAgICAgIC8vIEZJWE1FOiBOb3QgZHluYW1pYywgc2luY2Ugd2UgYWRkIHRoaXMgYnV0IGRvbid0 IHJlbW92ZSBpdCwgYnV0IGl0IG1heSBiZSBPSyBmb3Igbm93CisgICAgICAgICAgICAvLyB0aGF0 IHRoaXMgcmFyZWx5LXVzZWQgYXR0cmlidXRlIHdvbid0IHdvcmsgcHJvcGVybHkgaWYgeW91IHJl bW92ZSBpdC4KKyAgICAgICAgICAgIGFkZENTU0xlbmd0aChhdHRyLCBDU1NQcm9wZXJ0eVdpZHRo LCAiMCIpOworICAgICAgICAgICAgYWRkQ1NTTGVuZ3RoKGF0dHIsIENTU1Byb3BlcnR5SGVpZ2h0 LCAiMCIpOworICAgICAgICB9CiAgICAgfSBlbHNlIGlmIChpc0lkQXR0cmlidXRlTmFtZShhdHRy LT5uYW1lKCkpKSB7CiAgICAgICAgIGNvbnN0IEF0b21pY1N0cmluZyYgbmV3SWQgPSBhdHRyLT52 YWx1ZSgpOwogICAgICAgICBpZiAoaXNEb2NOYW1lZEl0ZW0oKSAmJiBpbkRvY3VtZW50KCkgJiYg ZG9jdW1lbnQoKS0+aXNIVE1MRG9jdW1lbnQoKSkgewpJbmRleDogU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MT2JqZWN0RWxlbWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTE9iamVjdEVsZW1lbnQuaAkocmV2aXNpb24gODMxNzIpCisrKyBTb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxPYmplY3RFbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTY2LDYgKzY2LDcgQEAg cHVibGljOgogcHJpdmF0ZToKICAgICBIVE1MT2JqZWN0RWxlbWVudChjb25zdCBRdWFsaWZpZWRO YW1lJiwgRG9jdW1lbnQqLCBIVE1MRm9ybUVsZW1lbnQqLCBib29sIGNyZWF0ZWRCeVBhcnNlcik7 CiAKKyAgICB2aXJ0dWFsIGJvb2wgbWFwVG9FbnRyeShjb25zdCBRdWFsaWZpZWROYW1lJiBhdHRy TmFtZSwgTWFwcGVkQXR0cmlidXRlRW50cnkmIHJlc3VsdCkgY29uc3Q7CiAgICAgdmlydHVhbCB2 b2lkIHBhcnNlTWFwcGVkQXR0cmlidXRlKEF0dHJpYnV0ZSopOwogICAgIHZpcnR1YWwgdm9pZCBp bnNlcnRlZEludG9UcmVlKGJvb2wgZGVlcCk7CiAgICAgdmlydHVhbCB2b2lkIHJlbW92ZWRGcm9t VHJlZShib29sIGRlZXApOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gODM0MzMpCisrKyBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0wNC0xMSAg UGVyZSBNYXJ0aXIgIDxwZXJlLm1hcnRpcjRAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01NjU3NQorCisgICAgICAgIFRlc3QgdGhlIHBsdWdpbnMgYXJlIGxvYWRl ZCBldmVuIHRoZXkgaGF2ZSB0aGUgYXR0cmlidXRlIGhpZGRlbiBzZXQuCisKKyAgICAgICAgKiBw bHVnaW5zL2hpZGRlbi1wbHVnaW4tbG9hZGVkLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAg ICogcGx1Z2lucy9oaWRkZW4tcGx1Z2luLWxvYWRlZC5odG1sOiBBZGRlZC4KKwogMjAxMS0wNC0x MSAgQWxlamFuZHJvIEcuIENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KIAogICAgICAgICBTa2lw cGVkIGFub3RoZXIgdGVzdCB0aGF0IHJlcXVpcmVzIGR1bXBSZXNvdXJjZVJlc3BvbnNlTUlNRVR5 cGVzLgpJbmRleDogTGF5b3V0VGVzdHMvcGx1Z2lucy9oaWRkZW4tcGx1Z2luLWxvYWRlZC1leHBl Y3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGx1Z2lucy9oaWRkZW4tcGx1Z2lu LWxvYWRlZC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbHVnaW5z L2hpZGRlbi1wbHVnaW4tbG9hZGVkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSwzIEBACitBTEVSVDogUEFTUworQUxFUlQ6IFBBU1MKKyAgCkluZGV4OiBMYXlvdXRUZXN0cy9w bHVnaW5zL2hpZGRlbi1wbHVnaW4tbG9hZGVkLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvcGx1Z2lucy9oaWRkZW4tcGx1Z2luLWxvYWRlZC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5 b3V0VGVzdHMvcGx1Z2lucy9oaWRkZW4tcGx1Z2luLWxvYWRlZC5odG1sCShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDM1IEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KKyAgIGlmICh3aW5kb3cu bGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBB c1RleHQoKTsKKyAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAg IH0KKworICAgZnVuY3Rpb24gcHJpbnRSZXN1bHRzKCkKKyAgIHsKKyAgICAgIHZhciBwbHVnaW4g PSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicGx1Z2luMSIpOworICAgICAgaWYgKHBsdWdpbiAm JiBwbHVnaW4udGVzdENhbGxiYWNrKQorCSAgICAgYWxlcnQoIlBBU1MiKTsKKyAgICAgIGVsc2UK KwkgICAgIGFsZXJ0KCJGQUlMIik7CisJCSAKKyAgICAgIHZhciBwbHVnaW4gPSBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgicGx1Z2luMiIpOworICAgICAgaWYgKHBsdWdpbiAmJiBwbHVnaW4udGVz dENhbGxiYWNrKQorCSAgICAgYWxlcnQoIlBBU1MiKTsKKyAgICAgIGVsc2UKKwkgICAgIGFsZXJ0 KCJGQUlMIik7CQkgCisJCSAgICAKKyAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xs ZXIpCisgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOyAgIAorICAg fQorICAgCisKKworPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InByaW50UmVzdWx0 cygpOyI+CisgICA8ZW1iZWQgIGhpZGRlbiBpZD0icGx1Z2luMSIgIHR5cGU9ImFwcGxpY2F0aW9u L3gtd2Via2l0LXRlc3QtbmV0c2NhcGUiLz4gCisgICA8b2JqZWN0IGhpZGRlbiBpZD0icGx1Z2lu MiIgdHlwZT0iYXBwbGljYXRpb24veC13ZWJraXQtdGVzdC1uZXRzY2FwZSIvPgorPC9ib2R5Pgor PC9odG1sPgo= 88992 2011-04-11 05:05:26 -0700 2011-05-04 03:18:37 -0700 Tabs removed HiddenAttribPatch.txt text/plain 5365 pere.martir4 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzNDMzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDQtMTEgIFBlcmUgTWFy dGlyICA8cGVyZS5tYXJ0aXI0QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBIYW5kbGluZyBoaWRkZW4gYXR0cmlidXRlIG9mIDxvYmpl Y3Q+IGJ5IHNldHRpbmcgQ1NTIGhlaWdodCBhbmQKKyAgICAgICAgaGVpZ2h0IHRvIHplcm8gYXMg PGVtYmVkPiBkb2VzLiBUaGlzIG1heSBiZSB0aGUgY29ycmVjdCB0aGluZyB0byAKKyAgICAgICAg ZG8gYmVmb3JlIHRoZSBwbHVnaW4gbG9hZGluZyBjb2RlIGlzIG1vdmVkIGZyb20gcmVuZGVycyB0 byBET00uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 NjU3NQorCisgICAgICAgIFRlc3Q6IHBsdWdpbnMvaGlkZGVuLXBsdWdpbi1sb2FkZWQuaHRtbAor CisgICAgICAgICogaHRtbC9IVE1MT2JqZWN0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpIVE1MT2JqZWN0RWxlbWVudDo6bWFwVG9FbnRyeSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1M T2JqZWN0RWxlbWVudDo6cGFyc2VNYXBwZWRBdHRyaWJ1dGUpOgorICAgICAgICAqIGh0bWwvSFRN TE9iamVjdEVsZW1lbnQuaDoKKwogMjAxMS0wNC0xMCAgQ2hhbmdTZW9rIE9oICA8c2hpdmFtaWRv d0BnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxPYmplY3RFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxPYmplY3RFbGVtZW50LmNwcAkocmV2aXNpb24gODMxNzIp CisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxPYmplY3RFbGVtZW50LmNwcAkod29ya2luZyBj b3B5KQpAQCAtNzcsNiArNzcsMTYgQEAgUmVuZGVyV2lkZ2V0KiBIVE1MT2JqZWN0RWxlbWVudDo6 cmVuZGVyVwogICAgIHJldHVybiByZW5kZXJQYXJ0KCk7IC8vIFRoaXMgd2lsbCByZXR1cm4gMCBp ZiB0aGUgcmVuZGVyZXIgaXMgbm90IGEgUmVuZGVyUGFydC4KIH0KIAorYm9vbCBIVE1MT2JqZWN0 RWxlbWVudDo6bWFwVG9FbnRyeShjb25zdCBRdWFsaWZpZWROYW1lJiBhdHRyTmFtZSwgTWFwcGVk QXR0cmlidXRlRW50cnkmIHJlc3VsdCkgY29uc3QKK3sKKyAgICBpZiAoYXR0ck5hbWUgPT0gaGlk ZGVuQXR0cikgeworICAgICAgICByZXN1bHQgPSBlVW5pdmVyc2FsOworICAgICAgICByZXR1cm4g ZmFsc2U7CisgICAgfQorCisgICAgcmV0dXJuIEhUTUxQbHVnSW5JbWFnZUVsZW1lbnQ6Om1hcFRv RW50cnkoYXR0ck5hbWUsIHJlc3VsdCk7Cit9CisKIHZvaWQgSFRNTE9iamVjdEVsZW1lbnQ6OnBh cnNlTWFwcGVkQXR0cmlidXRlKEF0dHJpYnV0ZSogYXR0cikKIHsKICAgICBpZiAoYXR0ci0+bmFt ZSgpID09IHR5cGVBdHRyKSB7CkBAIC0xMjAsNiArMTMwLDE0IEBAIHZvaWQgSFRNTE9iamVjdEVs ZW1lbnQ6OnBhcnNlTWFwcGVkQXR0cmkKICAgICAgICAgYWRkQ1NTUHJvcGVydHkoYXR0ciwgQ1NT UHJvcGVydHlCb3JkZXJSaWdodFN0eWxlLCBDU1NWYWx1ZVNvbGlkKTsKICAgICAgICAgYWRkQ1NT UHJvcGVydHkoYXR0ciwgQ1NTUHJvcGVydHlCb3JkZXJCb3R0b21TdHlsZSwgQ1NTVmFsdWVTb2xp ZCk7CiAgICAgICAgIGFkZENTU1Byb3BlcnR5KGF0dHIsIENTU1Byb3BlcnR5Qm9yZGVyTGVmdFN0 eWxlLCBDU1NWYWx1ZVNvbGlkKTsKKyAgICB9IGVsc2UgaWYgKGF0dHItPm5hbWUoKSA9PSBoaWRk ZW5BdHRyKSB7CisgICAgICAgIGNvbnN0IEF0b21pY1N0cmluZyYgdmFsdWUgPSBhdHRyLT52YWx1 ZSgpOworICAgICAgICBpZiAoZXF1YWxJZ25vcmluZ0Nhc2UodmFsdWUuc3RyaW5nKCksICJ5ZXMi KSB8fCBlcXVhbElnbm9yaW5nQ2FzZSh2YWx1ZS5zdHJpbmcoKSwgInRydWUiKSkgeworICAgICAg ICAgICAgLy8gRklYTUU6IE5vdCBkeW5hbWljLCBzaW5jZSB3ZSBhZGQgdGhpcyBidXQgZG9uJ3Qg cmVtb3ZlIGl0LCBidXQgaXQgbWF5IGJlIE9LIGZvciBub3cKKyAgICAgICAgICAgIC8vIHRoYXQg dGhpcyByYXJlbHktdXNlZCBhdHRyaWJ1dGUgd29uJ3Qgd29yayBwcm9wZXJseSBpZiB5b3UgcmVt b3ZlIGl0LgorICAgICAgICAgICAgYWRkQ1NTTGVuZ3RoKGF0dHIsIENTU1Byb3BlcnR5V2lkdGgs ICIwIik7CisgICAgICAgICAgICBhZGRDU1NMZW5ndGgoYXR0ciwgQ1NTUHJvcGVydHlIZWlnaHQs ICIwIik7CisgICAgICAgIH0KICAgICB9IGVsc2UgaWYgKGlzSWRBdHRyaWJ1dGVOYW1lKGF0dHIt Pm5hbWUoKSkpIHsKICAgICAgICAgY29uc3QgQXRvbWljU3RyaW5nJiBuZXdJZCA9IGF0dHItPnZh bHVlKCk7CiAgICAgICAgIGlmIChpc0RvY05hbWVkSXRlbSgpICYmIGluRG9jdW1lbnQoKSAmJiBk b2N1bWVudCgpLT5pc0hUTUxEb2N1bWVudCgpKSB7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxPYmplY3RFbGVtZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MT2JqZWN0RWxlbWVudC5oCShyZXZpc2lvbiA4MzE3MikKKysrIFNvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTE9iamVjdEVsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtNjYsNiArNjYsNyBAQCBw dWJsaWM6CiBwcml2YXRlOgogICAgIEhUTUxPYmplY3RFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5h bWUmLCBEb2N1bWVudCosIEhUTUxGb3JtRWxlbWVudCosIGJvb2wgY3JlYXRlZEJ5UGFyc2VyKTsK IAorICAgIHZpcnR1YWwgYm9vbCBtYXBUb0VudHJ5KGNvbnN0IFF1YWxpZmllZE5hbWUmIGF0dHJO YW1lLCBNYXBwZWRBdHRyaWJ1dGVFbnRyeSYgcmVzdWx0KSBjb25zdDsKICAgICB2aXJ0dWFsIHZv aWQgcGFyc2VNYXBwZWRBdHRyaWJ1dGUoQXR0cmlidXRlKik7CiAgICAgdmlydHVhbCB2b2lkIGlu c2VydGVkSW50b1RyZWUoYm9vbCBkZWVwKTsKICAgICB2aXJ0dWFsIHZvaWQgcmVtb3ZlZEZyb21U cmVlKGJvb2wgZGVlcCk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA4MzQzMykKKysrIExheW91dFRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDExLTA0LTExICBQ ZXJlIE1hcnRpciAgPHBlcmUubWFydGlyNEBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTU2NTc1CisKKyAgICAgICAgVGVzdCB0aGUgcGx1Z2lucyBhcmUgbG9hZGVk IGV2ZW4gdGhleSBoYXZlIHRoZSBhdHRyaWJ1dGUgaGlkZGVuIHNldC4KKworICAgICAgICAqIHBs dWdpbnMvaGlkZGVuLXBsdWdpbi1sb2FkZWQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBwbHVnaW5zL2hpZGRlbi1wbHVnaW4tbG9hZGVkLmh0bWw6IEFkZGVkLgorCiAyMDExLTA0LTEx ICBBbGVqYW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFNraXBw ZWQgYW5vdGhlciB0ZXN0IHRoYXQgcmVxdWlyZXMgZHVtcFJlc291cmNlUmVzcG9uc2VNSU1FVHlw ZXMuCkluZGV4OiBMYXlvdXRUZXN0cy9wbHVnaW5zL2hpZGRlbi1wbHVnaW4tbG9hZGVkLWV4cGVj dGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbHVnaW5zL2hpZGRlbi1wbHVnaW4t bG9hZGVkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3BsdWdpbnMv aGlkZGVuLXBsdWdpbi1sb2FkZWQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDMgQEAKK0FMRVJUOiBQQVNTCitBTEVSVDogUEFTUworICAKSW5kZXg6IExheW91dFRlc3RzL3Bs dWdpbnMvaGlkZGVuLXBsdWdpbi1sb2FkZWQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9wbHVnaW5zL2hpZGRlbi1wbHVnaW4tbG9hZGVkLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9wbHVnaW5zL2hpZGRlbi1wbHVnaW4tbG9hZGVkLmh0bWwJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsMzUgQEAKKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0PgorICAgaWYgKHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFz VGV4dCgpOworICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworICAg fQorCisgICBmdW5jdGlvbiBwcmludFJlc3VsdHMoKQorICAgeworICAgICAgdmFyIHBsdWdpbiA9 IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJwbHVnaW4xIik7CisgICAgICBpZiAocGx1Z2luICYm IHBsdWdpbi50ZXN0Q2FsbGJhY2spCisJICAgICBhbGVydCgiUEFTUyIpOworICAgICAgZWxzZQor CSAgICAgYWxlcnQoIkZBSUwiKTsKKwkJIAorICAgICAgdmFyIHBsdWdpbiA9IGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJwbHVnaW4yIik7CisgICAgICBpZiAocGx1Z2luICYmIHBsdWdpbi50ZXN0 Q2FsbGJhY2spCisJICAgICBhbGVydCgiUEFTUyIpOworICAgICAgZWxzZQorCSAgICAgYWxlcnQo IkZBSUwiKTsJCSAKKwkJICAgIAorICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl cikKKyAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7ICAgCisgICB9 CisgICAKKworCis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0icHJpbnRSZXN1bHRz KCk7Ij4KKyAgIDxlbWJlZCAgaGlkZGVuIGlkPSJwbHVnaW4xIiAgdHlwZT0iYXBwbGljYXRpb24v eC13ZWJraXQtdGVzdC1uZXRzY2FwZSIvPiAKKyAgIDxvYmplY3QgaGlkZGVuIGlkPSJwbHVnaW4y IiB0eXBlPSJhcHBsaWNhdGlvbi94LXdlYmtpdC10ZXN0LW5ldHNjYXBlIi8+Cis8L2JvZHk+Cis8 L2h0bWw+Cg==