<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>56547</bug_id>
          
          <creation_ts>2011-03-17 00:15:17 -0700</creation_ts>
          <short_desc>Add a few Objective-C++ files to the WebCore GYP build</short_desc>
          <delta_ts>2011-03-17 01:10:52 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>55018</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Barth">abarth</reporter>
          <assigned_to name="Adam Barth">abarth</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>dglazkov</cc>
    
    <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>368905</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-17 00:15:17 -0700</bug_when>
    <thetext>Add a few Objective-C++ files to the WebCore GYP build</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>368907</commentid>
    <comment_count>1</comment_count>
      <attachid>86038</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-17 00:15:59 -0700</bug_when>
    <thetext>Created attachment 86038
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>368908</commentid>
    <comment_count>2</comment_count>
      <attachid>86038</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-03-17 00:16:41 -0700</bug_when>
    <thetext>Comment on attachment 86038
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86038&amp;action=review

OK.

&gt; Source/WebCore/gyp/WebCore.gyp:73
&gt;          [&apos;exclude&apos;, &apos;bridge/testbindings\\.cpp$&apos;], # Remove from GYPI?
&gt; +        [&apos;exclude&apos;, &apos;bridge/testbindings\\.mm$&apos;], # Remove from GYPI?

Why not a pattern here?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>368926</commentid>
    <comment_count>3</comment_count>
      <attachid>86038</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-03-17 01:10:47 -0700</bug_when>
    <thetext>Comment on attachment 86038
Patch

Clearing flags on attachment: 86038

Committed r81337: &lt;http://trac.webkit.org/changeset/81337&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>368927</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-03-17 01:10:52 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>86038</attachid>
            <date>2011-03-17 00:15:59 -0700</date>
            <delta_ts>2011-03-17 01:10:47 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-56547-20110317001558.patch</filename>
            <type>text/plain</type>
            <size>1719</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODEyMzEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhZjQyNGRjNWYxOWNhOWI5
YjRkMWZlNzk2ODY2ZThiOTBlZWZjNjBiLi43NGFhM2ViZDZiNTIwNDc4NjcwMWM3ZjZjOGExYzNk
ZTE3NmQ1MmFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTcgQEAKIAogICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBBZGQgYSBmZXcgT2JqZWN0aXZlLUMrKyBm
aWxlcyB0byB0aGUgV2ViQ29yZSBHWVAgYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTU2NTQ3CisKKyAgICAgICAgNDY0IGxpbmsgZXJyb3JzLgor
CisgICAgICAgICogZ3lwL1dlYkNvcmUuZ3lwOgorCisyMDExLTAzLTE3ICBBZGFtIEJhcnRoICA8
YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKICAgICAgICAgQWRkIHBsdWdpbnMgYW5kIGJyaWRnZSB0byB0aGUgV2ViQ29yZSBHWVAgYnVp
bGQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2NTQ2
CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2d5cC9XZWJDb3JlLmd5cCBiL1NvdXJjZS9X
ZWJDb3JlL2d5cC9XZWJDb3JlLmd5cAppbmRleCBkNzE5NjlkMTU1ZmRiZjVhODgyMzgyYjU5MmI5
ZjQ4YjAyNjc2NmFiLi40MjM0MzA5ZGQzMTc0ZDM3MjkzNzM5YWEwYjczZWJlMTJlYmUyNTUwIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9neXAvV2ViQ29yZS5neXAKKysrIGIvU291cmNlL1dl
YkNvcmUvZ3lwL1dlYkNvcmUuZ3lwCkBAIC00NywxMCArNDcsOCBAQAogICAgICAgXSwKICAgICAg
ICdzb3VyY2VzLyc6IFsKICAgICAgICAgIyBGSVhNRTogRmlndXJlIG91dCBob3cgdG8gYnVpbGQg
dGhlc2UgbW0gZmlsZXMuCi0gICAgICAgIFsnZXhjbHVkZScsICdwYWdlL21hYy9bXi9dKy5tbSQn
XSwKICAgICAgICAgWydleGNsdWRlJywgJ3BsYXRmb3JtL21hYy9bXi9dKy5tbSQnXSwKICAgICAg
ICAgWydleGNsdWRlJywgJ0Rlcml2ZWRTb3VyY2VzLy4qXFwubW0kJ10sCi0gICAgICAgIFsnZXhj
bHVkZScsICdicmlkZ2UvLipcXC5tbSQnXSwKIAogICAgICAgICBbJ2V4Y2x1ZGUnLCAnYmluZGlu
Z3MvW14vXSsvJ10sCiAgICAgICAgIFsnaW5jbHVkZScsICdiaW5kaW5ncy9nZW5lcmljLyddLApA
QCAtNzIsNiArNzAsNyBAQAogICAgICAgICBbJ2V4Y2x1ZGUnLCAncGxhdGZvcm0vaW1hZ2UtZW5j
b2RlcnMvJ10sCiAKICAgICAgICAgWydleGNsdWRlJywgJ2JyaWRnZS90ZXN0YmluZGluZ3NcXC5j
cHAkJ10sICMgUmVtb3ZlIGZyb20gR1lQST8KKyAgICAgICAgWydleGNsdWRlJywgJ2JyaWRnZS90
ZXN0YmluZGluZ3NcXC5tbSQnXSwgIyBSZW1vdmUgZnJvbSBHWVBJPwogICAgICAgICBbJ2V4Y2x1
ZGUnLCAnYnJpZGdlL3Rlc3RxdGJpbmRpbmdzXFwuY3BwJCddLCAjIFJlbW92ZSBmcm9tIEdZUEk/
CiAgICAgICAgIFsnZXhjbHVkZScsICdwbGF0Zm9ybS9LaWxsUmluZ05vbmVcXC5jcHAkJ10sCiAg
ICAgICAgIFsnZXhjbHVkZScsICdwbGF0Zm9ybS9ncmFwaGljcy9jZy9Gb250UGxhdGZvcm1EYXRh
XFwuaCQnXSwK
</data>

          </attachment>
      

    </bug>

</bugzilla>