56529 2011-03-16 19:54:00 -0700 WebCore GYP build should build more derived sources 2011-03-16 23:12:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 55018 1 abarth abarth commit-queue dglazkov eric oldest_to_newest 368757 0 abarth 2011-03-16 19:54:00 -0700 WebCore GYP build should build more derived sources 368758 1 86020 abarth 2011-03-16 19:54:59 -0700 Created attachment 86020 Patch 368814 2 86020 eric 2011-03-16 22:22:08 -0700 Comment on attachment 86020 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86020&action=review > Source/WebCore/gyp/WebCore.gyp:92 > + ['exclude', 'JSMathMLElementWrapperFactory\\.(cpp|h)'], Should be keyed on mathml. 368836 3 86020 abarth 2011-03-16 22:51:01 -0700 Comment on attachment 86020 Patch Yeah, I haven't sorted out the enable flags yet. That's something for after it links. :) 368846 4 86020 commit-queue 2011-03-16 22:57:04 -0700 Comment on attachment 86020 Patch Rejecting attachment 86020 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2 Last 500 characters of output: force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/gyp/WebCore.gyp Hunk #1 FAILED at 52. Hunk #2 succeeded at 84 (offset 8 lines). Hunk #3 succeeded at 94 (offset 8 lines). 1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/gyp/WebCore.gyp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8188558 368859 5 86020 abarth 2011-03-16 23:12:30 -0700 Comment on attachment 86020 Patch Clearing flags on attachment: 86020 Committed r81326: <http://trac.webkit.org/changeset/81326> 368860 6 abarth 2011-03-16 23:12:34 -0700 All reviewed patches have been landed. Closing bug. 86020 2011-03-16 19:54:59 -0700 2011-03-16 23:12:30 -0700 Patch bug-56529-20110316195458.patch text/plain 2842 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogODEyMzEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0ZmVmNGU4N2M2ZTRjZDE3 YjM3MTBhNWM1MTRjZTVlODI0NWQxMWI1Li5jOTMxMGMyMDEyOTRhNTkyMmZmZGQ2OGU0MGFiZTU3 Y2I2MDZkMWU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTcgQEAKIAogICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBXZWJDb3JlIEdZUCBidWlsZCBzaG91bGQg YnVpbGQgbW9yZSBkZXJpdmVkIHNvdXJjZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTU2NTI5CisKKyAgICAgICAgVGhpcyBwYXRjaCBicmluZ3MgdXMg ZG93biB0byA1OTcgbGluayBlcnJvcnMuCisKKyAgICAgICAgKiBneXAvV2ViQ29yZS5neXA6CisK KzIwMTEtMDMtMTYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBXZWJDb3JlIEdZUCBzaG91bGQg YnVpbGQgKG1vc3QpIHJlbWFpbmluZyBzb3VyY2UgZmlsZXMKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2NTE1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2d5cC9XZWJDb3JlLmd5cCBiL1NvdXJjZS9XZWJDb3JlL2d5cC9XZWJDb3JlLmd5cApp bmRleCBiYmU2NjNlMzkzNmUxZTM3NWUxYTg4ZmJiNjM1MWEyZjBhNmQ5MTAzLi5jY2ZhYTMxYTk4 NjNjMTg3NTQyOTZiMDRmYTY5M2RmZTliMTQwZTA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9neXAvV2ViQ29yZS5neXAKKysrIGIvU291cmNlL1dlYkNvcmUvZ3lwL1dlYkNvcmUuZ3lwCkBA IC01Miw3ICs1Miw4IEBACiAgICAgICAgIFsnZXhjbHVkZScsICdwbGF0Zm9ybS9tYWMvW14vXSsu bW0kJ10sCiAKICAgICAgICAgIyBGSVhNRTogQnVpbGQgdGhlc2Ugb2JqZWN0cy4KLSAgICAgICAg WydleGNsdWRlJywgJyhEZXJpdmVkU291cmNlc3xicmlkZ2V8cGx1Z2lucykvLipcXC4oY3xjcHB8 bW0pJCddLAorICAgICAgICBbJ2V4Y2x1ZGUnLCAnRGVyaXZlZFNvdXJjZXMvLipcXC5tbSQnXSwK KyAgICAgICAgWydleGNsdWRlJywgJyhicmlkZ2V8cGx1Z2lucykvLipcXC4oY3BwfG1tKSQnXSwK IAogICAgICAgICBbJ2V4Y2x1ZGUnLCAnYmluZGluZ3MvW14vXSsvJ10sCiAgICAgICAgIFsnaW5j bHVkZScsICdiaW5kaW5ncy9nZW5lcmljLyddLApAQCAtNzUsNiArNzYsNyBAQAogCiAgICAgICAg IFsnZXhjbHVkZScsICdwbGF0Zm9ybS9LaWxsUmluZ05vbmVcXC5jcHAkJ10sCiAgICAgICAgIFsn ZXhjbHVkZScsICdwbGF0Zm9ybS9ncmFwaGljcy9jZy9Gb250UGxhdGZvcm1EYXRhXFwuaCQnXSwK KyAgICAgICAgWydleGNsdWRlJywgJ3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9Mb29wQmxpbm5QYXRo UHJvY2Vzc29yXFwuKGNwcHxoKSQnXSwKICAgICAgICAgIyBGSVhNRTogQ29uc2lkZXIgZXhjbHVk aW5nIEdMIGFzIGEgc3VmZml4LgogICAgICAgICBbJ2V4Y2x1ZGUnLCAncGxhdGZvcm0vZ3JhcGhp Y3Mvb3BlbmdsL1RleHR1cmVNYXBwZXJHTFxcLmNwcCQnXSwKICAgICAgICAgWydleGNsdWRlJywg J3BsYXRmb3JtL2dyYXBoaWNzL29wZW50eXBlL09wZW5UeXBlVXRpbGl0aWVzXFwuKGNwcHxoKSQn XSwKQEAgLTg0LDYgKzg2LDIyIEBACiAgICAgICAgIFsnZXhjbHVkZScsICdwbGF0Zm9ybS90ZXh0 L1RleHRFbmNvZGluZ0RldGVjdG9yTm9uZVxcLmNwcCQnXSwKICAgICAgICAgWydleGNsdWRlJywg J3BsYXRmb3JtL3RleHQvSHlwaGVuYXRpb25cXC5jcHAkJ10sCiAKKyAgICAgICAgIyBGSVhNRTog Q2hlY2sgd2hldGhlciB3ZSBuZWVkIHRvIGJ1aWxkIHRoZXNlIGRlcml2ZWQgc291cmNlIGZpbGVz LgorICAgICAgICBbJ2V4Y2x1ZGUnLCAnSlNBYnN0cmFjdFZpZXdcXC4oY3BwfGgpJ10sCisgICAg ICAgIFsnZXhjbHVkZScsICdKU0VsZW1lbnRUaW1lQ29udHJvbFxcLihjcHB8aCknXSwKKyAgICAg ICAgWydleGNsdWRlJywgJ0pTTWF0aE1MRWxlbWVudFdyYXBwZXJGYWN0b3J5XFwuKGNwcHxoKSdd LAorICAgICAgICBbJ2V4Y2x1ZGUnLCAnSlNTVkdFeHRlcm5hbFJlc291cmNlc1JlcXVpcmVkXFwu KGNwcHxoKSddLAorICAgICAgICBbJ2V4Y2x1ZGUnLCAnSlNTVkdGaWx0ZXJQcmltaXRpdmVTdGFu ZGFyZEF0dHJpYnV0ZXNcXC4oY3BwfGgpJ10sCisgICAgICAgIFsnZXhjbHVkZScsICdKU1NWR0Zp dFRvVmlld0JveFxcLihjcHB8aCknXSwKKyAgICAgICAgWydleGNsdWRlJywgJ0pTU1ZHTGFuZ1Nw YWNlXFwuKGNwcHxoKSddLAorICAgICAgICBbJ2V4Y2x1ZGUnLCAnSlNTVkdMb2NhdGFibGVcXC4o Y3BwfGgpJ10sCisgICAgICAgIFsnZXhjbHVkZScsICdKU1NWR1N0eWxhYmxlXFwuKGNwcHxoKSdd LAorICAgICAgICBbJ2V4Y2x1ZGUnLCAnSlNTVkdUZXN0c1xcLihjcHB8aCknXSwKKyAgICAgICAg WydleGNsdWRlJywgJ0pTU1ZHVHJhbnNmb3JtYWJsZVxcLihjcHB8aCknXSwKKyAgICAgICAgWydl eGNsdWRlJywgJ0pTU1ZHVVJJUmVmZXJlbmNlXFwuKGNwcHxoKSddLAorICAgICAgICBbJ2V4Y2x1 ZGUnLCAnSlNTVkdab29tQW5kUGFuXFwuKGNwcHxoKSddLAorICAgICAgICBbJ2V4Y2x1ZGUnLCAn dG9rZW5pemVyXFwuY3BwJ10sCisKICAgICAgICAgWydleGNsdWRlJywgJ0FsbEluT25lXFwuY3Bw JCddLAogICAgICAgXSwKICAgICAgICdtYWNfZnJhbWV3b3JrX2hlYWRlcnMnOiBbCg==