56498 2011-03-16 16:11:18 -0700 Move volume slider positioning logic to a custom renderer. 2011-03-22 11:39:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 53020 1 dglazkov dglazkov abarth darin eric.carlson eric webkit.review.bot oldest_to_newest 368612 0 dglazkov 2011-03-16 16:11:18 -0700 Move volume slider positioning logic to a custom renderer. 368613 1 85993 dglazkov 2011-03-16 16:12:55 -0700 Created attachment 85993 Patch 368975 2 85993 eric 2011-03-17 04:16:16 -0700 Comment on attachment 85993 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85993&action=review Seems reasonable. What's the motivation here? > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) You'll need to remove that. 369053 3 dglazkov 2011-03-17 08:24:05 -0700 (In reply to comment #2) > (From update of attachment 85993 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=85993&action=review > > Seems reasonable. What's the motivation here? Ah good question. I need to put a desc in ChangeLog. By moving the logic to a renderer, we are eliminating the need to fiddle with RenderStyle from DOM, which is what the original code was doing. If this were possible to accomplish with CSS, that would've been the proper route to follow. Since the behavior (stay on top of a sibling) can't be described in terms of CSS, the custom renderer is the way to go. > > > Source/WebCore/ChangeLog:8 > > + No new tests. (OOPS!) > > You'll need to remove that. OOPS indeed :) 371410 4 dglazkov 2011-03-22 09:16:49 -0700 Committed r81671: <http://trac.webkit.org/changeset/81671> 371515 5 webkit.review.bot 2011-03-22 11:39:48 -0700 http://trac.webkit.org/changeset/81671 might have broken GTK Linux 32-bit Debug The following tests are not passing: inspector/debugger/debug-inlined-scripts.html 85993 2011-03-16 16:12:55 -0700 2011-03-17 04:16:16 -0700 Patch bug-56498-20110316161254.patch text/plain 6323 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogODEyODMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2YWQ4NmE2NjlkNGIyYTU3 ODYwOWNiMzYyOTM2M2IyYjE1ZWNmMDA5Li41ZmNkMWMwYjYzNWVkMDZjMmMzNzdiZmVjNTVjZTQ4 NDJjZjdhNzgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQgQEAKIDIwMTEtMDMtMTYgIERpbWl0 cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3ZlIHZvbHVtZSBzbGlkZXIgcG9zaXRpb25p bmcgbG9naWMgdG8gYSBjdXN0b20gcmVuZGVyZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjQ5OAorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9P UFMhKQorCisgICAgICAgICogaHRtbC9zaGFkb3cvTWVkaWFDb250cm9scy5jcHA6CisgICAgICAg IChXZWJDb3JlOjpNZWRpYUNvbnRyb2xzOjp1cGRhdGVWb2x1bWVTbGlkZXJDb250YWluZXIpOiBS ZW1vdmVkIHBvc2l0aW9uaW5nIGxvZ2ljLgorICAgICAgICAqIHJlbmRlcmluZy9NZWRpYUNvbnRy b2xFbGVtZW50cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJNZWRpYVZvbHVtZVNsaWRl ckNvbnRhaW5lcjo6UmVuZGVyTWVkaWFWb2x1bWVTbGlkZXJDb250YWluZXIpOiBBZGRlZC4KKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlck1lZGlhVm9sdW1lU2xpZGVyQ29udGFpbmVyOjpsYXlvdXQp OiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhQ29udHJvbFZvbHVtZVNsaWRlckNvbnRh aW5lckVsZW1lbnQ6Ok1lZGlhQ29udHJvbFZvbHVtZVNsaWRlckNvbnRhaW5lckVsZW1lbnQpOiBS ZW1vdmVkIHN0b3Jpbmcgb2YgY29vcmRpbmF0ZXMuCisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNv bnRyb2xWb2x1bWVTbGlkZXJDb250YWluZXJFbGVtZW50OjpjcmVhdGVSZW5kZXJlcik6IEFkZGVk LgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFDb250cm9sVm9sdW1lU2xpZGVyQ29udGFpbmVyRWxl bWVudDo6c3R5bGVGb3JFbGVtZW50KTogUmVtb3ZlZCBzZXR0aW5nIG9mIGNvb3JkaW5hdGVzLgor ICAgICAgICAqIHJlbmRlcmluZy9NZWRpYUNvbnRyb2xFbGVtZW50cy5oOiBDaGFuZ2VkIGNvcnJl c3BvbmRpbmcgZGVjbHMuCisKKzIwMTEtMDMtMTYgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292 QGNocm9taXVtLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCiAKICAg ICAgICAgQWRkIHBsYXkgc3RhdGUgY2FsbGJhY2tzIHRvIE1lZGlhQ29udHJvbHMsIGtpbGwgdGlt ZVVwZGF0ZSB0aW1lci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01l ZGlhQ29udHJvbHMuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9s cy5jcHAKaW5kZXggZTIwMTFkMWMxMzJjOTQxNjQyN2QyMTllNjlkNzNlZGYwYjZkYTQzNi4uMDhj NzliOGFjMWFiMzUzZTFjZGE3MDMzOTQ1ODIzYjRhMjMzNzA5MCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9scy5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9scy5jcHAKQEAgLTQ4NSwxMyArNDg1LDYgQEAgdm9p ZCBNZWRpYUNvbnRyb2xzOjp1cGRhdGVWb2x1bWVTbGlkZXJDb250YWluZXIoYm9vbCB2aXNpYmxl KQogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIFJlZlB0cjxSZW5kZXJTdHlsZT4gcyA9 IG1fdm9sdW1lU2xpZGVyQ29udGFpbmVyLT5zdHlsZUZvckVsZW1lbnQoKTsKLSAgICAgICAgaW50 IGhlaWdodCA9IHMtPmhlaWdodCgpLmlzUGVyY2VudCgpID8gMCA6IHMtPmhlaWdodCgpLnZhbHVl KCk7Ci0gICAgICAgIGludCB3aWR0aCA9IHMtPndpZHRoKCkuaXNQZXJjZW50KCkgPyAwIDogcy0+ d2lkdGgoKS52YWx1ZSgpOwotICAgICAgICBJbnRQb2ludCBvZmZzZXQgPSBtX21lZGlhRWxlbWVu dC0+ZG9jdW1lbnQoKS0+cGFnZSgpLT50aGVtZSgpLT52b2x1bWVTbGlkZXJPZmZzZXRGcm9tTXV0 ZUJ1dHRvbihtX211dGVCdXR0b24tPnJlbmRlckJveCgpLCBJbnRTaXplKHdpZHRoLCBoZWlnaHQp KTsKLSAgICAgICAgaW50IHggPSBvZmZzZXQueCgpICsgbV9tdXRlQnV0dG9uLT5yZW5kZXJCb3go KS0+b2Zmc2V0TGVmdCgpOwotICAgICAgICBpbnQgeSA9IG9mZnNldC55KCkgKyBtX211dGVCdXR0 b24tPnJlbmRlckJveCgpLT5vZmZzZXRUb3AoKTsKLQotICAgICAgICBtX3ZvbHVtZVNsaWRlckNv bnRhaW5lci0+c2V0UG9zaXRpb24oeCwgeSk7CiAgICAgICAgIG1fdm9sdW1lU2xpZGVyQ29udGFp bmVyLT5zZXRWaXNpYmxlKHRydWUpOwogICAgICAgICBtX3ZvbHVtZVNsaWRlckNvbnRhaW5lci0+ dXBkYXRlKCk7CiAgICAgICAgIG1fdm9sdW1lU2xpZGVyLT51cGRhdGUoKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwCmluZGV4IGVlNjEx NzlmY2RjYjk0OTJhMDExZGEyMjY2ZTAwNGE3NzMyMDRhNGYuLjllNjEyOGFhZjNmYWEzZTM1ZWJk NzhiMzdiMTM2MDI0YTY5NmJiNGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcApAQCAtNDUsNiArNDUsNyBAQAogI2luY2x1ZGUgIlJl bmRlck1lZGlhLmgiCiAjaW5jbHVkZSAiUmVuZGVyU2xpZGVyLmgiCiAjaW5jbHVkZSAiUmVuZGVy VGhlbWUuaCIKKyNpbmNsdWRlICJSZW5kZXJWaWV3LmgiCiAjaW5jbHVkZSAiU2V0dGluZ3MuaCIK IAogbmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtMjUxLDExICsyNTIsNDEgQEAgY29uc3QgQXRvbWlj U3RyaW5nJiBNZWRpYUNvbnRyb2xUaW1lbGluZUNvbnRhaW5lckVsZW1lbnQ6OnNoYWRvd1BzZXVk b0lkKCkgY29uc3QKIAogLy8gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCitjbGFzcyBS ZW5kZXJNZWRpYVZvbHVtZVNsaWRlckNvbnRhaW5lciA6IHB1YmxpYyBSZW5kZXJCbG9jayB7Citw dWJsaWM6CisgICAgUmVuZGVyTWVkaWFWb2x1bWVTbGlkZXJDb250YWluZXIoTm9kZSopOworCitw cml2YXRlOgorICAgIHZpcnR1YWwgdm9pZCBsYXlvdXQoKTsKK307CisKK1JlbmRlck1lZGlhVm9s dW1lU2xpZGVyQ29udGFpbmVyOjpSZW5kZXJNZWRpYVZvbHVtZVNsaWRlckNvbnRhaW5lcihOb2Rl KiBub2RlKQorICAgIDogUmVuZGVyQmxvY2sobm9kZSkKK3sKK30KKwordm9pZCBSZW5kZXJNZWRp YVZvbHVtZVNsaWRlckNvbnRhaW5lcjo6bGF5b3V0KCkKK3sKKyAgICBSZW5kZXJCbG9jazo6bGF5 b3V0KCk7CisgICAgaWYgKHN0eWxlKCktPmRpc3BsYXkoKSA9PSBOT05FIHx8ICFwcmV2aW91c1Np YmxpbmcoKSB8fCAhcHJldmlvdXNTaWJsaW5nKCktPmlzQm94KCkpCisgICAgICAgIHJldHVybjsK KworICAgIFJlbmRlckJveCogYnV0dG9uQm94ID0gdG9SZW5kZXJCb3gocHJldmlvdXNTaWJsaW5n KCkpOworCisgICAgaWYgKHZpZXcoKSkKKyAgICAgICAgdmlldygpLT5kaXNhYmxlTGF5b3V0U3Rh dGUoKTsKKworICAgIEludFBvaW50IG9mZnNldCA9IHRoZW1lKCktPnZvbHVtZVNsaWRlck9mZnNl dEZyb21NdXRlQnV0dG9uKGJ1dHRvbkJveCwgSW50U2l6ZSh3aWR0aCgpLCBoZWlnaHQoKSkpOwor ICAgIHNldFgob2Zmc2V0LngoKSArIGJ1dHRvbkJveC0+b2Zmc2V0TGVmdCgpKTsKKyAgICBzZXRZ KG9mZnNldC55KCkgKyBidXR0b25Cb3gtPm9mZnNldFRvcCgpKTsKKworICAgIGlmICh2aWV3KCkp CisgICAgICAgIHZpZXcoKS0+ZW5hYmxlTGF5b3V0U3RhdGUoKTsKK30KKwogaW5saW5lIE1lZGlh Q29udHJvbFZvbHVtZVNsaWRlckNvbnRhaW5lckVsZW1lbnQ6Ok1lZGlhQ29udHJvbFZvbHVtZVNs aWRlckNvbnRhaW5lckVsZW1lbnQoSFRNTE1lZGlhRWxlbWVudCogbWVkaWFFbGVtZW50KQogICAg IDogTWVkaWFDb250cm9sRWxlbWVudChtZWRpYUVsZW1lbnQpCiAgICAgLCBtX2lzVmlzaWJsZShm YWxzZSkKLSAgICAsIG1feCgwKQotICAgICwgbV95KDApCiB7CiB9CiAKQEAgLTI2NCwxMiArMjk1 LDE1IEBAIFBhc3NSZWZQdHI8TWVkaWFDb250cm9sVm9sdW1lU2xpZGVyQ29udGFpbmVyRWxlbWVu dD4gTWVkaWFDb250cm9sVm9sdW1lU2xpZGVyQ29uCiAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBN ZWRpYUNvbnRyb2xWb2x1bWVTbGlkZXJDb250YWluZXJFbGVtZW50KG1lZGlhRWxlbWVudCkpOwog fQogCitSZW5kZXJPYmplY3QqIE1lZGlhQ29udHJvbFZvbHVtZVNsaWRlckNvbnRhaW5lckVsZW1l bnQ6OmNyZWF0ZVJlbmRlcmVyKFJlbmRlckFyZW5hKiBhcmVuYSwgUmVuZGVyU3R5bGUqKQorewor ICAgIHJldHVybiBuZXcgKGFyZW5hKSBSZW5kZXJNZWRpYVZvbHVtZVNsaWRlckNvbnRhaW5lcih0 aGlzKTsKK30KKwogUGFzc1JlZlB0cjxSZW5kZXJTdHlsZT4gTWVkaWFDb250cm9sVm9sdW1lU2xp ZGVyQ29udGFpbmVyRWxlbWVudDo6c3R5bGVGb3JFbGVtZW50KCkKIHsKICAgICBSZWZQdHI8UmVu ZGVyU3R5bGU+IHN0eWxlID0gTWVkaWFDb250cm9sRWxlbWVudDo6c3R5bGVGb3JFbGVtZW50KCk7 CiAgICAgc3R5bGUtPnNldFBvc2l0aW9uKEFic29sdXRlUG9zaXRpb24pOwotICAgIHN0eWxlLT5z ZXRMZWZ0KExlbmd0aChtX3gsIEZpeGVkKSk7Ci0gICAgc3R5bGUtPnNldFRvcChMZW5ndGgobV95 LCBGaXhlZCkpOwogICAgIHN0eWxlLT5zZXREaXNwbGF5KG1faXNWaXNpYmxlID8gQkxPQ0sgOiBO T05FKTsKICAgICByZXR1cm4gc3R5bGU7CiB9CkBAIC0yODEsMTQgKzMxNSw2IEBAIHZvaWQgTWVk aWFDb250cm9sVm9sdW1lU2xpZGVyQ29udGFpbmVyRWxlbWVudDo6c2V0VmlzaWJsZShib29sIHZp c2libGUpCiAgICAgbV9pc1Zpc2libGUgPSB2aXNpYmxlOwogfQogCi12b2lkIE1lZGlhQ29udHJv bFZvbHVtZVNsaWRlckNvbnRhaW5lckVsZW1lbnQ6OnNldFBvc2l0aW9uKGludCB4LCBpbnQgeSkK LXsKLSAgICBpZiAoeCA9PSBtX3ggJiYgeSA9PSBtX3kpCi0gICAgICAgIHJldHVybjsKLSAgICBt X3ggPSB4OwotICAgIG1feSA9IHk7Ci19Ci0KIGJvb2wgTWVkaWFDb250cm9sVm9sdW1lU2xpZGVy Q29udGFpbmVyRWxlbWVudDo6aGl0VGVzdChjb25zdCBJbnRQb2ludCYgYWJzUG9pbnQpCiB7CiAg ICAgaWYgKHJlbmRlcmVyKCkgJiYgcmVuZGVyZXIoKS0+c3R5bGUoKS0+aGFzQXBwZWFyYW5jZSgp KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL01lZGlhQ29udHJvbEVsZW1l bnRzLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvTWVkaWFDb250cm9sRWxlbWVudHMuaApp bmRleCAyMGFhYzBmMTM2Nzc4Nzc3NzM4NDdkZTQ5ZDkzNjk3NDY1Yzc2NTRjLi41MWM2MTQ5NzRm MTNhYWExYWFiOWM4NWUwNDM2ZjkwMjc2YjgxZTE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvTWVkaWFDb250cm9sRWxlbWVudHMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvTWVkaWFDb250cm9sRWxlbWVudHMuaApAQCAtMTQyLDE2ICsxNDIsMTYgQEAgcHVi bGljOgogICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxSZW5kZXJTdHlsZT4gc3R5bGVGb3JFbGVtZW50 KCk7CiAgICAgdm9pZCBzZXRWaXNpYmxlKGJvb2wpOwogICAgIGJvb2wgaXNWaXNpYmxlKCkgeyBy ZXR1cm4gbV9pc1Zpc2libGU7IH0KLSAgICB2b2lkIHNldFBvc2l0aW9uKGludCB4LCBpbnQgeSk7 CiAgICAgYm9vbCBoaXRUZXN0KGNvbnN0IEludFBvaW50JiBhYnNQb2ludCk7CiAKIHByaXZhdGU6 CiAgICAgTWVkaWFDb250cm9sVm9sdW1lU2xpZGVyQ29udGFpbmVyRWxlbWVudChIVE1MTWVkaWFF bGVtZW50Kik7CisKKyAgICB2aXJ0dWFsIFJlbmRlck9iamVjdCogY3JlYXRlUmVuZGVyZXIoUmVu ZGVyQXJlbmEqLCBSZW5kZXJTdHlsZSopOwogICAgIHZpcnR1YWwgTWVkaWFDb250cm9sRWxlbWVu dFR5cGUgZGlzcGxheVR5cGUoKSBjb25zdDsKICAgICB2aXJ0dWFsIGNvbnN0IEF0b21pY1N0cmlu ZyYgc2hhZG93UHNldWRvSWQoKSBjb25zdDsKIAogICAgIGJvb2wgbV9pc1Zpc2libGU7Ci0gICAg aW50IG1feCwgbV95OwogfTsKIAogLy8gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo=