56473 2011-03-16 11:16:25 -0700 Add play state callbacks to MediaControls, kill timeUpdate timer. 2011-03-16 15:16:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 56489 53020 1 dglazkov dglazkov darin eric.carlson oldest_to_newest 368407 0 dglazkov 2011-03-16 11:16:25 -0700 Add play state callbacks to MediaControls, kill timeUpdate timer. 368409 1 85944 dglazkov 2011-03-16 11:18:51 -0700 Created attachment 85944 Patch 368414 2 85944 eric.carlson 2011-03-16 11:22:35 -0700 Comment on attachment 85944 Patch Nice! 368434 3 dglazkov 2011-03-16 11:56:06 -0700 (In reply to comment #2) > (From update of attachment 85944 [details]) > Nice! Since this change does an extra update of the timeline/status as soon as we start playing, the status values are more accurate. However, this affects results in media/controls-without-preload.html, because canplaythrough event is fired asynchronously. By the time it's fired, we already started playing and the status is slightly different. Should I: a) change expectations for the test b) remove updating on start? 368562 4 dglazkov 2011-03-16 14:52:21 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 85944 [details] [details]) > > Nice! > > Since this change does an extra update of the timeline/status as soon as we start playing, the status values are more accurate. However, this affects results in media/controls-without-preload.html, because canplaythrough event is fired asynchronously. By the time it's fired, we already started playing and the status is slightly different. > > Should I: > a) change expectations for the test > b) remove updating on start? I ended up improving the test in http://trac.webkit.org/changeset/81280. 368574 5 dglazkov 2011-03-16 15:16:01 -0700 Committed r81283: <http://trac.webkit.org/changeset/81283> 85944 2011-03-16 11:18:51 -0700 2011-03-16 11:22:35 -0700 Patch bug-56473-20110316111849.patch text/plain 6336 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogODEyNTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5NjY0YjliMWZhNzQxNzFj NjA5OTBiYTQ3YzM2YmFmNjNjMjVkZGM2Li40NjFhMjc0ZTEwYjE2MDkyYzJjZGJmYTY5MDIwNjlj YzIyYWRiMmFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDMtMTYgIERpbWl0 cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgcGxheSBzdGF0ZSBjYWxsYmFja3MgdG8g TWVkaWFDb250cm9scywga2lsbCB0aW1lVXBkYXRlIHRpbWVyLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTY0NzMKKworICAgICAgICBObyBjaGFuZ2Ug aW4gYmVoYXZpb3IsIGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBodG1s L0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVu dDo6cGxheWJhY2tQcm9ncmVzc1RpbWVyRmlyZWQpOiBBZGRlZCBhIGNhbGwgdG8KKyAgICAgICAg ICAgIG1lZGlhIGNvbnRyb2xzLgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6 dXBkYXRlUGxheVN0YXRlKTogRGl0dG8uCisgICAgICAgICogaHRtbC9zaGFkb3cvTWVkaWFDb250 cm9scy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xzOjpNZWRpYUNvbnRyb2xz KTogUmVtb3ZlZCBpbml0aWFsaXphdGlvbiBvZiB0aGUgdGltZXIuCisgICAgICAgIChXZWJDb3Jl OjpNZWRpYUNvbnRyb2xzOjpwbGF5YmFja1Byb2dyZXNzZWQpOiBBZGRlZC4KKyAgICAgICAgKFdl YkNvcmU6Ok1lZGlhQ29udHJvbHM6OnBsYXliYWNrU3RhcnRlZCk6IEFkZGVkLCBmb3Igbm93IHJv dXRpbmcgdG8ganVzdAorICAgICAgICAgICAgY2FsbCBwbGF5YmFja1Byb2dyZXNzZWQuCisgICAg ICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xzOjpwbGF5YmFja1N0b3BwZWQpOiBEaXR0by4KKyAg ICAgICAgKFdlYkNvcmU6Ok1lZGlhQ29udHJvbHM6OnVwZGF0ZSk6IFJlbW92ZWQgdGhlIGNvZGUg dG8gc3RhcnQvc3RvcCB0aGUKKyAgICAgICAgICAgIHRpbWVyIHRoYXQncyBub3cgZ29uZS4KKyAg ICAgICAgKiBodG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xzLmg6IFJlbW92ZWQgdGltZXIgZGVjbHMu CisKIDIwMTEtMDMtMTYgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFF bGVtZW50LmNwcAppbmRleCAzNjkxNTdlMzE3MGFkMDlhZDIyNmFkOWQ1M2EzNGUzZDc1NWI3OTQ1 Li4wNDcxMTI2OTUyY2JmMzFiZTc4MmQ5ZWNhODkyNzQ1OWZiYjZmM2EzIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTE1OTUsNyArMTU5NSw5IEBAIHZvaWQg SFRNTE1lZGlhRWxlbWVudDo6cGxheWJhY2tQcm9ncmVzc1RpbWVyRmlyZWQoVGltZXI8SFRNTE1l ZGlhRWxlbWVudD4qKQogICAgICAgICByZXR1cm47CiAKICAgICBzY2hlZHVsZVRpbWV1cGRhdGVF dmVudCh0cnVlKTsKLSAgICAKKyAgICBpZiAoaGFzTWVkaWFDb250cm9scygpKQorICAgICAgICBt ZWRpYUNvbnRyb2xzKCktPnBsYXliYWNrUHJvZ3Jlc3NlZCgpOworCiAgICAgLy8gRklYTUU6IGRl YWwgd2l0aCBjdWUgcmFuZ2VzIGhlcmUKIH0KIApAQCAtMjExNyw2ICsyMTE5LDggQEAgdm9pZCBI VE1MTWVkaWFFbGVtZW50Ojp1cGRhdGVQbGF5U3RhdGUoKQogICAgICAgICAgICAgbV9wbGF5ZXIt PnBhdXNlKCk7CiAgICAgICAgIHJlZnJlc2hDYWNoZWRUaW1lKCk7CiAgICAgICAgIG1fcGxheWJh Y2tQcm9ncmVzc1RpbWVyLnN0b3AoKTsKKyAgICAgICAgaWYgKGhhc01lZGlhQ29udHJvbHMoKSkK KyAgICAgICAgICAgIG1lZGlhQ29udHJvbHMoKS0+cGxheWJhY2tTdG9wcGVkKCk7CiAgICAgICAg IHJldHVybjsKICAgICB9CiAgICAgCkBAIC0yMTQwLDYgKzIxNDQsOCBAQCB2b2lkIEhUTUxNZWRp YUVsZW1lbnQ6OnVwZGF0ZVBsYXlTdGF0ZSgpCiAgICAgICAgICAgICBtX3BsYXllci0+cGxheSgp OwogICAgICAgICB9CiAKKyAgICAgICAgaWYgKGhhc01lZGlhQ29udHJvbHMoKSkKKyAgICAgICAg ICAgIG1lZGlhQ29udHJvbHMoKS0+cGxheWJhY2tTdGFydGVkKCk7CiAgICAgICAgIHN0YXJ0UGxh eWJhY2tQcm9ncmVzc1RpbWVyKCk7CiAgICAgICAgIG1fcGxheWluZyA9IHRydWU7CiAKQEAgLTIx NTYsNiArMjE2Miw5IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6dXBkYXRlUGxheVN0YXRlKCkK IAogICAgICAgICBpZiAoY291bGRQbGF5SWZFbm91Z2hEYXRhKCkpCiAgICAgICAgICAgICBtX3Bs YXllci0+cHJlcGFyZVRvUGxheSgpOworCisgICAgICAgIGlmIChoYXNNZWRpYUNvbnRyb2xzKCkp CisgICAgICAgICAgICBtZWRpYUNvbnRyb2xzKCktPnBsYXliYWNrU3RvcHBlZCgpOwogICAgIH0K ICAgICAKICAgICBpZiAocmVuZGVyZXIoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvc2hhZG93L01lZGlhQ29udHJvbHMuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cv TWVkaWFDb250cm9scy5jcHAKaW5kZXggMmVlZDUzMWEyODYyZGMxOTVmOThkMzZjM2M0ZjY5YTlj OGNmYTg5Ny4uZTIwMTFkMWMxMzJjOTQxNjQyN2QyMTllNjlkNzNlZGYwYjZkYTQzNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9scy5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9scy5jcHAKQEAgLTQ3LDEyICs0 NywxMCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHVzaW5nIG5hbWVzcGFjZSBIVE1MTmFtZXM7 CiAKLXN0YXRpYyBjb25zdCBkb3VibGUgY1RpbWVVcGRhdGVSZXBlYXREZWxheSA9IDAuMjsKIHN0 YXRpYyBjb25zdCBkb3VibGUgY09wYWNpdHlBbmltYXRpb25SZXBlYXREZWxheSA9IDAuMDU7CiAK IE1lZGlhQ29udHJvbHM6Ok1lZGlhQ29udHJvbHMoSFRNTE1lZGlhRWxlbWVudCogbWVkaWFFbGVt ZW50KQogICAgIDogbV9tZWRpYUVsZW1lbnQobWVkaWFFbGVtZW50KQotICAgICwgbV90aW1lVXBk YXRlVGltZXIodGhpcywgJk1lZGlhQ29udHJvbHM6OnRpbWVVcGRhdGVUaW1lckZpcmVkKQogICAg ICwgbV9vcGFjaXR5QW5pbWF0aW9uVGltZXIodGhpcywgJk1lZGlhQ29udHJvbHM6Om9wYWNpdHlB bmltYXRpb25UaW1lckZpcmVkKQogICAgICwgbV9vcGFjaXR5QW5pbWF0aW9uU3RhcnRUaW1lKDAp CiAgICAgLCBtX29wYWNpdHlBbmltYXRpb25EdXJhdGlvbigwKQpAQCAtNjcsNiArNjUsMjMgQEAg dm9pZCBNZWRpYUNvbnRyb2xzOjpyZXNldCgpCiAgICAgdXBkYXRlKCk7CiB9CiAKK3ZvaWQgTWVk aWFDb250cm9sczo6cGxheWJhY2tQcm9ncmVzc2VkKCkKK3sKKyAgICBpZiAobV90aW1lbGluZSkK KyAgICAgICAgbV90aW1lbGluZS0+dXBkYXRlKGZhbHNlKTsKKyAgICB1cGRhdGVUaW1lRGlzcGxh eSgpOworfQorCit2b2lkIE1lZGlhQ29udHJvbHM6OnBsYXliYWNrU3RhcnRlZCgpCit7CisgICAg cGxheWJhY2tQcm9ncmVzc2VkKCk7Cit9CisKK3ZvaWQgTWVkaWFDb250cm9sczo6cGxheWJhY2tT dG9wcGVkKCkKK3sKKyAgICBwbGF5YmFja1Byb2dyZXNzZWQoKTsKK30KKwogdm9pZCBNZWRpYUNv bnRyb2xzOjpjaGFuZ2VkTXV0ZSgpCiB7CiAgICAgdXBkYXRlKCk7CkBAIC0xNjYsNyArMTgxLDYg QEAgdm9pZCBNZWRpYUNvbnRyb2xzOjp1cGRhdGUoKQogICAgICAgICB9CiAgICAgICAgIG1fb3Bh Y2l0eUFuaW1hdGlvblRvID0gMS4wZjsKICAgICAgICAgbV9vcGFjaXR5QW5pbWF0aW9uVGltZXIu c3RvcCgpOwotICAgICAgICBtX3RpbWVVcGRhdGVUaW1lci5zdG9wKCk7CiAgICAgICAgIHJldHVy bjsKICAgICB9CiAKQEAgLTE5OCwxMyArMjEyLDYgQEAgdm9pZCBNZWRpYUNvbnRyb2xzOjp1cGRh dGUoKQogICAgICAgICB9CiAgICAgfQogCi0gICAgaWYgKG1lZGlhLT5jYW5QbGF5KCkpIHsKLSAg ICAgICAgaWYgKG1fdGltZVVwZGF0ZVRpbWVyLmlzQWN0aXZlKCkpCi0gICAgICAgICAgICBtX3Rp bWVVcGRhdGVUaW1lci5zdG9wKCk7Ci0gICAgfSBlbHNlIGlmIChtZWRpYS0+cmVuZGVyZXIoKS0+ c3R5bGUoKS0+dmlzaWJpbGl0eSgpID09IFZJU0lCTEUgJiYgbV90aW1lbGluZSAmJiBtX3RpbWVs aW5lLT5yZW5kZXJlcigpICYmIG1fdGltZWxpbmUtPnJlbmRlcmVyKCktPnN0eWxlKCktPmRpc3Bs YXkoKSAhPSBOT05FKSB7Ci0gICAgICAgIG1fdGltZVVwZGF0ZVRpbWVyLnN0YXJ0UmVwZWF0aW5n KGNUaW1lVXBkYXRlUmVwZWF0RGVsYXkpOwotICAgIH0KLQogICAgIGlmIChtX3BhbmVsKSB7CiAg ICAgICAgIC8vIHVwZGF0ZSgpIG1pZ2h0IGFsdGVyIHRoZSBvcGFjaXR5IG9mIHRoZSBlbGVtZW50 LCBlc3BlY2lhbGx5IGlmIHdlIGFyZSBpbiB0aGUgbWlkZGxlCiAgICAgICAgIC8vIG9mIGFuIGFu aW1hdGlvbi4gVGhpcyBpcyB0aGUgb25seSBlbGVtZW50IGNvbmNlcm5lZCBhcyB3ZSBhbmltYXRl IG9ubHkgdGhpcyBlbGVtZW50LgpAQCAtMzc5LDEzICszODYsNiBAQCB2b2lkIE1lZGlhQ29udHJv bHM6OmNyZWF0ZUZ1bGxzY3JlZW5CdXR0b24oKQogICAgIG1fZnVsbHNjcmVlbkJ1dHRvbi0+YXR0 YWNoVG9QYXJlbnQobV9wYW5lbC5nZXQoKSk7CiB9CiAKLXZvaWQgTWVkaWFDb250cm9sczo6dGlt ZVVwZGF0ZVRpbWVyRmlyZWQoVGltZXI8TWVkaWFDb250cm9scz4qKQotewotICAgIGlmIChtX3Rp bWVsaW5lKQotICAgICAgICBtX3RpbWVsaW5lLT51cGRhdGUoZmFsc2UpOwotICAgIHVwZGF0ZVRp bWVEaXNwbGF5KCk7Ci19Ci0KIHZvaWQgTWVkaWFDb250cm9sczo6dXBkYXRlVGltZURpc3BsYXko KQogewogICAgIEFTU0VSVChtX21lZGlhRWxlbWVudC0+cmVuZGVyZXIoKSk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xzLmggYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xzLmgKaW5kZXggNmVhMTQ0OGI5NzE5NWViYzVl OTNkYmMzOTQ5NjJiOTYxZGI4NDcyZS4uNmQ2MmY4ZmFkMDhlZmQ1YTI0MTgzMTE1M2Q0Mzc4Mjlm OWIxY2ExMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250 cm9scy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01lZGlhQ29udHJvbHMuaApA QCAtNjMsNiArNjMsMTEgQEAgcHVibGljOgogICAgIE1lZGlhQ29udHJvbHMoSFRNTE1lZGlhRWxl bWVudCopOwogCiAgICAgdm9pZCByZXNldCgpOworCisgICAgdm9pZCBwbGF5YmFja1Byb2dyZXNz ZWQoKTsKKyAgICB2b2lkIHBsYXliYWNrU3RhcnRlZCgpOworICAgIHZvaWQgcGxheWJhY2tTdG9w cGVkKCk7CisKICAgICB2b2lkIGNoYW5nZWRNdXRlKCk7CiAgICAgdm9pZCBjaGFuZ2VkVm9sdW1l KCk7CiAgICAgdm9pZCBjaGFuZ2VkQ2xvc2VkQ2FwdGlvbnNWaXNpYmlsaXR5KCk7CkBAIC05OCw4 ICsxMDMsNiBAQCBwcml2YXRlOgogICAgIHZvaWQgY3JlYXRlVGltZVJlbWFpbmluZ0Rpc3BsYXko KTsKICAgICB2b2lkIGNyZWF0ZUZ1bGxzY3JlZW5CdXR0b24oKTsKIAotICAgIHZvaWQgdGltZVVw ZGF0ZVRpbWVyRmlyZWQoVGltZXI8TWVkaWFDb250cm9scz4qKTsKLQogICAgIHZvaWQgdXBkYXRl Q29udHJvbFZpc2liaWxpdHkoKTsKICAgICB2b2lkIGNoYW5nZU9wYWNpdHkoSFRNTEVsZW1lbnQq LCBmbG9hdCBvcGFjaXR5KTsKICAgICB2b2lkIG9wYWNpdHlBbmltYXRpb25UaW1lckZpcmVkKFRp bWVyPE1lZGlhQ29udHJvbHM+Kik7CkBAIC0xMjcsNyArMTMwLDYgQEAgcHJpdmF0ZToKICAgICBS ZWZQdHI8TWVkaWFDb250cm9sU3RhdHVzRGlzcGxheUVsZW1lbnQ+IG1fc3RhdHVzRGlzcGxheTsK IAogICAgIEhUTUxNZWRpYUVsZW1lbnQqIG1fbWVkaWFFbGVtZW50OwotICAgIFRpbWVyPE1lZGlh Q29udHJvbHM+IG1fdGltZVVwZGF0ZVRpbWVyOwogICAgIFRpbWVyPE1lZGlhQ29udHJvbHM+IG1f b3BhY2l0eUFuaW1hdGlvblRpbWVyOwogCiAgICAgZG91YmxlIG1fb3BhY2l0eUFuaW1hdGlvblN0 YXJ0VGltZTsK