56464 2011-03-16 08:24:35 -0700 Tiled backing store should only request repaint for updated areas 2011-04-13 02:01:59 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 45423 1 gustavo webkit-unassigned abarth eric kenneth kling webkit.review.bot oldest_to_newest 368335 0 gustavo 2011-03-16 08:24:35 -0700 Subject says it all. Currently the tiled backing store code has this FIXME: // FIXME: should not request system repaint for the full tile. 368337 1 85932 gustavo 2011-03-16 08:37:38 -0700 Created attachment 85932 Patch 368760 2 85932 kling 2011-03-16 19:59:28 -0700 Comment on attachment 85932 Patch Oh, awesome! r=me 369006 3 85932 gustavo 2011-03-17 05:00:44 -0700 Comment on attachment 85932 Patch Clearing flags on attachment: 85932 Committed r81347: <http://trac.webkit.org/changeset/81347> 369007 4 gustavo 2011-03-17 05:00:57 -0700 All reviewed patches have been landed. Closing bug. 369020 5 85932 kenneth 2011-03-17 05:27:35 -0700 Comment on attachment 85932 Patch Are we doing this for our webkit2 tiling? 369026 6 webkit.review.bot 2011-03-17 05:59:51 -0700 http://trac.webkit.org/changeset/81347 might have broken GTK Linux 64-bit Debug The following tests are not passing: svg/custom/clip-path-referencing-use2.svg 85932 2011-03-16 08:37:38 -0700 2011-03-17 05:27:35 -0700 Patch bug-56464-20110316123736.patch text/plain 4207 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogODEyNDAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5ZjUzOTlkODNlNGUwNjk3 NzhkOGUxM2M2YzdhOTIzYWVlZjQ0OGJkLi5lMDY1MWI5ODIxNWE4M2ZlZWYzOGU5ZTdhMmRmMjlk NDdjODI2MGE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDMtMTYgIEd1c3Rh dm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGlsZWQgYmFja2lu ZyBzdG9yZSBzaG91bGQgb25seSByZXF1ZXN0IHJlcGFpbnQgZm9yIHVwZGF0ZWQgYXJlYXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2NDY0CisKKyAg ICAgICAgUmV1c2UgdXBkYXRlQmFja0J1ZmZlcidzIGRpcnR5IHJlY3RhbmdsZSBjYWxjdWxhdGlv bnMgdG8gb25seQorICAgICAgICBpbnZhbGlkYXRlIHRoZSBuZWNlc3NhcnkgcGFydHMgb2YgdGhl IHdpbmRvdy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL1RpbGUuaDoKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpUaWxlZEJhY2tpbmdTdG9yZTo6dXBkYXRlVGlsZUJ1ZmZlcnMpOgorICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL3F0L1RpbGVRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUaWxlOjp1 cGRhdGVCYWNrQnVmZmVyKToKKwogMjAxMS0wMy0xNiAgQW5kcmV5IEFkYWlraW4gIDxhYW5kcmV5 QGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGUuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGUuaAppbmRleCBjNjIzZWM5ZmU3YjFlM2Y5 OTZiMTZhMmViMDlhYTU0M2E4ZWU2YjI1Li4wMjA3NmQyOTRhNmQ2YTdkOWIyN2QzY2E2M2ZiZjE5 NTVhZmJmMGFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9U aWxlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZS5oCkBAIC00 OSw3ICs0OSw3IEBAIHB1YmxpYzoKICAgICAKICAgICBib29sIGlzRGlydHkoKSBjb25zdDsKICAg ICB2b2lkIGludmFsaWRhdGUoY29uc3QgSW50UmVjdCYpOwotICAgIHZvaWQgdXBkYXRlQmFja0J1 ZmZlcigpOworICAgIFZlY3RvcjxJbnRSZWN0PiB1cGRhdGVCYWNrQnVmZmVyKCk7CiAgICAgdm9p ZCBzd2FwQmFja0J1ZmZlclRvRnJvbnQoKTsKICAgICBib29sIGlzUmVhZHlUb1BhaW50KCkgY29u c3Q7CiAgICAgdm9pZCBwYWludChHcmFwaGljc0NvbnRleHQqLCBjb25zdCBJbnRSZWN0Jik7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdT dG9yZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdT dG9yZS5jcHAKaW5kZXggNGQ2OTMzNDQ3OTBiMTBmZWQ3NWFmZmUzYTVmZTQyMDJjMmUzNDMxMC4u YWM3ZTljNmY1Mjk0MTEzZGZlZjZkMTNhZjRhODcwZTBjNjYyNmVlMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFja2luZ1N0b3JlLmNwcApA QCAtMTAyLDggKzEwMiw2IEBAIHZvaWQgVGlsZWRCYWNraW5nU3RvcmU6OnVwZGF0ZVRpbGVCdWZm ZXJzKCkKICAgICAgICAgaWYgKCFpdC0+c2Vjb25kLT5pc0RpcnR5KCkpCiAgICAgICAgICAgICBj b250aW51ZTsKICAgICAgICAgZGlydHlUaWxlcy5hcHBlbmQoaXQtPnNlY29uZCk7Ci0gICAgICAg IC8vIEZJWE1FOiBzaG91bGQgbm90IHJlcXVlc3Qgc3lzdGVtIHJlcGFpbnQgZm9yIHRoZSBmdWxs IHRpbGUuCi0gICAgICAgIHBhaW50ZWRBcmVhLmFwcGVuZChtYXBUb0NvbnRlbnRzKGl0LT5zZWNv bmQtPnJlY3QoKSkpOwogICAgIH0KICAgICAKICAgICBpZiAoZGlydHlUaWxlcy5pc0VtcHR5KCkp IHsKQEAgLTExNSwxMSArMTEzLDExIEBAIHZvaWQgVGlsZWRCYWNraW5nU3RvcmU6OnVwZGF0ZVRp bGVCdWZmZXJzKCkKICAgICAvLyBvbmUgYnkgb25lIGFuZCB0aGVuIHN3YXBwZWQgdG8gZnJvbnQg aW4gb25lIGdvLiBUaGlzIHdvdWxkIG1pbmltaXplIHRoZSB0aW1lIHNwZW50CiAgICAgLy8gYmxv Y2tpbmcgb24gdGlsZSB1cGRhdGVzLgogICAgIHVuc2lnbmVkIHNpemUgPSBkaXJ0eVRpbGVzLnNp emUoKTsKLSAgICBmb3IgKHVuc2lnbmVkIG4gPSAwOyBuIDwgc2l6ZTsgKytuKQotICAgICAgICBk aXJ0eVRpbGVzW25dLT51cGRhdGVCYWNrQnVmZmVyKCk7Ci0KLSAgICBmb3IgKHVuc2lnbmVkIG4g PSAwOyBuIDwgc2l6ZTsgKytuKQorICAgIGZvciAodW5zaWduZWQgbiA9IDA7IG4gPCBzaXplOyAr K24pIHsKKyAgICAgICAgVmVjdG9yPEludFJlY3Q+IHBhaW50ZWRSZWN0cyA9IGRpcnR5VGlsZXNb bl0tPnVwZGF0ZUJhY2tCdWZmZXIoKTsKKyAgICAgICAgcGFpbnRlZEFyZWEuYXBwZW5kKHBhaW50 ZWRSZWN0cyk7CiAgICAgICAgIGRpcnR5VGlsZXNbbl0tPnN3YXBCYWNrQnVmZmVyVG9Gcm9udCgp OworICAgIH0KIAogICAgIG1fY2xpZW50LT50aWxlZEJhY2tpbmdTdG9yZVBhaW50RW5kKHBhaW50 ZWRBcmVhKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3F0L1RpbGVRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9UaWxl UXQuY3BwCmluZGV4IDA5NmNlMTQ3YjA1OWIxNWU3MzYyOGEwODhhOTg5MWUyYzg2ZTI4Y2QuLjg3 MjNjZDRiNzJhYWNkNzRmMmMwMmQxZGFkNTg3OTA5Yzc3OWFjMzEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1RpbGVRdC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvVGlsZVF0LmNwcApAQCAtOTEsMTAgKzkxLDEwIEBA IHZvaWQgVGlsZTo6aW52YWxpZGF0ZShjb25zdCBJbnRSZWN0JiBkaXJ0eVJlY3QpCiAgICAgKm1f ZGlydHlSZWdpb24gKz0gdGlsZURpcnR5UmVjdDsKIH0KICAgICAKLXZvaWQgVGlsZTo6dXBkYXRl QmFja0J1ZmZlcigpCitWZWN0b3I8SW50UmVjdD4gVGlsZTo6dXBkYXRlQmFja0J1ZmZlcigpCiB7 CiAgICAgaWYgKG1fYnVmZmVyICYmICFpc0RpcnR5KCkpCi0gICAgICAgIHJldHVybjsKKyAgICAg ICAgcmV0dXJuIFZlY3RvcjxJbnRSZWN0PigpOwogCiAgICAgaWYgKCFtX2JhY2tCdWZmZXIpIHsK ICAgICAgICAgaWYgKCFtX2J1ZmZlcikgewpAQCAtMTE1LDE1ICsxMTUsMTkgQEAgdm9pZCBUaWxl Ojp1cGRhdGVCYWNrQnVmZmVyKCkKICAgICBHcmFwaGljc0NvbnRleHQgY29udGV4dCgmcGFpbnRl cik7CiAgICAgY29udGV4dC50cmFuc2xhdGUoLW1fcmVjdC54KCksIC1tX3JlY3QueSgpKTsKIAor ICAgIFZlY3RvcjxJbnRSZWN0PiB1cGRhdGVkUmVjdHM7CiAgICAgaW50IHNpemUgPSBkaXJ0eVJl Y3RzLnNpemUoKTsKICAgICBmb3IgKGludCBuID0gMDsgbiA8IHNpemU7ICsrbikgIHsKICAgICAg ICAgY29udGV4dC5zYXZlKCk7CiAgICAgICAgIEludFJlY3QgcmVjdCA9IGRpcnR5UmVjdHNbbl07 CisgICAgICAgIHVwZGF0ZWRSZWN0cy5hcHBlbmQocmVjdCk7CiAgICAgICAgIGNvbnRleHQuY2xp cChGbG9hdFJlY3QocmVjdCkpOwogICAgICAgICBjb250ZXh0LnNjYWxlKEZsb2F0U2l6ZShtX2Jh Y2tpbmdTdG9yZS0+bV9jb250ZW50c1NjYWxlLCBtX2JhY2tpbmdTdG9yZS0+bV9jb250ZW50c1Nj YWxlKSk7CiAgICAgICAgIG1fYmFja2luZ1N0b3JlLT5tX2NsaWVudC0+dGlsZWRCYWNraW5nU3Rv cmVQYWludCgmY29udGV4dCwgbV9iYWNraW5nU3RvcmUtPm1hcFRvQ29udGVudHMocmVjdCkpOwog ICAgICAgICBjb250ZXh0LnJlc3RvcmUoKTsKICAgICB9CisKKyAgICByZXR1cm4gdXBkYXRlZFJl Y3RzOwogfQogCiB2b2lkIFRpbGU6OnN3YXBCYWNrQnVmZmVyVG9Gcm9udCgpCg==