56463 2011-03-16 08:16:17 -0700 [Qt] TextBreakIteratorQt.cpp missing #include <algorithm> needed for some platforms. 2011-03-16 17:35:10 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Other RESOLVED FIXED P3 Normal --- 0 kamaji webkit-unassigned commit-queue laszlo.gombos max.hong.shen oldest_to_newest 368333 0 kamaji 2011-03-16 08:16:17 -0700 On some Qt-powered devices, std::swap is unable to be found unless the <algorithm> header is included, in the case of TextBreakIteratorQt.cpp. On Mac, this is appears to be accomplished by a universally included common header, but Qt does not use this. ../../../webkit/Source/WebCore/platform/text/qt/TextBreakIteratorQt.cpp: In function 'WebCore::TextBreakIterator* WebCore::acquireLineBreakIterator(const UChar*, int)': ../../../webkit/Source/WebCore/platform/text/qt/TextBreakIteratorQt.cpp:92: error: 'swap' is not a member of 'std' make[1]: *** [obj/release/TextBreakIteratorQt.o] Error 1 368587 1 85988 kamaji 2011-03-16 15:29:08 -0700 Created attachment 85988 Patch Patch with fix 368611 2 85988 kling 2011-03-16 16:11:00 -0700 Comment on attachment 85988 Patch r=me 368678 3 commit-queue 2011-03-16 17:32:50 -0700 The commit-queue encountered the following flaky tests while processing attachment 85988: http/tests/inspector/network/network-timing.html bug 56509 (author: pfeldman@chromium.org) The commit-queue is continuing to process your patch. 368680 4 85988 commit-queue 2011-03-16 17:35:06 -0700 Comment on attachment 85988 Patch Clearing flags on attachment: 85988 Committed r81302: <http://trac.webkit.org/changeset/81302> 368681 5 commit-queue 2011-03-16 17:35:10 -0700 All reviewed patches have been landed. Closing bug. 85988 2011-03-16 15:29:08 -0700 2011-03-16 17:35:06 -0700 Patch bug-56463-20110316183006.patch text/plain 1830 kamaji U3VidmVyc2lvbiBSZXZpc2lvbjogODEyODAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiMzAzMGRiZDk4ZDA5YWYw MGVhYjMzMjljM2IxNWQyN2YyZmVjNGM3Li45NjhmZWYzNzkyZWU4OGI1MWZjYmRlOGZlYjdhODIy Mzg0ZTUyNjI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDMtMTYgIEtlaXRo IEt5eml2YXQgIDxrZWl0aC5reXppdmF0QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEZpeCBzdGQ6OnN3YXAgbm90IGZvdW5k IGlzc3VlIG9uIG1vYmlsZSBRdCBkZXZpY2VzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTY0NjMKKworICAgICAgICBJbmNsdWRlIDxhbGdvcml0aG0+ IGluIFRleHRCcmVha0l0ZXJhdG9yUXQuY3BwIHNvIHN0ZDo6c3dhcCBpcyBmb3VuZAorICAgICAg ICBvbiBzb21lIFF0IG1vYmlsZSBkZXZpY2VzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0czogTm8g dGVzdHMgbmVlZGVkIC0gY29tcGlsYXRpb24gdmVyaWZpZWQgbWFudWFsbHkuCisKKyAgICAgICAg KiBwbGF0Zm9ybS90ZXh0L3F0L1RleHRCcmVha0l0ZXJhdG9yUXQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6YWNxdWlyZUxpbmVCcmVha0l0ZXJhdG9yKToKKwogMjAxMS0wMy0xNiAgRGF2aWQgTGV2 aW4gIDxsZXZpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ2hyb21pdW0gTGVvcGFyZCBidWls ZCBmaXggYXR0ZW1wdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQv cXQvVGV4dEJyZWFrSXRlcmF0b3JRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0 L3F0L1RleHRCcmVha0l0ZXJhdG9yUXQuY3BwCmluZGV4IDNmYWU2NTcxMWQ5ZGMwZDU1MTVmNzIx ZWU0MGY2YTkxYjk5MjMwODcuLjFmZTQwMGM2YmE5ZTBjOTQ1ODc1NTc4MzJhZDA2YmE2ODQ4ZGQx MmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvcXQvVGV4dEJyZWFr SXRlcmF0b3JRdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9xdC9UZXh0 QnJlYWtJdGVyYXRvclF0LmNwcApAQCAtMjIsNiArMjIsNyBAQAogI2luY2x1ZGUgIlRleHRCcmVh a0l0ZXJhdG9yLmgiCiAKICNpbmNsdWRlIDxRdENvcmUvcXRleHRib3VuZGFyeWZpbmRlci5oPgor I2luY2x1ZGUgPGFsZ29yaXRobT4KICNpbmNsdWRlIDxxZGVidWcuaD4KIAogLy8gI2RlZmluZSBE RUJVR19URVhUX0lURVJBVE9SUwpAQCAtODksNyArOTAsNyBAQCBjb25zdCBjaGFyKiBjdXJyZW50 VGV4dEJyZWFrTG9jYWxlSUQoKQogICAgICAgICBUZXh0QnJlYWtJdGVyYXRvciogbGluZUJyZWFr SXRlcmF0b3IgPSAwOwogICAgICAgICBpZiAoc3RhdGljTGluZUJyZWFrSXRlcmF0b3IpIHsKICAg ICAgICAgICAgIHNldFVwSXRlcmF0b3IoKnN0YXRpY0xpbmVCcmVha0l0ZXJhdG9yLCBRVGV4dEJv dW5kYXJ5RmluZGVyOjpMaW5lLCBzdHJpbmcsIGxlbmd0aCk7Ci0gICAgICAgICAgICBzd2FwKHN0 YXRpY0xpbmVCcmVha0l0ZXJhdG9yLCBsaW5lQnJlYWtJdGVyYXRvcik7CisgICAgICAgICAgICBz dGQ6OnN3YXAoc3RhdGljTGluZUJyZWFrSXRlcmF0b3IsIGxpbmVCcmVha0l0ZXJhdG9yKTsKICAg ICAgICAgfQogCiAgICAgICAgIGlmICghbGluZUJyZWFrSXRlcmF0b3IgJiYgc3RyaW5nICYmIGxl bmd0aCkK