56450 2011-03-15 23:18:23 -0700 Need to do an experiment to make sure that reftests don't cause any issues on all buildbots 2011-03-21 22:00:03 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 36065 1 hayato webkit-unassigned dpranke hamaji ojan oldest_to_newest 368207 0 hayato 2011-03-15 23:18:23 -0700 I'll submit the first reftest after all necessary changes are landed. 368209 1 85913 hayato 2011-03-15 23:20:14 -0700 Created attachment 85913 the-first-reftest 368210 2 hayato 2011-03-15 23:21:15 -0700 I've checked it as 'r?', but I won't submit this patch soon until all necessary changes are landed. 368986 3 85913 eric 2011-03-17 04:29:57 -0700 Comment on attachment 85913 the-first-reftest What identifies this as a reftest? expected.html I assume? 368993 4 hayato 2011-03-17 04:39:39 -0700 Yeah, we use a naming convention to identify. Please see a master bug to know how and why: https://bugs.webkit.org/show_bug.cgi?id=36065 And the Wiki page I started to write is here: http://trac.webkit.org/wiki/Writing%20Reftests (In reply to comment #3) > (From update of attachment 85913 [details]) > What identifies this as a reftest? expected.html I assume? 369899 5 85913 eric 2011-03-18 14:34:17 -0700 Comment on attachment 85913 the-first-reftest Seems this should go into the harness directory (which is about testing DRT/RWT) since this test doesn't really add much to our CSS testing. 370077 6 hayato 2011-03-18 19:17:02 -0700 This is an experiment reftest, so the test itself doesn't matter. If you think this test doesn't add much to our css testing, I am happy to revert it after we confirm all buildbots are happy with this reftest. We decided to use LayoutTest directory to where '-expected.html' is added as other existing LayoutTests do. So '-expected.html' must go into LayoutTests directory to do an experiment. (In reply to comment #5) > (From update of attachment 85913 [details]) > Seems this should go into the harness directory (which is about testing DRT/RWT) since this test doesn't really add much to our CSS testing. 370245 7 ojan 2011-03-20 15:24:29 -0700 I think Eric was just saying that the test should go in fast/harness instead of fast/css. 370273 8 86293 hayato 2011-03-20 21:04:14 -0700 Created attachment 86293 move-to-harness 370276 9 hayato 2011-03-20 21:08:29 -0700 Hi Ojan, thank you for clarifying that. Although I am not 100% sure what the purpose of the 'fast/harness' directory is, I've moved the test to 'fast/harness' directory. Could you review it? (In reply to comment #7) > I think Eric was just saying that the test should go in fast/harness instead of fast/css. 371198 10 hayato 2011-03-21 22:00:03 -0700 Committed r81644: <http://trac.webkit.org/changeset/81644> 85913 2011-03-15 23:20:14 -0700 2011-03-20 21:04:09 -0700 the-first-reftest bug-56450-20110316152013.patch text/plain 1657 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogODEyMDYKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4YzZiY2I0MDA0Nzg0NGI1OTdhMDE0 NjE1MWFmNmZlZDc5OGE3OWNjLi5iM2MwNWMyZGQ4YmUzNTUzMTViZjM2M2Q3MDgwYTc0NWYwNjI0 ZTZkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMTUgIEhheWF0byBJdG8gIDxoYXlh dG9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFkZCB0aGUgZmlyc3QgcmVmdGVzdCBzbyB0aGF0IHdlIGNhbiBtYWtlIHN1cmUg dGhhdCByZWZ0ZXN0cyB3b24ndCBjYXVzZQorICAgICAgICBhbnkgaXNzdWVzIG9uIGFsbCBidWls ZGJvdHMuCisgICAgICAgIFRoaXMgcGF0Y2ggd2lsbCBhbHNvIGFjdCBhcyBhIHNhbXBsZSByZWZ0 ZXN0IHdoaWNoIGEgV2lraSBwYWdlIHdpbGwgcmVmZXIuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2NDUwCisKKyAgICAgICAgKiBmYXN0L2Nzcy9m b250LXdlaWdodC1ib2xkLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3Nz L2ZvbnQtd2VpZ2h0LWJvbGQuaHRtbDogQWRkZWQuCisKIDIwMTEtMDMtMTUgIERhdmlkIExldmlu ICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVwZGF0ZSBsZW9wYXJkIHNwZWNpZmlj IGJhc2VsaW5lcyBmb3IgdGVzdHMgKGVkaXRpbmcsIGNzcykgY2hhbmdlcyBkdWUgdG8gcjgwNzU1 LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvZm9udC13ZWlnaHQtYm9sZC1leHBl Y3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvZm9udC13ZWlnaHQtYm9sZC1leHBlY3Rl ZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjAxMmQzMWM0ZTdhMGRkYjU0OThhZWY0ZmQ4MjEyMGMxODYwNTE1 ZDcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9mb250LXdlaWdodC1i b2xkLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSw1IEBACis8aHRtbD4KKzxib2R5PgorPGI+SGVs bG8gUmVmdGVzdHM8L2I+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9mYXN0L2Nzcy9mb250LXdlaWdodC1ib2xkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9m b250LXdlaWdodC1ib2xkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYTBjNjhkNTQ1N2Y0ZDUxZThkMTYzNjk2 NTZhMDgzYjA2NTk5MzViYwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3Nz L2ZvbnQtd2VpZ2h0LWJvbGQuaHRtbApAQCAtMCwwICsxLDEyIEBACis8aHRtbD4KKzxoZWFkPgor PHN0eWxlIHR5cGU9InRleHQvY3NzIj4KK2JvZHkgeworICBmb250LXdlaWdodDogYm9sZDsKK30K Kzwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KK0hlbGxvIFJlZnRlc3RzCis8L2JvZHk+Cis8L2h0 bWw+Cg== 86293 2011-03-20 21:04:14 -0700 2011-03-20 23:40:39 -0700 move-to-harness bug-56450-20110321130412.patch text/plain 1689 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogODEyMDYKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4YzZiY2I0MDA0Nzg0NGI1OTdhMDE0 NjE1MWFmNmZlZDc5OGE3OWNjLi41ZmE4MzljMjE2Y2NmNzg2MTdkMzMxOWRmMjViYjUzYjRkMTQ1 NzU3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMjAgIEhheWF0byBJdG8gIDxoYXlh dG9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFkZCB0aGUgZmlyc3QgcmVmdGVzdCBzbyB0aGF0IHdlIGNhbiBtYWtlIHN1cmUg dGhhdCByZWZ0ZXN0cyB3b24ndCBjYXVzZQorICAgICAgICBhbnkgaXNzdWVzIG9uIGFsbCBidWls ZGJvdHMuCisgICAgICAgIFRoaXMgcGF0Y2ggd2lsbCBhbHNvIGFjdCBhcyBhIHNhbXBsZSByZWZ0 ZXN0IHdoaWNoIGEgV2lraSBwYWdlIHdpbGwgcmVmZXIuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2NDUwCisKKyAgICAgICAgKiBmYXN0L2hhcm5l c3MvZm9udC13ZWlnaHQtYm9sZC1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0 L2hhcm5lc3MvZm9udC13ZWlnaHQtYm9sZC5odG1sOiBBZGRlZC4KKwogMjAxMS0wMy0xNSAgRGF2 aWQgTGV2aW4gIDxsZXZpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVXBkYXRlIGxlb3BhcmQg c3BlY2lmaWMgYmFzZWxpbmVzIGZvciB0ZXN0cyAoZWRpdGluZywgY3NzKSBjaGFuZ2VzIGR1ZSB0 byByODA3NTUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvZm9udC13ZWln aHQtYm9sZC1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL2ZvbnQtd2Vp Z2h0LWJvbGQtZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wMTJkMzFjNGU3YTBkZGI1NDk4YWVm NGZkODIxMjBjMTg2MDUxNWQ3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9o YXJuZXNzL2ZvbnQtd2VpZ2h0LWJvbGQtZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDUgQEAKKzxo dG1sPgorPGJvZHk+Cis8Yj5IZWxsbyBSZWZ0ZXN0czwvYj4KKzwvYm9keT4KKzwvaHRtbD4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvaGFybmVzcy9mb250LXdlaWdodC1ib2xkLmh0bWwg Yi9MYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvZm9udC13ZWlnaHQtYm9sZC5odG1sCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLmEwYzY4ZDU0NTdmNGQ1MWU4ZDE2MzY5NjU2YTA4M2IwNjU5OTM1YmMKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvZm9udC13ZWlnaHQtYm9sZC5odG1sCkBA IC0wLDAgKzEsMTIgQEAKKzxodG1sPgorPGhlYWQ+Cis8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgor Ym9keSB7CisgIGZvbnQtd2VpZ2h0OiBib2xkOworfQorPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5 PgorSGVsbG8gUmVmdGVzdHMKKzwvYm9keT4KKzwvaHRtbD4K