56417 2011-03-15 14:48:51 -0700 [Qt][Symbian][WK2] Fix exporting and importing WebProcessMainQt 2011-03-15 23:56:44 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC S60 3rd edition RESOLVED FIXED Qt, QtTriaged P2 Normal --- 50251 1 laszlo.gombos webkit-unassigned abarth commit-queue eric laszlo.gombos s.mathur webkit.review.bot oldest_to_newest 367958 0 laszlo.gombos 2011-03-15 14:48:51 -0700 Both in WebKit2/qt/MainQt.cpp and in WebKit2/WebProcess/qt/WebProcessMainQt.cpp QWEBKIT_EXPORT is defined to an empty string; so the WebProcessMainQt symbol does not get properly exported/imported. This is likely not only a problem on Symbian/RVCT but on Windows/MSVC as well. 367968 1 85861 laszlo.gombos 2011-03-15 15:00:17 -0700 Created attachment 85861 fix to land for cq+ Fix looks good to me, r+. 368007 2 85861 commit-queue 2011-03-15 15:55:24 -0700 Comment on attachment 85861 fix to land for cq+ Clearing flags on attachment: 85861 Committed r81186: <http://trac.webkit.org/changeset/81186> 368008 3 commit-queue 2011-03-15 15:55:29 -0700 All reviewed patches have been landed. Closing bug. 368224 4 webkit.review.bot 2011-03-15 23:56:44 -0700 http://trac.webkit.org/changeset/81186 might have broken WinCE Release (Build) 85861 2011-03-15 15:00:17 -0700 2011-03-15 15:55:24 -0700 fix to land for cq+ 56417.patch text/plain 2162 laszlo.gombos SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxMTc5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDMtMTUgIFNpZGRoYXJ0 aCBNYXRodXIgIDxzaWRkaGFydGgubWF0aHVyQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBMYXN6bG8gR29tYm9zLgorCisgICAgICAgIFtRdF1bU3ltYmlhbl1bV0syXSBGaXggZXhw b3J0aW5nIGFuZCBpbXBvcnRpbmcgdGhlIFdlYlByb2Nlc3NNYWluUXQgc3ltYm9sCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjQxNworCisgICAgICAg IFVzZSB0aGUgUV9ERUNMX0VYUE9SVCBhbmQgUV9ERUNMX0lNUE9SVCBtYWNyb3MgZGlyZWN0bHkg dG8gbWFrZSBzdXJlCisgICAgICAgIHRoZSBzeW1ib2wgaXMgYWx3YXlzIGV4cG9ydGVkL2ltcG9y dGVkLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzTWFpblF0LmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc01haW5RdCk6CisgICAgICAgICogcXQvTWFpblF0LmNw cDoKKwogMjAxMS0wMy0xNSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvcXQvV2ViUHJvY2Vzc01haW5RdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzTWFpblF0LmNwcAkocmV2aXNpb24gODExNzQp CisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1dlYlByb2Nlc3NNYWluUXQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC00OCwxMyArNDgsNiBAQAogI2VuZGlmCiAjZW5kaWYKIAotI2lmICFk ZWZpbmVkKFFXRUJLSVRfRVhQT1JUKQotI2lmIGRlZmluZWQoUVRfU0hBUkVEKQotI2RlZmluZSBR V0VCS0lUX0VYUE9SVCBRX0RFQ0xfRVhQT1JUCi0jZWxzZQotI2RlZmluZSBRV0VCS0lUX0VYUE9S VAotI2VuZGlmCi0jZW5kaWYKICNpZm5kZWYgTkRFQlVHCiAjaW5jbHVkZSA8UURlYnVnPgogI2Vu ZGlmCkBAIC0xMzcsNyArMTMwLDcgQEAgc3RhdGljIHZvaWQgaW5pdGlhbGl6ZVByb3h5KCkKICAg ICBRTmV0d29ya1Byb3h5RmFjdG9yeTo6c2V0VXNlU3lzdGVtQ29uZmlndXJhdGlvbih0cnVlKTsK IH0KIAotUVdFQktJVF9FWFBPUlQgaW50IFdlYlByb2Nlc3NNYWluUXQoaW50IGFyZ2MsIGNoYXIq KiBhcmd2KQorUV9ERUNMX0VYUE9SVCBpbnQgV2ViUHJvY2Vzc01haW5RdChpbnQgYXJnYywgY2hh cioqIGFyZ3YpCiB7CiAgICAgUUFwcGxpY2F0aW9uOjpzZXRHcmFwaGljc1N5c3RlbSgicmFzdGVy Iik7CiAgICAgUUFwcGxpY2F0aW9uKiBhcHAgPSBuZXcgUUFwcGxpY2F0aW9uKGFyZ2MsIGFyZ3Yp OwpJbmRleDogU291cmNlL1dlYktpdDIvcXQvTWFpblF0LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9xdC9NYWluUXQuY3BwCShyZXZpc2lvbiA4MTE3NCkKKysrIFNvdXJjZS9XZWJL aXQyL3F0L01haW5RdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI2LDE2ICsyNiw4IEBACiAKICNp bmNsdWRlIDxRdEdsb2JhbD4KIAotI2lmICFkZWZpbmVkKFFXRUJLSVRfRVhQT1JUKQotI2lmIGRl ZmluZWQoUVRfU0hBUkVEKQotI2RlZmluZSBRV0VCS0lUX0VYUE9SVCBRX0RFQ0xfRVhQT1JUCi0j ZWxzZQotI2RlZmluZSBRV0VCS0lUX0VYUE9SVAotI2VuZGlmCi0jZW5kaWYKLQogbmFtZXNwYWNl IFdlYktpdCB7Ci1RV0VCS0lUX0VYUE9SVCBpbnQgV2ViUHJvY2Vzc01haW5RdChpbnQgYXJnYywg Y2hhcioqIGFyZ3YpOworUV9ERUNMX0lNUE9SVCBpbnQgV2ViUHJvY2Vzc01haW5RdChpbnQgYXJn YywgY2hhcioqIGFyZ3YpOwogfQogCiAvLyBUaGUgZnJhbWV3b3JrIGVudHJ5IHBvaW50Lgo=