56231 2011-03-11 15:50:34 -0800 Introduce project_dir variable and make paths a whole lot saner. Ok, a little bit saner. 2011-03-11 18:53:16 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 55018 1 dglazkov dglazkov abarth commit-queue oldest_to_newest 366388 0 dglazkov 2011-03-11 15:50:34 -0800 Introduce project_dir variable and make paths a whole lot saner. Ok, a little bit saner. 366389 1 85549 dglazkov 2011-03-11 15:51:45 -0800 Created attachment 85549 Patch 366413 2 85549 eric 2011-03-11 16:33:28 -0800 Comment on attachment 85549 Patch Nice. Feel free to CC me on any other gyp changes. 366434 3 85549 commit-queue 2011-03-11 17:06:00 -0800 Comment on attachment 85549 Patch Clearing flags on attachment: 85549 Committed r80906: <http://trac.webkit.org/changeset/80906> 366435 4 commit-queue 2011-03-11 17:06:05 -0800 All reviewed patches have been landed. Closing bug. 366476 5 85549 abarth 2011-03-11 18:53:16 -0800 Comment on attachment 85549 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85549&action=review > Source/JavaScriptCore/JavaScriptCore.gypi:3 > + 'project_dir': [ '<(DEPTH)/JavaScriptCore' ], You don't need to use DEPTH here. project_dir ends in _dir, which means it's treated as relative to the file its in. So... "." would have worked too. 85549 2011-03-11 15:51:45 -0800 2011-03-11 18:53:16 -0800 Patch bug-56231-20110311155144.patch text/plain 5960 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogODA4ODIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGJh ZWYzZTJlOGM3YWZjYzRhZTc0ZjNiNTg1ODdlOGY1M2M0NDkyZDEuLjlkMWQ3YTA3Y2RlNWQ3YjRk MDVmMWZmZDc2NTg3MTg2YzhiNGIzMTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSw1 ICsxLDE2IEBACiAyMDExLTAzLTExICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1 bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SW50cm9kdWNlIHByb2plY3RfZGlyIHZhcmlhYmxlIGFuZCBtYWtlIHBhdGhzIGEgd2hvbGUgbG90 IHNhbmVyLiBPaywgYSBsaXR0bGUgYml0IHNhbmVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTYyMzEKKworICAgICAgICAqIEphdmFTY3JpcHRDb3Jl Lmd5cGk6IEFkZGVkIHByb2plY3RfZGlyIHZhcmlhYmxlLgorICAgICAgICAqIGd5cC9KYXZhU2Ny aXB0Q29yZS5neXA6IENoYW5nZWQgdG8gdXNlIHByb2plY3RfZGlyLCByYXRoZXIgdGhhbiBERVBU SC9KYXZhU2NyaXB0Q29yZS4KKyAgICAgICAgKiBneXAvZ2VuZXJhdGUtZHRyYWNlLWhlYWRlci5z aDogQ2hhbmdlZCB0byB1c2UgcHJvamVjdF9kaXIuCisKKzIwMTEtMDMtMTEgIERpbWl0cmkgR2xh emtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBBZGFt IEJhcnRoLgogCiAgICAgICAgIFN0YXJ0IHVzaW5nIGRlcml2ZWQgc291cmNlcyBjb3JyZWN0bHkg YW5kIGxpbmsgbWluaWRvbSB3aXRoIEphdmFTY3JpcHRDb3JlIGd5cCBwcm9qZWN0LgpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmd5cGkgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZ3lwaQppbmRleCA0NDVjOTUxZTFmZjc4MTk5 ZWRkMmZjNDAwOTU0OWQwNzM4NjAzZTUzLi5hMWU5NGJlNzUyM2Y2ZWNlYjE2ZTYyYTIyYzQwNDMx NWIyYjZiZjA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENv cmUuZ3lwaQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZ3lwaQpA QCAtMSw1ICsxLDYgQEAKIHsKICAgICAndmFyaWFibGVzJzogeworICAgICAgICAncHJvamVjdF9k aXInOiBbICc8KERFUFRIKS9KYXZhU2NyaXB0Q29yZScgXSwKICAgICAgICAgIyBUaGVzZSBoZWFk ZXJzIGFyZSBwYXJ0IG9mIEphdmFTY3JpcHRDb3JlJ3MgcHVibGljIEFQSSBpbiB0aGUgQXBwbGUg TWFjIGJ1aWxkLgogICAgICAgICAnamF2YXNjcmlwdGNvcmVfcHVibGljaGVhZGVyX2ZpbGVzJzog WwogICAgICAgICAgICAgJ0FQSS9KU0Jhc2UuaCcsCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZ3lwL0phdmFTY3JpcHRDb3JlLmd5cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9n eXAvSmF2YVNjcmlwdENvcmUuZ3lwCmluZGV4IDJhMGY3NjEzZDFlZDczOGQ0NzliMTNjNjExOTlk MjdjMDNiZTg4ZWYuLjYwYWM1ZTgzMWI4Njk2ZjkyNDQ0ZjRlNTg0NmRjNGE4NGYxODE5MTAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9neXAvSmF2YVNjcmlwdENvcmUuZ3lwCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9neXAvSmF2YVNjcmlwdENvcmUuZ3lwCkBAIC0zLDI4 ICszLDI4IEBACiAgICAgJy4uLy4uL2d5cC9jb21tb24uZ3lwaScsCiAgICAgJy4uL0phdmFTY3Jp cHRDb3JlLmd5cGknLAogICBdLAotICAneGNvZGVfY29uZmlnX2ZpbGUnOiAnPChERVBUSCkvSmF2 YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvRGVidWdSZWxlYXNlLnhjY29uZmlnJywKKyAgJ3hj b2RlX2NvbmZpZ19maWxlJzogJzwocHJvamVjdF9kaXIpL0NvbmZpZ3VyYXRpb25zL0RlYnVnUmVs ZWFzZS54Y2NvbmZpZycsCiAgICd2YXJpYWJsZXMnOiB7CiAgICAgIyBGSVhNRTogV2Ugc2hvdWxk IHVzZSBhIGhlYWRlciBtYXAgaW5zdGVhZCBvZiBsaXN0aW5nIHRoZXNlIGV4cGxpY2l0bHkuCiAg ICAgJ2phdmFzY3JpcHRjb3JlX2luY2x1ZGVfZGlycyc6IFsKICAgICAgICc8KERFUFRIKScsICMg U29tZSBwYXRocyBpbiBBUEkgaW5jbHVkZSBKYXZhU2NyaXB0Q29yZS8KLSAgICAgICc8KERFUFRI KS9KYXZhU2NyaXB0Q29yZScsCi0gICAgICAnPChERVBUSCkvSmF2YVNjcmlwdENvcmUvRm9yd2Fy ZGluZ0hlYWRlcnMnLAotICAgICAgJzwoREVQVEgpL0phdmFTY3JpcHRDb3JlL0FQSScsCi0gICAg ICAnPChERVBUSCkvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyJywKLSAgICAgICc8KERFUFRIKS9K YXZhU2NyaXB0Q29yZS9jb2xsZWN0b3IvaGFuZGxlcycsCi0gICAgICAnPChERVBUSCkvSmF2YVNj cmlwdENvcmUvYnl0ZWNvZGUnLAotICAgICAgJzwoREVQVEgpL0phdmFTY3JpcHRDb3JlL2J5dGVj b21waWxlcicsCi0gICAgICAnPChERVBUSCkvSmF2YVNjcmlwdENvcmUvZGVidWdnZXInLAotICAg ICAgJzwoREVQVEgpL0phdmFTY3JpcHRDb3JlL2ljdScsCi0gICAgICAnPChERVBUSCkvSmF2YVNj cmlwdENvcmUvaW50ZXJwcmV0ZXInLAotICAgICAgJzwoREVQVEgpL0phdmFTY3JpcHRDb3JlL2pp dCcsCi0gICAgICAnPChERVBUSCkvSmF2YVNjcmlwdENvcmUvcGFyc2VyJywKLSAgICAgICc8KERF UFRIKS9KYXZhU2NyaXB0Q29yZS9wcm9maWxlcicsCi0gICAgICAnPChERVBUSCkvSmF2YVNjcmlw dENvcmUvcnVudGltZScsCi0gICAgICAnPChERVBUSCkvSmF2YVNjcmlwdENvcmUvd3RmJywKLSAg ICAgICc8KERFUFRIKS9KYXZhU2NyaXB0Q29yZS93dGYvdW5pY29kZScsCi0gICAgICAnPChQUk9E VUNUX0RJUikvRGVyaXZlZFNvdXJjZXMvSmF2YVNjcmlwdENvcmUnLAorICAgICAgJzwocHJvamVj dF9kaXIpJywKKyAgICAgICc8KHByb2plY3RfZGlyKS9Gb3J3YXJkaW5nSGVhZGVycycsCisgICAg ICAnPChwcm9qZWN0X2RpcikvQVBJJywKKyAgICAgICc8KHByb2plY3RfZGlyKS9hc3NlbWJsZXIn LAorICAgICAgJzwocHJvamVjdF9kaXIpL2NvbGxlY3Rvci9oYW5kbGVzJywKKyAgICAgICc8KHBy b2plY3RfZGlyKS9ieXRlY29kZScsCisgICAgICAnPChwcm9qZWN0X2RpcikvYnl0ZWNvbXBpbGVy JywKKyAgICAgICc8KHByb2plY3RfZGlyKS9kZWJ1Z2dlcicsCisgICAgICAnPChwcm9qZWN0X2Rp cikvaWN1JywKKyAgICAgICc8KHByb2plY3RfZGlyKS9pbnRlcnByZXRlcicsCisgICAgICAnPChw cm9qZWN0X2Rpcikvaml0JywKKyAgICAgICc8KHByb2plY3RfZGlyKS9wYXJzZXInLAorICAgICAg JzwocHJvamVjdF9kaXIpL3Byb2ZpbGVyJywKKyAgICAgICc8KHByb2plY3RfZGlyKS9ydW50aW1l JywKKyAgICAgICc8KHByb2plY3RfZGlyKS93dGYnLAorICAgICAgJzwocHJvamVjdF9kaXIpL3d0 Zi91bmljb2RlJywKKyAgICAgICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKScsCiAgICAgXSwK ICAgICAnZGVyaXZlZF9zb3VyY2VfZmlsZXMnOiBbCiAgICAgICAnPChTSEFSRURfSU5URVJNRURJ QVRFX0RJUikvQXJyYXlQcm90b3R5cGUubHV0LmgnLApAQCAtNjksNyArNjksNyBAQAogICAgICAg J21hY19mcmFtZXdvcmtfcHJpdmF0ZV9oZWFkZXJzJzogWwogICAgICAgICAnPEAoamF2YXNjcmlw dGNvcmVfcHJpdmF0ZWhlYWRlcl9maWxlcyknLAogICAgICAgXSwKLSAgICAgICd4Y29kZV9jb25m aWdfZmlsZSc6ICc8KERFUFRIKS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0aW9ucy9KYXZhU2Ny aXB0Q29yZS54Y2NvbmZpZycsCisgICAgICAneGNvZGVfY29uZmlnX2ZpbGUnOiAnPChwcm9qZWN0 X2RpcikvQ29uZmlndXJhdGlvbnMvSmF2YVNjcmlwdENvcmUueGNjb25maWcnLAogICAgICAgJ3Nv dXJjZXMvJzogWwogICAgICAgICBbJ2V4Y2x1ZGUnLCAncXQnXSwKICAgICAgICAgWydleGNsdWRl JywgJ29zLXdpbjMyJ10sCkBAIC0xMTksOCArMTE5LDggQEAKICAgICAgICAgICAneGNvZGVfc2V0 dGluZ3MnOiB7CiAgICAgICAgICAgICAjIEZJWE1FOiBSZW1vdmUgdGhlc2Ugb3ZlcnJpZGVzIG9u Y2UgSmF2YVNjcmlwdENvcmUueGNjb25maWcgaXMKICAgICAgICAgICAgICMgdXNlZCBvbmx5IGJ5 IHRoaXMgcHJvamVjdC4KLSAgICAgICAgICAgICdHQ0NfUFJFRklYX0hFQURFUic6ICc8KERFUFRI KS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZVByZWZpeC5oJywKLSAgICAgICAgICAgICdJ TkZPUExJU1RfRklMRSc6ICc8KERFUFRIKS9KYXZhU2NyaXB0Q29yZS9JbmZvLnBsaXN0JywKKyAg ICAgICAgICAgICdHQ0NfUFJFRklYX0hFQURFUic6ICc8KHByb2plY3RfZGlyKS9KYXZhU2NyaXB0 Q29yZVByZWZpeC5oJywKKyAgICAgICAgICAgICdJTkZPUExJU1RfRklMRSc6ICc8KHByb2plY3Rf ZGlyKS9JbmZvLnBsaXN0JywKICAgICAgICAgICAgICMgVGhpcyBzZXR0aW5nIG1pcnJvcnMgdGhl IHNldHRpbmcgaW4gQmFzZS54Y2NvbmZpZywgd2l0aAogICAgICAgICAgICAgIyBvbmUgZGlmZmVy ZW5jZSBub3RlZCBiZWxvdy4KICAgICAgICAgICAgICdXQVJOSU5HX0NGTEFHU19CQVNFJzogWwpA QCAtMTY1LDcgKzE2NSw3IEBACiAgICAgICAgICAgJ2lucHV0cyc6IFtdLAogICAgICAgICAgICAn b3V0cHV0cyc6IFtdLAogICAgICAgICAgICAnYWN0aW9uJzogWwotICAgICAgICAgICAgICdzaCcs ICc8KERFUFRIKS9KYXZhU2NyaXB0Q29yZS9neXAvZ2VuZXJhdGUtZHRyYWNlLWhlYWRlci5zaCcs ICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKScKKyAgICAgICAgICAgICAnc2gnLCAnPChwcm9q ZWN0X2RpcikvZ3lwL2dlbmVyYXRlLWR0cmFjZS1oZWFkZXIuc2gnLCAnPChwcm9qZWN0X2Rpcikn LCAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUiknCiAgICAgICAgICAgICBdCiAgICAgICAgIH0K ICAgICAgIF0sCkBAIC0xNzgsNyArMTc4LDcgQEAKICAgICAgICAgJ2lucHV0cyc6IFtdLAogICAg ICAgICAgJ291dHB1dHMnOiBbXSwKICAgICAgICAgICdhY3Rpb24nOiBbCi0gICAgICAgICAgICdz aCcsICc8KERFUFRIKS9neXAvdXBkYXRlLWluZm8tcGxpc3Quc2gnLCAnPChERVBUSCkvSmF2YVNj cmlwdENvcmUvSW5mby5wbGlzdCcKKyAgICAgICAgICAgJ3NoJywgJzwoREVQVEgpL2d5cC91cGRh dGUtaW5mby1wbGlzdC5zaCcsICc8KHByb2plY3RfZGlyKS9JbmZvLnBsaXN0JwogICAgICAgICAg IF0KICAgICAgIH1dLAogICAgIH0sCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv Z3lwL2dlbmVyYXRlLWR0cmFjZS1oZWFkZXIuc2ggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZ3lw L2dlbmVyYXRlLWR0cmFjZS1oZWFkZXIuc2gKaW5kZXggYzVhNjc4ZjdlYTllNTIxMDBjOTRhNTky MDNjODdhNzBlNWEwMjIxOS4uMDBjMWI0MTk5YWE4MjA1MjVjY2JmM2Y2NWFlZWRhZmUzYWMyZTA0 NCAxMDA3NTUKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2d5cC9nZW5lcmF0ZS1kdHJhY2Ut aGVhZGVyLnNoCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9neXAvZ2VuZXJhdGUtZHRyYWNl LWhlYWRlci5zaApAQCAtMSw3ICsxLDcgQEAKICMhL2Jpbi9zaAogCi1UUkFDSU5HX0Q9IiR7U1JD Uk9PVH0vLi4vcnVudGltZS9UcmFjaW5nLmQiOwotVFJBQ0lOR19IPSIkMS9UcmFjaW5nRHRyYWNl LmgiOworVFJBQ0lOR19EPSIkMS9ydW50aW1lL1RyYWNpbmcuZCI7CitUUkFDSU5HX0g9IiQyL1Ry YWNpbmdEdHJhY2UuaCI7CiAKIGlmIFtbICIke0hBVkVfRFRSQUNFfSIgPSAiMSIgJiYgIiR7VFJB Q0lOR19EfSIgLW50ICIke1RSQUNJTkdfSH0iIF1dOyB0aGVuCiAgICAgZHRyYWNlIC1oIC1vICIk e1RSQUNJTkdfSH0iIC1zICIke1RSQUNJTkdfRH0iOwo=