<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>56217</bug_id>
          
          <creation_ts>2011-03-11 13:08:51 -0800</creation_ts>
          <short_desc>Start using derived sources correctly and link minidom with JavaScriptCore gyp project.</short_desc>
          <delta_ts>2011-03-11 13:59:54 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>55018</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Dimitri Glazkov (Google)">dglazkov</reporter>
          <assigned_to name="Dimitri Glazkov (Google)">dglazkov</assigned_to>
          <cc>abarth</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>366262</commentid>
    <comment_count>0</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2011-03-11 13:08:51 -0800</bug_when>
    <thetext>Start using derived sources correctly and link minidom with JavaScriptCore gyp project.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>366265</commentid>
    <comment_count>1</comment_count>
      <attachid>85517</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2011-03-11 13:10:22 -0800</bug_when>
    <thetext>Created attachment 85517
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>366274</commentid>
    <comment_count>2</comment_count>
      <attachid>85517</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-11 13:28:05 -0800</bug_when>
    <thetext>Comment on attachment 85517
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85517&amp;action=review

This restructures how the build works a bit, but probably in a good direction.

&gt; Source/JavaScriptCore/gyp/generate-dtrace-header.sh:3
&gt; +TRACING_D=&quot;${SRCROOT}/../runtime/Tracing.d&quot;;

The ... here makes me a bit sad, but it&apos;s probably ok.  Having these paths based on DEPTH is better.  Maybe we should pass the directory in like we&apos;re doing for the intermediate dir.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>366303</commentid>
    <comment_count>3</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2011-03-11 13:59:54 -0800</bug_when>
    <thetext>Committed r80882: &lt;http://trac.webkit.org/changeset/80882&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>85517</attachid>
            <date>2011-03-11 13:10:22 -0800</date>
            <delta_ts>2011-03-11 13:28:05 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-56217-20110311131021.patch</filename>
            <type>text/plain</type>
            <size>4615</size>
            <attacher name="Dimitri Glazkov (Google)">dglazkov</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODA4NzIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGE0
YTBhNmQ3ZTY1OWI2ZTg5YzZhYTZjOTVlNmQ2OTg3ZGYyNTJmMzcuLmIxMTk2YTM5MDg0NjM5YzRl
NjEwMmJiNThjMDhhZDAyMWE3NTE4NGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSw1
ICsxLDE3IEBACiAyMDExLTAzLTExICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1
bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
U3RhcnQgdXNpbmcgZGVyaXZlZCBzb3VyY2VzIGNvcnJlY3RseSBhbmQgbGluayBtaW5pZG9tIHdp
dGggSmF2YVNjcmlwdENvcmUgZ3lwIHByb2plY3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjIxNworCisgICAgICAgICogZ3lwL0phdmFTY3JpcHRD
b3JlLmd5cDogQWRkZWQgZGVyaXZlZCBzb3VyY2UgZmlsZXMgYW5kIHBhc3Npbmcgb2Ygc2hhcmVk
IGRpcmVjdG9yeQorICAgICAgICAgICAgdG8gdGhlIHNjcmlwdHMuCisgICAgICAgICogZ3lwL2dl
bmVyYXRlLWRlcml2ZWQtc291cmNlcy5zaDogQ2hhbmdlZCB0byB1c2UgcGFzc2VkIGRpcmVjdG9y
eS4KKyAgICAgICAgKiBneXAvZ2VuZXJhdGUtZHRyYWNlLWhlYWRlci5zaDogRGl0dG8uCisKKzIw
MTEtMDMtMTEgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KKwogICAg
ICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgogCiAgICAgICAgIFR3ZWFrIGR5bGliIHBhdGhz
IGFuZCBhZGQgZHRyYWNlIGhlYWRlciBnZW5lcmF0aW9uIGFjdGlvbiB0byBKYXZhU2NyaXB0Q29y
ZSBneXAgcHJvamVjdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9neXAvSmF2
YVNjcmlwdENvcmUuZ3lwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2d5cC9KYXZhU2NyaXB0Q29y
ZS5neXAKaW5kZXggY2NhMDk4NjNhMWRlYTliOTMzMGYxMGFjZmRmNWVmMGFmYTFhZmE1NC4uMmEw
Zjc2MTNkMWVkNzM4ZDQ3OWIxM2M2MTE5OWQyN2MwM2JlODhlZiAxMDA2NDQKLS0tIGEvU291cmNl
L0phdmFTY3JpcHRDb3JlL2d5cC9KYXZhU2NyaXB0Q29yZS5neXAKKysrIGIvU291cmNlL0phdmFT
Y3JpcHRDb3JlL2d5cC9KYXZhU2NyaXB0Q29yZS5neXAKQEAgLTI2LDYgKzI2LDIxIEBACiAgICAg
ICAnPChERVBUSCkvSmF2YVNjcmlwdENvcmUvd3RmL3VuaWNvZGUnLAogICAgICAgJzwoUFJPRFVD
VF9ESVIpL0Rlcml2ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlJywKICAgICBdLAorICAgICdkZXJp
dmVkX3NvdXJjZV9maWxlcyc6IFsKKyAgICAgICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS9B
cnJheVByb3RvdHlwZS5sdXQuaCcsCisgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikv
RGF0ZVByb3RvdHlwZS5sdXQuaCcsCisgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikv
SGVhZGVyRGV0ZWN0aW9uLmgnLAorICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIpL0pT
T05PYmplY3QubHV0LmgnLAorICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIpL0xleGVy
Lmx1dC5oJywKKyAgICAgICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS9NYXRoT2JqZWN0Lmx1
dC5oJywKKyAgICAgICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS9OdW1iZXJDb25zdHJ1Y3Rv
ci5sdXQuaCcsCisgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikvUmVnRXhwQ29uc3Ry
dWN0b3IubHV0LmgnLAorICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIpL1JlZ0V4cEpp
dFRhYmxlcy5oJywKKyAgICAgICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS9SZWdFeHBPYmpl
Y3QubHV0LmgnLAorICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIpL1N0cmluZ1Byb3Rv
dHlwZS5sdXQuaCcsCisgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikvVHJhY2luZ0R0
cmFjZS5oJywKKyAgICAgICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS9PYmplY3RDb25zdHJ1
Y3Rvci5sdXQuaCcsCisgICAgXSwKICAgfSwKICAgJ3RhcmdldHMnOiBbCiAgICAgewpAQCAtNDIs
NiArNTcsNyBAQAogICAgICAgICAnPEAoamF2YXNjcmlwdGNvcmVfZmlsZXMpJywKICAgICAgICAg
JzxAKGphdmFzY3JpcHRjb3JlX3B1YmxpY2hlYWRlcl9maWxlcyknLAogICAgICAgICAnPEAoamF2
YXNjcmlwdGNvcmVfcHJpdmF0ZWhlYWRlcl9maWxlcyknLAorICAgICAgICAnPEAoZGVyaXZlZF9z
b3VyY2VfZmlsZXMpJywKICAgICAgICAgJyQoU0RLUk9PVCkvU3lzdGVtL0xpYnJhcnkvRnJhbWV3
b3Jrcy9Db3JlRm91bmRhdGlvbi5mcmFtZXdvcmsnLAogICAgICAgICAnJChTREtST09UKS9TeXN0
ZW0vTGlicmFyeS9GcmFtZXdvcmtzL0ZvdW5kYXRpb24uZnJhbWV3b3JrJywKICAgICAgICAgJy91
c3IvbGliL2xpYmljdWNvcmUuZHlsaWInLApAQCAtMTM3LDkgKzE1MywxMSBAQAogICAgICAgICB7
CiAgICAgICAgICAgJ2FjdGlvbl9uYW1lJzogJ0dlbmVyYXRlIERlcml2ZWQgU291cmNlcycsCiAg
ICAgICAgICAgJ2lucHV0cyc6IFtdLAotICAgICAgICAgICdvdXRwdXRzJzogW10sCisgICAgICAg
ICAgJ291dHB1dHMnOiBbCisgICAgICAgICAgICAnPEAoZGVyaXZlZF9zb3VyY2VfZmlsZXMpJywK
KyAgICAgICAgICBdLAogICAgICAgICAgICdhY3Rpb24nOiBbCi0gICAgICAgICAgICAnc2gnLCAn
Z2VuZXJhdGUtZGVyaXZlZC1zb3VyY2VzLnNoJywKKyAgICAgICAgICAgICdzaCcsICdnZW5lcmF0
ZS1kZXJpdmVkLXNvdXJjZXMuc2gnLCAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUiknCiAgICAg
ICAgICAgXSwKICAgICAgICAgfSwKICAgICAgICAgewpAQCAtMTQ3LDcgKzE2NSw3IEBACiAgICAg
ICAgICAgJ2lucHV0cyc6IFtdLAogICAgICAgICAgICAnb3V0cHV0cyc6IFtdLAogICAgICAgICAg
ICAnYWN0aW9uJzogWwotICAgICAgICAgICAgICdzaCcsICc8KERFUFRIKS9KYXZhU2NyaXB0Q29y
ZS9neXAvZ2VuZXJhdGUtZHRyYWNlLWhlYWRlci5zaCcKKyAgICAgICAgICAgICAnc2gnLCAnPChE
RVBUSCkvSmF2YVNjcmlwdENvcmUvZ3lwL2dlbmVyYXRlLWR0cmFjZS1oZWFkZXIuc2gnLCAnPChT
SEFSRURfSU5URVJNRURJQVRFX0RJUiknCiAgICAgICAgICAgICBdCiAgICAgICAgIH0KICAgICAg
IF0sCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZ3lwL2dlbmVyYXRlLWRlcml2
ZWQtc291cmNlcy5zaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9neXAvZ2VuZXJhdGUtZGVyaXZl
ZC1zb3VyY2VzLnNoCmluZGV4IGZjZDMwNTZlODQwNDIzN2ZhYTY2ZTc4YzhmNzUwYmExMGVkYTA5
MjQuLjJmMjA1NWJjYjJkMGMwZmQ5NmFhMzgzYjMwZGM1ZGQ3MGI1YmY0MmQgMTAwNzU1Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9neXAvZ2VuZXJhdGUtZGVyaXZlZC1zb3VyY2VzLnNoCisr
KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9neXAvZ2VuZXJhdGUtZGVyaXZlZC1zb3VyY2VzLnNo
CkBAIC0xLDcgKzEsNyBAQAogIyEvYmluL3NoCiAKLW1rZGlyIC1wICIke0JVSUxUX1BST0RVQ1RT
X0RJUn0vRGVyaXZlZFNvdXJjZXMvSmF2YVNjcmlwdENvcmUvZG9jcyIKLWNkICIke0JVSUxUX1BS
T0RVQ1RTX0RJUn0vRGVyaXZlZFNvdXJjZXMvSmF2YVNjcmlwdENvcmUiCitta2RpciAtcCAiJDEv
ZG9jcyIKK2NkICIkMSIKIAogL2Jpbi9sbiAtc2ZoICIke1NSQ1JPT1R9Ly4uIiBKYXZhU2NyaXB0
Q29yZQogZXhwb3J0IEphdmFTY3JpcHRDb3JlPSJKYXZhU2NyaXB0Q29yZSIKZGlmZiAtLWdpdCBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9neXAvZ2VuZXJhdGUtZHRyYWNlLWhlYWRlci5zaCBiL1Nv
dXJjZS9KYXZhU2NyaXB0Q29yZS9neXAvZ2VuZXJhdGUtZHRyYWNlLWhlYWRlci5zaAppbmRleCA5
NmQ5NWNhNTAyMzY3NDNhMzk5YmFmYWJjYjEzZGQzNzVhMGRjNjVhLi5jNWE2NzhmN2VhOWU1MjEw
MGM5NGE1OTIwM2M4N2E3MGU1YTAyMjE5IDEwMDc1NQotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvZ3lwL2dlbmVyYXRlLWR0cmFjZS1oZWFkZXIuc2gKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL2d5cC9nZW5lcmF0ZS1kdHJhY2UtaGVhZGVyLnNoCkBAIC0xLDcgKzEsNyBAQAogIyEvYmlu
L3NoCiAKLVRSQUNJTkdfRD0iJHtTUkNST09UfS9ydW50aW1lL1RyYWNpbmcuZCI7Ci1UUkFDSU5H
X0g9IiR7QlVJTFRfUFJPRFVDVFNfRElSfS9EZXJpdmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZS9U
cmFjaW5nRHRyYWNlLmgiOworVFJBQ0lOR19EPSIke1NSQ1JPT1R9Ly4uL3J1bnRpbWUvVHJhY2lu
Zy5kIjsKK1RSQUNJTkdfSD0iJDEvVHJhY2luZ0R0cmFjZS5oIjsKIAogaWYgW1sgIiR7SEFWRV9E
VFJBQ0V9IiA9ICIxIiAmJiAiJHtUUkFDSU5HX0R9IiAtbnQgIiR7VFJBQ0lOR19IfSIgXV07IHRo
ZW4KICAgICBkdHJhY2UgLWggLW8gIiR7VFJBQ0lOR19IfSIgLXMgIiR7VFJBQ0lOR19EfSI7Cg==
</data>
<flag name="review"
          id="77653"
          type_id="1"
          status="+"
          setter="abarth"
    />
          </attachment>
      

    </bug>

</bugzilla>