<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>56207</bug_id>
          
          <creation_ts>2011-03-11 11:05:54 -0800</creation_ts>
          <short_desc>Tweak dylib paths and add dtrace header generation action to JavaScriptCore gyp project.</short_desc>
          <delta_ts>2011-03-11 11:13:41 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>55018</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Dimitri Glazkov (Google)">dglazkov</reporter>
          <assigned_to name="Dimitri Glazkov (Google)">dglazkov</assigned_to>
          <cc>abarth</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>366125</commentid>
    <comment_count>0</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2011-03-11 11:05:54 -0800</bug_when>
    <thetext>Tweak dylib paths and add dtrace header generation action to JavaScriptCore gyp project.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>366128</commentid>
    <comment_count>1</comment_count>
      <attachid>85497</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2011-03-11 11:08:18 -0800</bug_when>
    <thetext>Created attachment 85497
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>366132</commentid>
    <comment_count>2</comment_count>
      <attachid>85497</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-11 11:09:33 -0800</bug_when>
    <thetext>Comment on attachment 85497
Patch

Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>366134</commentid>
    <comment_count>3</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2011-03-11 11:11:52 -0800</bug_when>
    <thetext>Committed r80865: &lt;http://trac.webkit.org/changeset/80865&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>366135</commentid>
    <comment_count>4</comment_count>
      <attachid>85497</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-03-11 11:13:16 -0800</bug_when>
    <thetext>Comment on attachment 85497
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85497&amp;action=review

&gt; Source/JavaScriptCore/gyp/JavaScriptCore.gyp:149
&gt; +          &apos;action_name&apos;: &apos;Generate DTrace Header&apos;,
&gt; +          &apos;inputs&apos;: [],
&gt; +           &apos;outputs&apos;: [],
&gt; +           &apos;action&apos;: [

funny indent.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>366137</commentid>
    <comment_count>5</comment_count>
      <attachid>85497</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-03-11 11:13:41 -0800</bug_when>
    <thetext>Comment on attachment 85497
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85497&amp;action=review

&gt; Source/JavaScriptCore/gyp/generate-dtrace-header.sh:4
&gt; +TRACING_D=&quot;${SRCROOT}/runtime/Tracing.d&quot;;
&gt; +TRACING_H=&quot;${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/TracingDtrace.h&quot;;

the ; are not needed.

&gt; Source/JavaScriptCore/gyp/generate-dtrace-header.sh:8
&gt; +fi;

I don&apos;t think the ; i sneeded.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>85497</attachid>
            <date>2011-03-11 11:08:18 -0800</date>
            <delta_ts>2011-03-11 11:13:41 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-56207-20110311110817.patch</filename>
            <type>text/plain</type>
            <size>3880</size>
            <attacher name="Dimitri Glazkov (Google)">dglazkov</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODA4NTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDQ5
YTRlMWUxZTZmMGJmMDYyYzIzMjUxYzhmZDY3N2Y4ZmJiOGY4NTQuLjExMzZkMjBlNTg4YzJiYjNh
NTJmZTQ5NWEzMGU3MTJlMWQ5OWJiYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDE1IEBACisyMDExLTAzLTExICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1
bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
VHdlYWsgZHlsaWIgcGF0aHMgYW5kIGFkZCBkdHJhY2UgaGVhZGVyIGdlbmVyYXRpb24gYWN0aW9u
IHRvIEphdmFTY3JpcHRDb3JlIGd5cCBwcm9qZWN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTYyMDcKKworICAgICAgICAqIEphdmFTY3JpcHRDb3Jl
Lmd5cGk6IEFkZGVkIFRyYWNpbmcuZCB0byB0aGUgc291cmNlcy4KKyAgICAgICAgKiBneXAvZ2Vu
ZXJhdGUtZHRyYWNlLWhlYWRlci5zaDogQWRkZWQuCisgICAgICAgICogZ3lwL0phdmFTY3JpcHRD
b3JlLmd5cDogVXBkYXRlZCBkeWxpYiBwYXRocyAobm93IHRoZSBwcm9qZWN0IGNhbiBzZWUgdGhl
bSksCisgICAgICAgICAgICBhbmQgYWRkZWQgRFRyYWNlIGhlYWRlciBnZW5lcmF0aW5nIHN0ZXAu
CisKIDIwMTEtMDMtMTAgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAg
ICBSZXZpZXdlZCBieSBHYXZpbiBCYXJyYWNsb3VnaC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh
U2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5neXBpIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0ph
dmFTY3JpcHRDb3JlLmd5cGkKaW5kZXggMjkyNDczY2MwYjYwZDFlOTUyZjI4NTkyYWZlODMxZTcx
MTJkYWE2OS4uNDQ1Yzk1MWUxZmY3ODE5OWVkZDJmYzQwMDk1NDlkMDczODYwM2U1MyAxMDA2NDQK
LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmd5cGkKKysrIGIvU291
cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmd5cGkKQEAgLTUzOSw2ICs1MzksNyBA
QAogICAgICAgICAgICAgJ3J1bnRpbWUvU3RydWN0dXJlQ2hhaW4uY3BwJywKICAgICAgICAgICAg
ICdydW50aW1lL1RpbWVvdXRDaGVja2VyLmNwcCcsCiAgICAgICAgICAgICAncnVudGltZS9UcmFj
aW5nLmgnLAorICAgICAgICAgICAgJ3J1bnRpbWUvVHJhY2luZy5kJywKICAgICAgICAgICAgICdy
dW50aW1lL1VTdHJpbmcuY3BwJywKICAgICAgICAgICAgICdydW50aW1lL1VTdHJpbmdDb25jYXRl
bmF0ZS5oJywKICAgICAgICAgICAgICd3dGYvQXNzZXJ0aW9ucy5jcHAnLApkaWZmIC0tZ2l0IGEv
U291cmNlL0phdmFTY3JpcHRDb3JlL2d5cC9KYXZhU2NyaXB0Q29yZS5neXAgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvZ3lwL0phdmFTY3JpcHRDb3JlLmd5cAppbmRleCAxZTQ2MDk0ODJiMGY0OTdi
ZDQ0MTNmMWU2MDBlNjViYjg3N2ZjMWFiLi5jY2EwOTg2M2ExZGVhOWI5MzMwZjEwYWNmZGY1ZWYw
YWZhMWFmYTU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZ3lwL0phdmFTY3Jp
cHRDb3JlLmd5cAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZ3lwL0phdmFTY3JpcHRDb3Jl
Lmd5cApAQCAtNDQsOCArNDQsOCBAQAogICAgICAgICAnPEAoamF2YXNjcmlwdGNvcmVfcHJpdmF0
ZWhlYWRlcl9maWxlcyknLAogICAgICAgICAnJChTREtST09UKS9TeXN0ZW0vTGlicmFyeS9GcmFt
ZXdvcmtzL0NvcmVGb3VuZGF0aW9uLmZyYW1ld29yaycsCiAgICAgICAgICckKFNES1JPT1QpL1N5
c3RlbS9MaWJyYXJ5L0ZyYW1ld29ya3MvRm91bmRhdGlvbi5mcmFtZXdvcmsnLAotICAgICAgICAn
bGliaWN1Y29yZS5keWxpYicsCi0gICAgICAgICdsaWJvYmpjLmR5bGliJywKKyAgICAgICAgJy91
c3IvbGliL2xpYmljdWNvcmUuZHlsaWInLAorICAgICAgICAnL3Vzci9saWIvbGlib2JqYy5keWxp
YicsCiAgICAgICBdLAogICAgICAgJ21hY19mcmFtZXdvcmtfaGVhZGVycyc6IFsKICAgICAgICAg
JzxAKGphdmFzY3JpcHRjb3JlX3B1YmxpY2hlYWRlcl9maWxlcyknLApAQCAtMTMzLDE0ICsxMzMs
MjQgQEAKICAgICB7CiAgICAgICAndGFyZ2V0X25hbWUnOiAnRGVyaXZlZCBTb3VyY2VzJywKICAg
ICAgICd0eXBlJzogJ25vbmUnLAotICAgICAgJ2FjdGlvbnMnOiBbewotICAgICAgICAnYWN0aW9u
X25hbWUnOiAnR2VuZXJhdGUgRGVyaXZlZCBTb3VyY2VzJywKLSAgICAgICAgJ2lucHV0cyc6IFtd
LAotICAgICAgICAnb3V0cHV0cyc6IFtdLAotICAgICAgICAnYWN0aW9uJzogWwotICAgICAgICAg
ICdzaCcsICdnZW5lcmF0ZS1kZXJpdmVkLXNvdXJjZXMuc2gnLAotICAgICAgICBdLAotICAgICAg
fV0sCisgICAgICAnYWN0aW9ucyc6IFsKKyAgICAgICAgeworICAgICAgICAgICdhY3Rpb25fbmFt
ZSc6ICdHZW5lcmF0ZSBEZXJpdmVkIFNvdXJjZXMnLAorICAgICAgICAgICdpbnB1dHMnOiBbXSwK
KyAgICAgICAgICAnb3V0cHV0cyc6IFtdLAorICAgICAgICAgICdhY3Rpb24nOiBbCisgICAgICAg
ICAgICAnc2gnLCAnZ2VuZXJhdGUtZGVyaXZlZC1zb3VyY2VzLnNoJywKKyAgICAgICAgICBdLAor
ICAgICAgICB9LAorICAgICAgICB7CisgICAgICAgICAgJ2FjdGlvbl9uYW1lJzogJ0dlbmVyYXRl
IERUcmFjZSBIZWFkZXInLAorICAgICAgICAgICdpbnB1dHMnOiBbXSwKKyAgICAgICAgICAgJ291
dHB1dHMnOiBbXSwKKyAgICAgICAgICAgJ2FjdGlvbic6IFsKKyAgICAgICAgICAgICAnc2gnLCAn
PChERVBUSCkvSmF2YVNjcmlwdENvcmUvZ3lwL2dlbmVyYXRlLWR0cmFjZS1oZWFkZXIuc2gnCisg
ICAgICAgICAgICBdCisgICAgICAgIH0KKyAgICAgIF0sCiAgICAgfSwKICAgICB7CiAgICAgICAn
dGFyZ2V0X25hbWUnOiAnVXBkYXRlIFZlcnNpb24nLApAQCAtMjA5LDcgKzIxOSw3IEBACiAgICAg
ICAnc291cmNlcyc6IFsKICAgICAgICAgJzxAKGpzY19maWxlcyknLAogICAgICAgICAnJChTREtS
T09UKS9TeXN0ZW0vTGlicmFyeS9GcmFtZXdvcmtzL0NvcmVGb3VuZGF0aW9uLmZyYW1ld29yaycs
Ci0gICAgICAgICdsaWJlZGl0LmR5bGliJywKKyAgICAgICAgJy91c3IvbGliL2xpYmVkaXQuZHls
aWInLAogICAgICAgXSwKICAgICB9LAogICBdLCAjIHRhcmdldHMKZGlmZiAtLWdpdCBhL1NvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9neXAvZ2VuZXJhdGUtZHRyYWNlLWhlYWRlci5zaCBiL1NvdXJjZS9K
YXZhU2NyaXB0Q29yZS9neXAvZ2VuZXJhdGUtZHRyYWNlLWhlYWRlci5zaApuZXcgZmlsZSBtb2Rl
IDEwMDc1NQppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45
NmQ5NWNhNTAyMzY3NDNhMzk5YmFmYWJjYjEzZGQzNzVhMGRjNjVhCi0tLSAvZGV2L251bGwKKysr
IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2d5cC9nZW5lcmF0ZS1kdHJhY2UtaGVhZGVyLnNoCkBA
IC0wLDAgKzEsOSBAQAorIyEvYmluL3NoCisKK1RSQUNJTkdfRD0iJHtTUkNST09UfS9ydW50aW1l
L1RyYWNpbmcuZCI7CitUUkFDSU5HX0g9IiR7QlVJTFRfUFJPRFVDVFNfRElSfS9EZXJpdmVkU291
cmNlcy9KYXZhU2NyaXB0Q29yZS9UcmFjaW5nRHRyYWNlLmgiOworCitpZiBbWyAiJHtIQVZFX0RU
UkFDRX0iID0gIjEiICYmICIke1RSQUNJTkdfRH0iIC1udCAiJHtUUkFDSU5HX0h9IiBdXTsgdGhl
bgorICAgIGR0cmFjZSAtaCAtbyAiJHtUUkFDSU5HX0h9IiAtcyAiJHtUUkFDSU5HX0R9IjsKK2Zp
OworCg==
</data>
<flag name="review"
          id="77631"
          type_id="1"
          status="+"
          setter="abarth"
    />
          </attachment>
      

    </bug>

</bugzilla>