56171 2011-03-10 21:31:57 -0800 Fix textarea maxlength bug that return key is not considered. 2011-03-12 00:50:36 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED DUPLICATE 54443 P2 Normal --- 0 honten webkit-unassigned ap oldest_to_newest 365812 0 honten 2011-03-10 21:31:57 -0800 Fix textarea maxlength bug that return key is not considered. 366196 1 ap 2011-03-11 12:00:00 -0800 *** This bug has been marked as a duplicate of bug 54443 *** 366530 2 85574 honten 2011-03-11 23:38:16 -0800 Created attachment 85574 Patch 366531 3 honten 2011-03-11 23:39:27 -0800 Could you review? 366532 4 85574 ap 2011-03-11 23:52:00 -0800 Comment on attachment 85574 Patch It should be possible to make an automated test for this. Manual tests are nearly useless. Please attach patches to bug 54443, not here. 366533 5 honten 2011-03-12 00:03:47 -0800 I try to make automate test. But I'm not sure I can simulate key pressing in layout test. 366540 6 ap 2011-03-12 00:50:36 -0800 You can look what existing tests for maxlength do for an example. See e.g. fast/forms/script-tests/textarea-maxlength.js, or other tests with "maxlength" in file name. 85574 2011-03-11 23:38:16 -0800 2011-03-11 23:51:59 -0800 Patch bug-56171-20110311233815.patch text/plain 3071 honten U3VidmVyc2lvbiBSZXZpc2lvbjogODA0MzMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkMjM0OGZhNWYxZjAwZjM4 ZTVkYTE4M2NhNDViYjdlMWEyYTZmMzk4Li45MzQ3ODYzMGM4NWVhZTQ4MTkxODFmNTJkZDQ2OTM2 OTUwYmU4NjA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDMtMTAgIE5hb2tp IFRha2FubyAgPHRha2Fuby5uYW9raUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHRleHRhcmVhIG1heGxlbmd0aCBidWcgdGhh dCByZXR1cm4ga2V5IGlzIG5vdCBjb25zaWRlcmVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTYxNzEKKworICAgICAgICBXaGVuIHVzZXIgcHJlc3Mg YSByZXR1cm4ga2V5LCBUeXBpbmdDb21tYW5kOjppbnNlcnRMaW5lQnJlYWsoKSBpcyBjYWxsZWQu IFNvIGJlZm9yZSBhcHBlbmQgbmV3IGxpbmUsIGNoZWNrIGlmIHdlIGNhbiBhZGQgYSBuZXcgbGlu ZS4KKworICAgICAgICBtYW51YWwgdGVzdDogbWFudWFsLXRlc3RzL3RleHRhcmVhLW1heGxlbmd0 aC5odG1sCisKKyAgICAgICAgKiBlZGl0aW5nL1R5cGluZ0NvbW1hbmQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6VHlwaW5nQ29tbWFuZDo6aW5zZXJ0TGluZUJyZWFrKToKKyAgICAgICAgKiBtYW51 YWwtdGVzdHMvdGV4dGFyZWEtbWF4bGVuZ3RoLmh0bWw6IEFkZGVkIHRlc3QgdG8gY2hlY2sgbWFu dWFsbHkgbWF4IGxlbmd0aCB0YWcgaW4gdGV4dGFyZWEuCisKIDIwMTEtMDMtMDUgIFNoZXJpZmYg Qm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IHJvbGxpbmcgb3V0IHI4MDQyOC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcv VHlwaW5nQ29tbWFuZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1R5cGluZ0NvbW1hbmQu Y3BwCmluZGV4IDNiNDI5MTUwN2JhZGZhMjNlNjQ4OGI2YTgwYmI4ZDY2YWZjZDRmZDguLmE0NWY0 MzRlYjcxYzA1NmU3OWNlZjRhMGIzZjRmMDFhZTU0OWQ0MTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2VkaXRpbmcvVHlwaW5nQ29tbWFuZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRp dGluZy9UeXBpbmdDb21tYW5kLmNwcApAQCAtMjE0LDggKzIxNCwxOCBAQCB2b2lkIFR5cGluZ0Nv bW1hbmQ6Omluc2VydExpbmVCcmVhayhEb2N1bWVudCAqZG9jdW1lbnQsIFR5cGluZ0NvbW1hbmRP cHRpb25zIG9wdAogICAgIEVkaXRDb21tYW5kKiBsYXN0RWRpdENvbW1hbmQgPSBmcmFtZS0+ZWRp dG9yKCktPmxhc3RFZGl0Q29tbWFuZCgpOwogICAgIGlmIChpc09wZW5Gb3JNb3JlVHlwaW5nQ29t bWFuZChsYXN0RWRpdENvbW1hbmQpKSB7CiAgICAgICAgIFR5cGluZ0NvbW1hbmQqIGxhc3RUeXBp bmdDb21tYW5kID0gc3RhdGljX2Nhc3Q8VHlwaW5nQ29tbWFuZCo+KGxhc3RFZGl0Q29tbWFuZCk7 Ci0gICAgICAgIGxhc3RUeXBpbmdDb21tYW5kLT5zZXRTaG91bGRSZXRhaW5BdXRvY29ycmVjdGlv bkluZGljYXRvcihvcHRpb25zICYgUmV0YWluQXV0b2NvcnJlY3Rpb25JbmRpY2F0b3IpOwotICAg ICAgICBsYXN0VHlwaW5nQ29tbWFuZC0+aW5zZXJ0TGluZUJyZWFrKCk7CisgICAgICAgIEVsZW1l bnQqIHJvb3QgPSBsYXN0VHlwaW5nQ29tbWFuZC0+ZW5kaW5nU2VsZWN0aW9uKCkucm9vdEVkaXRh YmxlRWxlbWVudCgpOworICAgICAgICBpZiAocm9vdCkgeworICAgICAgICAgICAgLy8gQ2hlY2sg aWYgd2UgY2FuIGluc2VydCBuZXcgbGluZSBicmVhayB3aXRoIFxuKGxpbmUgZmVlZCkgc3RyaW5n LgorICAgICAgICAgICAgRXhjZXB0aW9uQ29kZSBlYyA9IDA7CisgICAgICAgICAgICBSZWZQdHI8 QmVmb3JlVGV4dEluc2VydGVkRXZlbnQ+IGV2dCA9IEJlZm9yZVRleHRJbnNlcnRlZEV2ZW50Ojpj cmVhdGUoU3RyaW5nKCJcbiIpKTsKKyAgICAgICAgICAgIHJvb3QtPmRpc3BhdGNoRXZlbnQoZXZ0 LCBlYyk7CisKKyAgICAgICAgICAgIGlmIChldnQtPnRleHQoKS5sZW5ndGgoKSkgeworICAgICAg ICAgICAgICAgIGxhc3RUeXBpbmdDb21tYW5kLT5zZXRTaG91bGRSZXRhaW5BdXRvY29ycmVjdGlv bkluZGljYXRvcihvcHRpb25zICYgUmV0YWluQXV0b2NvcnJlY3Rpb25JbmRpY2F0b3IpOworICAg ICAgICAgICAgICAgIGxhc3RUeXBpbmdDb21tYW5kLT5pbnNlcnRMaW5lQnJlYWsoKTsKKyAgICAg ICAgICAgIH0KKyAgICAgICAgfQogICAgICAgICByZXR1cm47CiAgICAgfQogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvdGV4dGFyZWEtbWF4bGVuZ3RoLmh0bWwgYi9T b3VyY2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvdGV4dGFyZWEtbWF4bGVuZ3RoLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uZTQ5NjU3ZjIxZmNlM2YyYjRhNGQ0NWIyZmQ2M2M2YmQwMThhYTgyOQotLS0gL2Rldi9u dWxsCisrKyBiL1NvdXJjZS9XZWJDb3JlL21hbnVhbC10ZXN0cy90ZXh0YXJlYS1tYXhsZW5ndGgu aHRtbApAQCAtMCwwICsxLDEyIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8 aDQ+VGV4dGFyZWEgbWF4bGVuZ3RoIHRlc3QuPC9oND4gCis8b2w+Cis8bGk+Rm9jdXMgdGhlIGN1 cnNvciB0byB0aGUgZm9sbG93aW5nIHRleHQgYXJlYS4KKzxsaT5QcmVzcyAnYScga2V5IGFuZCAn cmV0dXJuJyBrZXkgdHdpY2UuCis8bGk+TWFrZSBzdXJlIHRoZSBjdXJzb3Igc3RheXMgYXQgdGhl IHNlY29uZCBsaW5lLiBJZiB0aGUgY3Vyc29yIG1vdmVzIHRvIHRoZSB0aGlyZCBsaW5lLCB0aGlz IGlzIGEgYnVnLgorPC9vbD4KKzx0ZXh0YXJlYSBzdHlsZT0id2lkdGg6MzAwcHg7aGVpZ2h0OjIw MHB4IiBtYXhsZW5ndGg9IjIiPjwvdGV4dGFyZWE+Cis8L2JvZHk+IAorPC9odG1sPgo=