56076 2011-03-09 23:07:56 -0800 rebaseline-chromium-webkit-tests should ignore reftests. 2011-03-17 22:09:43 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 55457 36065 1 hayato webkit-unassigned dpranke hamaji ojan oldest_to_newest 365009 0 hayato 2011-03-09 23:07:56 -0800 Please see the master bug for the rationale: https://bugs.webkit.org/show_bug.cgi?id=36065 We are updating new-run-webkit-tests to support reftests. Rebaseline doesn't make sense for reftests, so rebaseline-chromium-webkit-test should ignore test files used by reftests. 365067 1 85302 hayato 2011-03-10 02:58:43 -0800 Created attachment 85302 check-reftest 365068 2 hayato 2011-03-10 03:00:58 -0800 The patch depends on another patch which is under the review. https://bugs.webkit.org/show_bug.cgi?id=55457 366928 3 85666 hayato 2011-03-14 03:58:53 -0700 Created attachment 85666 check-reftest 367579 4 85666 abarth 2011-03-15 02:22:10 -0700 Comment on attachment 85666 check-reftest This patch lacks a test. 367591 5 hayato 2011-03-15 02:45:10 -0700 Okay. Let me add a test. (In reply to comment #4) > (From update of attachment 85666 [details]) > This patch lacks a test. 368159 6 85902 hayato 2011-03-15 20:41:54 -0700 Created attachment 85902 add-tests 368784 7 85902 dpranke 2011-03-16 20:23:00 -0700 Comment on attachment 85902 add-tests View in context: https://bugs.webkit.org/attachment.cgi?id=85902&action=review > Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:256 > + self._rebaselining_tests = [] If you return like this, then Rebaseliner.run() will return True (success), and we won't think the rebaselining failed, which is probably not what we want to happen. I think you either need to change this to raise an Exception or modify the return value to a three-state thing (no tests to rebaseline, error, or proceed). Otherwise, the patch looks fine. 368797 8 86025 hayato 2011-03-16 21:03:26 -0700 Created attachment 86025 treat-it-as-error 368798 9 hayato 2011-03-16 21:06:38 -0700 Thank you for the review. (In reply to comment #7) > (From update of attachment 85902 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=85902&action=review > > > Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:256 > > + self._rebaselining_tests = [] > > If you return like this, then Rebaseliner.run() will return True (success), and we won't think the rebaselining failed, which is probably not what we want to happen. > > I think you either need to change this to raise an Exception or modify the return value to a three-state thing (no tests to rebaseline, error, or proceed). > > Otherwise, the patch looks fine. That's good point. I've updated the patch so that we can distinguish 'no-tests' and 'reftest-error' in a slightly different way from your suggestion. 368811 10 86025 dpranke 2011-03-16 22:18:23 -0700 Comment on attachment 86025 treat-it-as-error Looks fine. Thanks! 369100 11 86025 tony 2011-03-17 09:58:49 -0700 Comment on attachment 86025 treat-it-as-error View in context: https://bugs.webkit.org/attachment.cgi?id=86025&action=review > Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:242 > + False if reftests are wrongly marked as 'needs rebaseliing' or True rebaseliing -> rebaselining > Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:257 > + self._rebaselining_tests = [] Nit: Should this be set()? Maybe __init__ should use set() too. 369494 12 86025 hayato 2011-03-17 22:00:34 -0700 Comment on attachment 86025 treat-it-as-error Hi Tony, thank you for the review. I'll submit the patch after I fix the following minor points. View in context: https://bugs.webkit.org/attachment.cgi?id=86025&action=review >> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:242 >> + False if reftests are wrongly marked as 'needs rebaseliing' or True > > rebaseliing -> rebaselining Done >> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:257 >> + self._rebaselining_tests = [] > > Nit: Should this be set()? Maybe __init__ should use set() too. Done. I'll also fix __init__. It looks the current code doesn't assume self._rebaselining_tests must be 'set'. It seems that it must be 'iteratable' (list, set and so on). To be consistent with the return value of self._test_expectatations.get_rebaselining_failures(), 'set' is better here. 369497 13 hayato 2011-03-17 22:09:43 -0700 Committed r81441: <http://trac.webkit.org/changeset/81441> 85302 2011-03-10 02:58:43 -0800 2011-03-14 03:58:48 -0700 check-reftest bug-56076-20110310195841.patch text/plain 1870 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogODA2OTAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwMTJjMDY2ODMwNTc2MTdmNDM2ODMzNTE5MmViMWMwN2M1 ZTYzN2EwLi4xYzY5ZTM1NGExMTAyYWYwY2VjZTJiNGQzNGE4NzcxMGFhYmVhYjViIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDMtMTAgIEhheWF0byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGNoZWNrIGxv Z2ljIGZvciByZWZ0ZXN0cyBpbiBjYXNlIHRoYXQgYSByZWZ0ZXN0IGlzIG1hcmtlZCBBUyBSRUJB U0VMSU5FLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NjA3NgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcmViYXNl bGluZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMucHk6CisKIDIwMTEtMDMtMDkgIEFkYW0gUm9iZW4g IDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEhpZGUgTGVha3MgVmlld2VyJ3MgVVJMIHBy b21wdCBieSBkZWZhdWx0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9yZWJhc2VsaW5lX2Nocm9taXVtX3dlYmtpdF90ZXN0cy5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3JlYmFzZWxpbmVfY2hyb21pdW1fd2Via2l0X3Rlc3Rz LnB5CmluZGV4IDI0YjhjOTc2ZWQ3ZDYzMWE3ZTYxNTUzYTcxYTEwOWExMWZkNTE0M2UuLjg1ZjRl ODUwNTc1ZTg0NTY4NWZjY2RiM2I0MTI3NzJkNDIwZmYzMTMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3JlYmFzZWxpbmVfY2hyb21pdW1fd2Via2l0X3Rl c3RzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3JlYmFzZWxp bmVfY2hyb21pdW1fd2Via2l0X3Rlc3RzLnB5CkBAIC0yNDcsNiArMjQ3LDE1IEBAIGNsYXNzIFJl YmFzZWxpbmVyKG9iamVjdCk6CiAgICAgICAgICAgICBfbG9nLndhcm4oJ05vIHRlc3RzIGZvdW5k IHRoYXQgbmVlZCByZWJhc2VsaW5pbmcuJykKICAgICAgICAgICAgIHJldHVybiBOb25lCiAKKyAg ICAgICAgIyBEZXBlbmRzIG9uIHJlZnRlc3QgcGF0Y2guCisgICAgICAgIGZzID0gc2VsZi5fdGFy Z2V0X3BvcnQuX2ZpbGVzeXN0ZW0KKyAgICAgICAgZm9yIHRlc3QgaW4gc2VsZi5fcmViYXNlbGlu aW5nX3Rlc3RzOgorICAgICAgICAgICAgdGVzdF9hYnNwYXRoID0gc2VsZi5fdGFyZ2V0X3BvcnQu YWJzcGF0aF9mb3JfdGVzdCh0ZXN0KQorICAgICAgICAgICAgaWYgKGZzLmV4aXN0cyhzZWxmLl90 YXJnZXRfcG9ydC5yZWZ0ZXN0X2V4cGVjdGVkX2ZpbGVuYW1lKHRlc3RfYWJzcGF0aCkpIG9yCisg ICAgICAgICAgICAgICAgZnMuZXhpc3RzKHNlbGYuX3RhcmdldF9wb3J0LnJlZnRlc3RfZXhwZWN0 ZWRfbWlzbWF0Y2hfZmlsZW5hbWUodGVzdF9hYnNwYXRoKSkpOgorICAgICAgICAgICAgICAgIF9s b2cud2FybignJXMgc2VlbXMgdG8gYmUgYSByZWZ0ZXN0LiBXZSBjYW4gbm90IHJlYmFzZSBmb3Ig cmVmdGVzdHMuJywgdGVzdCkKKyAgICAgICAgICAgICAgICByZXR1cm4gTm9uZQorCiAgICAgICAg IF9sb2cuaW5mbygnVG90YWwgbnVtYmVyIG9mIHRlc3RzIG5lZWRpbmcgcmViYXNlbGluaW5nICcK ICAgICAgICAgICAgICAgICAgICdmb3IgIiVzIjogIiVkIicsIHNlbGYuX3BsYXRmb3JtLAogICAg ICAgICAgICAgICAgICAgbGVuKHNlbGYuX3JlYmFzZWxpbmluZ190ZXN0cykpCg== 85666 2011-03-14 03:58:53 -0700 2011-03-15 20:41:49 -0700 check-reftest bug-56076-20110314195851.patch text/plain 1881 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogODA2OTAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwMTJjMDY2ODMwNTc2MTdmNDM2ODMzNTE5MmViMWMwN2M1 ZTYzN2EwLi4xYzY5ZTM1NGExMTAyYWYwY2VjZTJiNGQzNGE4NzcxMGFhYmVhYjViIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDMtMTAgIEhheWF0byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGNoZWNrIGxv Z2ljIGZvciByZWZ0ZXN0cyBpbiBjYXNlIHRoYXQgYSByZWZ0ZXN0IGlzIG1hcmtlZCBBUyBSRUJB U0VMSU5FLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NjA3NgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcmViYXNl bGluZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMucHk6CisKIDIwMTEtMDMtMDkgIEFkYW0gUm9iZW4g IDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEhpZGUgTGVha3MgVmlld2VyJ3MgVVJMIHBy b21wdCBieSBkZWZhdWx0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9yZWJhc2VsaW5lX2Nocm9taXVtX3dlYmtpdF90ZXN0cy5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3JlYmFzZWxpbmVfY2hyb21pdW1fd2Via2l0X3Rlc3Rz LnB5CmluZGV4IDI0YjhjOTc2ZWQ3ZDYzMWE3ZTYxNTUzYTcxYTEwOWExMWZkNTE0M2UuLjZjY2I3 YzNlNTQyYTM0NWYxYWVkM2UxNjRkMmJkMTgxYjQ3ODI0MjMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3JlYmFzZWxpbmVfY2hyb21pdW1fd2Via2l0X3Rl c3RzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3JlYmFzZWxp bmVfY2hyb21pdW1fd2Via2l0X3Rlc3RzLnB5CkBAIC0yNDcsNiArMjQ3LDE1IEBAIGNsYXNzIFJl YmFzZWxpbmVyKG9iamVjdCk6CiAgICAgICAgICAgICBfbG9nLndhcm4oJ05vIHRlc3RzIGZvdW5k IHRoYXQgbmVlZCByZWJhc2VsaW5pbmcuJykKICAgICAgICAgICAgIHJldHVybiBOb25lCiAKKyAg ICAgICAgZnMgPSBzZWxmLl90YXJnZXRfcG9ydC5fZmlsZXN5c3RlbQorICAgICAgICBmb3IgdGVz dCBpbiBzZWxmLl9yZWJhc2VsaW5pbmdfdGVzdHM6CisgICAgICAgICAgICB0ZXN0X2Fic3BhdGgg PSBzZWxmLl90YXJnZXRfcG9ydC5hYnNwYXRoX2Zvcl90ZXN0KHRlc3QpCisgICAgICAgICAgICBp ZiAoZnMuZXhpc3RzKHNlbGYuX3RhcmdldF9wb3J0LnJlZnRlc3RfZXhwZWN0ZWRfZmlsZW5hbWUo dGVzdF9hYnNwYXRoKSkgb3IKKyAgICAgICAgICAgICAgICBmcy5leGlzdHMoc2VsZi5fdGFyZ2V0 X3BvcnQucmVmdGVzdF9leHBlY3RlZF9taXNtYXRjaF9maWxlbmFtZSh0ZXN0X2Fic3BhdGgpKSk6 CisgICAgICAgICAgICAgICAgX2xvZy5lcnJvcignJXMgc2VlbXMgdG8gYmUgYSByZWZ0ZXN0LiBX ZSBjYW4gbm90IHJlYmFzZSBmb3IgcmVmdGVzdHMuJywgdGVzdCkKKyAgICAgICAgICAgICAgICBz ZWxmLl9yZWJhc2VsaW5pbmdfdGVzdHMgPSBbXQorICAgICAgICAgICAgICAgIHJldHVybiBOb25l CisKICAgICAgICAgX2xvZy5pbmZvKCdUb3RhbCBudW1iZXIgb2YgdGVzdHMgbmVlZGluZyByZWJh c2VsaW5pbmcgJwogICAgICAgICAgICAgICAgICAgJ2ZvciAiJXMiOiAiJWQiJywgc2VsZi5fcGxh dGZvcm0sCiAgICAgICAgICAgICAgICAgICBsZW4oc2VsZi5fcmViYXNlbGluaW5nX3Rlc3RzKSkK 85902 2011-03-15 20:41:54 -0700 2011-03-16 21:03:21 -0700 add-tests bug-56076-20110316124152.patch text/plain 3446 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogODEyMDYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkODE1MTNkNjU1NTkwOWZiYWI0OTk1ZjMyZGU4ZjA0OGNm ZGZlNzY2Li5lMWVhYjMzM2ViYWI1NzJiZTdiNTY5MWRjYTM3NjM2MDk3NzVmZjM2IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDMtMTAgIEhheWF0byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGNoZWNrIGxv Z2ljIGZvciByZWZ0ZXN0cyBpbiBjYXNlIHRoYXQgYSByZWZ0ZXN0IGlzIG1hcmtlZCBBUyBSRUJB U0VMSU5FLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NjA3NgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcmViYXNl bGluZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMucHk6CisKIDIwMTEtMDMtMTUgIFNhbSBXZWluaWcg IDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3JlYmFzZWxpbmVf Y2hyb21pdW1fd2Via2l0X3Rlc3RzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMucHkKaW5kZXggMjRiOGM5NzZl ZDdkNjMxYTdlNjE1NTNhNzFhMTA5YTExZmQ1MTQzZS4uNmNjYjdjM2U1NDJhMzQ1ZjFhZWQzZTE2 NGQyYmQxODFiNDc4MjQyMyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRf dGVzdHMucHkKQEAgLTI0Nyw2ICsyNDcsMTUgQEAgY2xhc3MgUmViYXNlbGluZXIob2JqZWN0KToK ICAgICAgICAgICAgIF9sb2cud2FybignTm8gdGVzdHMgZm91bmQgdGhhdCBuZWVkIHJlYmFzZWxp bmluZy4nKQogICAgICAgICAgICAgcmV0dXJuIE5vbmUKIAorICAgICAgICBmcyA9IHNlbGYuX3Rh cmdldF9wb3J0Ll9maWxlc3lzdGVtCisgICAgICAgIGZvciB0ZXN0IGluIHNlbGYuX3JlYmFzZWxp bmluZ190ZXN0czoKKyAgICAgICAgICAgIHRlc3RfYWJzcGF0aCA9IHNlbGYuX3RhcmdldF9wb3J0 LmFic3BhdGhfZm9yX3Rlc3QodGVzdCkKKyAgICAgICAgICAgIGlmIChmcy5leGlzdHMoc2VsZi5f dGFyZ2V0X3BvcnQucmVmdGVzdF9leHBlY3RlZF9maWxlbmFtZSh0ZXN0X2Fic3BhdGgpKSBvcgor ICAgICAgICAgICAgICAgIGZzLmV4aXN0cyhzZWxmLl90YXJnZXRfcG9ydC5yZWZ0ZXN0X2V4cGVj dGVkX21pc21hdGNoX2ZpbGVuYW1lKHRlc3RfYWJzcGF0aCkpKToKKyAgICAgICAgICAgICAgICBf bG9nLmVycm9yKCclcyBzZWVtcyB0byBiZSBhIHJlZnRlc3QuIFdlIGNhbiBub3QgcmViYXNlIGZv ciByZWZ0ZXN0cy4nLCB0ZXN0KQorICAgICAgICAgICAgICAgIHNlbGYuX3JlYmFzZWxpbmluZ190 ZXN0cyA9IFtdCisgICAgICAgICAgICAgICAgcmV0dXJuIE5vbmUKKwogICAgICAgICBfbG9nLmlu Zm8oJ1RvdGFsIG51bWJlciBvZiB0ZXN0cyBuZWVkaW5nIHJlYmFzZWxpbmluZyAnCiAgICAgICAg ICAgICAgICAgICAnZm9yICIlcyI6ICIlZCInLCBzZWxmLl9wbGF0Zm9ybSwKICAgICAgICAgICAg ICAgICAgIGxlbihzZWxmLl9yZWJhc2VsaW5pbmdfdGVzdHMpKQpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRf dGVzdHNfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9y ZWJhc2VsaW5lX2Nocm9taXVtX3dlYmtpdF90ZXN0c191bml0dGVzdC5weQppbmRleCBjNTBlMWM0 NmQ1NjBiMjc5YjFlMzYzMzg0NGM2NzUyMmU5YmMyMjAzLi5hMTI0MjQ4YjcyOWRlMDBiY2I5NzZm OWI3MDJkNWRiODlhNzdkYzM1IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9yZWJhc2VsaW5lX2Nocm9taXVtX3dlYmtpdF90ZXN0c191bml0dGVzdC5weQor KysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9yZWJhc2VsaW5lX2Nocm9t aXVtX3dlYmtpdF90ZXN0c191bml0dGVzdC5weQpAQCAtMTc0LDYgKzE3NCwyMCBAQCBjbGFzcyBU ZXN0UmViYXNlbGluZXIodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICByZWJhc2VsaW5lci5y dW4oRmFsc2UpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwobGVuKGZpbGVzeXN0ZW0ud3JpdHRl bl9maWxlcyksIDEpCiAKKyAgICBkZWYgdGVzdF9yZWJhc2VsaW5pbmdfdGVzdHMoc2VsZik6Cisg ICAgICAgIHJlYmFzZWxpbmVyLCBmaWxlc3lzdGVtID0gc2VsZi5tYWtlX3JlYmFzZWxpbmVyKAor ICAgICAgICAgICAgIkJVR1ggUkVCQVNFTElORSBNQUMgOiBmYWlsdXJlcy9leHBlY3RlZC9pbWFn ZS5odG1sID0gSU1BR0UiKQorICAgICAgICByZWJhc2VsaW5pbmdfdGVzdHMgPSByZWJhc2VsaW5l ci5fY29tcGlsZV9yZWJhc2VsaW5pbmdfdGVzdHMoKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFs KHNldChbJ2ZhaWx1cmVzL2V4cGVjdGVkL2ltYWdlLmh0bWwnXSksIHJlYmFzZWxpbmluZ190ZXN0 cykKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChzZXQoWydmYWlsdXJlcy9leHBlY3RlZC9pbWFn ZS5odG1sJ10pLCByZWJhc2VsaW5lci5nZXRfcmViYXNlbGluaW5nX3Rlc3RzKCkpCisKKyAgICBk ZWYgdGVzdF9yZWJhc2VsaW5pbmdfdGVzdHNfc2hvdWxkX2lnbm9yZV9yZWZ0ZXN0cyhzZWxmKToK KyAgICAgICAgcmViYXNlbGluZXIsIGZpbGVzeXN0ZW0gPSBzZWxmLm1ha2VfcmViYXNlbGluZXIo CisgICAgICAgICAgICAiQlVHWCBSRUJBU0VMSU5FIDogZmFpbHVyZXMvZXhwZWN0ZWQvcmVmdGVz dC5odG1sID0gSU1BR0UiKQorICAgICAgICByZWJhc2VsaW5pbmdfdGVzdHMgPSByZWJhc2VsaW5l ci5fY29tcGlsZV9yZWJhc2VsaW5pbmdfdGVzdHMoKQorICAgICAgICBzZWxmLmFzc2VydEZhbHNl KHJlYmFzZWxpbmluZ190ZXN0cykKKyAgICAgICAgc2VsZi5hc3NlcnRGYWxzZShyZWJhc2VsaW5l ci5nZXRfcmViYXNlbGluaW5nX3Rlc3RzKCkpCisKICAgICBkZWYgdGVzdF9vbmVfcGxhdGZvcm0o c2VsZik6CiAgICAgICAgIHJlYmFzZWxpbmVyLCBmaWxlc3lzdGVtID0gc2VsZi5tYWtlX3JlYmFz ZWxpbmVyKAogICAgICAgICAgICAgIkJVR1ggUkVCQVNFTElORSBNQUMgOiBmYWlsdXJlcy9leHBl Y3RlZC9pbWFnZS5odG1sID0gSU1BR0UiKQo= 86025 2011-03-16 21:03:26 -0700 2011-03-17 22:00:34 -0700 treat-it-as-error bug-56076-20110317130324.patch text/plain 4441 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogODEyMDYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkODE1MTNkNjU1NTkwOWZiYWI0OTk1ZjMyZGU4ZjA0OGNm ZGZlNzY2Li5lMWVhYjMzM2ViYWI1NzJiZTdiNTY5MWRjYTM3NjM2MDk3NzVmZjM2IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDMtMTAgIEhheWF0byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGNoZWNrIGxv Z2ljIGZvciByZWZ0ZXN0cyBpbiBjYXNlIHRoYXQgYSByZWZ0ZXN0IGlzIG1hcmtlZCBBUyBSRUJB U0VMSU5FLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NjA3NgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcmViYXNl bGluZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMucHk6CisKIDIwMTEtMDMtMTUgIFNhbSBXZWluaWcg IDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3JlYmFzZWxpbmVf Y2hyb21pdW1fd2Via2l0X3Rlc3RzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMucHkKaW5kZXggMjRiOGM5NzZl ZDdkNjMxYTdlNjE1NTNhNzFhMTA5YTExZmQ1MTQzZS4uNTEzMzUzOTU4YjZmMGUwMDE3Y2Y2ZTkw OWI3MDE4OTBjYWM4YzQ5MiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRf dGVzdHMucHkKQEAgLTE5NCw2ICsxOTQsOCBAQCBjbGFzcyBSZWJhc2VsaW5lcihvYmplY3QpOgog CiAgICAgICAgIGxvZ19kYXNoZWRfc3RyaW5nKCdDb21waWxpbmcgcmViYXNlbGluaW5nIHRlc3Rz Jywgc2VsZi5fcGxhdGZvcm0pCiAgICAgICAgIGlmIG5vdCBzZWxmLl9jb21waWxlX3JlYmFzZWxp bmluZ190ZXN0cygpOgorICAgICAgICAgICAgcmV0dXJuIEZhbHNlCisgICAgICAgIGlmIG5vdCBz ZWxmLmdldF9yZWJhc2VsaW5pbmdfdGVzdHMoKToKICAgICAgICAgICAgIHJldHVybiBUcnVlCiAK ICAgICAgICAgbG9nX2Rhc2hlZF9zdHJpbmcoJ0Rvd25sb2FkaW5nIGFyY2hpdmUnLCBzZWxmLl9w bGF0Zm9ybSkKQEAgLTIzNywxNSArMjM5LDIzIEBAIGNsYXNzIFJlYmFzZWxpbmVyKG9iamVjdCk6 CiAgICAgICAgICIiIkNvbXBpbGUgbGlzdCBvZiB0ZXN0cyB0aGF0IG5lZWQgcmViYXNlbGluaW5n IGZvciB0aGUgcGxhdGZvcm0uCiAKICAgICAgICAgUmV0dXJuczoKLSAgICAgICAgICBMaXN0IG9m IHRlc3RzIHRoYXQgbmVlZCByZWJhc2VsaW5pbmcgb3IKLSAgICAgICAgICBOb25lIGlmIHRoZXJl IGlzIG5vIHN1Y2ggdGVzdC4KKyAgICAgICAgICBGYWxzZSBpZiByZWZ0ZXN0cyBhcmUgd3Jvbmds eSBtYXJrZWQgYXMgJ25lZWRzIHJlYmFzZWxpaW5nJyBvciBUcnVlCiAgICAgICAgICIiIgogCiAg ICAgICAgIHNlbGYuX3JlYmFzZWxpbmluZ190ZXN0cyA9IFwKICAgICAgICAgICAgIHNlbGYuX3Rl c3RfZXhwZWN0YXRpb25zLmdldF9yZWJhc2VsaW5pbmdfZmFpbHVyZXMoKQogICAgICAgICBpZiBu b3Qgc2VsZi5fcmViYXNlbGluaW5nX3Rlc3RzOgogICAgICAgICAgICAgX2xvZy53YXJuKCdObyB0 ZXN0cyBmb3VuZCB0aGF0IG5lZWQgcmViYXNlbGluaW5nLicpCi0gICAgICAgICAgICByZXR1cm4g Tm9uZQorICAgICAgICAgICAgcmV0dXJuIFRydWUKKworICAgICAgICBmcyA9IHNlbGYuX3Rhcmdl dF9wb3J0Ll9maWxlc3lzdGVtCisgICAgICAgIGZvciB0ZXN0IGluIHNlbGYuX3JlYmFzZWxpbmlu Z190ZXN0czoKKyAgICAgICAgICAgIHRlc3RfYWJzcGF0aCA9IHNlbGYuX3RhcmdldF9wb3J0LmFi c3BhdGhfZm9yX3Rlc3QodGVzdCkKKyAgICAgICAgICAgIGlmIChmcy5leGlzdHMoc2VsZi5fdGFy Z2V0X3BvcnQucmVmdGVzdF9leHBlY3RlZF9maWxlbmFtZSh0ZXN0X2Fic3BhdGgpKSBvcgorICAg ICAgICAgICAgICAgIGZzLmV4aXN0cyhzZWxmLl90YXJnZXRfcG9ydC5yZWZ0ZXN0X2V4cGVjdGVk X21pc21hdGNoX2ZpbGVuYW1lKHRlc3RfYWJzcGF0aCkpKToKKyAgICAgICAgICAgICAgICBfbG9n LmVycm9yKCclcyBzZWVtcyB0byBiZSBhIHJlZnRlc3QuIFdlIGNhbiBub3QgcmViYXNlIGZvciBy ZWZ0ZXN0cy4nLCB0ZXN0KQorICAgICAgICAgICAgICAgIHNlbGYuX3JlYmFzZWxpbmluZ190ZXN0 cyA9IFtdCisgICAgICAgICAgICAgICAgcmV0dXJuIEZhbHNlCiAKICAgICAgICAgX2xvZy5pbmZv KCdUb3RhbCBudW1iZXIgb2YgdGVzdHMgbmVlZGluZyByZWJhc2VsaW5pbmcgJwogICAgICAgICAg ICAgICAgICAgJ2ZvciAiJXMiOiAiJWQiJywgc2VsZi5fcGxhdGZvcm0sCkBAIC0yNTYsNyArMjY2 LDcgQEAgY2xhc3MgUmViYXNlbGluZXIob2JqZWN0KToKICAgICAgICAgICAgIF9sb2cuaW5mbygn ICAlZDogJXMnLCB0ZXN0X25vLCB0ZXN0KQogICAgICAgICAgICAgdGVzdF9ubyArPSAxCiAKLSAg ICAgICAgcmV0dXJuIHNlbGYuX3JlYmFzZWxpbmluZ190ZXN0cworICAgICAgICByZXR1cm4gVHJ1 ZQogCiAgICAgZGVmIF9nZXRfbGF0ZXN0X3JldmlzaW9uKHNlbGYsIHVybCk6CiAgICAgICAgICIi IkdldCB0aGUgbGF0ZXN0IGxheW91dCB0ZXN0IHJldmlzaW9uIG51bWJlciBmcm9tIGJ1aWxkYm90 LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcmViYXNl bGluZV9jaHJvbWl1bV93ZWJraXRfdGVzdHNfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9yZWJhc2VsaW5lX2Nocm9taXVtX3dlYmtpdF90ZXN0c191bml0 dGVzdC5weQppbmRleCBjNTBlMWM0NmQ1NjBiMjc5YjFlMzYzMzg0NGM2NzUyMmU5YmMyMjAzLi43 MTc5YmI3ZmI1NTQ2YmJiZDE1Mjg5ZmQwMTg3OGVkOTEzYmY5OGJjIDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9yZWJhc2VsaW5lX2Nocm9taXVtX3dlYmtp dF90ZXN0c191bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9yZWJhc2VsaW5lX2Nocm9taXVtX3dlYmtpdF90ZXN0c191bml0dGVzdC5weQpAQCAtMTc0 LDYgKzE3NCwyMCBAQCBjbGFzcyBUZXN0UmViYXNlbGluZXIodW5pdHRlc3QuVGVzdENhc2UpOgog ICAgICAgICByZWJhc2VsaW5lci5ydW4oRmFsc2UpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwo bGVuKGZpbGVzeXN0ZW0ud3JpdHRlbl9maWxlcyksIDEpCiAKKyAgICBkZWYgdGVzdF9yZWJhc2Vs aW5pbmdfdGVzdHMoc2VsZik6CisgICAgICAgIHJlYmFzZWxpbmVyLCBmaWxlc3lzdGVtID0gc2Vs Zi5tYWtlX3JlYmFzZWxpbmVyKAorICAgICAgICAgICAgIkJVR1ggUkVCQVNFTElORSBNQUMgOiBm YWlsdXJlcy9leHBlY3RlZC9pbWFnZS5odG1sID0gSU1BR0UiKQorICAgICAgICBjb21waWxlX3N1 Y2Nlc3MgPSByZWJhc2VsaW5lci5fY29tcGlsZV9yZWJhc2VsaW5pbmdfdGVzdHMoKQorICAgICAg ICBzZWxmLmFzc2VydFRydWUoY29tcGlsZV9zdWNjZXNzKQorICAgICAgICBzZWxmLmFzc2VydEVx dWFsKHNldChbJ2ZhaWx1cmVzL2V4cGVjdGVkL2ltYWdlLmh0bWwnXSksIHJlYmFzZWxpbmVyLmdl dF9yZWJhc2VsaW5pbmdfdGVzdHMoKSkKKworICAgIGRlZiB0ZXN0X3JlYmFzZWxpbmluZ190ZXN0 c19zaG91bGRfaWdub3JlX3JlZnRlc3RzKHNlbGYpOgorICAgICAgICByZWJhc2VsaW5lciwgZmls ZXN5c3RlbSA9IHNlbGYubWFrZV9yZWJhc2VsaW5lcigKKyAgICAgICAgICAgICJCVUdYIFJFQkFT RUxJTkUgOiBmYWlsdXJlcy9leHBlY3RlZC9yZWZ0ZXN0Lmh0bWwgPSBJTUFHRSIpCisgICAgICAg IGNvbXBpbGVfc3VjY2VzcyA9IHJlYmFzZWxpbmVyLl9jb21waWxlX3JlYmFzZWxpbmluZ190ZXN0 cygpCisgICAgICAgIHNlbGYuYXNzZXJ0RmFsc2UoY29tcGlsZV9zdWNjZXNzKQorICAgICAgICBz ZWxmLmFzc2VydEZhbHNlKHJlYmFzZWxpbmVyLmdldF9yZWJhc2VsaW5pbmdfdGVzdHMoKSkKKwog ICAgIGRlZiB0ZXN0X29uZV9wbGF0Zm9ybShzZWxmKToKICAgICAgICAgcmViYXNlbGluZXIsIGZp bGVzeXN0ZW0gPSBzZWxmLm1ha2VfcmViYXNlbGluZXIoCiAgICAgICAgICAgICAiQlVHWCBSRUJB U0VMSU5FIE1BQyA6IGZhaWx1cmVzL2V4cGVjdGVkL2ltYWdlLmh0bWwgPSBJTUFHRSIpCg==