56038 2011-03-09 11:43:29 -0800 Start focusing updates to media controls, away from generic "update everything". 2011-03-11 09:20:07 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 53020 1 dglazkov dglazkov eric.carlson oldest_to_newest 364657 0 dglazkov 2011-03-09 11:43:29 -0800 Start focusing updates to media controls, away from generic "update everything". 364665 1 85210 dglazkov 2011-03-09 11:50:13 -0800 Created attachment 85210 Patch 365189 2 85210 eric.carlson 2011-03-10 08:15:45 -0800 Comment on attachment 85210 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85210&action=review > Source/WebCore/ChangeLog:5 > + Start focusing updates to media controls, away from generic &quot;update everything&quot;. "&quot;" ? 365451 3 dglazkov 2011-03-10 12:51:20 -0800 (In reply to comment #2) > (From update of attachment 85210 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=85210&action=review > > > Source/WebCore/ChangeLog:5 > > + Start focusing updates to media controls, away from generic &quot;update everything&quot;. > > "&quot;" ? DOH. WIll fix on landing. 366040 4 dglazkov 2011-03-11 09:20:07 -0800 Committed r80855: <http://trac.webkit.org/changeset/80855> 85210 2011-03-09 11:50:13 -0800 2011-03-10 08:15:45 -0800 Patch bug-56038-20110309115012.patch text/plain 6767 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogODA1OTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyYjUyZGYxOWRiMjQ1ODhj ODI3YzJkYTU2OTU2YzQ1YmUwNzU4ODI2Li42YTBlNWEyN2Q3YWY3NDU3YTMwMmUzYTA2NmJhOTZl NDIyOWJjOTA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzIgQEAKKzIwMTEtMDMtMDkgIERpbWl0 cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdGFydCBmb2N1c2luZyB1cGRhdGVzIHRvIG1l ZGlhIGNvbnRyb2xzLCBhd2F5IGZyb20gZ2VuZXJpYyAmcXVvdDt1cGRhdGUgZXZlcnl0aGluZyZx dW90Oy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2 MDM4CisKKyAgICAgICAgRm9yIG5vdywgdGhlIG5ldyBtZXRob2RzIGp1c3QgY2FsbCBnZW5lcmlj IE1lZGlhQ29udHJvbHM6OnVwZGF0ZS4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRl c3RzLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmF0dHJpYnV0ZUNoYW5nZWQpOiBDaGFuZ2VkIHRvIHVz ZSBNZWRpYUNvbnRyb2xzOjpyZXNldC4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1l bnQ6OnNldE11dGVkKTogQ2hhbmdlZCB0byB1c2UgTWVkaWFDb250cm9sczo6Y2hhbmdlZE11dGUu CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojp1cGRhdGVWb2x1bWUpOiBDaGFu Z2VkIHRvIHVzZSBNZWRpYUNvbnRyb2xzOjpjaGFuZ2VkVm9sdW1lLgorICAgICAgICAoV2ViQ29y ZTo6SFRNTE1lZGlhRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcik6IENoYW5nZWQgdG8gdXNl IHRoZSBuZXcgbWVkaWFDb250cm9scworICAgICAgICAgICAgYWNjZXNzb3IuCisgICAgICAgIChX ZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpzZXRDbG9zZWRDYXB0aW9uc1Zpc2libGUpOiBDaGFu Z2VkIHRvIHVzZQorICAgICAgICAgICAgTWVkaWFDb250cm9sczo6Y2hhbmdlZENsb3NlZENhcHRp b25zVmlzaWJpbGl0eS4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6Om1lZGlh Q29udHJvbHMpOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6Omhh c01lZGlhQ29udHJvbHMpOiBBZGRlZC4KKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQu aDogQWRkZWQgZGVjbHMuCisgICAgICAgICogaHRtbC9zaGFkb3cvTWVkaWFDb250cm9scy5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xzOjpyZXNldCk6IEFkZGVkLgorICAgICAg ICAoV2ViQ29yZTo6TWVkaWFDb250cm9sczo6Y2hhbmdlZE11dGUpOiBBZGRlZC4KKyAgICAgICAg KFdlYkNvcmU6Ok1lZGlhQ29udHJvbHM6OmNoYW5nZWRWb2x1bWUpOiBBZGRlZC4KKyAgICAgICAg KFdlYkNvcmU6Ok1lZGlhQ29udHJvbHM6OmNoYW5nZWRDbG9zZWRDYXB0aW9uc1Zpc2liaWxpdHkp OiBBZGRlZC4KKyAgICAgICAgKiBodG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xzLmg6IEFkZGVkIGRl Y2xzLgorCiAyMDExLTAzLTA4ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1Ad2Via2l0Lm9yZz4K IAogICAgICAgICBNb3JlIGJ1aWxkIGJ1c3RhZ2UgZml4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TE1lZGlhRWxlbWVudC5jcHAKaW5kZXggYWFhMWJlZWZjOWJiMTM4ZTBhZTYyZTMzNWY0YTliNWYx MzNmM2JlYy4uN2JjNDhjYWU3ZTVkMmUyNmVlZTMwYTAwYWNlNTI2MmFjYjQwYmViZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCkBAIC0yMjIsOCArMjIyLDggQEAg dm9pZCBIVE1MTWVkaWFFbGVtZW50OjphdHRyaWJ1dGVDaGFuZ2VkKEF0dHJpYnV0ZSogYXR0ciwg Ym9vbCBwcmVzZXJ2ZURlY2xzKQogICAgICAgICAgICAgZGV0YWNoKCk7CiAgICAgICAgICAgICBh dHRhY2goKTsKICAgICAgICAgfQotICAgICAgICBpZiAocmVuZGVyZXIoKSkKLSAgICAgICAgICAg IHJlbmRlcmVyKCktPnVwZGF0ZUZyb21FbGVtZW50KCk7CisgICAgICAgIGlmIChoYXNNZWRpYUNv bnRyb2xzKCkpCisgICAgICAgICAgICBtZWRpYUNvbnRyb2xzKCktPnJlc2V0KCk7CiAjZWxzZQog ICAgICAgICBpZiAobV9wbGF5ZXIpCiAgICAgICAgICAgICBtX3BsYXllci0+c2V0Q29udHJvbHMo Y29udHJvbHMoKSk7CkBAIC0xNTI1LDggKzE1MjUsOCBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6 OnNldE11dGVkKGJvb2wgbXV0ZWQpCiAgICAgICAgIGlmICghcHJvY2Vzc2luZ01lZGlhUGxheWVy Q2FsbGJhY2soKSkgewogICAgICAgICAgICAgaWYgKG1fcGxheWVyKSB7CiAgICAgICAgICAgICAg ICAgbV9wbGF5ZXItPnNldE11dGVkKG1fbXV0ZWQpOwotICAgICAgICAgICAgICAgIGlmIChyZW5k ZXJlcigpKQotICAgICAgICAgICAgICAgICAgICByZW5kZXJlcigpLT51cGRhdGVGcm9tRWxlbWVu dCgpOworICAgICAgICAgICAgICAgIGlmIChoYXNNZWRpYUNvbnRyb2xzKCkpCisgICAgICAgICAg ICAgICAgICAgIG1lZGlhQ29udHJvbHMoKS0+Y2hhbmdlZE11dGUoKTsKICAgICAgICAgICAgIH0K ICAgICAgICAgfQogICAgICAgICBzY2hlZHVsZUV2ZW50KGV2ZW50TmFtZXMoKS52b2x1bWVjaGFu Z2VFdmVudCk7CkBAIC0yMTAwLDkgKzIxMDAsOSBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnVw ZGF0ZVZvbHVtZSgpCiAgICAgICAgIG1fcGxheWVyLT5zZXRNdXRlZChtX211dGVkKTsKICAgICAg ICAgbV9wbGF5ZXItPnNldFZvbHVtZShtX3ZvbHVtZSAqIHZvbHVtZU11bHRpcGxpZXIpOwogICAg IH0KLSAgICAKLSAgICBpZiAocmVuZGVyZXIoKSkKLSAgICAgICAgcmVuZGVyZXIoKS0+dXBkYXRl RnJvbUVsZW1lbnQoKTsKKworICAgIGlmIChoYXNNZWRpYUNvbnRyb2xzKCkpCisgICAgICAgIG1l ZGlhQ29udHJvbHMoKS0+Y2hhbmdlZFZvbHVtZSgpOwogfQogCiB2b2lkIEhUTUxNZWRpYUVsZW1l bnQ6OnVwZGF0ZVBsYXlTdGF0ZSgpCkBAIC0yMzAyLDggKzIzMDIsOCBAQCB2b2lkIEhUTUxNZWRp YUVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIoRXZlbnQqIGV2ZW50KQogICAgIGlmICh3aWRn ZXQpCiAgICAgICAgIHdpZGdldC0+aGFuZGxlRXZlbnQoZXZlbnQpOwogI2Vsc2UKLSAgICBpZiAo cmVuZGVyZXIoKSAmJiByZW5kZXJlcigpLT5pc01lZGlhKCkpCi0gICAgICAgIHRvUmVuZGVyTWVk aWEocmVuZGVyZXIoKSktPmNvbnRyb2xzKCktPmZvcndhcmRFdmVudChldmVudCk7CisgICAgaWYg KGhhc01lZGlhQ29udHJvbHMoKSkKKyAgICAgICAgbWVkaWFDb250cm9scygpLT5mb3J3YXJkRXZl bnQoZXZlbnQpOwogICAgIGlmIChldmVudC0+ZGVmYXVsdEhhbmRsZWQoKSkKICAgICAgICAgcmV0 dXJuOwogICAgIEhUTUxFbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKGV2ZW50KTsKQEAgLTI0 NzksOCArMjQ3OSw4IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6c2V0Q2xvc2VkQ2FwdGlvbnNW aXNpYmxlKGJvb2wgY2xvc2VkQ2FwdGlvblZpc2libGUpCiAKICAgICBtX2Nsb3NlZENhcHRpb25z VmlzaWJsZSA9IGNsb3NlZENhcHRpb25WaXNpYmxlOwogICAgIG1fcGxheWVyLT5zZXRDbG9zZWRD YXB0aW9uc1Zpc2libGUoY2xvc2VkQ2FwdGlvblZpc2libGUpOwotICAgIGlmIChyZW5kZXJlcigp KQotICAgICAgICByZW5kZXJlcigpLT51cGRhdGVGcm9tRWxlbWVudCgpOworICAgIGlmIChoYXNN ZWRpYUNvbnRyb2xzKCkpCisgICAgICAgIG1lZGlhQ29udHJvbHMoKS0+Y2hhbmdlZENsb3NlZENh cHRpb25zVmlzaWJpbGl0eSgpOwogfQogCiB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnNldFdlYmtp dENsb3NlZENhcHRpb25zVmlzaWJsZShib29sIHZpc2libGUpCkBAIC0yNTcwLDYgKzI1NzAsMTcg QEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50Ojpwcml2YXRlQnJvd3NpbmdTdGF0ZURpZENoYW5nZSgp CiAgICAgbV9wbGF5ZXItPnNldFByaXZhdGVCcm93c2luZ01vZGUocHJpdmF0ZU1vZGUpOwogfQog CitNZWRpYUNvbnRyb2xzKiBIVE1MTWVkaWFFbGVtZW50OjptZWRpYUNvbnRyb2xzKCkKK3sKKyAg ICBBU1NFUlQocmVuZGVyZXIoKSk7CisgICAgcmV0dXJuIHRvUmVuZGVyTWVkaWEocmVuZGVyZXIo KSktPmNvbnRyb2xzKCk7Cit9CisKK2Jvb2wgSFRNTE1lZGlhRWxlbWVudDo6aGFzTWVkaWFDb250 cm9scygpIGNvbnN0Cit7CisgICAgcmV0dXJuIHJlbmRlcmVyKCkgJiYgcmVuZGVyZXIoKS0+aXNN ZWRpYSgpOworfQorCiB9CiAKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MTWVkaWFFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1l bnQuaAppbmRleCBmODcwNTg2YmIyOGY1MGQ0NjI1OWM5ZDc1ODliZjgwY2FlMTE2Y2YyLi4xMTA4 MzMwMTI0NTJiMWY0YTE0ZTc0NTVjY2MxNTkzYTU3NTg1M2ZkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxNZWRpYUVsZW1lbnQuaApAQCAtNDEsNiArNDEsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKIGNsYXNzIEV2ZW50OwogY2xhc3MgSFRNTFNvdXJjZUVsZW1lbnQ7CitjbGFzcyBNZWRpYUNv bnRyb2xzOwogY2xhc3MgTWVkaWFFcnJvcjsKIGNsYXNzIEtVUkw7CiBjbGFzcyBUaW1lUmFuZ2Vz OwpAQCAtMTcxLDYgKzE3Miw4IEBAIHB1YmxpYzoKICAgICBib29sIGNsb3NlZENhcHRpb25zVmlz aWJsZSgpIGNvbnN0OwogICAgIHZvaWQgc2V0Q2xvc2VkQ2FwdGlvbnNWaXNpYmxlKGJvb2wpOwog CisgICAgTWVkaWFDb250cm9scyogbWVkaWFDb250cm9scygpOworCiAgICAgYm9vbCBwcm9jZXNz aW5nVXNlckdlc3R1cmUoKSBjb25zdDsKIAogICAgIHZvaWQgc291cmNlV2lsbEJlUmVtb3ZlZChI VE1MU291cmNlRWxlbWVudCopOwpAQCAtMzE5LDYgKzMyMiw4IEBAIHByaXZhdGU6CiAgICAgdm9p ZCBpbnZhbGlkYXRlQ2FjaGVkVGltZSgpOwogICAgIHZvaWQgcmVmcmVzaENhY2hlZFRpbWUoKSBj b25zdDsKIAorICAgIGJvb2wgaGFzTWVkaWFDb250cm9scygpIGNvbnN0OworCiAgICAgVGltZXI8 SFRNTE1lZGlhRWxlbWVudD4gbV9sb2FkVGltZXI7CiAgICAgVGltZXI8SFRNTE1lZGlhRWxlbWVu dD4gbV9hc3luY0V2ZW50VGltZXI7CiAgICAgVGltZXI8SFRNTE1lZGlhRWxlbWVudD4gbV9wcm9n cmVzc0V2ZW50VGltZXI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9N ZWRpYUNvbnRyb2xzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01lZGlhQ29udHJv bHMuY3BwCmluZGV4IGQ4Yzk5MzYwZDIwMGIzZTBmYjFkNWM5MDlkZWM4OWRlZTljMGM2NWEuLmQw NDdmZDJkYTdkNGVlMWU2OTE2MjFiODJkMjQxMTIwNjkzNDI0YTUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvc2hhZG93L01lZGlhQ29udHJvbHMuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvc2hhZG93L01lZGlhQ29udHJvbHMuY3BwCkBAIC02Miw2ICs2MiwyNiBAQCBNZWRp YUNvbnRyb2xzOjpNZWRpYUNvbnRyb2xzKEhUTUxNZWRpYUVsZW1lbnQqIG1lZGlhRWxlbWVudCkK IHsKIH0KIAordm9pZCBNZWRpYUNvbnRyb2xzOjpyZXNldCgpCit7CisgICAgdXBkYXRlKCk7Cit9 CisKK3ZvaWQgTWVkaWFDb250cm9sczo6Y2hhbmdlZE11dGUoKQoreworICAgIHVwZGF0ZSgpOwor fQorCit2b2lkIE1lZGlhQ29udHJvbHM6OmNoYW5nZWRWb2x1bWUoKQoreworICAgIHVwZGF0ZSgp OworfQorCit2b2lkIE1lZGlhQ29udHJvbHM6OmNoYW5nZWRDbG9zZWRDYXB0aW9uc1Zpc2liaWxp dHkoKQoreworICAgIHVwZGF0ZSgpOworfQorCiB2b2lkIE1lZGlhQ29udHJvbHM6OnVwZGF0ZVN0 eWxlKCkKIHsKICAgICBpZiAoIW1fY29udHJvbHNTaGFkb3dSb290KQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9scy5oIGIvU291cmNlL1dlYkNvcmUv aHRtbC9zaGFkb3cvTWVkaWFDb250cm9scy5oCmluZGV4IDk4ZTAxN2Y5ZGJkMmQzOTY3MmNkY2Fk ZWZkYTkzMWJmMjRlY2FiOTkuLmE5ZjQyYTNmYzQyZGQxZWVhZWZjOTMzZjczYWUzOTI2MTExZjJj YTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01lZGlhQ29udHJvbHMu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xzLmgKQEAgLTYy LDYgKzYyLDExIEBAIGNsYXNzIE1lZGlhQ29udHJvbHMgewogcHVibGljOgogICAgIE1lZGlhQ29u dHJvbHMoSFRNTE1lZGlhRWxlbWVudCopOwogCisgICAgdm9pZCByZXNldCgpOworICAgIHZvaWQg Y2hhbmdlZE11dGUoKTsKKyAgICB2b2lkIGNoYW5nZWRWb2x1bWUoKTsKKyAgICB2b2lkIGNoYW5n ZWRDbG9zZWRDYXB0aW9uc1Zpc2liaWxpdHkoKTsKKwogICAgIHZvaWQgZGVzdHJveSgpOwogICAg IHZvaWQgdXBkYXRlKCk7CiAgICAgdm9pZCB1cGRhdGVTdHlsZSgpOwo=