56009 2011-03-09 04:15:55 -0800 JavaNPObject should not use JNI directly 2011-03-09 11:14:34 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 55383 1 steveblock webkit-unassigned andreip jorlow steveblock oldest_to_newest 364423 0 steveblock 2011-03-09 04:15:55 -0800 JavaNPObject should not know about JNI. Instead it should make calls to Java through JavaInstance, which will in turn use JNI to access Java. This will allow us to factor out a JavaInstance interface which is independent of JNI. See Bug 55383. 364452 1 85165 steveblock 2011-03-09 05:40:44 -0800 Created attachment 85165 Patch 364549 2 andreip 2011-03-09 09:52:38 -0800 LGTM 364557 3 85165 jorlow 2011-03-09 10:01:21 -0800 Comment on attachment 85165 Patch r(ubber stamp)=me 364634 4 steveblock 2011-03-09 11:14:34 -0800 Committed r80653: <http://trac.webkit.org/changeset/80653> 85165 2011-03-09 05:40:44 -0800 2011-03-09 10:01:20 -0800 Patch bug-56009-20110309134042.patch text/plain 3514 steveblock U3VidmVyc2lvbiBSZXZpc2lvbjogODA2MzUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwMzAzZWY5MTdiYzQzOWUz NDE2OTRmZDIxY2ZmYzViYzE0MjM2MTBiLi5iNTk1MDc5OTk1MjM0OWFmZDgzYmUxYzhiZjFiYmJm MGY0NDE3MjhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDMtMDkgIFN0ZXZl IEJsb2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEphdmFOUE9iamVjdCBzaG91bGQgbm90IHVzZSBKTkkg ZGlyZWN0bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU2MDA5CisKKyAgICAgICAgV2UgbW92ZSB0aGUgSk5JIGNvZGUgdG8gYWNjZXNzIGEgSmF2YSBv YmplY3QncyBmaWVsZHMgaW50bworICAgICAgICBhIG5ldyBKYXZhSW5zdGFuY2U6OmdldEZpZWxk KCkgbWV0aG9kLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgcmVmYWN0b3Jpbmcgb25seS4KKwor ICAgICAgICAqIGJyaWRnZS9qbmkvdjgvSmF2YUluc3RhbmNlVjguY3BwOgorICAgICAgICAoSmF2 YUluc3RhbmNlOjpnZXRGaWVsZCk6CisgICAgICAgICogYnJpZGdlL2puaS92OC9KYXZhSW5zdGFu Y2VWOC5oOgorICAgICAgICAqIGJyaWRnZS9qbmkvdjgvSmF2YU5QT2JqZWN0VjguY3BwOgorICAg ICAgICAoSlNDOjpCaW5kaW5nczo6SmF2YU5QT2JqZWN0R2V0UHJvcGVydHkpOgorCiAyMDExLTAz LTA4ICBIYW5zIFdlbm5ib3JnICA8aGFuc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgSmVyZW15IE9ybG93LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYnJpZGdlL2pu aS92OC9KYXZhSW5zdGFuY2VWOC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9icmlkZ2Uvam5pL3Y4L0ph dmFJbnN0YW5jZVY4LmNwcAppbmRleCBkMmE1ZDYzNDI0N2JkYzljMThmYzc2NzRhZjg2YzMzY2Nh NDk3MWViLi44NjYyYmRmODY1OTUwZGQyMGFiMTNkMTk5MWRjOThmMjI1OGFlZDEyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9icmlkZ2Uvam5pL3Y4L0phdmFJbnN0YW5jZVY4LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9icmlkZ2Uvam5pL3Y4L0phdmFJbnN0YW5jZVY4LmNwcApAQCAtMjks NiArMjksNyBAQAogCiAjaWYgRU5BQkxFKEpBVkFfQlJJREdFKQogCisjaW5jbHVkZSAiSmF2YUZp ZWxkVjguaCIKICNpbmNsdWRlICJKYXZhTWV0aG9kLmgiCiAjaW5jbHVkZSAiSk5JVXRpbGl0eVBy aXZhdGUuaCIKICNpbmNsdWRlICJKYXZhQ2xhc3NWOC5oIgpAQCAtMTEwLDQgKzExMSwxMCBAQCBi b29sIEphdmFJbnN0YW5jZTo6aW52b2tlTWV0aG9kKGNvbnN0IGNoYXIqIG1ldGhvZE5hbWUsIGNv bnN0IE5QVmFyaWFudCogYXJncywgaQogICAgIHJldHVybiB0cnVlOwogfQogCitqdmFsdWUgSmF2 YUluc3RhbmNlOjpnZXRGaWVsZChjb25zdCBKYXZhRmllbGQqIGZpZWxkKQoreworICAgIEFTU0VS VChnZXRDbGFzcygpLT5maWVsZE5hbWVkKGZpZWxkLT5uYW1lKCkudXRmOCgpKSA9PSBmaWVsZCk7 CisgICAgcmV0dXJuIGdldEpOSUZpZWxkKGphdmFJbnN0YW5jZSgpLCBmaWVsZC0+Z2V0Sk5JVHlw ZSgpLCBmaWVsZC0+bmFtZSgpLnV0ZjgoKSwgZmllbGQtPnR5cGUoKSk7Cit9CisKICNlbmRpZiAv LyBFTkFCTEUoSkFWQV9CUklER0UpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9icmlkZ2Uv am5pL3Y4L0phdmFJbnN0YW5jZVY4LmggYi9Tb3VyY2UvV2ViQ29yZS9icmlkZ2Uvam5pL3Y4L0ph dmFJbnN0YW5jZVY4LmgKaW5kZXggOGVlMzE5NTYyMDc5NzgyOTFiNjEyZDFjYTRkYmE0MDFhZDc1 OGY0MC4uNmVkYzBjYmM0ZGJmNmFhZTcwMDA2ZDA0ZWJlZWM1NTY4N2UzMGEyZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvYnJpZGdlL2puaS92OC9KYXZhSW5zdGFuY2VWOC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2JyaWRnZS9qbmkvdjgvSmF2YUluc3RhbmNlVjguaApAQCAtNDMsNiArNDMs NyBAQCBuYW1lc3BhY2UgSlNDIHsKIG5hbWVzcGFjZSBCaW5kaW5ncyB7CiAKIGNsYXNzIEphdmFD bGFzczsKK2NsYXNzIEphdmFGaWVsZDsKIAogY2xhc3MgSmF2YUluc3RhbmNlIDogcHVibGljIFJl ZkNvdW50ZWQ8SmF2YUluc3RhbmNlPiB7CiBwdWJsaWM6CkBAIC01Miw2ICs1Myw3IEBAIHB1Ymxp YzoKICAgICBKYXZhQ2xhc3MqIGdldENsYXNzKCkgY29uc3Q7CiAKICAgICBib29sIGludm9rZU1l dGhvZChjb25zdCBjaGFyKiBuYW1lLCBjb25zdCBOUFZhcmlhbnQqIGFyZ3MsIGludCBhcmdzQ291 bnQsIE5QVmFyaWFudCogcmVzdWx0KTsKKyAgICBqdmFsdWUgZ2V0RmllbGQoY29uc3QgSmF2YUZp ZWxkKik7CiAKICAgICBqb2JqZWN0IGphdmFJbnN0YW5jZSgpIGNvbnN0IHsgcmV0dXJuIG1faW5z dGFuY2UtPm1faW5zdGFuY2U7IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYnJpZGdl L2puaS92OC9KYXZhTlBPYmplY3RWOC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9icmlkZ2Uvam5pL3Y4 L0phdmFOUE9iamVjdFY4LmNwcAppbmRleCA5Njg5YTk5ZWEyYWFiZTVkZDcwOTQyZDgxYjUzNTk1 NmE3MzI1ZTYyLi4yOWU4OWVmZTBjNTgyODEwYjcyNzI0ZTFmNzQ3MGE0Yzg3NjNiZWU3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9icmlkZ2Uvam5pL3Y4L0phdmFOUE9iamVjdFY4LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9icmlkZ2Uvam5pL3Y4L0phdmFOUE9iamVjdFY4LmNwcApAQCAt MTUwLDE2ICsxNTAsMTIgQEAgYm9vbCBKYXZhTlBPYmplY3RHZXRQcm9wZXJ0eShOUE9iamVjdCog b2JqLCBOUElkZW50aWZpZXIgaWRlbnRpZmllciwgTlBWYXJpYW50KgogCiAgICAgaW5zdGFuY2Ut PmJlZ2luKCk7CiAgICAgSmF2YUZpZWxkKiBmaWVsZCA9IGluc3RhbmNlLT5nZXRDbGFzcygpLT5m aWVsZE5hbWVkKG5hbWUpOwotICAgIGluc3RhbmNlLT5lbmQoKTsKICAgICBmcmVlKG5hbWUpOyAv LyBUT0RPOiB1c2UgTlBOX01lbUZyZWUKLQogICAgIGlmICghZmllbGQpCiAgICAgICAgIHJldHVy biBmYWxzZTsKIAotICAgIGp2YWx1ZSB2YWx1ZSA9IGdldEpOSUZpZWxkKGluc3RhbmNlLT5qYXZh SW5zdGFuY2UoKSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmaWVsZC0+Z2V0Sk5J VHlwZSgpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZpZWxkLT5uYW1lKCkudXRm OCgpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZpZWxkLT50eXBlKCkpOworICAg IGp2YWx1ZSB2YWx1ZSA9IGluc3RhbmNlLT5nZXRGaWVsZChmaWVsZCk7CisgICAgaW5zdGFuY2Ut PmVuZCgpOwogCiAgICAgY29udmVydEpWYWx1ZVRvTlBWYXJpYW50KHZhbHVlLCBmaWVsZC0+Z2V0 Sk5JVHlwZSgpLCBmaWVsZC0+dHlwZSgpLCByZXN1bHQpOwogCg==