55936 2011-03-08 05:03:12 -0800 old-run-webkit-tests should ignore test files used by reftests 2012-01-17 08:12:11 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 67936 36065 1 hayato webkit-unassigned dpranke hamaji ojan oldest_to_newest 363932 0 hayato 2011-03-08 05:03:12 -0800 Please see the master bug for the rationale: https://bugs.webkit.org/show_bug.cgi?id=36065 We are updating new-run-webkit-tests to support reftests. A old-run-webkit-tests should ignore test files used by reftests to avoid unexpected errors. 364290 1 85126 hayato 2011-03-08 19:23:58 -0800 Created attachment 85126 ignore-reftests 364331 2 85126 ojan 2011-03-08 23:07:42 -0800 Comment on attachment 85126 ignore-reftests View in context: https://bugs.webkit.org/attachment.cgi?id=85126&action=review Might want to wait until bug 55457 is r+'ed to make sure that none of the paths will change. > Tools/Scripts/old-run-webkit-tests:2460 > + extra line break 364404 3 hayato 2011-03-09 03:33:35 -0800 Hi Ojan, Thank you for the review. I'll fix the extra line break and land this after 55457 is r+'ed. (In reply to comment #2) > (From update of attachment 85126 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=85126&action=review > > Might want to wait until bug 55457 is r+'ed to make sure that none of the paths will change. > > > Tools/Scripts/old-run-webkit-tests:2460 > > + > > extra line break 368250 4 hayato 2011-03-16 00:51:38 -0700 Committed r81225: <http://trac.webkit.org/changeset/81225> 85126 2011-03-08 19:23:58 -0800 2011-03-08 23:07:42 -0800 ignore-reftests bug-55936-20110309122355.patch text/plain 1973 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogODA1MzkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxYTVkMzU4ZTZkODlmMmUxOTcyNzg5YjVlOTM0YTliOGY0 ZmIyNDNiLi5kNzQ3ODg4ZTMwYmI0NDViZjQ2NDI1MmEwYThjYjZmNTFiMTE4MDM4IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDMtMDggIEhheWF0byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElnbm9yZSBmaWxlcyB0 aGF0IHdpbGwgYmUgdXNlZCBieSByZWZ0ZXN0cyBpbiBvbGQtcnVuLXdlYmtpdC10ZXN0cy4KKwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU5MzYKKwor ICAgICAgICAqIFNjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHM6CisKIDIwMTEtMDMtMDcgIE9q YW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFt IEJhcnRoLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cyBi L1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKaW5kZXggYTBjOWQyMTc5MGIwZjU1 Yjk5NDM1ZjAyMmU5NWQzMmMwY2VmYzgxYi4uMmY0M2MwOWFmODIwZWI2YWNmMzUyNGJkZGY4ZTBm MjZjODBkNzEyNCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0 cworKysgYi9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCkBAIC0xODcsNiArMTg3 LDcgQEAgJHRlc3RIVFRQID0gMCBpZiAoaXNXeCgpKTsKIG15ICRwZXJsSW50ZXJwcmV0ZXIgPSAi cGVybCI7CiAKIG15ICRleHBlY3RlZFRhZyA9ICJleHBlY3RlZCI7CitteSAkbWlzbWF0Y2hUYWcg PSAibWlzbWF0Y2giOwogbXkgJGFjdHVhbFRhZyA9ICJhY3R1YWwiOwogbXkgJHByZXR0eURpZmZU YWcgPSAicHJldHR5LWRpZmYiOwogbXkgJGRpZmZzVGFnID0gImRpZmZzIjsKQEAgLTI0NDYsNiAr MjQ0NywxNyBAQCBzdWIgcmVhZFNraXBwZWRGaWxlcygkKQogCiBteSBAdGVzdHNGb3VuZDsKIAor c3ViIGlzVXNlZEluUmVmdGVzdAoreworICAgIG15ICRmaWxlbmFtZSA9ICRfOworICAgIGlmICgk ZmlsZW5hbWUgPX4gLy0kZXhwZWN0ZWRUYWcoLSRtaXNtYXRjaFRhZyk/XC5odG1sJC8pIHsKKyAg ICAgICAgcmV0dXJuIDE7CisgICAgfQorICAgIG15ICRiYXNlID0gc3RyaXBFeHRlbnNpb24oJGZp bGVuYW1lKTsKKyAgICByZXR1cm4gKC1mICIkYmFzZS0kZXhwZWN0ZWRUYWcuaHRtbCIgfHwgLWYg IiRiYXNlLSRleHBlY3RlZFRhZy0kbWlzbWF0Y2hUYWcuaHRtbCIpOworfQorCisKIHN1YiBkaXJl Y3RvcnlGaWx0ZXIKIHsKICAgICByZXR1cm4gKCkgaWYgZXhpc3RzICRpZ25vcmVkTG9jYWxEaXJl Y3Rvcmllc3tiYXNlbmFtZSgkRmlsZTo6RmluZDo6ZGlyKX07CkBAIC0yNDU3LDcgKzI0NjksOCBA QCBzdWIgZmlsZUZpbHRlcgogewogICAgIG15ICRmaWxlbmFtZSA9ICRfOwogICAgIGlmICgkZmls ZW5hbWUgPX4gL1wuKFteLl0rKSQvKSB7Ci0gICAgICAgIGlmIChleGlzdHMgJHN1cHBvcnRlZEZp bGVFeHRlbnNpb25zeyQxfSkgeworICAgICAgICBteSAkZXh0ZW5zaW9uID0gJDE7CisgICAgICAg IGlmIChleGlzdHMgJHN1cHBvcnRlZEZpbGVFeHRlbnNpb25zeyRleHRlbnNpb259ICYmICFpc1Vz ZWRJblJlZnRlc3QoJGZpbGVuYW1lKSkgewogICAgICAgICAgICAgbXkgJHBhdGggPSBGaWxlOjpT cGVjLT5hYnMycmVsKGNhdGZpbGUoJEZpbGU6OkZpbmQ6OmRpciwgJGZpbGVuYW1lKSwgJHRlc3RE aXJlY3RvcnkpOwogICAgICAgICAgICAgcHVzaCBAdGVzdHNGb3VuZCwgJHBhdGggaWYgIWV4aXN0 cyAkaWdub3JlZEZpbGVzeyRwYXRofTsKICAgICAgICAgfQo=