55934 2011-03-08 04:22:44 -0800 [GTK] Implement ResourceRequest and ResourceResponse encoder/decoder 2011-06-16 09:03:31 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 alex webkit-unassigned mrobinson svillar sy302.park webkit.review.bot oldest_to_newest 363929 0 alex 2011-03-08 04:22:44 -0800 We have to implement the proper encoder and decoder to make the policy work, currently we just have a stub to make the communication work, check: - Source/WebKit2/Shared/gtk/WebCoreArgumentCodersGtk.cpp 421052 1 sy302.park 2011-06-14 23:32:27 -0700 Would you like to make patch for this bug? if not, can I make it? 421078 2 alex 2011-06-15 00:09:48 -0700 (In reply to comment #1) > Would you like to make patch for this bug? if not, can I make it? Please go ahead :), thanks. 421168 3 97270 sy302.park 2011-06-15 03:41:32 -0700 Created attachment 97270 patch for ResourceRequest and ResourceResponse encoder/decoder 421327 4 mrobinson 2011-06-15 08:51:55 -0700 CCing svillar who might have some opinions about whether or not it be good to do this with gvariant. 421954 5 svillar 2011-06-16 07:53:37 -0700 (In reply to comment #4) > CCing svillar who might have some opinions about whether or not it be good to do this with gvariant. I'd say, if we have tools in WebKit to do it then let's do it that way. Doing it with GVariant wouldn't outcome simpler code. 421961 6 97270 mrobinson 2011-06-16 08:14:33 -0700 Comment on attachment 97270 patch for ResourceRequest and ResourceResponse encoder/decoder Okay. Seems sane! 421984 7 97270 webkit.review.bot 2011-06-16 09:03:27 -0700 Comment on attachment 97270 patch for ResourceRequest and ResourceResponse encoder/decoder Clearing flags on attachment: 97270 Committed r89030: <http://trac.webkit.org/changeset/89030> 421985 8 webkit.review.bot 2011-06-16 09:03:31 -0700 All reviewed patches have been landed. Closing bug. 97270 2011-06-15 03:41:32 -0700 2011-06-16 09:03:27 -0700 patch for ResourceRequest and ResourceResponse encoder/decoder patch text/plain 7300 sy302.park SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4OTE1KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDYtMTUgIFNhbmd5b25n IFBhcmsgIDxzeTMwMi5wYXJrQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBJbXBsZW1lbnQgUmVzb3VyY2VSZXF1ZXN0IGFu ZCBSZXNvdXJjZVJlc3BvbnNlIGVuY29kZXIvZGVjb2RlcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU5MzQKKworICAgICAgICAqIFNoYXJlZC9ndGsv V2ViQ29yZUFyZ3VtZW50Q29kZXJzR3RrLmNwcDoKKyAgICAgICAgKENvcmVJUEM6OmVuY29kZVJl c291cmNlUmVxdWVzdCk6CisgICAgICAgIChDb3JlSVBDOjpkZWNvZGVSZXNvdXJjZVJlcXVlc3Qp OgorICAgICAgICAoQ29yZUlQQzo6ZW5jb2RlUmVzb3VyY2VSZXNwb25zZSk6CisgICAgICAgIChD b3JlSVBDOjpkZWNvZGVSZXNvdXJjZVJlc3BvbnNlKToKKwogMjAxMS0wNi0xNCAgRXVubWkgTGVl ICA8ZXVubWkxNS5sZWVAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdl aW5pZy4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9ndGsvV2ViQ29yZUFyZ3VtZW50Q29k ZXJzR3RrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvZ3RrL1dlYkNv cmVBcmd1bWVudENvZGVyc0d0ay5jcHAJKHJldmlzaW9uIDg4OTE0KQorKysgU291cmNlL1dlYktp dDIvU2hhcmVkL2d0ay9XZWJDb3JlQXJndW1lbnRDb2RlcnNHdGsuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yNSwzOSArMjUsMTYzIEBACiAgKi8KIAogI2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1 ZGUgIlJlc291cmNlUmVxdWVzdC5oIgogI2luY2x1ZGUgIldlYkNvcmVBcmd1bWVudENvZGVycy5o IgogCi0jaW5jbHVkZSA8V2ViQ29yZS9Ob3RJbXBsZW1lbnRlZC5oPgotCiBuYW1lc3BhY2UgQ29y ZUlQQyB7CiAKIHZvaWQgZW5jb2RlUmVzb3VyY2VSZXF1ZXN0KEFyZ3VtZW50RW5jb2RlciogZW5j b2RlciwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiByZXNvdXJjZVJlcXVlc3QpCiB7 Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICBlbmNvZGVyLT5lbmNvZGUoQ29yZUlQQzo6SW4o cmVzb3VyY2VSZXF1ZXN0LnVybCgpLnN0cmluZygpKSk7CisgICAgZW5jb2Rlci0+ZW5jb2RlKENv cmVJUEM6OkluKHJlc291cmNlUmVxdWVzdC5odHRwTWV0aG9kKCkpKTsKKworICAgIGNvbnN0IFdl YkNvcmU6OkhUVFBIZWFkZXJNYXAmIGhlYWRlcnMgPSByZXNvdXJjZVJlcXVlc3QuaHR0cEhlYWRl ckZpZWxkcygpOworICAgIGVuY29kZXItPmVuY29kZShDb3JlSVBDOjpJbihzdGF0aWNfY2FzdDx1 aW50MzJfdD4oaGVhZGVycy5zaXplKCkpKSk7CisgICAgaWYgKCFoZWFkZXJzLmlzRW1wdHkoKSkg eworICAgICAgICBXZWJDb3JlOjpIVFRQSGVhZGVyTWFwOjpjb25zdF9pdGVyYXRvciBlbmQgPSBo ZWFkZXJzLmVuZCgpOworICAgICAgICBmb3IgKFdlYkNvcmU6OkhUVFBIZWFkZXJNYXA6OmNvbnN0 X2l0ZXJhdG9yIGl0ID0gaGVhZGVycy5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpCisgICAgICAg ICAgICBlbmNvZGVyLT5lbmNvZGUoQ29yZUlQQzo6SW4oaXQtPmZpcnN0LCBpdC0+c2Vjb25kKSk7 CisgICAgfQorCisgICAgV2ViQ29yZTo6Rm9ybURhdGEqIGh0dHBCb2R5ID0gcmVzb3VyY2VSZXF1 ZXN0Lmh0dHBCb2R5KCk7CisgICAgZW5jb2Rlci0+ZW5jb2RlKENvcmVJUEM6OkluKHN0YXRpY19j YXN0PGJvb2w+KGh0dHBCb2R5KSkpOworICAgIGlmIChodHRwQm9keSkKKyAgICAgICAgZW5jb2Rl ci0+ZW5jb2RlKENvcmVJUEM6OkluKGh0dHBCb2R5LT5mbGF0dGVuVG9TdHJpbmcoKSkpOworCisg ICAgZW5jb2Rlci0+ZW5jb2RlKENvcmVJUEM6OkluKHJlc291cmNlUmVxdWVzdC5maXJzdFBhcnR5 Rm9yQ29va2llcygpLnN0cmluZygpKSk7CisgICAgZW5jb2Rlci0+ZW5jb2RlKENvcmVJUEM6Oklu KHN0YXRpY19jYXN0PHVpbnQzMl90PihyZXNvdXJjZVJlcXVlc3Quc291cE1lc3NhZ2VGbGFncygp KSkpOwogfQogCiBib29sIGRlY29kZVJlc291cmNlUmVxdWVzdChBcmd1bWVudERlY29kZXIqIGRl Y29kZXIsIFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYgcmVzb3VyY2VSZXF1ZXN0KQogewotICAg IG5vdEltcGxlbWVudGVkKCk7CisgICAgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0IHJlcXVlc3Q7 CiAKLSAgICAvLyBGSVhNRTogQWRkIHJlYWwgaW1wbGVtZW50YXRpb24gd2hlbiB3ZSB3YW50IHRv IGltcGxlbWVudCBzb21ldGhpbmcgdGhhdAotICAgIC8vIGRlcGVuZHMgb24gdGhpcyBsaWtlIHRo ZSBwb2xpY3kgY2xpZW50LgotICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01NTkzNAotICAgIHJlc291cmNlUmVxdWVzdCA9IFdlYkNvcmU6OlJlc291cmNlUmVx dWVzdCgpOworICAgIFN0cmluZyB1cmw7CisgICAgaWYgKCFkZWNvZGVyLT5kZWNvZGUoQ29yZUlQ Qzo6T3V0KHVybCkpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgcmVxdWVzdC5zZXRVUkwo V2ViQ29yZTo6S1VSTChXZWJDb3JlOjpLVVJMKCksIHVybCkpOworCisgICAgU3RyaW5nIGh0dHBN ZXRob2Q7CisgICAgaWYgKCFkZWNvZGVyLT5kZWNvZGUoQ29yZUlQQzo6T3V0KGh0dHBNZXRob2Qp KSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIHJlcXVlc3Quc2V0SFRUUE1ldGhvZChodHRw TWV0aG9kKTsKKworICAgIHVpbnQzMl90IHNpemU7CisgICAgaWYgKCFkZWNvZGVyLT5kZWNvZGUo Q29yZUlQQzo6T3V0KHNpemUpKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIGlmIChzaXpl KSB7CisgICAgICAgIEF0b21pY1N0cmluZyBuYW1lOworICAgICAgICBTdHJpbmcgdmFsdWU7Cisg ICAgICAgIGZvciAodWludDMyX3QgaSA9IDA7IGkgPCBzaXplOyArK2kpIHsKKyAgICAgICAgICAg IGlmICghZGVjb2Rlci0+ZGVjb2RlKENvcmVJUEM6Ok91dChuYW1lLCB2YWx1ZSkpKQorICAgICAg ICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgICAgIHJlcXVlc3Quc2V0SFRUUEhlYWRl ckZpZWxkKG5hbWUsIHZhbHVlKTsKKyAgICAgICAgfQorICAgIH0KKworICAgIGJvb2wgaGFzSFRU UEJvZHk7CisgICAgaWYgKCFkZWNvZGVyLT5kZWNvZGUoQ29yZUlQQzo6T3V0KGhhc0hUVFBCb2R5 KSkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICBpZiAoaGFzSFRUUEJvZHkpIHsKKyAgICAg ICAgU3RyaW5nIGh0dHBCb2R5OworICAgICAgICBpZiAoIWRlY29kZXItPmRlY29kZShDb3JlSVBD OjpPdXQoaHR0cEJvZHkpKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgcmVx dWVzdC5zZXRIVFRQQm9keShXZWJDb3JlOjpGb3JtRGF0YTo6Y3JlYXRlKGh0dHBCb2R5LnV0Zjgo KSkpOworICAgIH0KKworICAgIFN0cmluZyBmaXJzdFBhcnR5Rm9yQ29va2llczsKKyAgICBpZiAo IWRlY29kZXItPmRlY29kZShDb3JlSVBDOjpPdXQoZmlyc3RQYXJ0eUZvckNvb2tpZXMpKSkKKyAg ICAgICAgcmV0dXJuIGZhbHNlOworICAgIHJlcXVlc3Quc2V0Rmlyc3RQYXJ0eUZvckNvb2tpZXMo V2ViQ29yZTo6S1VSTChXZWJDb3JlOjpLVVJMKCksIGZpcnN0UGFydHlGb3JDb29raWVzKSk7CisK KyAgICB1aW50MzJfdCBzb3VwTWVzc2FnZUZsYWdzOworICAgIGlmICghZGVjb2Rlci0+ZGVjb2Rl KENvcmVJUEM6Ok91dChzb3VwTWVzc2FnZUZsYWdzKSkpCisgICAgICAgIHJldHVybiBmYWxzZTsK KyAgICByZXF1ZXN0LnNldFNvdXBNZXNzYWdlRmxhZ3Moc3RhdGljX2Nhc3Q8U291cE1lc3NhZ2VG bGFncz4oc291cE1lc3NhZ2VGbGFncykpOworCisgICAgcmVzb3VyY2VSZXF1ZXN0ID0gcmVxdWVz dDsKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAogdm9pZCBlbmNvZGVSZXNvdXJjZVJlc3BvbnNlKEFy Z3VtZW50RW5jb2RlciogZW5jb2RlciwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZSYg cmVzb3VyY2VSZXNwb25zZSkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIGVuY29kZXIt PmVuY29kZShDb3JlSVBDOjpJbihyZXNvdXJjZVJlc3BvbnNlLnVybCgpLnN0cmluZygpKSk7Cisg ICAgZW5jb2Rlci0+ZW5jb2RlKENvcmVJUEM6OkluKHN0YXRpY19jYXN0PGludDMyX3Q+KHJlc291 cmNlUmVzcG9uc2UuaHR0cFN0YXR1c0NvZGUoKSkpKTsKKworICAgIGNvbnN0IFdlYkNvcmU6OkhU VFBIZWFkZXJNYXAmIGhlYWRlcnMgPSByZXNvdXJjZVJlc3BvbnNlLmh0dHBIZWFkZXJGaWVsZHMo KTsKKyAgICBlbmNvZGVyLT5lbmNvZGUoQ29yZUlQQzo6SW4oc3RhdGljX2Nhc3Q8dWludDMyX3Q+ KGhlYWRlcnMuc2l6ZSgpKSkpOworICAgIGlmICghaGVhZGVycy5pc0VtcHR5KCkpIHsKKyAgICAg ICAgV2ViQ29yZTo6SFRUUEhlYWRlck1hcDo6Y29uc3RfaXRlcmF0b3IgZW5kID0gaGVhZGVycy5l bmQoKTsKKyAgICAgICAgZm9yIChXZWJDb3JlOjpIVFRQSGVhZGVyTWFwOjpjb25zdF9pdGVyYXRv ciBpdCA9IGhlYWRlcnMuYmVnaW4oKTsgaXQgIT0gZW5kOyArK2l0KQorICAgICAgICAgICAgZW5j b2Rlci0+ZW5jb2RlKENvcmVJUEM6OkluKGl0LT5maXJzdCwgaXQtPnNlY29uZCkpOworICAgIH0K KworICAgIGVuY29kZXItPmVuY29kZShDb3JlSVBDOjpJbihzdGF0aWNfY2FzdDx1aW50MzJfdD4o cmVzb3VyY2VSZXNwb25zZS5zb3VwTWVzc2FnZUZsYWdzKCkpKSk7CisgICAgZW5jb2Rlci0+ZW5j b2RlKENvcmVJUEM6OkluKHJlc291cmNlUmVzcG9uc2UubWltZVR5cGUoKSkpOworICAgIGVuY29k ZXItPmVuY29kZShDb3JlSVBDOjpJbihyZXNvdXJjZVJlc3BvbnNlLnRleHRFbmNvZGluZ05hbWUo KSkpOworICAgIGVuY29kZXItPmVuY29kZShDb3JlSVBDOjpJbihzdGF0aWNfY2FzdDxpbnQ2NF90 PihyZXNvdXJjZVJlc3BvbnNlLmV4cGVjdGVkQ29udGVudExlbmd0aCgpKSkpOworICAgIGVuY29k ZXItPmVuY29kZShDb3JlSVBDOjpJbihyZXNvdXJjZVJlc3BvbnNlLmh0dHBTdGF0dXNUZXh0KCkp KTsKKyAgICBlbmNvZGVyLT5lbmNvZGUoQ29yZUlQQzo6SW4ocmVzb3VyY2VSZXNwb25zZS5zdWdn ZXN0ZWRGaWxlbmFtZSgpKSk7CiB9CiAKIGJvb2wgZGVjb2RlUmVzb3VyY2VSZXNwb25zZShBcmd1 bWVudERlY29kZXIqIGRlY29kZXIsIFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2UmIHJlc291cmNl UmVzcG9uc2UpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICBXZWJDb3JlOjpSZXNvdXJj ZVJlc3BvbnNlIHJlc3BvbnNlOworCisgICAgU3RyaW5nIHVybDsKKyAgICBpZiAoIWRlY29kZXIt PmRlY29kZShDb3JlSVBDOjpPdXQodXJsKSkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICBy ZXNwb25zZS5zZXRVUkwoV2ViQ29yZTo6S1VSTChXZWJDb3JlOjpLVVJMKCksIHVybCkpOworCisg ICAgaW50MzJfdCBodHRwU3RhdHVzQ29kZTsKKyAgICBpZiAoIWRlY29kZXItPmRlY29kZShDb3Jl SVBDOjpPdXQoaHR0cFN0YXR1c0NvZGUpKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIHJl c3BvbnNlLnNldEhUVFBTdGF0dXNDb2RlKGh0dHBTdGF0dXNDb2RlKTsKKworICAgIHVpbnQzMl90 IHNpemU7CisgICAgaWYgKCFkZWNvZGVyLT5kZWNvZGUoQ29yZUlQQzo6T3V0KHNpemUpKSkKKyAg ICAgICAgcmV0dXJuIGZhbHNlOworICAgIGlmIChzaXplKSB7CisgICAgICAgIEF0b21pY1N0cmlu ZyBuYW1lOworICAgICAgICBTdHJpbmcgdmFsdWU7CisgICAgICAgIGZvciAodWludDMyX3QgaSA9 IDA7IGkgPCBzaXplOyArK2kpIHsKKyAgICAgICAgICAgIGlmICghZGVjb2Rlci0+ZGVjb2RlKENv cmVJUEM6Ok91dChuYW1lLCB2YWx1ZSkpKQorICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsK KyAgICAgICAgICAgIHJlc3BvbnNlLnNldEhUVFBIZWFkZXJGaWVsZChuYW1lLCB2YWx1ZSk7Cisg ICAgICAgIH0KKyAgICB9CisKKyAgICB1aW50MzJfdCBzb3VwTWVzc2FnZUZsYWdzOworICAgIGlm ICghZGVjb2Rlci0+ZGVjb2RlKENvcmVJUEM6Ok91dChzb3VwTWVzc2FnZUZsYWdzKSkpCisgICAg ICAgIHJldHVybiBmYWxzZTsKKyAgICByZXNwb25zZS5zZXRTb3VwTWVzc2FnZUZsYWdzKHN0YXRp Y19jYXN0PFNvdXBNZXNzYWdlRmxhZ3M+KHNvdXBNZXNzYWdlRmxhZ3MpKTsKKworICAgIFN0cmlu ZyBtaW1lVHlwZTsKKyAgICBpZiAoIWRlY29kZXItPmRlY29kZShDb3JlSVBDOjpPdXQobWltZVR5 cGUpKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIHJlc3BvbnNlLnNldE1pbWVUeXBlKG1p bWVUeXBlKTsKKworICAgIFN0cmluZyB0ZXh0RW5jb2RpbmdOYW1lOworICAgIGlmICghZGVjb2Rl ci0+ZGVjb2RlKENvcmVJUEM6Ok91dCh0ZXh0RW5jb2RpbmdOYW1lKSkpCisgICAgICAgIHJldHVy biBmYWxzZTsKKyAgICByZXNwb25zZS5zZXRUZXh0RW5jb2RpbmdOYW1lKHRleHRFbmNvZGluZ05h bWUpOworCisgICAgaW50NjRfdCBjb250ZW50TGVuZ3RoOworICAgIGlmICghZGVjb2Rlci0+ZGVj b2RlKENvcmVJUEM6Ok91dChjb250ZW50TGVuZ3RoKSkpCisgICAgICAgIHJldHVybiBmYWxzZTsK KyAgICByZXNwb25zZS5zZXRFeHBlY3RlZENvbnRlbnRMZW5ndGgoY29udGVudExlbmd0aCk7CisK KyAgICBTdHJpbmcgaHR0cFN0YXR1c1RleHQ7CisgICAgaWYgKCFkZWNvZGVyLT5kZWNvZGUoQ29y ZUlQQzo6T3V0KGh0dHBTdGF0dXNUZXh0KSkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICBy ZXNwb25zZS5zZXRIVFRQU3RhdHVzVGV4dChodHRwU3RhdHVzVGV4dCk7CisKKyAgICBTdHJpbmcg c3VnZ2VzdGVkRmlsZW5hbWU7CisgICAgaWYgKCFkZWNvZGVyLT5kZWNvZGUoQ29yZUlQQzo6T3V0 KHN1Z2dlc3RlZEZpbGVuYW1lKSkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICByZXNwb25z ZS5zZXRTdWdnZXN0ZWRGaWxlbmFtZShzdWdnZXN0ZWRGaWxlbmFtZSk7CiAKLSAgICAvLyBGSVhN RTogRGl0dG8uCi0gICAgcmVzb3VyY2VSZXNwb25zZSA9IFdlYkNvcmU6OlJlc291cmNlUmVzcG9u c2UoKTsKKyAgICByZXNvdXJjZVJlc3BvbnNlID0gcmVzcG9uc2U7CiAgICAgcmV0dXJuIHRydWU7 CiB9Cg==