55907 2011-03-07 14:45:24 -0800 new-run-webkit-tests should upload crash logs 2011-06-28 08:19:53 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 63468 34984 1 dpranke abarth abarth aroben eric lforschler mrobinson oldest_to_newest 363601 0 dpranke 2011-03-07 14:45:24 -0800 old-run-webkit-tests now uploads crash logs; we need to modify new-run-webkit-tests to do the same. Quoting from an email to aroben@: On Mar 2, 2011, at 3:44 PM, Dirk Pranke wrote: > What did you need to change to make this happen? What do I need to add > to new-run-webkit-tests? There (thankfully) isn't very much code in old-run-webkit-tests to support this. The functions captureSavedCrashLogs and setUpWindowsCrashLogSaving and their callers/callees, plus the END block, are all that is required. 363647 1 eric 2011-03-07 15:48:46 -0800 If we wrote the code out nicely in webkitpy, we could easily expose commands (as part of webkit-patch or a separate tool) which ORWT could call, so that we could share a single python implementation instead of having two copies. :) 428339 2 98793 abarth 2011-06-27 14:59:01 -0700 Created attachment 98793 Patch 428357 3 98793 dpranke 2011-06-27 15:07:46 -0700 Comment on attachment 98793 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98793&action=review > Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:181 > + fs.write_text_file(filename, log if log else error) I just looked at the crashlogs.py module for the first time; does this actually work if you are running multiple DRTs at once? How do you know which pid generated the log? It looks like there is a timestamp and maybe some other number in the crash log filename; is that naming convention configurable, or is there some other way to get a pid into the filename? 428365 4 eric 2011-06-27 15:15:25 -0700 The pid is in the file. We could parse it out if necessary. I'm not sure we need to associate pid->crashlog yet though. 428369 5 dpranke 2011-06-27 15:18:31 -0700 (In reply to comment #4) > The pid is in the file. We could parse it out if necessary. I'm not sure we need to associate pid->crashlog yet though. Well, since there are multiple workers running in parallel, the risk is that you'll end up associating stacks with the wrong tests. I've certainly seen cases where we've had lots (or all) tests crashing at once, but maybe the break is so obvious that you only really need to see one stack to fix the problem? If the pid is in the crash file, it doesn't seem like it would be that much harder to pull it out ... 428372 6 98793 eric 2011-06-27 15:21:56 -0700 Comment on attachment 98793 Patch LGTM. I suspect we'll iterate from here. 428374 7 abarth 2011-06-27 15:23:18 -0700 There's a slight problem in that ReportCrash takes a very long time to run and the master gets bored and kills it. :( 428417 8 abarth 2011-06-27 16:05:42 -0700 Committed r89873: <http://trac.webkit.org/changeset/89873> 428434 9 98793 abarth 2011-06-27 16:27:00 -0700 Comment on attachment 98793 Patch I'm going to leave this bug closed, but there's going to be some follow up work because ReportCrash is super, duper slow and tricks us into think the test timed out. 428894 10 aroben 2011-06-28 08:19:53 -0700 Have other bugs been filed to cover the remaining work? (Waiting appropriately for ReportCrash, dealing with multiple concurrent crashes, making this work on Windows…) It seems wrong to close this bug if not. 98793 2011-06-27 14:59:01 -0700 2011-06-27 16:27:00 -0700 Patch bug-55907-20110627145900.patch text/plain 6565 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDg5ODYzKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTEtMDYtMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBuZXctcnVuLXdl YmtpdC10ZXN0cyBzaG91bGQgdXBsb2FkIGNyYXNoIGxvZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1OTA3CisKKyAgICAgICAgTlJXVCB1c2VkIHRv IGhhdmUgYSBkaWZmZXJlbnQgbmFtZSBmb3IgY3Jhc2ggbG9ncy4gIEkndmUgY2hhbmdlZCB0aGUK KyAgICAgICAgbmFtZSB0byBwYXRjaCBPUldULgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvdGVzdF9yZXN1bHRfd3JpdGVyLnB5OgorICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfaW50 ZWdyYXRpb250ZXN0LnB5OgorCiAyMDExLTA2LTI3ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtp dC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGlyayBQcmFua2UuCkluZGV4OiBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX2ludGVncmF0aW9u dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9ydW5fd2Via2l0X3Rlc3RzX2ludGVncmF0aW9udGVzdC5weQkocmV2aXNpb24gODk4NTQpCisr KyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX2lu dGVncmF0aW9udGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtNDE1LDYgKzQxNSwyMiBAQCBjbGFz cyBNYWluVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgICAgICBmaWxlc3lzdGVtPWZz KQogICAgICAgICBzZWxmLmFzc2VydFRydWUoZnMucmVhZF90ZXh0X2ZpbGUoJy90bXAvbGF5b3V0 LXRlc3QtcmVzdWx0cy91bmV4cGVjdGVkX3Jlc3VsdHMuanNvbicpLmZpbmQoJ3siY3Jhc2gtd2l0 aC1zdGRlcnIuaHRtbCI6eyJleHBlY3RlZCI6IlBBU1MiLCJhY3R1YWwiOiJDUkFTSCIsImhhc19z dGRlcnIiOnRydWV9fScpICE9IC0xKQogCisgICAgZGVmIHRlc3RfY3Jhc2hfbG9nKHNlbGYpOgor ICAgICAgICBtb2NrX2NyYXNoX3JlcG9ydCA9ICdtb2NrLWNyYXNoLXJlcG9ydCcKKyAgICAgICAg ZnMgPSBwb3J0LnVuaXRfdGVzdF9maWxlc3lzdGVtKCkKKyAgICAgICAgZnMud3JpdGVfdGV4dF9m aWxlKCcvVXNlcnMvbW9jay9MaWJyYXJ5L0xvZ3MvRGlhZ25vc3RpY1JlcG9ydHMvRHVtcFJlbmRl clRyZWVfMjAxMS0wNi0xMy0xNTA3MTlfcXVhZHplbi5jcmFzaCcsIG1vY2tfY3Jhc2hfcmVwb3J0 KQorICAgICAgICByZXMsIGJ1aWxkYm90X291dHB1dCwgcmVndWxhcl9vdXRwdXQsIHVzZXIgPSBs b2dnaW5nX3J1bihbCisgICAgICAgICAgICAgICAgJ2ZhaWx1cmVzL3VuZXhwZWN0ZWQvY3Jhc2gt d2l0aC1zdGRlcnIuaHRtbCcsCisgICAgICAgICAgICBdLAorICAgICAgICAgICAgdGVzdHNfaW5j bHVkZWQ9VHJ1ZSwKKyAgICAgICAgICAgIHJlY29yZF9yZXN1bHRzPVRydWUsCisgICAgICAgICAg ICBmaWxlc3lzdGVtPWZzKQorICAgICAgICBleHBlY3RlZF9jcmFzaF9sb2cgPSBtb2NrX2NyYXNo X3JlcG9ydAorICAgICAgICAjIEN1cnJlbnRseSBDcmFzaExvZyB1cGxvYWRpbmcgb25seSB3b3Jr cyBvbiBEYXJ3aW4uCisgICAgICAgIGlmIHN5cy5wbGF0Zm9ybSAhPSAiZGFyd2luIjoKKyAgICAg ICAgICAgIGV4cGVjdGVkX2NyYXNoX2xvZyA9ICJtb2NrLXN0ZC1lcnJvci1vdXRwdXQiCisgICAg ICAgIHNlbGYuYXNzZXJ0RXF1YWxzKGZzLnJlYWRfdGV4dF9maWxlKCcvdG1wL2xheW91dC10ZXN0 LXJlc3VsdHMvZmFpbHVyZXMvdW5leHBlY3RlZC9jcmFzaC13aXRoLXN0ZGVyci1jcmFzaC1sb2cu dHh0JyksIGV4cGVjdGVkX2NyYXNoX2xvZykKKwogICAgIGRlZiB0ZXN0X2V4aXRfYWZ0ZXJfbl9m YWlsdXJlc191cGxvYWQoc2VsZik6CiAgICAgICAgIGZzID0gcG9ydC51bml0X3Rlc3RfZmlsZXN5 c3RlbSgpCiAgICAgICAgIHJlcywgYnVpbGRib3Rfb3V0cHV0LCByZWd1bGFyX291dHB1dCwgdXNl ciA9IGxvZ2dpbmdfcnVuKFsKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfcmVzdWx0X3dyaXRlci5weQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS90ZXN0X3Jl c3VsdF93cml0ZXIucHkJKHJldmlzaW9uIDg5ODU0KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvdGVzdF9yZXN1bHRfd3JpdGVyLnB5CSh3b3Jr aW5nIGNvcHkpCkBAIC0zMCw2ICszMCw3IEBACiBpbXBvcnQgbG9nZ2luZwogaW1wb3J0IG9zCiAK K2Zyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5jcmFzaGxvZ3MgaW1wb3J0IENyYXNoTG9ncwog ZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMubGF5b3V0X3BhY2thZ2UgaW1wb3J0IHRlc3RfZmFp bHVyZXMKIAogCkBAIC0xMDAsNiArMTAxLDcgQEAgY2xhc3MgVGVzdFJlc3VsdFdyaXRlcihvYmpl Y3QpOgogICAgIEZJTEVOQU1FX1NVRkZJWF9FWFBFQ1RFRCA9ICItZXhwZWN0ZWQiCiAgICAgRklM RU5BTUVfU1VGRklYX0RJRkYgPSAiLWRpZmYiCiAgICAgRklMRU5BTUVfU1VGRklYX1NUREVSUiA9 ICItc3RkZXJyIgorICAgIEZJTEVOQU1FX1NVRkZJWF9DUkFTSF9MT0cgPSAiLWNyYXNoLWxvZyIK ICAgICBGSUxFTkFNRV9TVUZGSVhfV0RJRkYgPSAiLXdkaWZmLmh0bWwiCiAgICAgRklMRU5BTUVf U1VGRklYX1BSRVRUWV9QQVRDSCA9ICItcHJldHR5LWRpZmYuaHRtbCIKICAgICBGSUxFTkFNRV9T VUZGSVhfSU1BR0VfRElGRiA9ICItZGlmZi5wbmciCkBAIC0xNjcsMTEgKzE2OSwxNiBAQCBjbGFz cyBUZXN0UmVzdWx0V3JpdGVyKG9iamVjdCk6CiAgICAgICAgIGZzLndyaXRlX2JpbmFyeV9maWxl KGZpbGVuYW1lLCBlcnJvcikKIAogICAgIGRlZiB3cml0ZV9jcmFzaF9yZXBvcnQoc2VsZiwgZXJy b3IpOgotICAgICAgICAiIiJXcml0ZSBjcmFzaCBpbmZvcm1hdGlvbi4iIiIKICAgICAgICAgZnMg PSBzZWxmLl9wb3J0Ll9maWxlc3lzdGVtCi0gICAgICAgIGZpbGVuYW1lID0gc2VsZi5vdXRwdXRf ZmlsZW5hbWUoIi1zdGFjay50eHQiKQorICAgICAgICBmaWxlbmFtZSA9IHNlbGYub3V0cHV0X2Zp bGVuYW1lKHNlbGYuRklMRU5BTUVfU1VGRklYX0NSQVNIX0xPRyArICIudHh0IikKICAgICAgICAg ZnMubWF5YmVfbWFrZV9kaXJlY3RvcnkoZnMuZGlybmFtZShmaWxlbmFtZSkpCi0gICAgICAgIGZz LndyaXRlX3RleHRfZmlsZShmaWxlbmFtZSwgZXJyb3IpCisgICAgICAgICMgRklYTUU6IFdlIHNo b3VsZG4ndCBiZSBncmFiYmluZyBwcml2YXRlIG1lbWJlcnMgb2YgcG9ydC4KKyAgICAgICAgY3Jh c2hfbG9ncyA9IENyYXNoTG9ncyhzZWxmLl9wb3J0Ll9leGVjdXRpdmUsIGZzKQorICAgICAgICAj IEZJWE1FOiBXZSBuZWVkIHRvIGdldCB0aGUgZHJpdmVyIG5hbWUgZnJvbSBwb3J0LgorICAgICAg ICBsb2cgPSBjcmFzaF9sb2dzLmZpbmRfbmV3ZXN0X2xvZygiRHVtcFJlbmRlclRyZWUiKQorICAg ICAgICAjIENyYXNoTG9ncyBkb2Vzbid0IHN1cHBvcnQgZXZlcnkgcGxhdGZvcm0sIHNvIHdlIGZh bGwgYmFjayB0bworICAgICAgICAjIGluY2x1ZGluZyB0aGUgc3RkZXJyIG91dHB1dCwgd2hpY2gg aXMgYWRtaXR0ZWRseSBzb21ld2hhdCByZWR1bmRhbnQuCisgICAgICAgIGZzLndyaXRlX3RleHRf ZmlsZShmaWxlbmFtZSwgbG9nIGlmIGxvZyBlbHNlIGVycm9yKQogCiAgICAgZGVmIHdyaXRlX3Rl eHRfZmlsZXMoc2VsZiwgYWN0dWFsX3RleHQsIGV4cGVjdGVkX3RleHQpOgogICAgICAgICBzZWxm LndyaXRlX291dHB1dF9maWxlcygiLnR4dCIsIGFjdHVhbF90ZXh0LCBleHBlY3RlZF90ZXh0KQpJ bmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0No YW5nZUxvZwkocmV2aXNpb24gODk4NjMpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wNi0yNyAgQWRhbSBCYXJ0aCAgPGFiYXJ0 aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIG5ldy1ydW4td2Via2l0LXRlc3RzIHNob3VsZCB1cGxvYWQgY3Jhc2ggbG9ncworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU5MDcKKworICAg ICAgICAqIGZhc3QvaGFybmVzcy9yZXNvdXJjZXMvcmVzdWx0cy10ZXN0LmpzOgorICAgICAgICAq IGZhc3QvaGFybmVzcy9yZXN1bHRzLmh0bWw6CisKIDIwMTEtMDYtMjcgIEplc3NpZSBCZXJsaW4g IDxqYmVybGluQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgV2luZG93cy1zcGVjaWZpYyByZXN1 bHRzIGZvciB0aGUgdGVzdCBhZGRlZCBpbiByODk3NDUuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0 L2hhcm5lc3MvcmVzdWx0cy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvaGFy bmVzcy9yZXN1bHRzLmh0bWwJKHJldmlzaW9uIDg5ODUzKQorKysgTGF5b3V0VGVzdHMvZmFzdC9o YXJuZXNzL3Jlc3VsdHMuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtNTg4LDcgKzU4OCw3IEBAIGZ1 bmN0aW9uIHRlc3RMaXN0KHRlc3RzLCBoZWFkZXIsIHRhYmxlSWQKICAgICAgICAgZWxzZSBpZiAo dGFibGVJZCA9PSAncGFzc2VzLXRhYmxlJykKICAgICAgICAgICAgIGh0bWwgKz0gdGVzdE9iamVj dC5leHBlY3RlZDsKICAgICAgICAgZWxzZSBpZiAodGFibGVJZCA9PSAnY3Jhc2gtdGVzdHMtdGFi bGUnKQotICAgICAgICAgICAgaHRtbCArPSByZXN1bHRMaW5rKHN0cmlwRXh0ZW5zaW9uKHRlc3Qp LCAnLXN0YWNrLnR4dCcsICdjcmFzaCBzdGFjaycpOworICAgICAgICAgICAgaHRtbCArPSByZXN1 bHRMaW5rKHN0cmlwRXh0ZW5zaW9uKHRlc3QpLCAnLWNyYXNoLWxvZy50eHQnLCAnY3Jhc2ggbG9n Jyk7CiAgICAgICAgIGVsc2UgaWYgKHRhYmxlSWQgPT0gJ3RpbWVvdXQtdGVzdHMtdGFibGUnKSB7 CiAgICAgICAgICAgICAvLyBGSVhNRTogb25seSBpbmNsdWRlIHRpbWVvdXQgYWN0dWFsL2RpZmYg cmVzdWx0cyBoZXJlIGlmIHdlIGFjdHVhbGx5IHNwaXQgb3V0IHJlc3VsdHMgZm9yIHRpbWVvdXQg dGVzdHMuCiAgICAgICAgICAgICBodG1sICs9IHRleHRSZXN1bHRMaW5rcyhzdHJpcEV4dGVuc2lv bih0ZXN0KSk7CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvcmVzb3VyY2VzL3Jlc3Vs dHMtdGVzdC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvcmVzb3Vy Y2VzL3Jlc3VsdHMtdGVzdC5qcwkocmV2aXNpb24gODk4NTMpCisrKyBMYXlvdXRUZXN0cy9mYXN0 L2hhcm5lc3MvcmVzb3VyY2VzL3Jlc3VsdHMtdGVzdC5qcwkod29ya2luZyBjb3B5KQpAQCAtMTc0 LDcgKzE3NCw3IEBAIGZ1bmN0aW9uIHJ1blRlc3RzKCkKICAgICAgICAgYXNzZXJ0VHJ1ZShleHBl Y3RhdGlvblR5cGVzWzJdLnRleHRDb250ZW50ID09ICdJTUFHRScpOwogICAgICAgICAKICAgICAg ICAgYXNzZXJ0VHJ1ZShkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY3Jhc2gtdGVzdHMtdGFibGUn KSk7Ci0gICAgICAgIGFzc2VydFRydWUoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NyYXNoLXRl c3RzLXRhYmxlJykudGV4dENvbnRlbnQuaW5kZXhPZignc3RhY2snKSAhPSAtMSk7CisgICAgICAg IGFzc2VydFRydWUoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NyYXNoLXRlc3RzLXRhYmxlJyku dGV4dENvbnRlbnQuaW5kZXhPZignY3Jhc2ggbG9nJykgIT0gLTEpOwogICAgICAgICBhc3NlcnRU cnVlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0aW1lb3V0LXRlc3RzLXRhYmxlJykpOwogICAg ICAgICBhc3NlcnRUcnVlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0aW1lb3V0LXRlc3RzLXRh YmxlJykudGV4dENvbnRlbnQuaW5kZXhPZignZXhwZWN0ZWQgYWN0dWFsIGRpZmYnKSAhPSAtMSk7 CiAgICAgfSk7Cg==