55904 2011-03-07 13:45:06 -0800 selectionHasStyle should call selectionStartHasStyle when shouldToggleStyleBasedOnStartOfSelection 2017-07-18 08:29:48 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All NEW P2 Minor --- 55902 1 rniwa webkit-unassigned darin enrica eric tony oldest_to_newest 363554 0 rniwa 2011-03-07 13:45:06 -0800 Currently, EditorCommand is responsible for checking the value returned by shouldToggleStyleBasedOnStartOfSelection and calling either selectionHasStyle or selectionStartHasStyle. However, each port also calls selectionHasStyle in Source/WebKit without calling shouldToggleStyleBasedOnStartOfSelection and causing Mac port to behave inconsistently. We should merge these two functions so that selectionHasStyle calls selectionStartHasStyle as needed. 363832 1 rniwa 2011-03-07 22:46:51 -0800 Mn... this bug might be invalid after all. We do call selectionHasStyle in WebKit but only for text direction. And it seems odd to determine the direction of text merely based at the selection start.