<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>55806</bug_id>
          
          <creation_ts>2011-03-04 17:11:06 -0800</creation_ts>
          <short_desc>WebCore GYP build should Check For Inappropriate Files in Framework</short_desc>
          <delta_ts>2011-03-04 17:44:24 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>55018</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Barth">abarth</reporter>
          <assigned_to name="Adam Barth">abarth</assigned_to>
          <cc>dglazkov</cc>
    
    <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>362813</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-04 17:11:06 -0800</bug_when>
    <thetext>WebCore GYP build should Check For Inappropriate Files in Framework</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>362814</commentid>
    <comment_count>1</comment_count>
      <attachid>84834</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-04 17:11:39 -0800</bug_when>
    <thetext>Created attachment 84834
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>362819</commentid>
    <comment_count>2</comment_count>
      <attachid>84834</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-03-04 17:31:49 -0800</bug_when>
    <thetext>Comment on attachment 84834
Patch

This is correct. But this rule sucks.  It should remove the stuff and warn.  Otherwise these things stick around (erroring out your build!) until you clean build. :(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>362822</commentid>
    <comment_count>3</comment_count>
      <attachid>84834</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-04 17:44:20 -0800</bug_when>
    <thetext>Comment on attachment 84834
Patch

Clearing flags on attachment: 84834

Committed r80399: &lt;http://trac.webkit.org/changeset/80399&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>362823</commentid>
    <comment_count>4</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-04 17:44:24 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>84834</attachid>
            <date>2011-03-04 17:11:39 -0800</date>
            <delta_ts>2011-03-04 17:44:20 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-55806-20110304171138.patch</filename>
            <type>text/plain</type>
            <size>1804</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODAzOTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyNDAyNjdhOGE1NzQ1MTli
MTJmY2FkOWFlM2FjOTMyZGYyODljYmQzLi5iYjAzOWJjODUzMWQ1ODcxZTRhMzNiNThjNTI0NmVm
ZGRmMjI0MjZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTUgQEAKIAogICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBXZWJDb3JlIEdZUCBidWlsZCBzaG91bGQg
Q2hlY2sgRm9yIEluYXBwcm9wcmlhdGUgRmlsZXMgaW4gRnJhbWV3b3JrCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTgwNgorCisgICAgICAgICogZ3lw
L1dlYkNvcmUuZ3lwOgorCisyMDExLTAzLTA0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v
cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgV2Vi
Q29yZSBHWVAgYnVpbGQgc2hvdWxkIGxpa2Ugd2l0aCB0aGUgY29ycmVjdCBmcmFtZXdvcmtzCiAg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTgwNAogCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9neXAvV2ViQ29yZS5neXAgYi9Tb3VyY2UvV2ViQ29y
ZS9neXAvV2ViQ29yZS5neXAKaW5kZXggYmFhYjgzYWJhNTVkN2QyYzhlNzM4ZGVkYzYxYWM3NzVh
YzEyZTgxYi4uNzc2NDYzMGU5NmEwM2M3ZDY2ZTM5NWJlY2I0ZDY0MmFmNWExNGM3MyAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYkNvcmUvZ3lwL1dlYkNvcmUuZ3lwCisrKyBiL1NvdXJjZS9XZWJDb3Jl
L2d5cC9XZWJDb3JlLmd5cApAQCAtNDYsNiArNDYsNyBAQAogICAgICAgICAnPEAod2ViY29yZV9w
cml2YXRlaGVhZGVyX2ZpbGVzKScsCiAgICAgICBdLAogICAgICAgJ3hjb2RlX2NvbmZpZ19maWxl
JzogJy4uL0NvbmZpZ3VyYXRpb25zL1dlYkNvcmUueGNjb25maWcnLAorICAgICAgIyBGSVhNRTog
QSBudW1iZXIgb2YgdGhlc2UgYWN0aW9ucyBhcmVuJ3Qgc3VwcG9zZWQgdG8gcnVuIGlmICIke0FD
VElPTn0iID0gImluc3RhbGxoZHJzIgogICAgICAgJ3Bvc3RidWlsZHMnOiBbCiAgICAgICAgIHsK
ICAgICAgICAgICAncG9zdGJ1aWxkX25hbWUnOiAnQ2hlY2sgRm9yIEdsb2JhbCBJbml0aWFsaXpl
cnMnLApAQCAtNjUsNyArNjYsMTIgQEAKICAgICAgICAgICAgICdzaCcsICc8KERFUFRIKS9neXAv
cnVuLWlmLWV4aXN0cy5zaCcsICc8KERFUFRIKS8uLi9Ub29scy9TY3JpcHRzL2NoZWNrLWZvci13
ZWFrLXZ0YWJsZXMtYW5kLWV4dGVybmFscycKICAgICAgICAgICBdLAogICAgICAgICB9LAotICAg
ICAgICAjIEZJWE1FOiBBZGQgIkNoZWNrIGZvIEluYXBwcm9wcmlhdGUgRmlsZXMgaW4gRnJhbWV3
b3JrIi4KKyAgICAgICAgeworICAgICAgICAgICdwb3N0YnVpbGRfbmFtZSc6ICdDaGVjayBGb3Ig
SW5hcHByb3ByaWF0ZSBGaWxlcyBpbiBGcmFtZXdvcmsnLAorICAgICAgICAgICdhY3Rpb24nOiBb
CisgICAgICAgICAgICAnc2gnLCAnPChERVBUSCkvZ3lwL3J1bi1pZi1leGlzdHMuc2gnLCAnPChE
RVBUSCkvLi4vVG9vbHMvU2NyaXB0cy9jaGVjay1mb3ItaW5hcHByb3ByaWF0ZS1maWxlcy1pbi1m
cmFtZXdvcmsnCisgICAgICAgICAgXSwKKyAgICAgICAgfSwKICAgICAgIF0sCiAgICAgICAnY29u
ZGl0aW9ucyc6IFsKICAgICAgICAgWydPUz09Im1hYyInLCB7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>