55769 2011-03-04 05:39:40 -0800 Web Inspector: [Text editor] DOMNodeRemoved events are missing 2011-03-04 06:20:25 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 53588 0 aandrey webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr podivilov rik timothy yurys oldest_to_newest 362441 0 aandrey 2011-03-04 05:39:40 -0800 In WebKit the DOMNodeRemoved event is fired AFTER the node is removed, thus it should be attached to all DOM nodes that we want to track. Instead, we attach the DOMNodeRemoved listeners only on the line rows, and use DOMSubtreeModified to track node removals inside the line rows. For more info see: https://bugs.webkit.org/show_bug.cgi?id=55666 362442 1 84732 aandrey 2011-03-04 05:42:21 -0800 Created attachment 84732 Patch 362449 2 84732 podivilov 2011-03-04 06:20:13 -0800 Comment on attachment 84732 Patch Clearing flags on attachment: 84732 Committed r80346: <http://trac.webkit.org/changeset/80346> 362451 3 podivilov 2011-03-04 06:20:25 -0800 All reviewed patches have been landed. Closing bug. 84732 2011-03-04 05:42:21 -0800 2011-03-04 06:20:13 -0800 Patch bug-55769-20110304164219.patch text/plain 7472 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogODAxMjEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiODIzMzY0M2I3Y2M1NzQ3 NzhmMTI3NTEyODBlNDY2NTIyMDM2YWFlLi5iMjYzZmI4MzY3NjI0MWI3YjI3ZDRhYjUyODE1YTJl YTI5ODgyOTQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMDQgIEFuZHJl eSBBZGFpa2luICA8YWFuZHJleUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtUZXh0IGVkaXRvcl0gRE9N Tm9kZVJlbW92ZWQgZXZlbnRzIGFyZSBtaXNzaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTc2OQorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250 LWVuZC9UZXh0Vmlld2VyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JNYWlu UGFuZWwpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JNYWluUGFuZWwucHJvdG90 eXBlLl9oYW5kbGVET01VcGRhdGVzKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9y TWFpbkNodW5rKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpbkNodW5rLnBy b3RvdHlwZS5fY3JlYXRlUm93KToKKwogMjAxMS0wMy0wMSAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFZpZXdlci5qcyBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFZpZXdlci5qcwppbmRleCA5OGNk MGUxOTk5NTEyMjRiMGU0ZDA5MDMwMWU4ZGJkNWEyODkxNjBhLi4yZGE3MTVlMjk2ZTFkYzNiZjg4 ODgzMWQwNGY5ZDgzZmFiMjA4MzNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1RleHRWaWV3ZXIuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9UZXh0Vmlld2VyLmpzCkBAIC02NzcsNiArNjc3LDcgQEAgV2ViSW5zcGVjdG9y LlRleHRFZGl0b3JNYWluUGFuZWwgPSBmdW5jdGlvbih0ZXh0TW9kZWwsIHVybCwgc3luY1Njcm9s bExpc3RlbmVyLAogCiAgICAgdGhpcy5lbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgi ZGl2Iik7CiAgICAgdGhpcy5lbGVtZW50LmNsYXNzTmFtZSA9ICJ0ZXh0LWVkaXRvci1jb250ZW50 cyI7CisgICAgdGhpcy5lbGVtZW50LnRhYkluZGV4ID0gMDsKIAogICAgIHRoaXMuX2NvbnRhaW5l ciA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwogICAgIHRoaXMuX2NvbnRhaW5lci5j bGFzc05hbWUgPSAiaW5uZXItY29udGFpbmVyIjsKQEAgLTY4OSwxMyArNjkwLDE0IEBAIFdlYklu c3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVsID0gZnVuY3Rpb24odGV4dE1vZGVsLCB1cmwsIHN5 bmNTY3JvbGxMaXN0ZW5lciwKICAgICBpZiAoIVByZWZlcmVuY2VzLnNvdXJjZUVkaXRvckVuYWJs ZWQpCiAgICAgICAgIHRoaXMuX2NvbnRhaW5lci5hZGRFdmVudExpc3RlbmVyKCJrZXlkb3duIiwg dGhpcy5faGFuZGxlS2V5RG93bi5iaW5kKHRoaXMpLCBmYWxzZSk7CiAKLSAgICB2YXIgaGFuZGxl RE9NVXBkYXRlcyA9IHRoaXMuX2hhbmRsZURPTVVwZGF0ZXMuYmluZCh0aGlzKTsKLSAgICB0aGlz Ll9jb250YWluZXIuYWRkRXZlbnRMaXN0ZW5lcigiRE9NQ2hhcmFjdGVyRGF0YU1vZGlmaWVkIiwg aGFuZGxlRE9NVXBkYXRlcywgZmFsc2UpOwotICAgIHRoaXMuX2NvbnRhaW5lci5hZGRFdmVudExp c3RlbmVyKCJET01Ob2RlSW5zZXJ0ZWQiLCBoYW5kbGVET01VcGRhdGVzLCBmYWxzZSk7Ci0gICAg dGhpcy5fY29udGFpbmVyLmFkZEV2ZW50TGlzdGVuZXIoIkRPTU5vZGVSZW1vdmVkIiwgaGFuZGxl RE9NVXBkYXRlcywgZmFsc2UpOwotICAgIC8vIEZvciBzb21lIHJlYXNvbnMsIGluIGEgZmV3IGNv cm5lciBjYXNlcyB0aGUgZXZlbnRzIGFib3ZlIGFyZSBub3QgYWJsZSB0byBjYXRjaCB0aGUgZWRp dGluZ3MuCi0gICAgLy8gVG8gd29ya2Fyb3VuZCB0aGF0IHdlIGFsc28gbGlzdGVuIHRvIGEgbW9y ZSBnZW5lcmFsIGV2ZW50IGFzIGEgYmFja3VwLgotICAgIHRoaXMuX2NvbnRhaW5lci5hZGRFdmVu dExpc3RlbmVyKCJET01TdWJ0cmVlTW9kaWZpZWQiLCB0aGlzLl9oYW5kbGVET01TdWJ0cmVlTW9k aWZpZWQuYmluZCh0aGlzKSwgZmFsc2UpOworICAgIC8vIEluIFdlYktpdCB0aGUgRE9NTm9kZVJl bW92ZWQgZXZlbnQgaXMgZmlyZWQgQUZURVIgdGhlIG5vZGUgaXMgcmVtb3ZlZCwgdGh1cyBpdCBz aG91bGQgYmUKKyAgICAvLyBhdHRhY2hlZCB0byBhbGwgRE9NIG5vZGVzIHRoYXQgd2Ugd2FudCB0 byB0cmFjay4gSW5zdGVhZCwgd2UgYXR0YWNoIHRoZSBET01Ob2RlUmVtb3ZlZAorICAgIC8vIGxp c3RlbmVycyBvbmx5IG9uIHRoZSBsaW5lIHJvd3MsIGFuZCB1c2UgRE9NU3VidHJlZU1vZGlmaWVk IHRvIHRyYWNrIG5vZGUgcmVtb3ZhbHMgaW5zaWRlCisgICAgLy8gdGhlIGxpbmUgcm93cy4gRm9y IG1vcmUgaW5mbyBzZWU6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 NTY2NgorICAgIHRoaXMuX2hhbmRsZURPTVVwZGF0ZXNDYWxsYmFjayA9IHRoaXMuX2hhbmRsZURP TVVwZGF0ZXMuYmluZCh0aGlzKTsKKyAgICB0aGlzLl9jb250YWluZXIuYWRkRXZlbnRMaXN0ZW5l cigiRE9NQ2hhcmFjdGVyRGF0YU1vZGlmaWVkIiwgdGhpcy5faGFuZGxlRE9NVXBkYXRlc0NhbGxi YWNrLCBmYWxzZSk7CisgICAgdGhpcy5fY29udGFpbmVyLmFkZEV2ZW50TGlzdGVuZXIoIkRPTU5v ZGVJbnNlcnRlZCIsIHRoaXMuX2hhbmRsZURPTVVwZGF0ZXNDYWxsYmFjaywgZmFsc2UpOworICAg IHRoaXMuX2NvbnRhaW5lci5hZGRFdmVudExpc3RlbmVyKCJET01TdWJ0cmVlTW9kaWZpZWQiLCB0 aGlzLl9oYW5kbGVET01VcGRhdGVzQ2FsbGJhY2ssIGZhbHNlKTsKIAogICAgIHRoaXMuZnJlZUNh Y2hlZEVsZW1lbnRzKCk7CiAgICAgdGhpcy5fYnVpbGRDaHVua3MoKTsKQEAgLTExMjcsNzEgKzEx MjksMjEgQEAgV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JNYWluUGFuZWwucHJvdG90eXBlID0gewog ICAgICAgICBpZiAoIWxpbmVSb3cpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgaWYg KGxpbmVSb3cuZGVjb3JhdGlvbnNFbGVtZW50ICYmIGxpbmVSb3cuZGVjb3JhdGlvbnNFbGVtZW50 LmlzQW5jZXN0b3IodGFyZ2V0KSkgewotICAgICAgICAgICAgaWYgKHRoaXMuX3N5bmNEZWNvcmF0 aW9uc0ZvckxpbmVMaXN0ZW5lcikgewotICAgICAgICAgICAgICAgIC8vIFdhaXQgdW50aWwgdGhp cyBldmVudCBpcyBwcm9jZXNzZWQgYW5kIG9ubHkgdGhlbiBzeW5jIHRoZSBzaXplcy4gVGhpcyBp cyBuZWNlc3NhcnkgaW4KLSAgICAgICAgICAgICAgICAvLyBjYXNlIG9mIHRoZSBET01Ob2RlUmVt b3ZlZCBldmVudCwgYmVjYXVzZSBpdCBpcyBkaXNwYXRjaGVkIGJlZm9yZSB0aGUgcmVtb3ZhbCB0 YWtlcyBwbGFjZS4KLSAgICAgICAgICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgewotICAg ICAgICAgICAgICAgICAgICB0aGlzLl9zeW5jRGVjb3JhdGlvbnNGb3JMaW5lTGlzdGVuZXIobGlu ZVJvdy5saW5lTnVtYmVyKTsKLSAgICAgICAgICAgICAgICB9LmJpbmQodGhpcyksIDApOwotICAg ICAgICAgICAgfQorICAgICAgICBpZiAobGluZVJvdy5kZWNvcmF0aW9uc0VsZW1lbnQgJiYgKGxp bmVSb3cuZGVjb3JhdGlvbnNFbGVtZW50ID09PSB0YXJnZXQgfHwgbGluZVJvdy5kZWNvcmF0aW9u c0VsZW1lbnQuaXNBbmNlc3Rvcih0YXJnZXQpKSkgeworICAgICAgICAgICAgaWYgKHRoaXMuX3N5 bmNEZWNvcmF0aW9uc0ZvckxpbmVMaXN0ZW5lcikKKyAgICAgICAgICAgICAgICB0aGlzLl9zeW5j RGVjb3JhdGlvbnNGb3JMaW5lTGlzdGVuZXIobGluZVJvdy5saW5lTnVtYmVyKTsKICAgICAgICAg ICAgIHJldHVybjsKICAgICAgICAgfQogCiAgICAgICAgIGlmICh0aGlzLl9yZWFkT25seSkKICAg ICAgICAgICAgIHJldHVybjsKIAotICAgICAgICBpZiAodGFyZ2V0ID09PSBsaW5lUm93ICYmIChl LnR5cGUgPT09ICJET01Ob2RlSW5zZXJ0ZWQiIHx8IGUudHlwZSA9PT0gIkRPTU5vZGVSZW1vdmVk IikpIHsKLSAgICAgICAgICAgIC8vIFRoZSAibGluZU51bWJlciIgKGlmIGFueSkgaXMgbm8gbG9u Z2VyIHZhbGlkIGZvciBhIGxpbmUgYmVpbmcgcmVtb3ZlZCBvciBpbnNlcnRlZC4KLSAgICAgICAg ICAgIGRlbGV0ZSBsaW5lUm93LmxpbmVOdW1iZXI7Ci0gICAgICAgIH0KLQotICAgICAgICB2YXIg c3RhcnRMaW5lID0gMDsKLSAgICAgICAgZm9yICh2YXIgcm93ID0gbGluZVJvdzsgcm93OyByb3cg PSByb3cucHJldmlvdXNTaWJsaW5nKSB7Ci0gICAgICAgICAgICBpZiAodHlwZW9mIHJvdy5saW5l TnVtYmVyID09PSAibnVtYmVyIikgewotICAgICAgICAgICAgICAgIHN0YXJ0TGluZSA9IHJvdy5s aW5lTnVtYmVyOwotICAgICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgfQotICAgICAg ICB9Ci0KLSAgICAgICAgdmFyIGVuZExpbmUgPSB0aGlzLl90ZXh0TW9kZWwubGluZXNDb3VudDsK LSAgICAgICAgZm9yICh2YXIgcm93ID0gbGluZVJvdy5uZXh0U2libGluZzsgcm93OyByb3cgPSBy b3cubmV4dFNpYmxpbmcpIHsKLSAgICAgICAgICAgIGlmICh0eXBlb2Ygcm93LmxpbmVOdW1iZXIg PT09ICJudW1iZXIiKSB7Ci0gICAgICAgICAgICAgICAgZW5kTGluZSA9IHJvdy5saW5lTnVtYmVy OwotICAgICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgfQotICAgICAgICB9Ci0KLSAg ICAgICAgdGhpcy5fbWFya0RpcnR5TGluZXMoc3RhcnRMaW5lLCBlbmRMaW5lKTsKLSAgICB9LAot Ci0gICAgX2hhbmRsZURPTVN1YnRyZWVNb2RpZmllZDogZnVuY3Rpb24oZSkKLSAgICB7Ci0gICAg ICAgIGlmICh0aGlzLl9kb21VcGRhdGVDb2FsZXNjaW5nTGV2ZWwgfHwgdGhpcy5fcmVhZE9ubHkg fHwgZS50YXJnZXQgIT09IHRoaXMuX2NvbnRhaW5lcikKLSAgICAgICAgICAgIHJldHVybjsKLQot ICAgICAgICAvLyBQcm9jZWVkIG9ubHkgd2hlbiBvdGhlciBldmVudHMgZmFpbGVkIHRvIGNhdGNo IHRoZSBET00gdXBkYXRlcywgb3RoZXJ3aXNlIGl0IGlzIG5vdCBuZWNlc3NhcnkuCi0gICAgICAg IGlmICh0aGlzLl9kaXJ0eUxpbmVzKQotICAgICAgICAgICAgcmV0dXJuOwotCi0gICAgICAgIHZh ciBzZWxlY3Rpb24gPSB0aGlzLl9nZXRTZWxlY3Rpb24oKTsKLSAgICAgICAgaWYgKCFzZWxlY3Rp b24pCi0gICAgICAgICAgICByZXR1cm47Ci0KLSAgICAgICAgdmFyIHN0YXJ0TGluZSA9IE1hdGgu bWluKHNlbGVjdGlvbi5zdGFydExpbmUsIHNlbGVjdGlvbi5lbmRMaW5lKTsKLSAgICAgICAgdmFy IGVuZExpbmUgPSBNYXRoLm1heChzZWxlY3Rpb24uc3RhcnRMaW5lLCBzZWxlY3Rpb24uZW5kTGlu ZSkgKyAxOwotICAgICAgICBlbmRMaW5lID0gTWF0aC5taW4odGhpcy5fdGV4dE1vZGVsLmxpbmVz Q291bnQsIGVuZExpbmUpOwotCi0gICAgICAgIHRoaXMuX21hcmtEaXJ0eUxpbmVzKHN0YXJ0TGlu ZSwgZW5kTGluZSk7Ci0gICAgfSwKLQotICAgIF9tYXJrRGlydHlMaW5lczogZnVuY3Rpb24oc3Rh cnRMaW5lLCBlbmRMaW5lKQotICAgIHsKKyAgICAgICAgdmFyIGxpbmVOdW1iZXIgPSBsaW5lUm93 LmxpbmVOdW1iZXI7CiAgICAgICAgIGlmICh0aGlzLl9kaXJ0eUxpbmVzKSB7Ci0gICAgICAgICAg ICB0aGlzLl9kaXJ0eUxpbmVzLnN0YXJ0ID0gTWF0aC5taW4odGhpcy5fZGlydHlMaW5lcy5zdGFy dCwgc3RhcnRMaW5lKTsKLSAgICAgICAgICAgIHRoaXMuX2RpcnR5TGluZXMuZW5kID0gTWF0aC5t YXgodGhpcy5fZGlydHlMaW5lcy5lbmQsIGVuZExpbmUpOworICAgICAgICAgICAgdGhpcy5fZGly dHlMaW5lcy5zdGFydCA9IE1hdGgubWluKHRoaXMuX2RpcnR5TGluZXMuc3RhcnQsIGxpbmVOdW1i ZXIpOworICAgICAgICAgICAgdGhpcy5fZGlydHlMaW5lcy5lbmQgPSBNYXRoLm1heCh0aGlzLl9k aXJ0eUxpbmVzLmVuZCwgbGluZU51bWJlciArIDEpOwogICAgICAgICB9IGVsc2UgewotICAgICAg ICAgICAgdGhpcy5fZGlydHlMaW5lcyA9IHsgc3RhcnQ6IHN0YXJ0TGluZSwgZW5kOiBlbmRMaW5l IH07CisgICAgICAgICAgICB0aGlzLl9kaXJ0eUxpbmVzID0geyBzdGFydDogbGluZU51bWJlciwg ZW5kOiBsaW5lTnVtYmVyICsgMSB9OwogICAgICAgICAgICAgc2V0VGltZW91dCh0aGlzLl9hcHBs eURvbVVwZGF0ZXMuYmluZCh0aGlzKSwgMCk7CiAgICAgICAgICAgICAvLyBSZW1vdmUgbWFya2Vk IHJhbmdlcywgaWYgYW55LgogICAgICAgICAgICAgdGhpcy5tYXJrQW5kUmV2ZWFsUmFuZ2UobnVs bCk7CkBAIC0xNDQ5LDYgKzE0MDEsNyBAQCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvck1haW5DaHVu ayA9IGZ1bmN0aW9uKHRleHRWaWV3ZXIsIHN0YXJ0TGluZSwgZW5kTGluZSkKICAgICB0aGlzLmVs ZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKICAgICB0aGlzLmVsZW1lbnQu bGluZU51bWJlciA9IHN0YXJ0TGluZTsKICAgICB0aGlzLmVsZW1lbnQuY2xhc3NOYW1lID0gIndl YmtpdC1saW5lLWNvbnRlbnQiOworICAgIHRoaXMuZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJE T01Ob2RlUmVtb3ZlZCIsIHRoaXMuX3RleHRWaWV3ZXIuX2hhbmRsZURPTVVwZGF0ZXNDYWxsYmFj aywgZmFsc2UpOwogCiAgICAgdGhpcy5fc3RhcnRMaW5lID0gc3RhcnRMaW5lOwogICAgIGVuZExp bmUgPSBNYXRoLm1pbih0aGlzLl90ZXh0TW9kZWwubGluZXNDb3VudCwgZW5kTGluZSk7CkBAIC0x NTc5LDYgKzE1MzIsNyBAQCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvck1haW5DaHVuay5wcm90b3R5 cGUgPSB7CiAgICAgICAgIHZhciBsaW5lUm93ID0gdGhpcy5fdGV4dFZpZXdlci5fY2FjaGVkUm93 cy5wb3AoKSB8fCBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKICAgICAgICAgbGluZVJv dy5saW5lTnVtYmVyID0gbGluZU51bWJlcjsKICAgICAgICAgbGluZVJvdy5jbGFzc05hbWUgPSAi d2Via2l0LWxpbmUtY29udGVudCI7CisgICAgICAgIGxpbmVSb3cuYWRkRXZlbnRMaXN0ZW5lcigi RE9NTm9kZVJlbW92ZWQiLCB0aGlzLl90ZXh0Vmlld2VyLl9oYW5kbGVET01VcGRhdGVzQ2FsbGJh Y2ssIGZhbHNlKTsKICAgICAgICAgbGluZVJvdy50ZXh0Q29udGVudCA9IHRoaXMuX3RleHRNb2Rl bC5saW5lKGxpbmVOdW1iZXIpOwogICAgICAgICBpZiAoIWxpbmVSb3cudGV4dENvbnRlbnQpCiAg ICAgICAgICAgICBsaW5lUm93LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImJy IikpOwo=