55737 2011-03-03 18:37:00 -0800 RenderBox::canBeProgramaticallyScrolled() incorrectly returns 'true' for (i)frames with attribute 'scrolling=no' 2011-03-04 16:02:26 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED INVALID P2 Normal --- 0 sievers webkit-unassigned jamesr oldest_to_newest 362190 0 sievers 2011-03-03 18:37:00 -0800 Also see bug 55257. 362191 1 sievers 2011-03-03 18:38:59 -0800 The problem is that checking 'node()->isDocumentNode()' is too permissive. The frame might have the attribute scrolling=no set and will never be scrollable. Also see bug 55257, where this would lead to creation of an unwanted compositing layer. 362202 2 84681 sievers 2011-03-03 19:05:25 -0800 Created attachment 84681 Patch 362309 3 jamesr 2011-03-03 23:25:13 -0800 Doing some quick testing it seems that iframes with scrolling=no are programmatically scrollable in Firefox nightlies + the latest Opera stable. My testcase: <!DOCTYPE html> <iframe src="data:text/html;charset=utf-8,<!DOCTYPE html><script>setTimeout('window.scroll(0,10)',500)</script><div style='height:500px'>lala</div>" scrolling=no></iframe> Are you sure we want to change this? 362596 4 sievers 2011-03-04 10:08:11 -0800 I see, in that case it's probably ok to allow layers in bug 55257 for that case also. Thanks! (In reply to comment #3) > Doing some quick testing it seems that iframes with scrolling=no are programmatically scrollable in Firefox nightlies + the latest Opera stable. My testcase: > > <!DOCTYPE html> > <iframe src="data:text/html;charset=utf-8,<!DOCTYPE html><script>setTimeout('window.scroll(0,10)',500)</script><div style='height:500px'>lala</div>" scrolling=no></iframe> > > Are you sure we want to change this? 362772 5 84681 darin 2011-03-04 16:01:55 -0800 Comment on attachment 84681 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84681&action=review > Source/WebCore/ChangeLog:10 > + No new tests. (OOPS!) Why no tests? We normally require tests for all bug fixes. 362773 6 84681 darin 2011-03-04 16:02:26 -0800 Comment on attachment 84681 Patch I see. This bug was closed. Clearing the review flag, then. 84681 2011-03-03 19:05:25 -0800 2011-03-04 16:02:26 -0800 Patch bug-55737-20110303190524.patch text/plain 2708 sievers U3VidmVyc2lvbiBSZXZpc2lvbjogODAzMDgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzNTYwNjVlZGU0N2I5YWFh OGM3ZTU3MWFiNjY2OTY4NzMzZDNiM2VhLi4yNDBiNmJmZThlY2E1ZDYyNzc5NzJjMjUzODUyNWNh ZWMxZjNjNWJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDMtMDMgIERhbmll bCBTaWV2ZXJzICA8c2lldmVyc0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE92ZXJ3cml0ZSBSZW5kZXJWaWV3OjpjYW5CZVByb2dy YW1tYXRpY2FsbHlTY3JvbGxlZCgpIHRvIGdpdmUgdGhlIGNvcnJlY3QgYW5zd2VyIGZvciAKKyAg ICAgICAgZnJhbWVzL2lmcmFtZXMgdGhhdCBoYXZlIHRoZSAnc2Nyb2xsaW5nJyBhdHRyaWJ1dGUg c2V0IHRvICdubycgYW5kIHdpbGwgbmV2ZXIgYmUgc2Nyb2xsYWJsZS4KKyAgICAgICAgCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTczNworCisgICAg ICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclZp ZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVmlldzo6Y2FuQmVQcm9ncmFtYXRpY2Fs bHlTY3JvbGxlZCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclZpZXcuaDoKKwogMjAxMS0w My0wMiAgSmVyZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBTdGV2ZSBCbG9jay4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmNw cAppbmRleCA2ZGQ1NzY3ZDlhM2UyNGQwYmNlMmZkZTY2MWI4MzY3NTQwM2JmMDBhLi4yNWJjNTU5 M2RmN2U2NjdmZjkxMDQ5ZjYyZDA1NDhjYzI2YTRmMjk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclZpZXcuY3BwCkBAIC0yNyw3ICsyNyw5IEBACiAjaW5jbHVkZSAiRnJhbWUuaCIK ICNpbmNsdWRlICJGcmFtZVZpZXcuaCIKICNpbmNsdWRlICJHcmFwaGljc0NvbnRleHQuaCIKKyNp bmNsdWRlICJIVE1MRnJhbWVFbGVtZW50QmFzZS5oIgogI2luY2x1ZGUgIkhUTUxGcmFtZU93bmVy RWxlbWVudC5oIgorI2luY2x1ZGUgIkhUTUxOYW1lcy5oIgogI2luY2x1ZGUgIkhpdFRlc3RSZXN1 bHQuaCIKICNpbmNsdWRlICJSZW5kZXJMYXllci5oIgogI2luY2x1ZGUgIlJlbmRlclNlbGVjdGlv bkluZm8uaCIKQEAgLTgwMCw0ICs4MDIsMTkgQEAgdm9pZCBSZW5kZXJWaWV3Ojp3aWxsTW92ZU9m ZnNjcmVlbigpCiAjZW5kaWYKIH0KIAorYm9vbCBSZW5kZXJWaWV3OjpjYW5CZVByb2dyYW1hdGlj YWxseVNjcm9sbGVkKGJvb2wpIGNvbnN0Cit7CisgICAgaWYgKG5vZGUoKSAmJiBub2RlKCktPmlz RG9jdW1lbnROb2RlKCkpIHsKKyAgICAgICAgLy8gSGFuZGxlIHNjcm9sbGluZz0ibm8iIHN0eWxl IGZvciAoaSlmcmFtZXMuCisgICAgICAgIEhUTUxGcmFtZU93bmVyRWxlbWVudCogb3duZXJFbGVt ZW50ID0gZG9jdW1lbnQoKS0+b3duZXJFbGVtZW50KCk7CisgICAgICAgIGlmIChvd25lckVsZW1l bnQgJiYgKG93bmVyRWxlbWVudC0+aGFzVGFnTmFtZShIVE1MTmFtZXM6OmlmcmFtZVRhZykgfHwg b3duZXJFbGVtZW50LT5oYXNUYWdOYW1lKEhUTUxOYW1lczo6ZnJhbWVUYWcpKSkgeworICAgICAg ICAgICAgSFRNTEZyYW1lRWxlbWVudEJhc2UqIGZyYW1lID0gc3RhdGljX2Nhc3Q8SFRNTEZyYW1l RWxlbWVudEJhc2UqPihvd25lckVsZW1lbnQpOworICAgICAgICAgICAgaWYgKGZyYW1lLT5zY3Jv bGxpbmdNb2RlKCkgPT0gU2Nyb2xsYmFyQWx3YXlzT2ZmKQorICAgICAgICAgICAgICAgIHJldHVy biBmYWxzZTsKKyAgICAgICAgfQorICAgIH0KKworICAgIHJldHVybiBSZW5kZXJCb3g6OmNhbkJl UHJvZ3JhbWF0aWNhbGx5U2Nyb2xsZWQoZmFsc2UpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJD b3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5oIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuaAppbmRleCA3ZTViNGUxYzgwMGVm ZmRhNjJmZjEyYTQ5MGQxYzFjYWVjZDUwN2MzLi41MjJjYWNiY2YwYTJkMjk4ZmJhYzE4YjcwZTVi Y2U3YWQ1YWE5MDk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy Vmlldy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmgKQEAgLTE2 Myw2ICsxNjMsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCBkaWRNb3ZlT25zY3JlZW4oKTsKICAgICB2 b2lkIHdpbGxNb3ZlT2Zmc2NyZWVuKCk7CiAKKyAgICB2aXJ0dWFsIGJvb2wgY2FuQmVQcm9ncmFt YXRpY2FsbHlTY3JvbGxlZChib29sKSBjb25zdDsKKwogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01Q T1NJVElORykKICAgICBSZW5kZXJMYXllckNvbXBvc2l0b3IqIGNvbXBvc2l0b3IoKTsKICAgICBi b29sIHVzZXNDb21wb3NpdGluZygpIGNvbnN0Owo=