<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>55712</bug_id>
          
          <creation_ts>2011-03-03 14:56:16 -0800</creation_ts>
          <short_desc>JavaScriptCore GYP build should use a header map</short_desc>
          <delta_ts>2011-03-04 12:57:30 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>55018</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Barth">abarth</reporter>
          <assigned_to name="Adam Barth">abarth</assigned_to>
          <cc>abarth</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dglazkov</cc>
    
    <cc>eric</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>361972</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-03 14:56:16 -0800</bug_when>
    <thetext>JavaScriptCore GYP build should use a header map</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>361978</commentid>
    <comment_count>1</comment_count>
      <attachid>84634</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-03 14:57:51 -0800</bug_when>
    <thetext>Created attachment 84634
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>361979</commentid>
    <comment_count>2</comment_count>
      <attachid>84634</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2011-03-03 14:59:18 -0800</bug_when>
    <thetext>Comment on attachment 84634
Patch

k</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>361982</commentid>
    <comment_count>3</comment_count>
      <attachid>84634</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-03-03 15:00:13 -0800</bug_when>
    <thetext>Comment on attachment 84634
Patch

Really?  Are you sure you want this?  We&apos;ll need an explicit include list for other ports anyway...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>362248</commentid>
    <comment_count>4</comment_count>
      <attachid>84634</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-03-03 21:16:23 -0800</bug_when>
    <thetext>Comment on attachment 84634
Patch

Rejecting attachment 84634 from commit-queue.

Failed to run &quot;[&apos;./Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;--bot-id=cr-jail-7&apos;, &apos;apply-...&quot; exit_code: 2

Last 500 characters of output:
).
1 out of 2 hunks FAILED -- saving rejects to file Source/JavaScriptCore/JavaScriptCore.gypi.rej
patching file Source/JavaScriptCore/gyp/JavaScriptCore.gyp
Hunk #1 succeeded at 110 (offset 3 lines).
Hunk #2 FAILED at 195.
Hunk #3 FAILED at 216.
Hunk #4 FAILED at 238.
3 out of 4 hunks FAILED -- saving rejects to file Source/JavaScriptCore/gyp/JavaScriptCore.gyp.rej

Failed to run &quot;[u&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply&apos;, u&apos;--reviewer&apos;, u&apos;Dimitri Glazkov&apos;, u&apos;--...&quot; exit_code: 1

Full output: http://queues.webkit.org/results/8086447</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>362640</commentid>
    <comment_count>5</comment_count>
      <attachid>84634</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-04 11:21:40 -0800</bug_when>
    <thetext>Comment on attachment 84634
Patch

Clearing flags on attachment: 84634

Committed r80368: &lt;http://trac.webkit.org/changeset/80368&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>362641</commentid>
    <comment_count>6</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-04 11:21:44 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>362667</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-03-04 12:57:30 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/80368 might have broken GTK Linux 32-bit Release</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>84634</attachid>
            <date>2011-03-03 14:57:51 -0800</date>
            <delta_ts>2011-03-04 11:21:40 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-55712-20110303145750.patch</filename>
            <type>text/plain</type>
            <size>3845</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODAyNzUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGJk
NmI3ZWIzNDRiYjZiMzg4NTFiNjZmNzdhYTU2ODIxMzg1NGJhYzYuLmMyMDRlZWRmYTQwMGJhYmI4
NjUxMDQyM2YxMzc2Mjc3YTJlZjM2NTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMiw2
ICsyLDIzIEBACiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCiAKKyAgICAg
ICAgSmF2YVNjcmlwdENvcmUgR1lQIGJ1aWxkIHNob3VsZCB1c2UgYSBoZWFkZXIgbWFwCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTcxMgorCisgICAg
ICAgIFRoaXMgcGF0Y2ggbW92ZXMgdGhlIG9zLXdpbjMyIGZpbGVzIGludG8gdGhlaXIgb3duIHZh
cmlhYmxlIHNvIHRoYXQgd2UKKyAgICAgICAgY2FuIHVzZSBhIGhlYWRlciBtYXAgaW4gdGhlIEFw
cGxlIE1hYyBYY29kZSBidWlsZC4gIFRoZSBwcm9ibGVtIGlzIHRoYXQKKyAgICAgICAgdGhlIGhl
YWRlciBtYXAgc2VhcmNoZXMgdGhlIHdob2xlIHByb2plY3QgcmF0aGVyIHRoYW4ganVzdCB0aGUg
ZmlsZXMKKyAgICAgICAgaW5jbHVkZWQgaW4gYSBnaXZlbiB0YXJnZXQuICBBbm90aGVyIHNvbHV0
aW9uIHRvIHRoaXMgcHJvYmxlbSBpcyB0bworICAgICAgICBtYWtlIEdZUCBzbWFydGVyIGFib3V0
IGZpbHRlcmluZyBvdXQgd2hhdCBmaWxlcyBhcmUgYWRkZWQgdG8gdGhlCisgICAgICAgIHByb2pl
Y3QgZmlsZS4KKworICAgICAgICAqIEphdmFTY3JpcHRDb3JlLmd5cGk6CisgICAgICAgICogZ3lw
L0phdmFTY3JpcHRDb3JlLmd5cDoKKworMjAxMS0wMy0wMyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3
ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAg
ICAgIEFkZCBqc2MgdG8gSmF2YVNjcmlwdENvcmUgR1lQIGJ1aWxkCiAgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTcxMQogCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZ3lwaSBiL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9KYXZhU2NyaXB0Q29yZS5neXBpCmluZGV4IDVkYTIzOTRiOWEwNmIxNDgzY2Y3OTBhNDVj
ZjAyM2FhNGEwNjA3MzcuLjBkYTI5MGFiZDFmNTMyOTMzMDVjZGI4MTAxMmViYWIxYTNiZWY4OGQg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5neXBpCisr
KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5neXBpCkBAIC0zNTEsMTAg
KzM1MSw2IEBACiAgICAgICAgICAgICAnaml0L0pTSW50ZXJmYWNlSklULmgnLAogICAgICAgICAg
ICAgJ2ppdC9TcGVjaWFsaXplZFRodW5rSklULmgnLAogICAgICAgICAgICAgJ2ppdC9UaHVua0dl
bmVyYXRvcnMuY3BwJywKLSAgICAgICAgICAgICdvcy13aW4zMi9XaW5NYWluLmNwcCcsCi0gICAg
ICAgICAgICAnb3Mtd2luMzIvaW50dHlwZXMuaCcsCi0gICAgICAgICAgICAnb3Mtd2luMzIvc3Rk
Ym9vbC5oJywKLSAgICAgICAgICAgICdvcy13aW4zMi9zdGRpbnQuaCcsCiAgICAgICAgICAgICAn
cGFyc2VyL0FTVEJ1aWxkZXIuaCcsCiAgICAgICAgICAgICAncGFyc2VyL0pTUGFyc2VyLmNwcCcs
CiAgICAgICAgICAgICAncGFyc2VyL0pTUGFyc2VyLmgnLApAQCAtNjU4LDYgKzY1NCwxNCBAQAog
ICAgICAgICAgICAgJ3lhcnIvWWFyclN5bnRheENoZWNrZXIuY3BwJywKICAgICAgICAgICAgICd5
YXJyL1lhcnJTeW50YXhDaGVja2VyLmgnLAogICAgICAgICBdLAorICAgICAgICAjIFRoZXNlIGZp
bGVzIGFyZSBzZXBhcmF0ZSBmcm9tIGphdmFzY3JpcHRjb3JlX2ZpbGVzIHNvIHdlIGNhbiB1c2Ug
YQorICAgICAgICAjIGhlYWRlciBtYXAgaW4gdGhlIEFwcGxlIE1hYyBYY29kZSBidWlsZC4KKyAg
ICAgICAgJ29zX3dpbjMyX2ZpbGVzJzogWworICAgICAgICAgICAgJ29zLXdpbjMyL1dpbk1haW4u
Y3BwJywKKyAgICAgICAgICAgICdvcy13aW4zMi9pbnR0eXBlcy5oJywKKyAgICAgICAgICAgICdv
cy13aW4zMi9zdGRib29sLmgnLAorICAgICAgICAgICAgJ29zLXdpbjMyL3N0ZGludC5oJywKKyAg
ICAgICAgXSwKICAgICAgICAgJ21pbmlkb21fZmlsZXMnOiBbCiAgICAgICAgICAgICAnQVBJL3Rl
c3RzL0pTTm9kZS5jJywKICAgICAgICAgICAgICdBUEkvdGVzdHMvSlNOb2RlLmgnLApkaWZmIC0t
Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2d5cC9KYXZhU2NyaXB0Q29yZS5neXAgYi9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvZ3lwL0phdmFTY3JpcHRDb3JlLmd5cAppbmRleCA2NWFjMDg4MTc0
ZTA2YTFhMWVkYzA0MzcxZjE3ZTM4OWExYzYxMjNlLi43MDk5MmNlOGE4ZTMzNmI4MGZhZmQwOTRh
ZDMzYTFhYWQ0YzNlMTQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZ3lwL0ph
dmFTY3JpcHRDb3JlLmd5cAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZ3lwL0phdmFTY3Jp
cHRDb3JlLmd5cApAQCAtMTA3LDcgKzEwNyw2IEBACiAgICAgICAgIFsnT1M9PSJtYWMiJywgewog
ICAgICAgICAgICdtYWNfYnVuZGxlJzogMSwKICAgICAgICAgICAneGNvZGVfc2V0dGluZ3MnOiB7
Ci0gICAgICAgICAgICAnVVNFX0hFQURFUk1BUCc6ICdOTycsCiAgICAgICAgICAgICAjIEZJWE1F
OiBSZW1vdmUgdGhlc2Ugb3ZlcnJpZGVzIG9uY2UgSmF2YVNjcmlwdENvcmUueGNjb25maWcgaXMK
ICAgICAgICAgICAgICMgdXNlZCBvbmx5IGJ5IHRoaXMgcHJvamVjdC4KICAgICAgICAgICAgICdH
Q0NfUFJFRklYX0hFQURFUic6ICc8KERFUFRIKS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29y
ZVByZWZpeC5oJywKQEAgLTE5MywxMyArMTkyLDYgQEAKICAgICAgICAgJ1Byb2R1Y3Rpb24nOiB7
fSwKICAgICAgIH0sCiAgICAgICAnZGVmYXVsdF9jb25maWd1cmF0aW9uJzogJ0RlYnVnJywKLSAg
ICAgICdjb25kaXRpb25zJzogWwotICAgICAgICBbJ09TPT0ibWFjIicsIHsKLSAgICAgICAgICAn
eGNvZGVfc2V0dGluZ3MnOiB7Ci0gICAgICAgICAgICAnVVNFX0hFQURFUk1BUCc6ICdOTycsCi0g
ICAgICAgICAgfQotICAgICAgICB9XSwKLSAgICAgIF0sCiAgICAgfSwKICAgICB7CiAgICAgICAn
dGFyZ2V0X25hbWUnOiAndGVzdGFwaScsCkBAIC0yMjEsMTMgKzIxMyw2IEBACiAgICAgICAgICdQ
cm9kdWN0aW9uJzoge30sCiAgICAgICB9LAogICAgICAgJ2RlZmF1bHRfY29uZmlndXJhdGlvbic6
ICdEZWJ1ZycsCi0gICAgICAnY29uZGl0aW9ucyc6IFsKLSAgICAgICAgWydPUz09Im1hYyInLCB7
Ci0gICAgICAgICAgJ3hjb2RlX3NldHRpbmdzJzogewotICAgICAgICAgICAgJ1VTRV9IRUFERVJN
QVAnOiAnTk8nLAotICAgICAgICAgIH0KLSAgICAgICAgfV0sCi0gICAgICBdLAogICAgIH0sCiAg
ICAgewogICAgICAgJ3RhcmdldF9uYW1lJzogJ2pzYycsCkBAIC0yNTAsMTMgKzIzNSw2IEBACiAg
ICAgICAgICdQcm9kdWN0aW9uJzoge30sCiAgICAgICB9LAogICAgICAgJ2RlZmF1bHRfY29uZmln
dXJhdGlvbic6ICdEZWJ1ZycsCi0gICAgICAnY29uZGl0aW9ucyc6IFsKLSAgICAgICAgWydPUz09
Im1hYyInLCB7Ci0gICAgICAgICAgJ3hjb2RlX3NldHRpbmdzJzogewotICAgICAgICAgICAgJ1VT
RV9IRUFERVJNQVAnOiAnTk8nLAotICAgICAgICAgIH0KLSAgICAgICAgfV0sCi0gICAgICBdLAog
ICAgIH0sCiAgIF0sICMgdGFyZ2V0cwogfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>