55557 2011-03-01 23:49:50 -0800 Override paintScrollCorner() for FramelessScrollView to do nothing (fixes a crash) 2011-03-04 08:07:38 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 isherman isherman commit-queue dhollowa eric fishd isherman jamesr pkasting priyajeet.hora tkent oldest_to_newest 360629 0 isherman 2011-03-01 23:49:50 -0800 Override paintScrollCorner() for FramelessScrollView to do nothing (fixes a crash) 360631 1 84377 isherman 2011-03-01 23:51:56 -0800 Created attachment 84377 Patch 360660 2 84377 tkent 2011-03-02 01:29:55 -0800 Comment on attachment 84377 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84377&action=review > Source/WebCore/platform/chromium/FramelessScrollView.cpp:79 > +void FramelessScrollView::paintScrollCorner(GraphicsContext*, const IntRect& cornerRect) should remove the unused argument name. 360661 3 tkent 2011-03-02 01:31:39 -0800 Probably fishd or eric is familiar with this code. I don't understand why this change fixes the crash. We need to add a reason to the patch. 360662 4 84377 eric 2011-03-02 01:35:39 -0800 Comment on attachment 84377 Patch What does the crash look like? What's the test case to repro the crash? I doubt this is the right fix w/o that info. 360667 5 84383 isherman 2011-03-02 02:06:13 -0800 Created attachment 84383 Patch 360668 6 isherman 2011-03-02 02:07:25 -0800 (In reply to comment #4) > (From update of attachment 84377 [details]) > What does the crash look like? What's the test case to repro the crash? Take a look at http://crbug.com/73772 -- esp crbug.com/73772#c23 361158 7 84383 jamesr 2011-03-02 16:27:01 -0800 Comment on attachment 84383 Patch Why isn't this testable? 361234 8 84383 jamesr 2011-03-02 17:23:51 -0800 Comment on attachment 84383 Patch I assume the bad cast you are referring to is this one: http://trac.webkit.org/browser/trunk/Source/WebCore/platform/ScrollbarThemeComposite.cpp#L309 ? What does the comment in http://trac.webkit.org/browser/trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromium.cpp#L140 mean, then? Something somewhere here is inconsistent - not sure if it's the code or the comments. 361262 9 isherman 2011-03-02 17:49:06 -0800 (In reply to comment #8) > (From update of attachment 84383 [details]) > I assume the bad cast you are referring to is this one: http://trac.webkit.org/browser/trunk/Source/WebCore/platform/ScrollbarThemeComposite.cpp#L309 ? Yep, that's the one. > What does the comment in http://trac.webkit.org/browser/trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromium.cpp#L140 mean, then? On Mac, we never reach ScrollbarThemeChromium... probably because we want to use native scroll widgets? Perhaps it would be more appropriate to move the code from ScrollbarThemeChromium.cpp to FramelessScrollView.cpp? 361276 10 isherman 2011-03-02 18:04:28 -0800 (In reply to comment #7) > (From update of attachment 84383 [details]) > Why isn't this testable? On non-Mac platforms, trying to bring up the select popup crashes DRT. On Mac, we have a custom <select> popup, and there's currently no way to bring up the FramelessScrollView popup that autofill uses. Also, if we could bring that up, it would probably crash DRT for the same reason as on other platforms -- which I think is something along the lines of DRT isn't prepared to show this new window object. 361278 11 jamesr 2011-03-02 18:11:01 -0800 (In reply to comment #9) > (In reply to comment #8) > > (From update of attachment 84383 [details] [details]) > > I assume the bad cast you are referring to is this one: http://trac.webkit.org/browser/trunk/Source/WebCore/platform/ScrollbarThemeComposite.cpp#L309 ? > > Yep, that's the one. > > > What does the comment in http://trac.webkit.org/browser/trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromium.cpp#L140 mean, then? > > On Mac, we never reach ScrollbarThemeChromium... probably because we want to use native scroll widgets? Perhaps it would be more appropriate to move the code from ScrollbarThemeChromium.cpp to FramelessScrollView.cpp? Maybe - we definitely want to only have one solution to this problem, not two. 361336 12 84516 isherman 2011-03-02 20:21:31 -0800 Created attachment 84516 Patch 361392 13 84516 jamesr 2011-03-02 23:43:41 -0800 Comment on attachment 84516 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84516&action=review > Source/WebCore/platform/chromium/FramelessScrollView.cpp:83 > + ScrollbarTheme().paintScrollCorner(this, context, cornerRect); This looks weird. We just make a ScrollbarTheme out of nowhere and use it? I'm not very familiar with the relationship between a Scrollbar, ScrollView, and ScrollbarTheme but this is definitely a code smell. 361419 14 84516 isherman 2011-03-03 00:35:30 -0800 Comment on attachment 84516 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84516&action=review >> Source/WebCore/platform/chromium/FramelessScrollView.cpp:83 >> + ScrollbarTheme().paintScrollCorner(this, context, cornerRect); > > This looks weird. We just make a ScrollbarTheme out of nowhere and use it? > > I'm not very familiar with the relationship between a Scrollbar, ScrollView, and ScrollbarTheme but this is definitely a code smell. So, ScrollbarTheme::paintScrollCorner() provides a default implementation of the method, and is essentially a static function. Two obvious alternatives to writing the code this way are: 1) Copy the default implementation into FramelessScrollView::paintsScrollCorner. 2) Add a static function to ScrollbarTheme that implements the default action, and call that. I'm not a fan of code duplication, so option (1) is out. I'm not sure that option (2) is great either, but I guess I'll switch to that for now. Do you have a moar awesomer suggestion? 361422 15 84532 isherman 2011-03-03 00:44:59 -0800 Created attachment 84532 Patch 361895 16 84532 jamesr 2011-03-03 13:29:06 -0800 Comment on attachment 84532 Patch I don't have a moar awesome suggestion, but this seems at least a bit cleaner than the previous iterations. R=me, especially since this is a top crasher, but if anyone has an even better idea I'm open to it! 362497 17 commit-queue 2011-03-04 08:04:48 -0800 The commit-queue encountered the following flaky tests while processing attachment 84532: security/block-test.html bug 55741 (authors: beidson@apple.com, mrowe@apple.com, and sam@webkit.org) The commit-queue is continuing to process your patch. 362498 18 84532 commit-queue 2011-03-04 08:07:32 -0800 Comment on attachment 84532 Patch Clearing flags on attachment: 84532 Committed r80353: <http://trac.webkit.org/changeset/80353> 362499 19 commit-queue 2011-03-04 08:07:38 -0800 All reviewed patches have been landed. Closing bug. 84377 2011-03-01 23:51:56 -0800 2011-03-02 02:06:10 -0800 Patch bug-55557-20110301235155.patch text/plain 2251 isherman U3VidmVyc2lvbiBSZXZpc2lvbjogODAwMDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyOTU2YTY1MWEyNTk0NDQ5 ZTk5NGFkMmZjOGIxZDg0Mzg1M2M3NzA1Li4zMjcxYjQzYWIwYmU5ZDQ3ODkxZDE5MWE2MTIxMmMz MDZiYjUyNzFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDMtMDEgIElseWEg U2hlcm1hbiAgPGlzaGVybWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdmVycmlkZSBwYWludFNjcm9sbENvcm5lcigpIGZv ciBGcmFtZWxlc3NTY3JvbGxWaWV3IHRvIGRvIG5vdGhpbmcgKGZpeGVzIGEgY3Jhc2gpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTU1NworICAgICAg ICBodHRwOi8vY3JidWcuY29tLzczNzcyCisKKyAgICAgICAgTm8gdGVzdHMgYWRkZWQgYmVjYXVz ZSB0aGlzIGZpeCBpcyBDaHJvbWl1bS1zcGVjaWZpYyBhbmQgdGhlIGNvZGUgaXMgY3VycmVudGx5 IHVudGVzdGFibGUgZnJvbSB3aXRoaW4gV2ViS2l0LgorCisgICAgICAgICogcGxhdGZvcm0vY2hy b21pdW0vRnJhbWVsZXNzU2Nyb2xsVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZWxl c3NTY3JvbGxWaWV3OjpwYWludFNjcm9sbENvcm5lcik6IE92ZXJyaWRkZW4gdG8gYmUgYSBub29w LgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL0ZyYW1lbGVzc1Njcm9sbFZpZXcuaDoKKwog MjAxMS0wMy0wMSAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2Nocm9taXVtL0ZyYW1lbGVzc1Njcm9sbFZpZXcuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vRnJhbWVsZXNzU2Nyb2xsVmlldy5jcHAKaW5kZXggM2Zi ZjJkNjc4MzMyZGI5ZGNlM2JkMWFhNzVjYTE4ODIyOWRlODNiYy4uMDYzODE0MWZjMzgxMDg0YTU4 OTU1NmQ5NWQ5NDhhYWFmOGE4ZWU2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vY2hyb21pdW0vRnJhbWVsZXNzU2Nyb2xsVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vY2hyb21pdW0vRnJhbWVsZXNzU2Nyb2xsVmlldy5jcHAKQEAgLTc2LDYgKzc2LDEw IEBAIHZvaWQgRnJhbWVsZXNzU2Nyb2xsVmlldzo6cGFpbnRDb250ZW50cyhHcmFwaGljc0NvbnRl eHQqLCBjb25zdCBJbnRSZWN0JiBkYW1hZ2VSCiB7CiB9CiAKK3ZvaWQgRnJhbWVsZXNzU2Nyb2xs Vmlldzo6cGFpbnRTY3JvbGxDb3JuZXIoR3JhcGhpY3NDb250ZXh0KiwgY29uc3QgSW50UmVjdCYg Y29ybmVyUmVjdCkKK3sKK30KKwogdm9pZCBGcmFtZWxlc3NTY3JvbGxWaWV3Ojpjb250ZW50c1Jl c2l6ZWQoKQogewogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21p dW0vRnJhbWVsZXNzU2Nyb2xsVmlldy5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21p dW0vRnJhbWVsZXNzU2Nyb2xsVmlldy5oCmluZGV4IDAzM2Q5NTMyYTNhNGY5YzZhYmQ5N2I4MzIw YTE0ZDY5NTI0MjZhNGMuLjE3NzIwNjk3MzRiZWI4MTNhMzRlZjEyNjk5MDZjYTcxM2M0YmIyOTIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0ZyYW1lbGVzc1Nj cm9sbFZpZXcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9GcmFtZWxl c3NTY3JvbGxWaWV3LmgKQEAgLTc1LDYgKzc1LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAg IHByb3RlY3RlZDoKICAgICAgICAgLy8gU2Nyb2xsVmlldyBwcm90ZWN0ZWQgbWV0aG9kczoKICAg ICAgICAgdmlydHVhbCB2b2lkIHBhaW50Q29udGVudHMoR3JhcGhpY3NDb250ZXh0KiwgY29uc3Qg SW50UmVjdCYgZGFtYWdlUmVjdCk7CisgICAgICAgIHZpcnR1YWwgdm9pZCBwYWludFNjcm9sbENv cm5lcihHcmFwaGljc0NvbnRleHQqLCBjb25zdCBJbnRSZWN0JiBjb3JuZXJSZWN0KTsKICAgICAg ICAgdmlydHVhbCB2b2lkIGNvbnRlbnRzUmVzaXplZCgpOwogICAgICAgICB2aXJ0dWFsIHZvaWQg dmlzaWJsZUNvbnRlbnRzUmVzaXplZCgpOwogCg== 84383 2011-03-02 02:06:13 -0800 2011-03-02 20:21:28 -0800 Patch bug-55557-20110302020612.patch text/plain 2602 isherman U3VidmVyc2lvbiBSZXZpc2lvbjogODAwMDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyOTU2YTY1MWEyNTk0NDQ5 ZTk5NGFkMmZjOGIxZDg0Mzg1M2M3NzA1Li40MjI5MWNkMWQxNzY2OTY1NjQ4NGI0NDlhZjczNTQ5 YzliMjY0OTAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDMtMDEgIElseWEg U2hlcm1hbiAgPGlzaGVybWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdmVycmlkZSBwYWludFNjcm9sbENvcm5lcigpIGZv ciBGcmFtZWxlc3NTY3JvbGxWaWV3IHRvIGRvIG5vdGhpbmcuCisgICAgICAgIFRoZSBTY3JvbGxW aWV3IGltcGxlbWVudGF0aW9uIHRyaWVzIHRvIGNhc3QgdGhlIHNjcm9sbHZpZXcgdG8gYSBGcmFt ZVZpZXcsCisgICAgICAgIHdoaWNoIGlzIGluYXBwcm9wcmlhdGUgZm9yIGEgRnJhbWVsZXNzU2Ny b2xsVmlldy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU1NTU3CisgICAgICAgIGh0dHA6Ly9jcmJ1Zy5jb20vNzM3NzIKKworICAgICAgICBObyB0ZXN0 cyBhZGRlZCBiZWNhdXNlIHRoaXMgZml4IGlzIENocm9taXVtLXNwZWNpZmljIGFuZCB0aGUgY29k ZSBpcyBjdXJyZW50bHkgdW50ZXN0YWJsZSBmcm9tIHdpdGhpbiBXZWJLaXQuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9jaHJvbWl1bS9GcmFtZWxlc3NTY3JvbGxWaWV3LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkZyYW1lbGVzc1Njcm9sbFZpZXc6OnBhaW50U2Nyb2xsQ29ybmVyKTogT3ZlcnJpZGRl biB0byBiZSBhIG5vb3AuCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vRnJhbWVsZXNzU2Ny b2xsVmlldy5oOgorCiAyMDExLTAzLTAxICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vRnJhbWVsZXNzU2Nyb2xsVmlldy5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9GcmFtZWxlc3NTY3JvbGxWaWV3 LmNwcAppbmRleCAzZmJmMmQ2NzgzMzJkYjlkY2UzYmQxYWE3NWNhMTg4MjI5ZGU4M2JjLi40NGNi OWYyMmY3ZDY1MzUwZTNiYzFiMDQxZThjOTIxM2IwZmRiMDUyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9GcmFtZWxlc3NTY3JvbGxWaWV3LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9GcmFtZWxlc3NTY3JvbGxWaWV3LmNwcApA QCAtNzIsNyArNzIsMTEgQEAgSW50UmVjdCBGcmFtZWxlc3NTY3JvbGxWaWV3Ojp3aW5kb3dDbGlw UmVjdChib29sIGNsaXBUb0NvbnRlbnRzKSBjb25zdAogICAgIHJldHVybiBjb250ZW50c1RvV2lu ZG93KHZpc2libGVDb250ZW50UmVjdCghY2xpcFRvQ29udGVudHMpKTsKIH0KIAotdm9pZCBGcmFt ZWxlc3NTY3JvbGxWaWV3OjpwYWludENvbnRlbnRzKEdyYXBoaWNzQ29udGV4dCosIGNvbnN0IElu dFJlY3QmIGRhbWFnZVJlY3QpCit2b2lkIEZyYW1lbGVzc1Njcm9sbFZpZXc6OnBhaW50Q29udGVu dHMoR3JhcGhpY3NDb250ZXh0KiwgY29uc3QgSW50UmVjdCYpCit7Cit9CisKK3ZvaWQgRnJhbWVs ZXNzU2Nyb2xsVmlldzo6cGFpbnRTY3JvbGxDb3JuZXIoR3JhcGhpY3NDb250ZXh0KiwgY29uc3Qg SW50UmVjdCYpCiB7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2No cm9taXVtL0ZyYW1lbGVzc1Njcm9sbFZpZXcuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2No cm9taXVtL0ZyYW1lbGVzc1Njcm9sbFZpZXcuaAppbmRleCAwMzNkOTUzMmEzYTRmOWM2YWJkOTdi ODMyMGExNGQ2OTUyNDI2YTRjLi5kN2E1OTZmYzIwNDMwNmNiYTY0NTJiMjQ5MmVlODJlODIzYmVl MjVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9GcmFtZWxl c3NTY3JvbGxWaWV3LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vRnJh bWVsZXNzU2Nyb2xsVmlldy5oCkBAIC03NCw3ICs3NCw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsK IAogICAgIHByb3RlY3RlZDoKICAgICAgICAgLy8gU2Nyb2xsVmlldyBwcm90ZWN0ZWQgbWV0aG9k czoKLSAgICAgICAgdmlydHVhbCB2b2lkIHBhaW50Q29udGVudHMoR3JhcGhpY3NDb250ZXh0Kiwg Y29uc3QgSW50UmVjdCYgZGFtYWdlUmVjdCk7CisgICAgICAgIHZpcnR1YWwgdm9pZCBwYWludENv bnRlbnRzKEdyYXBoaWNzQ29udGV4dCosIGNvbnN0IEludFJlY3QmKTsKKyAgICAgICAgdmlydHVh bCB2b2lkIHBhaW50U2Nyb2xsQ29ybmVyKEdyYXBoaWNzQ29udGV4dCosIGNvbnN0IEludFJlY3Qm KTsKICAgICAgICAgdmlydHVhbCB2b2lkIGNvbnRlbnRzUmVzaXplZCgpOwogICAgICAgICB2aXJ0 dWFsIHZvaWQgdmlzaWJsZUNvbnRlbnRzUmVzaXplZCgpOwogCg== 84516 2011-03-02 20:21:31 -0800 2011-03-03 00:44:56 -0800 Patch bug-55557-20110302202130.patch text/plain 5245 isherman U3VidmVyc2lvbiBSZXZpc2lvbjogODAwMDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyOTU2YTY1MWEyNTk0NDQ5 ZTk5NGFkMmZjOGIxZDg0Mzg1M2M3NzA1Li4wYTJiZDg2MDZmODNhODhiYmMyOGFlMTc1YjgzYTM4 MGY2YzkxOTQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDMtMDIgIElseWEg U2hlcm1hbiAgPGlzaGVybWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdmVycmlkZSBwYWludFNjcm9sbENvcm5lcigpIGZv ciBGcmFtZWxlc3NTY3JvbGxWaWV3IHRvIGZvcmVnbyBhbnkgY3VzdG9tIHNjcm9sbGJhciBjb3Ju ZXIgcmVuZGVyaW5nLgorICAgICAgICBUaGlzIHdhcyBwcmV2aW91c2x5IGRvbmUgaW4gU2Nyb2xs YmFyVGhlbWVDaHJvbWl1bSwgYnV0IHdlIGFsc28gbmVlZCB0aGlzIG9uIHRoZSBNYWMgd2hlbiB0 aGUgU2Nyb2xsVmlldworICAgICAgICBpcyBhIEZyYW1lbGVzc1Njcm9sbFZpZXcgLS0gd2hpY2gg aXMgbW9zdGx5IGp1c3QgZm9yIEF1dG9maWxsLgorICAgICAgICBJbiBzZXJ2aWNlIG9mIGh0dHA6 Ly9jcmJ1Zy5jb20vNzM3NzIgKGNyYXNoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTU1NTcKKworICAgICAgICBObyB0ZXN0cyBhZGRlZCBiZWNhdXNl IHRoaXMgZml4IGlzIENocm9taXVtLXNwZWNpZmljIGFuZCB0aGUgY29kZSBpcyBjdXJyZW50bHkg dW50ZXN0YWJsZSBmcm9tIHdpdGhpbiBXZWJLaXQuCisgICAgICAgIEluIHBhcnRpY3VsYXIsIERS VCBjcmFzaGVzIHdoZW4gdHJ5aW5nIHRvIHJlbmRlciBhIEZyYW1lbGVzc1Njcm9sbFZpZXcuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9GcmFtZWxlc3NTY3JvbGxWaWV3LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkZyYW1lbGVzc1Njcm9sbFZpZXc6OnBhaW50Q29udGVudHMpOgorICAg ICAgICAoV2ViQ29yZTo6RnJhbWVsZXNzU2Nyb2xsVmlldzo6cGFpbnRTY3JvbGxDb3JuZXIpOiBG aXggaW1wbGVtZW50YXRpb24gbW92ZWQgdG8gaGVyZSBmcm9tIFNjcm9sbGJhclRoZW1lQ2hyb21p dW0KKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9GcmFtZWxlc3NTY3JvbGxWaWV3Lmg6Cisg ICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bS5jcHA6Cisg ICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bS5oOgorCiAy MDExLTAzLTAxICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vY2hyb21pdW0vRnJhbWVsZXNzU2Nyb2xsVmlldy5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9GcmFtZWxlc3NTY3JvbGxWaWV3LmNwcAppbmRleCAzZmJm MmQ2NzgzMzJkYjlkY2UzYmQxYWE3NWNhMTg4MjI5ZGU4M2JjLi5jOGRhZDQ3MjQwMzI0ZDQzOWZm YjdkMTlkMmI4ODM5MjA3NTU3ZDdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9jaHJvbWl1bS9GcmFtZWxlc3NTY3JvbGxWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9jaHJvbWl1bS9GcmFtZWxlc3NTY3JvbGxWaWV3LmNwcApAQCAtMzIsNiArMzIsNyBA QAogI2luY2x1ZGUgIkZyYW1lbGVzc1Njcm9sbFZpZXcuaCIKIAogI2luY2x1ZGUgIkZyYW1lbGVz c1Njcm9sbFZpZXdDbGllbnQuaCIKKyNpbmNsdWRlICJTY3JvbGxiYXJUaGVtZS5oIgogCiBuYW1l c3BhY2UgV2ViQ29yZSB7CiAKQEAgLTcyLDEwICs3MywxNiBAQCBJbnRSZWN0IEZyYW1lbGVzc1Nj cm9sbFZpZXc6OndpbmRvd0NsaXBSZWN0KGJvb2wgY2xpcFRvQ29udGVudHMpIGNvbnN0CiAgICAg cmV0dXJuIGNvbnRlbnRzVG9XaW5kb3codmlzaWJsZUNvbnRlbnRSZWN0KCFjbGlwVG9Db250ZW50 cykpOwogfQogCi12b2lkIEZyYW1lbGVzc1Njcm9sbFZpZXc6OnBhaW50Q29udGVudHMoR3JhcGhp Y3NDb250ZXh0KiwgY29uc3QgSW50UmVjdCYgZGFtYWdlUmVjdCkKK3ZvaWQgRnJhbWVsZXNzU2Ny b2xsVmlldzo6cGFpbnRDb250ZW50cyhHcmFwaGljc0NvbnRleHQqLCBjb25zdCBJbnRSZWN0JikK IHsKIH0KIAordm9pZCBGcmFtZWxlc3NTY3JvbGxWaWV3OjpwYWludFNjcm9sbENvcm5lcihHcmFw aGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IEludFJlY3QmIGNvcm5lclJlY3QpCit7CisgICAg Ly8gU2Nyb2xsYmFyVGhlbWVDb21wb3NpdGU6OnBhaW50U2Nyb2xsQ29ybmVyIGluY29ycmVjdGx5 IGFzc3VtZXMgdGhhdCB0aGUgU2Nyb2xsVmlldyBpcyBhIEZyYW1lVmlldy4KKyAgICBTY3JvbGxi YXJUaGVtZSgpLnBhaW50U2Nyb2xsQ29ybmVyKHRoaXMsIGNvbnRleHQsIGNvcm5lclJlY3QpOwor fQorCiB2b2lkIEZyYW1lbGVzc1Njcm9sbFZpZXc6OmNvbnRlbnRzUmVzaXplZCgpCiB7CiB9CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9GcmFtZWxlc3NTY3Jv bGxWaWV3LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9GcmFtZWxlc3NTY3Jv bGxWaWV3LmgKaW5kZXggMDMzZDk1MzJhM2E0ZjljNmFiZDk3YjgzMjBhMTRkNjk1MjQyNmE0Yy4u NzI0ODI5ZDM1NjliMDdkNzFkYWI0ZTI1NmYyY2RjODc0N2NkMzA0NyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vRnJhbWVsZXNzU2Nyb2xsVmlldy5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0ZyYW1lbGVzc1Njcm9sbFZpZXcuaApA QCAtNzQsNyArNzQsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICBwcm90ZWN0ZWQ6CiAg ICAgICAgIC8vIFNjcm9sbFZpZXcgcHJvdGVjdGVkIG1ldGhvZHM6Ci0gICAgICAgIHZpcnR1YWwg dm9pZCBwYWludENvbnRlbnRzKEdyYXBoaWNzQ29udGV4dCosIGNvbnN0IEludFJlY3QmIGRhbWFn ZVJlY3QpOworICAgICAgICB2aXJ0dWFsIHZvaWQgcGFpbnRDb250ZW50cyhHcmFwaGljc0NvbnRl eHQqLCBjb25zdCBJbnRSZWN0Jik7CisgICAgICAgIHZpcnR1YWwgdm9pZCBwYWludFNjcm9sbENv cm5lcihHcmFwaGljc0NvbnRleHQqLCBjb25zdCBJbnRSZWN0JiBjb3JuZXJSZWN0KTsKICAgICAg ICAgdmlydHVhbCB2b2lkIGNvbnRlbnRzUmVzaXplZCgpOwogICAgICAgICB2aXJ0dWFsIHZvaWQg dmlzaWJsZUNvbnRlbnRzUmVzaXplZCgpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW0uY3BwCmluZGV4IDll NzAwYzIwNWQzNjhiMGU5NzQ5NjcyMDgzNTAyNzA3OWRmZmY2ZGMuLjg0M2ZjM2NiZDI4Njg1ZGM3 YjZhMWFhMDlhNzI3YzQ5N2JhZTUyN2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW0uY3BwCkBAIC0xMzcs MTMgKzEzNyw0IEBAIHZvaWQgU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bTo6cGFpbnRUaWNrbWFya3Mo R3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBTY3JvbGxiYXIqCiAgICAgY29udGV4dC0+cmVzdG9y ZSgpOwogfQogCi12b2lkIFNjcm9sbGJhclRoZW1lQ2hyb21pdW06OnBhaW50U2Nyb2xsQ29ybmVy KFNjcm9sbFZpZXcqIHZpZXcsIEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgSW50UmVj dCYgY29ybmVyUmVjdCkKLXsKLSAgICAvLyBTY3JvbGxiYXJUaGVtZUNvbXBvc2l0ZTo6cGFpbnRT Y3JvbGxDb3JuZXIgaW5jb3JyZWN0bHkgYXNzdW1lcyB0aGF0IHRoZQotICAgIC8vIFNjcm9sbFZp ZXcgaXMgYSBGcmFtZVZpZXcgKHNlZSBGcmFtZWxlc3NTY3JvbGxWaWV3KSwgc28gd2UgY2Fubm90 IGxldAotICAgIC8vIHRoYXQgY29kZSBydW4uICBGb3IgRnJhbWVWaWV3J3MgdGhpcyBpcyBjb3Jy ZWN0IHNpbmNlIHdlIGRvbid0IGRvIGN1c3RvbQotICAgIC8vIHNjcm9sbGJhciBjb3JuZXIgcmVu ZGVyaW5nLCB3aGljaCBTY3JvbGxiYXJUaGVtZUNvbXBvc2l0ZSBzdXBwb3J0cy4KLSAgICBTY3Jv bGxiYXJUaGVtZTo6cGFpbnRTY3JvbGxDb3JuZXIodmlldywgY29udGV4dCwgY29ybmVyUmVjdCk7 Ci19Ci0KIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW0uaCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW0uaAppbmRleCBiNTNk NGFlMTZhZGJlOThmM2Y4NmI0ODZjN2M3YTVlZDA4NThlZWI2Li4xMTc4MTI1NjlmNjlmMjAwMzcx YmFjMGY5ZGE4N2E3YzMyZGU0ZmE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9jaHJvbWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtLmgKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bS5oCkBAIC00OCw4ICs0OCw2 IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdmlydHVhbCBJbnRSZWN0IGZvcndhcmRC dXR0b25SZWN0KFNjcm9sbGJhciosIFNjcm9sbGJhclBhcnQsIGJvb2wgcGFpbnRpbmcgPSBmYWxz ZSk7CiAgICAgICAgIHZpcnR1YWwgSW50UmVjdCB0cmFja1JlY3QoU2Nyb2xsYmFyKiwgYm9vbCBw YWludGluZyA9IGZhbHNlKTsKIAotICAgICAgICB2aXJ0dWFsIHZvaWQgcGFpbnRTY3JvbGxDb3Ju ZXIoU2Nyb2xsVmlldyosIEdyYXBoaWNzQ29udGV4dCosIGNvbnN0IEludFJlY3QmKTsKLQogICAg ICAgICB2aXJ0dWFsIHZvaWQgcGFpbnRUcmFja0JhY2tncm91bmQoR3JhcGhpY3NDb250ZXh0Kiwg U2Nyb2xsYmFyKiwgY29uc3QgSW50UmVjdCYpOwogICAgICAgICB2aXJ0dWFsIHZvaWQgcGFpbnRU aWNrbWFya3MoR3JhcGhpY3NDb250ZXh0KiwgU2Nyb2xsYmFyKiwgY29uc3QgSW50UmVjdCYpOwog Cg== 84532 2011-03-03 00:44:59 -0800 2011-03-04 08:07:32 -0800 Patch bug-55557-20110303004457.patch text/plain 6534 isherman U3VidmVyc2lvbiBSZXZpc2lvbjogODAwMDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyOTU2YTY1MWEyNTk0NDQ5 ZTk5NGFkMmZjOGIxZDg0Mzg1M2M3NzA1Li4xNzc0NmExNGE0NzlkZjI0ZTI2MTlmNDRiODU1NDA0 MjMzNTFjNGFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDMtMDIgIElseWEg U2hlcm1hbiAgPGlzaGVybWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdmVycmlkZSBwYWludFNjcm9sbENvcm5lcigpIGZv ciBGcmFtZWxlc3NTY3JvbGxWaWV3IHRvIGZvcmVnbyBhbnkgY3VzdG9tIHNjcm9sbGJhciBjb3Ju ZXIgcmVuZGVyaW5nLgorICAgICAgICBUaGlzIHdhcyBwcmV2aW91c2x5IGRvbmUgaW4gU2Nyb2xs YmFyVGhlbWVDaHJvbWl1bSwgYnV0IHdlIGFsc28gbmVlZCB0aGlzIG9uIHRoZSBNYWMgd2hlbiB0 aGUgU2Nyb2xsVmlldworICAgICAgICBpcyBhIEZyYW1lbGVzc1Njcm9sbFZpZXcgLS0gd2hpY2gg aXMgbW9zdGx5IGp1c3QgZm9yIEF1dG9maWxsLgorICAgICAgICBJbiBzZXJ2aWNlIG9mIGh0dHA6 Ly9jcmJ1Zy5jb20vNzM3NzIgKGNyYXNoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTU1NTcKKworICAgICAgICBObyB0ZXN0cyBhZGRlZCBiZWNhdXNl IHRoaXMgZml4IGlzIENocm9taXVtLXNwZWNpZmljIGFuZCB0aGUgY29kZSBpcyBjdXJyZW50bHkg dW50ZXN0YWJsZSBmcm9tIHdpdGhpbiBXZWJLaXQuCisgICAgICAgIEluIHBhcnRpY3VsYXIsIERS VCBjcmFzaGVzIHdoZW4gdHJ5aW5nIHRvIHJlbmRlciBhIEZyYW1lbGVzc1Njcm9sbFZpZXcuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxiYXJUaGVtZS5oOgorICAgICAgICAoV2ViQ29yZTo6 U2Nyb2xsYmFyVGhlbWU6OnBhaW50U2Nyb2xsQ29ybmVyKTogQm9keSBtb3ZlZCB0byBzdGF0aWMg ZnVuY3Rpb24gZGVmYXVsdFBhaW50U2Nyb2xsQ29ybmVyKCkuCisgICAgICAgIChXZWJDb3JlOjpT Y3JvbGxiYXJUaGVtZTo6ZGVmYXVsdFBhaW50U2Nyb2xsQ29ybmVyKTogQWRkZWQuCisgICAgICAg ICogcGxhdGZvcm0vY2hyb21pdW0vRnJhbWVsZXNzU2Nyb2xsVmlldy5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpGcmFtZWxlc3NTY3JvbGxWaWV3OjpwYWludENvbnRlbnRzKToKKyAgICAgICAgKFdl YkNvcmU6OkZyYW1lbGVzc1Njcm9sbFZpZXc6OnBhaW50U2Nyb2xsQ29ybmVyKTogRml4IGltcGxl bWVudGF0aW9uIG1vdmVkIHRvIGhlcmUgZnJvbSBTY3JvbGxiYXJUaGVtZUNocm9taXVtCisgICAg ICAgICogcGxhdGZvcm0vY2hyb21pdW0vRnJhbWVsZXNzU2Nyb2xsVmlldy5oOgorICAgICAgICAq IHBsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW0uY3BwOgorICAgICAgICAq IHBsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW0uaDoKKwogMjAxMS0wMy0w MSAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL1Njcm9sbGJhclRoZW1lLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxiYXJU aGVtZS5oCmluZGV4IGVmNTJiMGQ2ZTg5NGQzMjk2NzZiZGM2MTc0ZTE3Nzc0NjYzY2MwZjUuLmY1 YTEwYjc4Y2IxMTk0NzQzNjBiZTdlMjYzZGFiNjA3Nzk2ZDg1Y2UgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbGJhclRoZW1lLmgKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vU2Nyb2xsYmFyVGhlbWUuaApAQCAtNzYsNyArNzYsOCBAQCBwdWJsaWM6CiAKICAg ICB2aXJ0dWFsIHZvaWQgaW52YWxpZGF0ZVBhcnQoU2Nyb2xsYmFyKiwgU2Nyb2xsYmFyUGFydCkg e30KIAotICAgIHZpcnR1YWwgdm9pZCBwYWludFNjcm9sbENvcm5lcihTY3JvbGxWaWV3KiwgR3Jh cGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBJbnRSZWN0JiBjb3JuZXJSZWN0KSB7IGNvbnRl eHQtPmZpbGxSZWN0KGNvcm5lclJlY3QsIENvbG9yOjp3aGl0ZSwgQ29sb3JTcGFjZURldmljZVJH Qik7IH0KKyAgICB2aXJ0dWFsIHZvaWQgcGFpbnRTY3JvbGxDb3JuZXIoU2Nyb2xsVmlldyosIEdy YXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgSW50UmVjdCYgY29ybmVyUmVjdCkgeyBkZWZh dWx0UGFpbnRTY3JvbGxDb3JuZXIoY29udGV4dCwgY29ybmVyUmVjdCk7IH0KKyAgICBzdGF0aWMg dm9pZCBkZWZhdWx0UGFpbnRTY3JvbGxDb3JuZXIoR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBj b25zdCBJbnRSZWN0JiBjb3JuZXJSZWN0KSB7IGNvbnRleHQtPmZpbGxSZWN0KGNvcm5lclJlY3Qs IENvbG9yOjp3aGl0ZSwgQ29sb3JTcGFjZURldmljZVJHQik7IH0KIAogICAgIHZpcnR1YWwgYm9v bCBzaG91bGRDZW50ZXJPblRodW1iKFNjcm9sbGJhciosIGNvbnN0IFBsYXRmb3JtTW91c2VFdmVu dCYpIHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgdmlydHVhbCBib29sIHNob3VsZFNuYXBCYWNrVG9E cmFnT3JpZ2luKFNjcm9sbGJhciosIGNvbnN0IFBsYXRmb3JtTW91c2VFdmVudCYpIHsgcmV0dXJu IGZhbHNlOyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9G cmFtZWxlc3NTY3JvbGxWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVt L0ZyYW1lbGVzc1Njcm9sbFZpZXcuY3BwCmluZGV4IDNmYmYyZDY3ODMzMmRiOWRjZTNiZDFhYTc1 Y2ExODgyMjlkZTgzYmMuLmI2YThmNTNjNTA4YjE1MzBiNDk1MWU3OGM0NzIzMDM3NWMzYTgyYWUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0ZyYW1lbGVzc1Nj cm9sbFZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0ZyYW1l bGVzc1Njcm9sbFZpZXcuY3BwCkBAIC0zMiw2ICszMiw3IEBACiAjaW5jbHVkZSAiRnJhbWVsZXNz U2Nyb2xsVmlldy5oIgogCiAjaW5jbHVkZSAiRnJhbWVsZXNzU2Nyb2xsVmlld0NsaWVudC5oIgor I2luY2x1ZGUgIlNjcm9sbGJhclRoZW1lLmgiCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAt NzIsMTAgKzczLDE2IEBAIEludFJlY3QgRnJhbWVsZXNzU2Nyb2xsVmlldzo6d2luZG93Q2xpcFJl Y3QoYm9vbCBjbGlwVG9Db250ZW50cykgY29uc3QKICAgICByZXR1cm4gY29udGVudHNUb1dpbmRv dyh2aXNpYmxlQ29udGVudFJlY3QoIWNsaXBUb0NvbnRlbnRzKSk7CiB9CiAKLXZvaWQgRnJhbWVs ZXNzU2Nyb2xsVmlldzo6cGFpbnRDb250ZW50cyhHcmFwaGljc0NvbnRleHQqLCBjb25zdCBJbnRS ZWN0JiBkYW1hZ2VSZWN0KQordm9pZCBGcmFtZWxlc3NTY3JvbGxWaWV3OjpwYWludENvbnRlbnRz KEdyYXBoaWNzQ29udGV4dCosIGNvbnN0IEludFJlY3QmKQogewogfQogCit2b2lkIEZyYW1lbGVz c1Njcm9sbFZpZXc6OnBhaW50U2Nyb2xsQ29ybmVyKEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwg Y29uc3QgSW50UmVjdCYgY29ybmVyUmVjdCkKK3sKKyAgICAvLyBTY3JvbGxiYXJUaGVtZUNvbXBv c2l0ZTo6cGFpbnRTY3JvbGxDb3JuZXIgaW5jb3JyZWN0bHkgYXNzdW1lcyB0aGF0IHRoZSBTY3Jv bGxWaWV3IGlzIGEgRnJhbWVWaWV3LgorICAgIFNjcm9sbGJhclRoZW1lOjpkZWZhdWx0UGFpbnRT Y3JvbGxDb3JuZXIoY29udGV4dCwgY29ybmVyUmVjdCk7Cit9CisKIHZvaWQgRnJhbWVsZXNzU2Ny b2xsVmlldzo6Y29udGVudHNSZXNpemVkKCkKIHsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2Nocm9taXVtL0ZyYW1lbGVzc1Njcm9sbFZpZXcuaCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2Nocm9taXVtL0ZyYW1lbGVzc1Njcm9sbFZpZXcuaAppbmRleCAwMzNkOTUz MmEzYTRmOWM2YWJkOTdiODMyMGExNGQ2OTUyNDI2YTRjLi43MjQ4MjlkMzU2OWIwN2Q3MWRhYjRl MjU2ZjJjZGM4NzQ3Y2QzMDQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9j aHJvbWl1bS9GcmFtZWxlc3NTY3JvbGxWaWV3LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vY2hyb21pdW0vRnJhbWVsZXNzU2Nyb2xsVmlldy5oCkBAIC03NCw3ICs3NCw4IEBAIG5hbWVz cGFjZSBXZWJDb3JlIHsKIAogICAgIHByb3RlY3RlZDoKICAgICAgICAgLy8gU2Nyb2xsVmlldyBw cm90ZWN0ZWQgbWV0aG9kczoKLSAgICAgICAgdmlydHVhbCB2b2lkIHBhaW50Q29udGVudHMoR3Jh cGhpY3NDb250ZXh0KiwgY29uc3QgSW50UmVjdCYgZGFtYWdlUmVjdCk7CisgICAgICAgIHZpcnR1 YWwgdm9pZCBwYWludENvbnRlbnRzKEdyYXBoaWNzQ29udGV4dCosIGNvbnN0IEludFJlY3QmKTsK KyAgICAgICAgdmlydHVhbCB2b2lkIHBhaW50U2Nyb2xsQ29ybmVyKEdyYXBoaWNzQ29udGV4dCos IGNvbnN0IEludFJlY3QmIGNvcm5lclJlY3QpOwogICAgICAgICB2aXJ0dWFsIHZvaWQgY29udGVu dHNSZXNpemVkKCk7CiAgICAgICAgIHZpcnR1YWwgdm9pZCB2aXNpYmxlQ29udGVudHNSZXNpemVk KCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9s bGJhclRoZW1lQ2hyb21pdW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0v U2Nyb2xsYmFyVGhlbWVDaHJvbWl1bS5jcHAKaW5kZXggOWU3MDBjMjA1ZDM2OGIwZTk3NDk2NzIw ODM1MDI3MDc5ZGZmZjZkYy4uODQzZmMzY2JkMjg2ODVkYzdiNmExYWEwOWE3MjdjNDk3YmFlNTI3 ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFy VGhlbWVDaHJvbWl1bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0v U2Nyb2xsYmFyVGhlbWVDaHJvbWl1bS5jcHAKQEAgLTEzNywxMyArMTM3LDQgQEAgdm9pZCBTY3Jv bGxiYXJUaGVtZUNocm9taXVtOjpwYWludFRpY2ttYXJrcyhHcmFwaGljc0NvbnRleHQqIGNvbnRl eHQsIFNjcm9sbGJhcioKICAgICBjb250ZXh0LT5yZXN0b3JlKCk7CiB9CiAKLXZvaWQgU2Nyb2xs YmFyVGhlbWVDaHJvbWl1bTo6cGFpbnRTY3JvbGxDb3JuZXIoU2Nyb2xsVmlldyogdmlldywgR3Jh cGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBJbnRSZWN0JiBjb3JuZXJSZWN0KQotewotICAg IC8vIFNjcm9sbGJhclRoZW1lQ29tcG9zaXRlOjpwYWludFNjcm9sbENvcm5lciBpbmNvcnJlY3Rs eSBhc3N1bWVzIHRoYXQgdGhlCi0gICAgLy8gU2Nyb2xsVmlldyBpcyBhIEZyYW1lVmlldyAoc2Vl IEZyYW1lbGVzc1Njcm9sbFZpZXcpLCBzbyB3ZSBjYW5ub3QgbGV0Ci0gICAgLy8gdGhhdCBjb2Rl IHJ1bi4gIEZvciBGcmFtZVZpZXcncyB0aGlzIGlzIGNvcnJlY3Qgc2luY2Ugd2UgZG9uJ3QgZG8g Y3VzdG9tCi0gICAgLy8gc2Nyb2xsYmFyIGNvcm5lciByZW5kZXJpbmcsIHdoaWNoIFNjcm9sbGJh clRoZW1lQ29tcG9zaXRlIHN1cHBvcnRzLgotICAgIFNjcm9sbGJhclRoZW1lOjpwYWludFNjcm9s bENvcm5lcih2aWV3LCBjb250ZXh0LCBjb3JuZXJSZWN0KTsKLX0KLQogfSAvLyBuYW1lc3BhY2Ug V2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vU2Ny b2xsYmFyVGhlbWVDaHJvbWl1bS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0v U2Nyb2xsYmFyVGhlbWVDaHJvbWl1bS5oCmluZGV4IGI1M2Q0YWUxNmFkYmU5OGYzZjg2YjQ4NmM3 YzdhNWVkMDg1OGVlYjYuLjExNzgxMjU2OWY2OWYyMDAzNzFiYWMwZjlkYTg3YTdjMzJkZTRmYTUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRo ZW1lQ2hyb21pdW0uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3Jv bGxiYXJUaGVtZUNocm9taXVtLmgKQEAgLTQ4LDggKzQ4LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUg ewogICAgICAgICB2aXJ0dWFsIEludFJlY3QgZm9yd2FyZEJ1dHRvblJlY3QoU2Nyb2xsYmFyKiwg U2Nyb2xsYmFyUGFydCwgYm9vbCBwYWludGluZyA9IGZhbHNlKTsKICAgICAgICAgdmlydHVhbCBJ bnRSZWN0IHRyYWNrUmVjdChTY3JvbGxiYXIqLCBib29sIHBhaW50aW5nID0gZmFsc2UpOwogCi0g ICAgICAgIHZpcnR1YWwgdm9pZCBwYWludFNjcm9sbENvcm5lcihTY3JvbGxWaWV3KiwgR3JhcGhp Y3NDb250ZXh0KiwgY29uc3QgSW50UmVjdCYpOwotCiAgICAgICAgIHZpcnR1YWwgdm9pZCBwYWlu dFRyYWNrQmFja2dyb3VuZChHcmFwaGljc0NvbnRleHQqLCBTY3JvbGxiYXIqLCBjb25zdCBJbnRS ZWN0Jik7CiAgICAgICAgIHZpcnR1YWwgdm9pZCBwYWludFRpY2ttYXJrcyhHcmFwaGljc0NvbnRl eHQqLCBTY3JvbGxiYXIqLCBjb25zdCBJbnRSZWN0Jik7CiAK