<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>55532</bug_id>
          
          <creation_ts>2011-03-01 17:04:13 -0800</creation_ts>
          <short_desc>Teach JavaScriptCore GYP build about private headers</short_desc>
          <delta_ts>2011-03-03 20:30:13 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>55018</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Barth">abarth</reporter>
          <assigned_to name="Adam Barth">abarth</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>dglazkov</cc>
    
    <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>360404</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-01 17:04:13 -0800</bug_when>
    <thetext>Teach JavaScriptCore GYP build about private headers</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>360406</commentid>
    <comment_count>1</comment_count>
      <attachid>84329</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-01 17:05:35 -0800</bug_when>
    <thetext>Created attachment 84329
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>360407</commentid>
    <comment_count>2</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-01 17:05:51 -0800</bug_when>
    <thetext>This patch depends on this GYP patch:

http://codereview.chromium.org/6592088/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>360409</commentid>
    <comment_count>3</comment_count>
      <attachid>84329</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-03-01 17:08:29 -0800</bug_when>
    <thetext>Comment on attachment 84329
Patch

OK.  I&apos;ll let you CQ it if your gyp patch lands.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>361843</commentid>
    <comment_count>4</comment_count>
      <attachid>84329</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-03 12:38:13 -0800</bug_when>
    <thetext>Comment on attachment 84329
Patch

The GYP change has landed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>362216</commentid>
    <comment_count>5</comment_count>
      <attachid>84329</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-03-03 20:09:51 -0800</bug_when>
    <thetext>Comment on attachment 84329
Patch

Clearing flags on attachment: 84329

Committed r80312: &lt;http://trac.webkit.org/changeset/80312&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>362217</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-03-03 20:09:56 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>362228</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-03-03 20:30:13 -0800</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 84329:

security/block-test.html bug 55741 (authors: beidson@apple.com, mrowe@apple.com, and sam@webkit.org)
The commit-queue is continuing to process your patch.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>84329</attachid>
            <date>2011-03-01 17:05:35 -0800</date>
            <delta_ts>2011-03-03 20:09:51 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-55532-20110301170534.patch</filename>
            <type>text/plain</type>
            <size>1682</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODAwMjAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDU5
ZGM3NTlkODZmYjgzZjM2MWE5MmVhMjE5MGQ3MDNkNmMzYmQwNTguLmNkYzZiNDJiMDA3YmM5YWE4
YzJlYTdjNDU3NWQ4OWYwMjRhZWQ1ZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMiw2
ICsyLDE5IEBACiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCiAKKyAgICAg
ICAgVGVhY2ggSmF2YVNjcmlwdENvcmUgR1lQIGJ1aWxkIGFib3V0IHByaXZhdGUgaGVhZGVycwor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU1MzIKKwor
ICAgICAgICBUaGlzIHBhdGNoIGRpc3Rpbmd1aXNoZXMgYmV0d2VlbiBwdWJsaWMgYW5kIHByaXZh
dGUgZnJhbWV3b3JrIGhlYWRlcnMKKyAgICAgICAgc28gdGhhdCBwdWJsaWMgaGVhZGVycyBhcmUg
Y29waWVkIGludG8gdGhlIEhlYWRlcnMgZGlyZWN0b3J5IGFuZAorICAgICAgICBwcml2YXRlIGhl
YWRlcnMgYXJlIGNvcGllZCBpbnRvIHRoZSBQcml2YXRlSGVhZGVycyBkaXJlY3RvcnkuCisKKyAg
ICAgICAgKiBneXAvSmF2YVNjcmlwdENvcmUuZ3lwOgorCisyMDExLTAzLTAxICBBZGFtIEJhcnRo
ICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKICAgICAgICAgSmF2YVNjcmlwdENvcmUgR1lQIGJ1aWxkIHNob3VsZCBjb3B5IHNvbWUg
aGVhZGVycyBpbnRvIHRoZSB0YXJnZXQgZnJhbWV3b3JrCiAgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTUyNAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvZ3lwL0phdmFTY3JpcHRDb3JlLmd5cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9neXAvSmF2YVNjcmlwdENvcmUuZ3lwCmluZGV4IGE3ZDI2NDU5NTUyOGQxYWQ2YjY3MWVjMmE5
YTgwNWU3YzY2MGY1ODguLjg2Nzc4OTc4M2ZkMWJkNzcyMzBiYWVlZmZiNzlhMDgwODE0ZjBlMGUg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9neXAvSmF2YVNjcmlwdENvcmUuZ3lw
CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9neXAvSmF2YVNjcmlwdENvcmUuZ3lwCkBAIC00
NCw3ICs0NCw5IEBACiAgICAgICBdLAogICAgICAgJ21hY19mcmFtZXdvcmtfaGVhZGVycyc6IFsK
ICAgICAgICAgJzxAKGphdmFzY3JpcHRjb3JlX3B1YmxpY2hlYWRlcl9maWxlcyknLAotICAgICAg
ICAnPEAoamF2YXNjcmlwdGNvcmVfcHJpdmF0ZWhlYWRlcl9maWxlcyknLCAjIEZJWE1FOiBUaGVz
ZSBzaG91bGQgYmUgcHJpdmF0ZSBoZWFkZXJzLgorICAgICAgXSwKKyAgICAgICdtYWNfZnJhbWV3
b3JrX3ByaXZhdGVfaGVhZGVycyc6IFsKKyAgICAgICAgJzxAKGphdmFzY3JpcHRjb3JlX3ByaXZh
dGVoZWFkZXJfZmlsZXMpJywKICAgICAgIF0sCiAgICAgICAneGNvZGVfY29uZmlnX2ZpbGUnOiAn
PChERVBUSCkvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvSmF2YVNjcmlwdENvcmUueGNj
b25maWcnLAogICAgICAgJ3NvdXJjZXMvJzogWwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>