55523 2011-03-01 16:19:45 -0800 Fix a bug in platform/mac/editing/input/selection-change-closes-typing.html 2011-03-17 15:44:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED INVALID P2 Normal --- 56588 51389 1 rniwa webkit-unassigned ap darin oldest_to_newest 360351 0 rniwa 2011-03-01 16:19:45 -0800 In platform/mac/editing/input/selection-change-closes-typing.html, we do: textInputController.setMarkedText("P", 1, 0); testInput.value="PAS"; eventSender.keyDown("S"); but it should read: textInputController.setMarkedText("P", 0, 1); testInput.value="PAS"; eventSender.keyDown("S"); because textInput initially has no value, and the marked text must be inserted at offset 0 with length 1, not at offset 1 with length 0. 360355 1 84320 rniwa 2011-03-01 16:22:39 -0800 Created attachment 84320 fixes the bug 360377 2 rniwa 2011-03-01 16:38:27 -0800 Thanks for the review, Alexey! 360383 3 rniwa 2011-03-01 16:45:18 -0800 Committed r80064: <http://trac.webkit.org/changeset/80064> 369353 4 ap 2011-03-17 15:35:55 -0700 This got reverted in bug 56588. 84320 2011-03-01 16:22:39 -0800 2011-03-01 16:32:15 -0800 fixes the bug bug-55523-20110302092237.patch text/plain 1333 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDgwMDYwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDMtMDEgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRml4IGEgYnVnIGluIHBsYXRmb3JtL21hYy9lZGl0aW5nL2lucHV0L3NlbGVjdGlv bi1jaGFuZ2UtY2xvc2VzLXR5cGluZy5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01NTUyMworCisgICAgICAgIFRoZSBtYXJrZWQgdGV4dCBpcyBh dCBvZmZzZXQgMCB3aXRoIGxlbmd0aCAxLCBub3QgYXQgb2Zmc2V0IDEgd2l0aCBsZW5ndGggMC4K KworICAgICAgICAqIHBsYXRmb3JtL21hYy9lZGl0aW5nL2lucHV0L3NlbGVjdGlvbi1jaGFuZ2Ut Y2xvc2VzLXR5cGluZy5odG1sOgorCiAyMDExLTAzLTAxICBSeW9zdWtlIE5pd2EgIDxybml3YUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2VkaXRpbmcvaW5wdXQvc2VsZWN0aW9uLWNoYW5nZS1jbG9z ZXMtdHlwaW5nLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Vk aXRpbmcvaW5wdXQvc2VsZWN0aW9uLWNoYW5nZS1jbG9zZXMtdHlwaW5nLmh0bWwJKHJldmlzaW9u IDgwMDYwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2VkaXRpbmcvaW5wdXQvc2VsZWN0 aW9uLWNoYW5nZS1jbG9zZXMtdHlwaW5nLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTE1LDcgKzE1 LDcgQEAgV2l0aCBQaW55aW4gU2ltcGxpZmllZCBJTSwgYSB3cm9uZyBjaGFyYQogICAgIGlmICh3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKICAgICAgICAgCiAgICAgICAgIHRyeSB7Ci0g ICAgICAgICAgICB0ZXh0SW5wdXRDb250cm9sbGVyLnNldE1hcmtlZFRleHQoIlAiLCAxLCAwKTsK KyAgICAgICAgICAgIHRleHRJbnB1dENvbnRyb2xsZXIuc2V0TWFya2VkVGV4dCgiUCIsIDAsIDEp OwogICAgICAgICAgICAgdGVzdElucHV0LnZhbHVlPSJQQVMiOwogICAgICAgICAgICAgZXZlbnRT ZW5kZXIua2V5RG93bigiUyIpOwogCg==