55505 2011-03-01 14:06:05 -0800 ApplicationCache - doesn't pick the "most appropriate" cache when there are multiple candidates 2024-03-19 08:03:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED WONTFIX P2 Normal --- 1 michaeln webkit-unassigned annevk ap commit-queue michaeln webkit.review.bot oldest_to_newest 360211 0 michaeln 2011-03-01 14:06:05 -0800 Please see http://code.google.com/p/chromium/issues/detail?id=68479 for some history. -- some comments from the chromium bug --- URLs? http://dictionarymid.sourceforge.net/htmlApp/playground/EngLat_IDP1/ http://dictionarymid.sourceforge.net/htmlApp/playground/EngLat_IDP2/ Other browsers tested: Add OK or FAIL after other browsers where you have tested this issue: Safari 5: FAIL Firefox 3.x: FAIL Firefox 4 : OK IE 7/8: N/A [does not support Application Cache] What steps will reproduce the problem? 1. Open http://dictionarymid.sourceforge.net/htmlApp/playground/EngLat_IDP1/ 2. Wait for application cache to be loaded (total of 127 files; press "cache info" and wait for status 'IDLE') 3. Open http://dictionarymid.sourceforge.net/htmlApp/playground/EngLat_IDP2/ What is the expected result? The URL from step 3. is correctly loaded, no error occurs. What happens instead? An error window pops up: "XMLHttpRequestSend Exception 101" Both manifests contain the same URLs from the ../htmlApp directory # # HTML files for mini_hmi # . ../htmlApp/mini_hmi/OptionWindow.html # # Files generated by GWT # ../htmlApp/translationlayergwt/0DFD596AF51F4CC7A00293FBD296E92A.cache.html ../htmlApp/translationlayergwt/688A00B4C9356DCDA436BE1DA13D5CBA.cache.html ../htmlApp/translationlayergwt/720FBED404E45C61EFEA4E4AD451AB8F.cache.html ../htmlApp/translationlayergwt/8EC125F3977CC8A7FC592AE673DBFB17.cache.html ../htmlApp/translationlayergwt/clear.cache.gif ../htmlApp/translationlayergwt/hosted.html ../htmlApp/translationlayergwt/translationlayergwt.nocache.js When one of these duplicate resources is loaded as a document into a frame, the system has to pick one of the two instances to load. The spec is squishy about which to pick (it isn't specified), but our impl clearly chooses the wrong one in this case. Both apps are loading 8EC125F3977CC8A7FC592AE673DBFB17.cache.html into a subframe. Since the parent frame's appcache contains the resource its pretty clear that the system should load the resource from the parent frames manifest... but its not doing that. Similarly when mini_hmi/OptionWindow.html is opened in a seperate window, that should load the resource from the invoking frame's appcache (if present in that cache), but currently its not guaranteed to do that. To fix this I'll think we'll need to inform the appcache about which document (ultimately the appcache in use by that document) caused the creation of the document being loaded. In the case of a subframe that's the parent document, and in the case of a pop out window it's the opener document. And in the case of starting a shared worker, the invoking document. Ideally basic <a> tag navigations should also be sensitive to which document initiated the navigation. 360592 1 ap 2011-03-01 22:36:56 -0800 Specifically, HTML5 says: ----------------------------------- Multiple application caches in different application cache groups can contain the same resource, e.g. if the manifests all reference that resource. If the user agent is to select an application cache from a list of relevant application caches that contain a resource, the user agent must use the application cache that the user most likely wants to see the resource from, taking into account the following: which application cache was most recently updated, which application cache was being used to display the resource from which the user decided to look at the new resource, and which application cache the user prefers. ----------------------------------- Cross platform WebKit code makes no attempt to implement that yet, indeed. 360958 2 michaeln 2011-03-02 12:02:14 -0800 > Cross platform WebKit code makes no attempt to implement that yet, indeed. Neither does chrome, but this seems like a pretty big rough edge that i'm interested in smoothing out. Doing so may involve changes to some of the code that we do share... "which application cache was being used to display the resource from which the user decided to look at the new resource" ... arranging for that input in particular when choosing which cached main resource to load. 367421 3 85753 michaeln 2011-03-14 18:42:21 -0700 Created attachment 85753 frameParam Some groundwork for fixing this in chromium. An additional webFrame parameter to a webkit api so chromium's impl has enough info to figure out the "most appropiate". 367427 4 webkit.review.bot 2011-03-14 18:44:58 -0700 Attachment 85753 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/public/WebApplicationCacheHost.h:80: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 367458 5 85762 michaeln 2011-03-14 19:30:09 -0700 Created attachment 85762 frameParam fix style'ism 367489 6 85762 ap 2011-03-14 21:06:13 -0700 Comment on attachment 85762 frameParam OK. I would suggest fixing cross-platform code behavior first if possible though. As this is an observable behavior, it's something we should maintain parity at, and working on code that has more parties interested in would guarantee fewer surprises than backporting from Chromium branch. 367991 7 commit-queue 2011-03-15 15:29:54 -0700 The commit-queue encountered the following flaky tests while processing attachment 85762: transitions/interrupted-accelerated-transition.html bug 56242 (authors: simon.fraser@apple.com and tonyg@chromium.org) The commit-queue is continuing to process your patch. 367993 8 85762 commit-queue 2011-03-15 15:31:50 -0700 Comment on attachment 85762 frameParam Clearing flags on attachment: 85762 Committed r81183: <http://trac.webkit.org/changeset/81183> 367994 9 commit-queue 2011-03-15 15:31:56 -0700 All reviewed patches have been landed. Closing bug. 367995 10 michaeln 2011-03-15 15:33:00 -0700 reopening, the initial patch was just some groundwork 367998 11 commit-queue 2011-03-15 15:36:55 -0700 The commit-queue encountered the following flaky tests while processing attachment 85762: transitions/interrupted-accelerated-transition.html bug 56242 (authors: simon.fraser@apple.com and tonyg@chromium.org) The commit-queue is continuing to process your patch. 371906 12 michaeln 2011-03-22 18:55:46 -0700 My plan for this in chrome is to modify the storage.FindResponseForMainRequest method to accept an additional input about which manifest_url the caller would like a bias towards, and to provide that input based on the manifest used by the opener|parent. Ties would go to the resource from the preferred manifest_url. I've got a start at this here... http://codereview.chromium.org/6727006/ A further refinement could be to have a bias towards the manifest used by the document currently residing in the frame into which a new document is being loaded, but for now i'm just starting with what the opener|parent has to say. I have not looked at webcore's impl in any detail, but breaking ties in the same way should be possible there too. 387007 13 michaeln 2011-04-15 16:22:23 -0700 I've landed changes in the chromium along these lines, here's the CL description. Select a more appropiate appcache based on the opener or the parent or the target frame of the new document. The change determines a 'preferred manifest url' in these cases: * <iframe> loading, we prefer the parent frame's manifest url * window.open() loading, we prefer the opener frame's manifest url * href clicking to navigate a frame in place, we prefer the manifest url of the document in the frame when the navigation starts More details can be found here. http://code.google.com/p/chromium/issues/detail?id=68479 2022137 14 annevk 2024-03-19 08:03:26 -0700 This feature is in the process of being removed. 85753 2011-03-14 18:42:21 -0700 2011-03-14 19:30:09 -0700 frameParam frameParam.txt text/plain 3567 michaeln SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4MTA5MSkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTEtMDMtMTQgIE1pY2hhZWwgTm9yZG1hbiAgPG1pY2hhZWxuQGdvb2dsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBpbml0 aWF0aW5nIGEgbWFpbiByZXNvdXJjZSBsb2FkLCBsZXQgdGhlIGFwcGxpY2F0aW9uIGNhY2hlCisg ICAgICAgIGtub3cgd2hpY2ggZnJhbWUgdGhlIGxvYWQgaXMgYmVpbmcgY29uZHVjdGVkIGZvci4g VGhpcyBwYXRjaCBkb2Vzbid0CisgICAgICAgIHJlc29sdmUgdGhlIGZvbGxvd2luZyBidWcsIGJ1 dCB0aGUgYWRkaXRpb25hbCBXZWJGcmFtZSBwYXJhbWV0ZXIKKyAgICAgICAgc2hvdWxkIHByb3Zp ZGUgdGhlIGNocm9taXVtIHBvcnQgd2l0aCBlbm91Z2ggaW5mbyB0byBwaWNrIHRoZQorICAgICAg ICAibW9zdCBhcHByb3BpYXRlIiBjYWNoZWQgcmVzb3VyY2UuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTUwNQorCisgICAgICAgIEFsc28gZml4dXAg YSBzdGFsZSBjb21tZW50IGluIHN0b3BMb2FkaW5nSW5GcmFtZS4KKworICAgICAgICAqIHB1Ymxp Yy9XZWJBcHBsaWNhdGlvbkNhY2hlSG9zdC5oOgorICAgICAgICAoV2ViS2l0OjpXZWJBcHBsaWNh dGlvbkNhY2hlSG9zdDo6d2lsbFN0YXJ0TWFpblJlc291cmNlUmVxdWVzdCk6CisgICAgICAgICog c3JjL0FwcGxpY2F0aW9uQ2FjaGVIb3N0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFwcGxpY2F0 aW9uQ2FjaGVIb3N0OjptYXliZUxvYWRNYWluUmVzb3VyY2UpOgorICAgICAgICAoV2ViQ29yZTo6 QXBwbGljYXRpb25DYWNoZUhvc3Q6OnN0b3BMb2FkaW5nSW5GcmFtZSk6CisKIDIwMTEtMDMtMTQg IEpvaG4gS25vdHRlbmJlbHQgIDxqa25vdHRlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgU3RldmUgQmxvY2suCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJBcHBsaWNhdGlvbkNhY2hlSG9zdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkFwcGxpY2F0aW9uQ2FjaGVIb3N0LmgJKHJldmlzaW9uIDgxMDg3 KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQXBwbGljYXRpb25DYWNoZUhv c3QuaAkod29ya2luZyBjb3B5KQpAQCAtMzgsNiArMzgsNyBAQAogbmFtZXNwYWNlIFdlYktpdCB7 CiAKIGNsYXNzIFdlYkFwcGxpY2F0aW9uQ2FjaGVIb3N0Q2xpZW50OworY2xhc3MgV2ViRnJhbWU7 CiBjbGFzcyBXZWJVUkw7CiBjbGFzcyBXZWJVUkxSZXF1ZXN0OwogY2xhc3MgV2ViVVJMUmVzcG9u c2U7CkBAIC03Myw5ICs3NCwxMSBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB+V2ViQXBwbGljYXRp b25DYWNoZUhvc3QoKSB7IH0KIAogICAgIC8vIENhbGxlZCBmb3IgZXZlcnkgcmVxdWVzdCBtYWRl IHdpdGhpbiB0aGUgY29udGV4dC4KLSAgICB2aXJ0dWFsIHZvaWQgd2lsbFN0YXJ0TWFpblJlc291 cmNlUmVxdWVzdChXZWJVUkxSZXF1ZXN0JikgeyB9CisgICAgdmlydHVhbCB2b2lkIHdpbGxTdGFy dE1haW5SZXNvdXJjZVJlcXVlc3QoV2ViVVJMUmVxdWVzdCYgciwgY29uc3QgV2ViRnJhbWUqKSB7 IHdpbGxTdGFydE1haW5SZXNvdXJjZVJlcXVlc3Qocik7IH0KICAgICB2aXJ0dWFsIHZvaWQgd2ls bFN0YXJ0U3ViUmVzb3VyY2VSZXF1ZXN0KFdlYlVSTFJlcXVlc3QmKSB7IH0KIAorICAgIHZpcnR1 YWwgdm9pZCB3aWxsU3RhcnRNYWluUmVzb3VyY2VSZXF1ZXN0KFdlYlVSTFJlcXVlc3QmKSB7IH0g IC8vIERFUFJFQ0FURUQsIHJlbW92ZSBhZnRlciBkZXJpdmVkIGNsYXNzZXMgaGF2ZSBjYXVnaHQg dXAuCisKICAgICAvLyBPbmUgb3IgdGhlIG90aGVyIHNlbGVjdENhY2hlIG1ldGhvZHMgaXMgY2Fs bGVkIGFmdGVyIGhhdmluZyBwYXJzZWQgdGhlIDxodG1sPiB0YWcuCiAgICAgLy8gVGhlIGxhdHRl ciByZXR1cm5zIGZhbHNlIGlmIHRoZSBjdXJyZW50IGRvY3VtZW50IGhhcyBiZWVuIGlkZW50aWZp ZWQgYXMgYSAiZm9yZWlnbiIKICAgICAvLyBlbnRyeSwgaW4gd2hpY2ggY2FzZSB0aGUgZnJhbWUg bmF2aWdhdGlvbiB3aWxsIGJlIHJlc3RhcnRlZCBieSB3ZWJraXQuCkluZGV4OiBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXBwbGljYXRpb25DYWNoZUhvc3QuY3BwCShyZXZp c2lvbiA4MTA4NykKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0FwcGxpY2F0aW9uQ2Fj aGVIb3N0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDIsNiArNDIsNyBAQAogI2luY2x1ZGUgIlBh Z2UuaCIKICNpbmNsdWRlICJQcm9ncmVzc0V2ZW50LmgiCiAjaW5jbHVkZSAiU2V0dGluZ3MuaCIK KyNpbmNsdWRlICJXZWJGcmFtZUltcGwuaCIKICNpbmNsdWRlICJXZWJVUkwuaCIKICNpbmNsdWRl ICJXZWJVUkxFcnJvci5oIgogI2luY2x1ZGUgIldlYlVSTFJlc3BvbnNlLmgiCkBAIC04MSw3ICs4 Miw3IEBAIHZvaWQgQXBwbGljYXRpb25DYWNoZUhvc3Q6Om1heWJlTG9hZE1haW4KICAgICBtX2lu dGVybmFsLnNldChuZXcgQXBwbGljYXRpb25DYWNoZUhvc3RJbnRlcm5hbCh0aGlzKSk7CiAgICAg aWYgKG1faW50ZXJuYWwtPm1fb3V0ZXJIb3N0KSB7CiAgICAgICAgIFdyYXBwZWRSZXNvdXJjZVJl cXVlc3Qgd3JhcHBlZChyZXF1ZXN0KTsKLSAgICAgICAgbV9pbnRlcm5hbC0+bV9vdXRlckhvc3Qt PndpbGxTdGFydE1haW5SZXNvdXJjZVJlcXVlc3Qod3JhcHBlZCk7CisgICAgICAgIG1faW50ZXJu YWwtPm1fb3V0ZXJIb3N0LT53aWxsU3RhcnRNYWluUmVzb3VyY2VSZXF1ZXN0KHdyYXBwZWQsIFdl YkZyYW1lSW1wbDo6ZnJvbUZyYW1lKG1fZG9jdW1lbnRMb2FkZXItPmZyYW1lKCkpKTsKICAgICB9 IGVsc2UKICAgICAgICAgbV9pbnRlcm5hbC5jbGVhcigpOwogCkBAIC0yNTksNyArMjYwLDcgQEAg dm9pZCBBcHBsaWNhdGlvbkNhY2hlSG9zdDo6c3RvcERlZmVycmluZwogCiB2b2lkIEFwcGxpY2F0 aW9uQ2FjaGVIb3N0OjpzdG9wTG9hZGluZ0luRnJhbWUoRnJhbWUqIGZyYW1lKQogewotICAgIC8v IEZJWE1FOiBJbXBsZW1lbnQgdGhpcyBtZXRob2QuCisgICAgLy8gTi9BIHRvIHRoZSBjaHJvbWl1 bSBwb3J0CiB9CiAKIHZvaWQgQXBwbGljYXRpb25DYWNoZUhvc3Q6OmRpc3BhdGNoRE9NRXZlbnQo RXZlbnRJRCBpZCwgaW50IHRvdGFsLCBpbnQgZG9uZSkK 85762 2011-03-14 19:30:09 -0700 2011-03-15 15:31:50 -0700 frameParam frameParam2.txt text/plain 3566 michaeln SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4MTA5MSkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTEtMDMtMTQgIE1pY2hhZWwgTm9yZG1hbiAgPG1pY2hhZWxuQGdvb2dsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBpbml0 aWF0aW5nIGEgbWFpbiByZXNvdXJjZSBsb2FkLCBsZXQgdGhlIGFwcGxpY2F0aW9uIGNhY2hlCisg ICAgICAgIGtub3cgd2hpY2ggZnJhbWUgdGhlIGxvYWQgaXMgYmVpbmcgY29uZHVjdGVkIGZvci4g VGhpcyBwYXRjaCBkb2Vzbid0CisgICAgICAgIHJlc29sdmUgdGhlIGZvbGxvd2luZyBidWcsIGJ1 dCB0aGUgYWRkaXRpb25hbCBXZWJGcmFtZSBwYXJhbWV0ZXIKKyAgICAgICAgc2hvdWxkIHByb3Zp ZGUgdGhlIGNocm9taXVtIHBvcnQgd2l0aCBlbm91Z2ggaW5mbyB0byBwaWNrIHRoZQorICAgICAg ICAibW9zdCBhcHByb3BpYXRlIiBjYWNoZWQgcmVzb3VyY2UuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTUwNQorCisgICAgICAgIEFsc28gZml4dXAg YSBzdGFsZSBjb21tZW50IGluIHN0b3BMb2FkaW5nSW5GcmFtZS4KKworICAgICAgICAqIHB1Ymxp Yy9XZWJBcHBsaWNhdGlvbkNhY2hlSG9zdC5oOgorICAgICAgICAoV2ViS2l0OjpXZWJBcHBsaWNh dGlvbkNhY2hlSG9zdDo6d2lsbFN0YXJ0TWFpblJlc291cmNlUmVxdWVzdCk6CisgICAgICAgICog c3JjL0FwcGxpY2F0aW9uQ2FjaGVIb3N0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFwcGxpY2F0 aW9uQ2FjaGVIb3N0OjptYXliZUxvYWRNYWluUmVzb3VyY2UpOgorICAgICAgICAoV2ViQ29yZTo6 QXBwbGljYXRpb25DYWNoZUhvc3Q6OnN0b3BMb2FkaW5nSW5GcmFtZSk6CisKIDIwMTEtMDMtMTQg IEpvaG4gS25vdHRlbmJlbHQgIDxqa25vdHRlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgU3RldmUgQmxvY2suCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJBcHBsaWNhdGlvbkNhY2hlSG9zdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkFwcGxpY2F0aW9uQ2FjaGVIb3N0LmgJKHJldmlzaW9uIDgxMDg3 KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQXBwbGljYXRpb25DYWNoZUhv c3QuaAkod29ya2luZyBjb3B5KQpAQCAtMzgsNiArMzgsNyBAQAogbmFtZXNwYWNlIFdlYktpdCB7 CiAKIGNsYXNzIFdlYkFwcGxpY2F0aW9uQ2FjaGVIb3N0Q2xpZW50OworY2xhc3MgV2ViRnJhbWU7 CiBjbGFzcyBXZWJVUkw7CiBjbGFzcyBXZWJVUkxSZXF1ZXN0OwogY2xhc3MgV2ViVVJMUmVzcG9u c2U7CkBAIC03Myw5ICs3NCwxMSBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB+V2ViQXBwbGljYXRp b25DYWNoZUhvc3QoKSB7IH0KIAogICAgIC8vIENhbGxlZCBmb3IgZXZlcnkgcmVxdWVzdCBtYWRl IHdpdGhpbiB0aGUgY29udGV4dC4KLSAgICB2aXJ0dWFsIHZvaWQgd2lsbFN0YXJ0TWFpblJlc291 cmNlUmVxdWVzdChXZWJVUkxSZXF1ZXN0JikgeyB9CisgICAgdmlydHVhbCB2b2lkIHdpbGxTdGFy dE1haW5SZXNvdXJjZVJlcXVlc3QoV2ViVVJMUmVxdWVzdCYgciwgY29uc3QgV2ViRnJhbWUqKSB7 IHdpbGxTdGFydE1haW5SZXNvdXJjZVJlcXVlc3Qocik7IH0KICAgICB2aXJ0dWFsIHZvaWQgd2ls bFN0YXJ0U3ViUmVzb3VyY2VSZXF1ZXN0KFdlYlVSTFJlcXVlc3QmKSB7IH0KIAorICAgIHZpcnR1 YWwgdm9pZCB3aWxsU3RhcnRNYWluUmVzb3VyY2VSZXF1ZXN0KFdlYlVSTFJlcXVlc3QmKSB7IH0g Ly8gREVQUkVDQVRFRCwgcmVtb3ZlIGFmdGVyIGRlcml2ZWQgY2xhc3NlcyBoYXZlIGNhdWdodCB1 cC4KKwogICAgIC8vIE9uZSBvciB0aGUgb3RoZXIgc2VsZWN0Q2FjaGUgbWV0aG9kcyBpcyBjYWxs ZWQgYWZ0ZXIgaGF2aW5nIHBhcnNlZCB0aGUgPGh0bWw+IHRhZy4KICAgICAvLyBUaGUgbGF0dGVy IHJldHVybnMgZmFsc2UgaWYgdGhlIGN1cnJlbnQgZG9jdW1lbnQgaGFzIGJlZW4gaWRlbnRpZmll ZCBhcyBhICJmb3JlaWduIgogICAgIC8vIGVudHJ5LCBpbiB3aGljaCBjYXNlIHRoZSBmcmFtZSBu YXZpZ2F0aW9uIHdpbGwgYmUgcmVzdGFydGVkIGJ5IHdlYmtpdC4KSW5kZXg6IFNvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL0FwcGxpY2F0aW9uQ2FjaGVIb3N0LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHAJKHJldmlz aW9uIDgxMDg3KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXBwbGljYXRpb25DYWNo ZUhvc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Miw2ICs0Miw3IEBACiAjaW5jbHVkZSAiUGFn ZS5oIgogI2luY2x1ZGUgIlByb2dyZXNzRXZlbnQuaCIKICNpbmNsdWRlICJTZXR0aW5ncy5oIgor I2luY2x1ZGUgIldlYkZyYW1lSW1wbC5oIgogI2luY2x1ZGUgIldlYlVSTC5oIgogI2luY2x1ZGUg IldlYlVSTEVycm9yLmgiCiAjaW5jbHVkZSAiV2ViVVJMUmVzcG9uc2UuaCIKQEAgLTgxLDcgKzgy LDcgQEAgdm9pZCBBcHBsaWNhdGlvbkNhY2hlSG9zdDo6bWF5YmVMb2FkTWFpbgogICAgIG1faW50 ZXJuYWwuc2V0KG5ldyBBcHBsaWNhdGlvbkNhY2hlSG9zdEludGVybmFsKHRoaXMpKTsKICAgICBp ZiAobV9pbnRlcm5hbC0+bV9vdXRlckhvc3QpIHsKICAgICAgICAgV3JhcHBlZFJlc291cmNlUmVx dWVzdCB3cmFwcGVkKHJlcXVlc3QpOwotICAgICAgICBtX2ludGVybmFsLT5tX291dGVySG9zdC0+ d2lsbFN0YXJ0TWFpblJlc291cmNlUmVxdWVzdCh3cmFwcGVkKTsKKyAgICAgICAgbV9pbnRlcm5h bC0+bV9vdXRlckhvc3QtPndpbGxTdGFydE1haW5SZXNvdXJjZVJlcXVlc3Qod3JhcHBlZCwgV2Vi RnJhbWVJbXBsOjpmcm9tRnJhbWUobV9kb2N1bWVudExvYWRlci0+ZnJhbWUoKSkpOwogICAgIH0g ZWxzZQogICAgICAgICBtX2ludGVybmFsLmNsZWFyKCk7CiAKQEAgLTI1OSw3ICsyNjAsNyBAQCB2 b2lkIEFwcGxpY2F0aW9uQ2FjaGVIb3N0OjpzdG9wRGVmZXJyaW5nCiAKIHZvaWQgQXBwbGljYXRp b25DYWNoZUhvc3Q6OnN0b3BMb2FkaW5nSW5GcmFtZShGcmFtZSogZnJhbWUpCiB7Ci0gICAgLy8g RklYTUU6IEltcGxlbWVudCB0aGlzIG1ldGhvZC4KKyAgICAvLyBOL0EgdG8gdGhlIGNocm9taXVt IHBvcnQKIH0KIAogdm9pZCBBcHBsaWNhdGlvbkNhY2hlSG9zdDo6ZGlzcGF0Y2hET01FdmVudChF dmVudElEIGlkLCBpbnQgdG90YWwsIGludCBkb25lKQo=