55478 2011-03-01 10:13:29 -0800 [Qt][WK2] generate-forwarding-headers.pl should generate paths with framework names 2011-03-07 06:17:18 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 50251 1 abecsi abecsi commit-queue laszlo.gombos ossy oldest_to_newest 359986 0 abecsi 2011-03-01 10:13:29 -0800 On case-insensitive systems the generated forwarding headers case build problems, because of file name clashes. One such example is: Source/WebKit2/Platform/Logging.h and Source/WebCore/platform/Logging.h where including (p|P)latform/Logging.h in the final build step is ambiguous on case-insensitive systems, so the generated header should also contain the framework name. 360774 1 84414 abecsi 2011-03-02 07:09:38 -0800 Created attachment 84414 proposed patch 360786 2 84414 laszlo.gombos 2011-03-02 07:32:13 -0800 Comment on attachment 84414 proposed patch Nice, thanks. r+. 360799 3 84414 commit-queue 2011-03-02 08:02:02 -0800 Comment on attachment 84414 proposed patch Clearing flags on attachment: 84414 Committed r80131: <http://trac.webkit.org/changeset/80131> 360800 4 commit-queue 2011-03-02 08:02:06 -0800 All reviewed patches have been landed. Closing bug. 84414 2011-03-02 07:09:38 -0800 2011-03-02 08:02:02 -0800 proposed patch generate-fw-headers.patch text/plain 2978 abecsi ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5ZDMyZDdiLi4wOWFmMDM0 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDMtMDIgIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUB3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bV0syXSBnZW5lcmF0 ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGwgc2hvdWxkIGdlbmVyYXRlIHBhdGhzIHdpdGggZnJhbWV3 b3JrIG5hbWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NTQ3OAorCisgICAgICAgIE9uIGNhc2UgaW5zZW5zaXRpdmUgc3lzdGVtcyB0aGUgZ2VuZXJh dGVkIGZvcndhcmRpbmcgaGVhZGVycyBjYXVzZSBidWlsZCBwcm9ibGVtcy4KKworICAgICAgICAq IFNvdXJjZS9XZWJLaXQucHJpOiBBZGp1c3QgSU5DTFVERVBBVEggZm9yIHRoZSBwcm9qZWN0Lgor CiAyMDExLTAzLTAxICBBbmRyYXMgQmVjc2kgIDxhYmVjc2lAd2Via2l0Lm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBDc2FiYSBPc3p0cm9nb27DoWMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0LnByaSBiL1NvdXJjZS9XZWJLaXQucHJpCmluZGV4IDUxZDEzZjAuLmY2MWI0ODkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQucHJpCisrKyBiL1NvdXJjZS9XZWJLaXQucHJpCkBAIC02OCwx NSArNjgsMTIgQEAgQ09ORklHKHJlbGVhc2UsIGRlYnVnfHJlbGVhc2UpIHsKIH0KIAogSU5DTFVE RVBBVEggKz0gXAorICAgICQkUFdEIFwKICAgICAkJE9VVFBVVF9ESVIvaW5jbHVkZS9RdFdlYktp dCBcCi0gICAgJCRPVVRQVVRfRElSL2luY2x1ZGUKLUlOQ0xVREVQQVRIICs9ICQkUVQuc2NyaXB0 LmluY2x1ZGVzCisgICAgJCRPVVRQVVRfRElSL2luY2x1ZGUgXAorICAgICQkUVQuc2NyaXB0Lmlu Y2x1ZGVzCiAKLXdlYmtpdDIgewotICAgIElOQ0xVREVQQVRIICs9ICQkT1VUUFVUX0RJUi9pbmNs dWRlL1dlYktpdDIKLSAgICAjIEZJWE1FOiBPbmNlIHRoZSBwdWJsaWMgaGVhZGVyIGFyZSB3ZWxs IGRlZmluZWQgZm9yIFdlYktpdDIsIHRoaXMgbXVzdCBnbyBhd2F5LgotICAgIElOQ0xVREVQQVRI ICs9ICQkUFdEL1dlYktpdDIvCi19Cit3ZWJraXQyOklOQ0xVREVQQVRIICo9ICQkT1VUUFVUX0RJ Ui9pbmNsdWRlL1dlYktpdDIKIAogIyBQaWNrIHVwIDNyZHBhcnR5IGxpYnJhcmllcyBmcm9tIElO Q0xVREUvTElCIGp1c3QgbGlrZSB3aXRoIE1TVkMKIHdpbjMyLWcrKyogewpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4 IDRkZDY5OTcuLmY2Y2UwMzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wMy0w MiAgQW5kcmFzIEJlY3NpICA8YWJlY3NpQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XVtXSzJdIGdlbmVyYXRlLWZvcndhcmRp bmctaGVhZGVycy5wbCBzaG91bGQgZ2VuZXJhdGUgcGF0aHMgd2l0aCBmcmFtZXdvcmsgbmFtZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1NDc4CisK KyAgICAgICAgT24gY2FzZSBpbnNlbnNpdGl2ZSBzeXN0ZW1zIHRoZSBnZW5lcmF0ZWQgZm9yd2Fy ZGluZyBoZWFkZXJzIGNhdXNlIGJ1aWxkIHByb2JsZW1zLgorCisgICAgICAgICogU2NyaXB0cy9n ZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGw6IFRoZSBnZW5lcmF0ZWQgaGVhZGVyIHNob3Vs ZAorICAgICAgICBhbHNvIGNvbnRhaW4gdGhlIGZyYW1ld29yayBuYW1lLgorCiAyMDExLTAzLTAx ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBDb252ZXJ0IHNlY29u ZHMgdG8gbWlsbGlzZWNvbmRzIGJlZm9yZSBjYWxsaW5nIDo6U2V0VGltZXIKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvZ2VuZXJhdGUtZm9yd2FyZGluZy1oZWFkZXJzLnBsIGIv U291cmNlL1dlYktpdDIvU2NyaXB0cy9nZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGwKaW5k ZXggODgzZjgwMy4uNWE1M2Q4MSAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktpdDIvU2NyaXB0cy9n ZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGwKKysrIGIvU291cmNlL1dlYktpdDIvU2NyaXB0 cy9nZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGwKQEAgLTkzLDcgKzkzLDcgQEAgc3ViIGNy ZWF0ZUZvcndhcmRpbmdIZWFkZXJzRm9yRnJhbWV3b3JrIHsKICAgICAgICAgIyBJZiB3ZSBmb3Vu ZCBtb3JlIGhlYWRlcnMgd2l0aCB0aGUgc2FtZSBuYW1lLCBvbmx5IGdlbmVyYXRlIGEgZm9yd2Fy ZGluZyBoZWFkZXIgZm9yIHRoZSBjdXJyZW50IHBsYXRmb3JtCiAgICAgICAgIGlmKGdyZXAoJF8g PX4gIi8kaGVhZGVyTmFtZVwkIiwgQGZyYW1ld29ya0hlYWRlcnMpID09IDEgfHwgJGhlYWRlciA9 fiAiLyRwbGF0Zm9ybS8iICkgewogICAgICAgICAgICAgbXkgJGZvcndhcmRpbmdIZWFkZXJQYXRo ID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZSgkdGFyZ2V0RGlyZWN0b3J5LCAkaGVhZGVyTmFtZSk7Ci0g ICAgICAgICAgICBteSAkZXhwZWN0ZWRJbmNsdWRlU3RhdGVtZW50ID0gIiNpbmNsdWRlIFwiJGhl YWRlclwiIjsKKyAgICAgICAgICAgIG15ICRleHBlY3RlZEluY2x1ZGVTdGF0ZW1lbnQgPSAiI2lu Y2x1ZGUgXCIkZnJhbWV3b3JrLyRoZWFkZXJcIiI7CiAgICAgICAgICAgICBteSAkZm91bmRJbmNs dWRlU3RhdGVtZW50ID0gMDsKIAogICAgICAgICAgICAgJGZvdW5kSW5jbHVkZVN0YXRlbWVudCA9 IDxFWElTVElOR19IRUFERVI+IGlmIG9wZW4oRVhJU1RJTkdfSEVBREVSLCAiPCRmb3J3YXJkaW5n SGVhZGVyUGF0aCIpOwo=