55425 2011-02-28 16:39:35 -0800 Teach JavaScriptCore GYP build about DEPTH 2011-03-01 00:14:51 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 55018 1 abarth abarth commit-queue dglazkov eric oldest_to_newest 359483 0 abarth 2011-02-28 16:39:35 -0800 Teach JavaScriptCore GYP build about DEPTH 359484 1 84150 abarth 2011-02-28 16:40:47 -0800 Created attachment 84150 Patch 359690 2 84150 eric 2011-02-28 23:55:23 -0800 Comment on attachment 84150 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84150&action=review > Source/JavaScriptCore/gyp/JavaScriptCore.gyp:27 > + '<(DEPTH)', # Some paths in API include JavaScriptCore/ > + '<(DEPTH)/JavaScriptCore', > + '<(DEPTH)/JavaScriptCore/ForwardingHeaders', > + '<(DEPTH)/JavaScriptCore/API', > + '<(DEPTH)/JavaScriptCore/assembler', > + '<(DEPTH)/JavaScriptCore/collector/handles', > + '<(DEPTH)/JavaScriptCore/bytecode', > + '<(DEPTH)/JavaScriptCore/bytecompiler', > + '<(DEPTH)/JavaScriptCore/debugger', > + '<(DEPTH)/JavaScriptCore/icu', > + '<(DEPTH)/JavaScriptCore/interpreter', > + '<(DEPTH)/JavaScriptCore/jit', > + '<(DEPTH)/JavaScriptCore/parser', > + '<(DEPTH)/JavaScriptCore/profiler', > + '<(DEPTH)/JavaScriptCore/runtime', > + '<(DEPTH)/JavaScriptCore/wtf', > + '<(DEPTH)/JavaScriptCore/wtf/unicode', This seems annoyingly verbose. Would be nice to have an INCLUDE_ROOT feature for gyp. :) 359694 3 abarth 2011-03-01 00:06:58 -0800 We can create an INCLUDE_ROOT variable pretty easily. 359697 4 eric 2011-03-01 00:12:02 -0800 I mean so that we don't have to use DEPTH for every include line. 359699 5 84150 commit-queue 2011-03-01 00:14:46 -0800 Comment on attachment 84150 Patch Clearing flags on attachment: 84150 Committed r79974: <http://trac.webkit.org/changeset/79974> 359701 6 commit-queue 2011-03-01 00:14:51 -0800 All reviewed patches have been landed. Closing bug. 84150 2011-02-28 16:40:47 -0800 2011-03-01 00:14:46 -0800 Patch bug-55425-20110228164046.patch text/plain 4401 abarth SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzk5NDApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTEtMDItMjggIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZWFjaCBKYXZhU2NyaXB0Q29y ZSBHWVAgYnVpbGQgYWJvdXQgREVQVEgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU1NDI1CisKKyAgICAgICAgSW4gYWRkaXRpb24gdG8gdGVhY2hpbmcg dGhlIEphdmFTY3JpcHRDb3JlIEdZUCBidWlsZCBhYm91dCBERVBUSCwgdGhpcworICAgICAgICBj aGFuZ2Ugb3ZlcnJpZGVzIHRoZSBHQ0Mgd2FybmluZyBjb25maWd1cmF0aW9uIHRvIGRpc2FibGUg YSB3YXJuaW5nCisgICAgICAgIHRoYXQncyBjYXVzaW5nIHByb2JlbXMgaW4gQXNzZXJ0aW9ucy5j cHAuICBXaXRoIHRoYXQgd2FybmluZyBkaXNhYmxlZCwKKyAgICAgICAgSmF2YVNjcmlwdENvcmUg YnVpbGRzIGFnYWluLgorCisgICAgICAgICogZ3lwL0phdmFTY3JpcHRDb3JlLmd5cDoKKwogMjAx MS0wMi0yOCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9neXAv SmF2YVNjcmlwdENvcmUuZ3lwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9n eXAvSmF2YVNjcmlwdENvcmUuZ3lwCShyZXZpc2lvbiA3OTkyNCkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9neXAvSmF2YVNjcmlwdENvcmUuZ3lwCSh3b3JraW5nIGNvcHkpCkBAIC0yLDI5ICsy LDI5IEBACiAgICdpbmNsdWRlcyc6IFsKICAgICAnLi4vSmF2YVNjcmlwdENvcmUuZ3lwaScsCiAg IF0sCi0gICd4Y29kZV9jb25maWdfZmlsZSc6ICcuLi9Db25maWd1cmF0aW9ucy9EZWJ1Z1JlbGVh c2UueGNjb25maWcnLAorICAneGNvZGVfY29uZmlnX2ZpbGUnOiAnPChERVBUSCkvSmF2YVNjcmlw dENvcmUvQ29uZmlndXJhdGlvbnMvRGVidWdSZWxlYXNlLnhjY29uZmlnJywKICAgJ3RhcmdldHMn OiBbCiAgICAgewogICAgICAgJ3RhcmdldF9uYW1lJzogJ0phdmFTY3JpcHRDb3JlJywKICAgICAg ICd0eXBlJzogJ3NoYXJlZF9saWJyYXJ5JywKICAgICAgICdpbmNsdWRlX2RpcnMnOiBbCi0gICAg ICAgICcuLi8uLicsICMgU29tZSBwYXRocyBpbiBBUEkgaW5jbHVkZSBKYXZhU2NyaXB0Q29yZS8K LSAgICAgICAgJy4uJywKLSAgICAgICAgJy4uL0ZvcndhcmRpbmdIZWFkZXJzJywKLSAgICAgICAg Jy4uL0FQSScsCi0gICAgICAgICcuLi9hc3NlbWJsZXInLAotICAgICAgICAnLi4vY29sbGVjdG9y L2hhbmRsZXMnLAotICAgICAgICAnLi4vYnl0ZWNvZGUnLAotICAgICAgICAnLi4vYnl0ZWNvbXBp bGVyJywKLSAgICAgICAgJy4uL2RlYnVnZ2VyJywKLSAgICAgICAgJy4uL2ljdScsCi0gICAgICAg ICcuLi9pbnRlcnByZXRlcicsCi0gICAgICAgICcuLi9qaXQnLAotICAgICAgICAnLi4vcGFyc2Vy JywKLSAgICAgICAgJy4uL3Byb2ZpbGVyJywKLSAgICAgICAgJy4uL3J1bnRpbWUnLAotICAgICAg ICAnLi4vd3RmJywKLSAgICAgICAgJy4uL3d0Zi91bmljb2RlJywKKyAgICAgICAgJzwoREVQVEgp JywgIyBTb21lIHBhdGhzIGluIEFQSSBpbmNsdWRlIEphdmFTY3JpcHRDb3JlLworICAgICAgICAn PChERVBUSCkvSmF2YVNjcmlwdENvcmUnLAorICAgICAgICAnPChERVBUSCkvSmF2YVNjcmlwdENv cmUvRm9yd2FyZGluZ0hlYWRlcnMnLAorICAgICAgICAnPChERVBUSCkvSmF2YVNjcmlwdENvcmUv QVBJJywKKyAgICAgICAgJzwoREVQVEgpL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlcicsCisgICAg ICAgICc8KERFUFRIKS9KYXZhU2NyaXB0Q29yZS9jb2xsZWN0b3IvaGFuZGxlcycsCisgICAgICAg ICc8KERFUFRIKS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZScsCisgICAgICAgICc8KERFUFRIKS9K YXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXInLAorICAgICAgICAnPChERVBUSCkvSmF2YVNjcmlw dENvcmUvZGVidWdnZXInLAorICAgICAgICAnPChERVBUSCkvSmF2YVNjcmlwdENvcmUvaWN1JywK KyAgICAgICAgJzwoREVQVEgpL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyJywKKyAgICAgICAg JzwoREVQVEgpL0phdmFTY3JpcHRDb3JlL2ppdCcsCisgICAgICAgICc8KERFUFRIKS9KYXZhU2Ny aXB0Q29yZS9wYXJzZXInLAorICAgICAgICAnPChERVBUSCkvSmF2YVNjcmlwdENvcmUvcHJvZmls ZXInLAorICAgICAgICAnPChERVBUSCkvSmF2YVNjcmlwdENvcmUvcnVudGltZScsCisgICAgICAg ICc8KERFUFRIKS9KYXZhU2NyaXB0Q29yZS93dGYnLAorICAgICAgICAnPChERVBUSCkvSmF2YVNj cmlwdENvcmUvd3RmL3VuaWNvZGUnLAogICAgICAgICAnPChQUk9EVUNUX0RJUikvRGVyaXZlZFNv dXJjZXMvSmF2YVNjcmlwdENvcmUnLAogICAgICAgXSwKICAgICAgICdzb3VyY2VzJzogWwpAQCAt MzUsNyArMzUsNyBAQAogICAgICAgICAnbGliaWN1Y29yZS5keWxpYicsCiAgICAgICAgICdsaWJv YmpjLmR5bGliJywKICAgICAgIF0sCi0gICAgICAneGNvZGVfY29uZmlnX2ZpbGUnOiAnLi4vQ29u ZmlndXJhdGlvbnMvSmF2YVNjcmlwdENvcmUueGNjb25maWcnLAorICAgICAgJ3hjb2RlX2NvbmZp Z19maWxlJzogJzwoREVQVEgpL0phdmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25zL0phdmFTY3Jp cHRDb3JlLnhjY29uZmlnJywKICAgICAgICdzb3VyY2VzLyc6IFsKICAgICAgICAgWydleGNsdWRl JywgJ3F0J10sCiAgICAgICAgIFsnZXhjbHVkZScsICdvcy13aW4zMiddLApAQCAtNzksOCArNzks MzMgQEAKICAgICAgICAgWydPUz09Im1hYyInLCB7CiAgICAgICAgICAgJ21hY19idW5kbGUnOiAx LAogICAgICAgICAgICd4Y29kZV9zZXR0aW5ncyc6IHsKLSAgICAgICAgICAgICdVU0VfSEVBREVS TUFQJzogJ05PJywgIyBGSVhNRTogRG8gd2UgbmVlZCB0aGlzPwotICAgICAgICAgIH0KKyAgICAg ICAgICAgICdVU0VfSEVBREVSTUFQJzogJ05PJywKKyAgICAgICAgICAgICMgRklYTUU6IFJlbW92 ZSB0aGVzZSBvdmVycmlkZXMgb25jZSBKYXZhU2NyaXB0Q29yZS54Y2NvbmZpZyBpcworICAgICAg ICAgICAgIyB1c2VkIG9ubHkgYnkgdGhpcyBwcm9qZWN0LgorICAgICAgICAgICAgJ0dDQ19QUkVG SVhfSEVBREVSJzogJzwoREVQVEgpL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlUHJlZml4 LmgnLAorICAgICAgICAgICAgJ0lORk9QTElTVF9GSUxFJzogJzwoREVQVEgpL0phdmFTY3JpcHRD b3JlL0luZm8ucGxpc3QnLAorICAgICAgICAgICAgIyBUaGlzIHNldHRpbmcgbWlycm9ycyB0aGUg c2V0dGluZyBpbiBCYXNlLnhjY29uZmlnLCB3aXRoCisgICAgICAgICAgICAjIG9uZSBkaWZmZXJl bmNlIG5vdGVkIGJlbG93LgorICAgICAgICAgICAgJ1dBUk5JTkdfQ0ZMQUdTX0JBU0UnOiBbCisg ICAgICAgICAgICAgICctV2FsbCcsCisgICAgICAgICAgICAgICctV2V4dHJhJywKKyAgICAgICAg ICAgICAgJy1XY2FzdC1xdWFsJywKKyAgICAgICAgICAgICAgJy1XY2hhci1zdWJzY3JpcHRzJywK KyAgICAgICAgICAgICAgJy1XZXh0cmEtdG9rZW5zJywKKyAgICAgICAgICAgICAgJy1XZm9ybWF0 PTInLAorICAgICAgICAgICAgICAnLVdpbml0LXNlbGYnLAorICAgICAgICAgICAgICAjIEZJWE1F OiBGb3Igc29tZSByZWFzb24sIC1XbWlzc2luZy1mb3JtYXQtYXR0cmlidXRlIGNhdXNlcyBhCisg ICAgICAgICAgICAgICMgYnVpbGQgZXJyb3IgaW4gQXNzZXJ0aW9ucy5jcHAgaW4gdGhlIEdZUCBi dWlsZCBidXQgbm90IGluIHRoZQorICAgICAgICAgICAgICAjIG5vbi1HWVAgYnVpbGQuCisgICAg ICAgICAgICAgICMgJy1XbWlzc2luZy1mb3JtYXQtYXR0cmlidXRlJywKKyAgICAgICAgICAgICAg Jy1XbWlzc2luZy1ub3JldHVybicsCisgICAgICAgICAgICAgICctV3BhY2tlZCcsCisgICAgICAg ICAgICAgICctV3BvaW50ZXItYXJpdGgnLAorICAgICAgICAgICAgICAnLVdyZWR1bmRhbnQtZGVj bHMnLAorICAgICAgICAgICAgICAnLVd1bmRlZicsCisgICAgICAgICAgICAgICctV3dyaXRlLXN0 cmluZ3MnLAorICAgICAgICAgICAgXSwKKyAgICAgICAgICB9LAogICAgICAgICB9XSwKICAgICAg IF0sCiAgICAgfSwK