55414 2011-02-28 14:55:24 -0800 Fix race condition in 4 media tests 2011-02-28 18:03:32 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 54355 1 tonyg tonyg abarth commit-queue eric jamesr mihaip simon.fraser wangxianzhu webkit.review.bot oldest_to_newest 359385 0 tonyg 2011-02-28 14:55:24 -0800 Fix race condition in 4 media tests 359421 1 84134 tonyg 2011-02-28 15:22:41 -0800 Created attachment 84134 Patch 359426 2 84134 darin 2011-02-28 15:28:05 -0800 Comment on attachment 84134 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84134&action=review Looks OK as long as the waitForEvent function is only ever used on events that are unique enough. > LayoutTests/media/video-test.js:3 > -var mediaElement = null; > +var mediaElement = document; This is pretty strange; expedient but pretty unclear! Probably needs a comment. 359433 3 tonyg 2011-02-28 15:36:08 -0800 (In reply to comment #2) > (From update of attachment 84134 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=84134&action=review > > Looks OK as long as the waitForEvent function is only ever used on events that are unique enough. They are all unique to media elements except for 'error.' I don't think this is a big problem as other errors on the page should be unexpected. But if you think it is a good idea, I could also check the target of the event and only dispatch the callback if it is a media element. > > > LayoutTests/media/video-test.js:3 > > -var mediaElement = null; > > +var mediaElement = document; > > This is pretty strange; expedient but pretty unclear! Probably needs a comment. It ends up being strange because of these special "video" and "mediaElement" global variables. Would be much more clear if they were arguments to the method, but that is more refactoring that I want to do here. Will add a comment. 359436 4 84136 tonyg 2011-02-28 15:46:56 -0800 Created attachment 84136 Patch for landing 359535 5 84136 commit-queue 2011-02-28 17:31:52 -0800 Comment on attachment 84136 Patch for landing Clearing flags on attachment: 84136 Committed r79949: <http://trac.webkit.org/changeset/79949> 359536 6 commit-queue 2011-02-28 17:31:57 -0800 All reviewed patches have been landed. Closing bug. 359560 7 webkit.review.bot 2011-02-28 18:03:32 -0800 http://trac.webkit.org/changeset/79949 might have broken SnowLeopard Intel Release (Build) 84134 2011-02-28 15:22:41 -0800 2011-02-28 15:46:53 -0800 Patch bug-55414-20110228152240.patch text/plain 7523 tonyg U3VidmVyc2lvbiBSZXZpc2lvbjogNzk5MjUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA3MjRlN2RkMDMyNmU1NDhjODcxNzlh Njk3ZjRiYThiMDU1OTJmODFmLi5lYWU5NWIyMDU2YWVmNGU3ZDNiNTRhYzU4ZjkxY2FjNTM3M2Q2 NjgzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTEtMDItMjggIFRvbnkgR2VudGlsY29yZSAg PHRvbnlnQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBGaXggcmFjZSBjb25kaXRpb24gaW4gNCBtZWRpYSB0ZXN0cworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU0MTQKKworICAgICAg ICBUaGUgcGFyc2VyIG1heSB5aWVsZCBhbmQgZ2l2ZSBldmVudHMgYSBjaGFuY2UgdG8gZGlzcGF0 Y2ggYmV0d2VlbiBhbnkgdHdvIHRva2Vucy4gU28KKyAgICAgICAgaXQgaXMgcG9zc2libGUgdGhh dCB0aGUgbG9hZHN0YXJ0IGV2ZW50IGZpcmVzIGltbWVkaWF0ZWx5IGFmdGVyIHRoZSB2aWRlbyB0 YWcgaXMKKyAgICAgICAgaW5zZXJ0ZWQgaW50byB0aGUgZG9jdW1lbnQgYnV0IGJlZm9yZSB0aGUg c3Vic2VxdWVudCBzY3JpcHQgaXMgcGFyc2VkLiBUaGlzIGlzIHZlcnkKKyAgICAgICAgcmFyZSBp biB0aGUgbGF5b3V0IHRlc3QgZW52aXJvbm1lbnQgc2luY2UgdGhlc2Ugc21hbGwgZmlsZXMgYXJl IGxvYWRlZCBmcm9tIGRpc2suCisKKyAgICAgICAgVGhpcyBwYXRjaCBlbGltaW5hdGVzIHRoYXQg cmFjZSBjb25kaXRpb24gYnkgYWxsb3dpbmcgd2FpdEZvckV2ZW50IHRvIHJlZ2lzdGVyIGZvcgor ICAgICAgICBldmVudHMgdGhhdCBidWJibGUgdXAgdG8gdGhlIGRvY3VtZW50IGZyb20gYW55IGVs ZW1lbnQuIFRoZW4gdGhlIHJlZ2lzdHJhdGlvbiBjYW4KKyAgICAgICAgaGFwcGVuIGJlZm9yZSBi ZWZvcmUgdGhlIGVsZW1lbnQgaXMgaW5zZXJ0ZWQgaW50byB0aGUgZG9jdW1lbnQuCisKKyAgICAg ICAgKiBtZWRpYS92aWRlby1zb3VyY2UtbWVkaWEuaHRtbDoKKyAgICAgICAgKiBtZWRpYS92aWRl by1zb3VyY2Utbm9uZS1zdXBwb3J0ZWQuaHRtbDoKKyAgICAgICAgKiBtZWRpYS92aWRlby1zb3Vy Y2UtdHlwZS1wYXJhbXMuaHRtbDoKKyAgICAgICAgKiBtZWRpYS92aWRlby1zb3VyY2UtdHlwZS5o dG1sOgorICAgICAgICAqIG1lZGlhL3ZpZGVvLXRlc3QuanM6CisgICAgICAgICh3YWl0Rm9yRXZl bnQpOgorICAgICAgICAod2FpdEZvckV2ZW50QW5kVGVzdCk6CisKIDIwMTEtMDItMjggIEp1bmdz aGlrIFNoaW4gIDxqc2hpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1MTIxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9t ZWRpYS92aWRlby1zb3VyY2UtbWVkaWEuaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXNv dXJjZS1tZWRpYS5odG1sCmluZGV4IGE4NjYyNWI4ZGZmMDg0OWEwMTFmYWFhNGFlMmI5NmNhYjAw MzFjNDguLjJkNjg1ZmMyNDE1MGQ3Y2Y5MGRkOTI1ZjYwZjE5YTgwMWMwZGE5ZGQgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXNvdXJjZS1tZWRpYS5odG1sCisrKyBiL0xheW91 dFRlc3RzL21lZGlhL3ZpZGVvLXNvdXJjZS1tZWRpYS5odG1sCkBAIC0xLDE1ICsxLDE0IEBACiA8 Ym9keT4KIDxzY3JpcHQgc3JjPXZpZGVvLXRlc3QuanM+PC9zY3JpcHQ+Ci08dmlkZW8gY29udHJv bHM+Ci0gICAgPHNvdXJjZSBzcmM9Y29udGVudC9lcnJvci5tcGVnIG1lZGlhPSJwcmludCI+Ci0g ICAgPHNvdXJjZSBzcmM9Y29udGVudC9lcnJvcjIubXBlZyBtZWRpYT0ic2NyZWVuIGFuZCAobWlu LWRldmljZS13aWR0aDogODAwMDBweCkiPgotICAgIDxzb3VyY2Ugc3JjPWNvbnRlbnQvdGVzdC5t cDQgbWVkaWE9InNjcmVlbiBhbmQgKG1pbi1kZXZpY2Utd2lkdGg6IDEwMHB4KSI+Ci08L3ZpZGVv PgogPHNjcmlwdD4KLSAgICB2aWRlbyA9IG1lZGlhRWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1l bnRzQnlUYWdOYW1lKCd2aWRlbycpWzBdOwogICAgIHdhaXRGb3JFdmVudCgnbG9hZHN0YXJ0Jywg ZnVuY3Rpb24gKCkgeyAKKyAgICAgICAgdmlkZW8gPSBtZWRpYUVsZW1lbnQgPSBkb2N1bWVudC5n ZXRFbGVtZW50c0J5VGFnTmFtZSgndmlkZW8nKVswXTsKICAgICAgICAgdGVzdEV4cGVjdGVkKCJy ZWxhdGl2ZVVSTCh2aWRlby5jdXJyZW50U3JjKSIsICJjb250ZW50L3Rlc3QubXA0Iik7CiAgICAg ICAgIGVuZFRlc3QoKTsKICAgICB9ICk7Ci0KIDwvc2NyaXB0PgorPHZpZGVvIGNvbnRyb2xzPgor ICAgIDxzb3VyY2Ugc3JjPWNvbnRlbnQvZXJyb3IubXBlZyBtZWRpYT0icHJpbnQiPgorICAgIDxz b3VyY2Ugc3JjPWNvbnRlbnQvZXJyb3IyLm1wZWcgbWVkaWE9InNjcmVlbiBhbmQgKG1pbi1kZXZp Y2Utd2lkdGg6IDgwMDAwcHgpIj4KKyAgICA8c291cmNlIHNyYz1jb250ZW50L3Rlc3QubXA0IG1l ZGlhPSJzY3JlZW4gYW5kIChtaW4tZGV2aWNlLXdpZHRoOiAxMDBweCkiPgorPC92aWRlbz4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXNvdXJjZS1ub25lLXN1cHBvcnRlZC5o dG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tc291cmNlLW5vbmUtc3VwcG9ydGVkLmh0bWwK aW5kZXggYTNmM2I5ZTI2ZWNiNThmYTFlZWEyN2Q4NTg5N2RkNjFkYWIxYWViMy4uZGVjODk0Y2Uw NzcyZjc3YzU5ZTExZjhjMzE3Y2M4ZTlkYTlkZWQyYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv bWVkaWEvdmlkZW8tc291cmNlLW5vbmUtc3VwcG9ydGVkLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv bWVkaWEvdmlkZW8tc291cmNlLW5vbmUtc3VwcG9ydGVkLmh0bWwKQEAgLTQsMTUgKzQsMTEgQEAK ICAgICA8dGl0bGU+bm8gdXNhYmxlICZsdDtzb3VyY2UmZ3Q7IHRlc3Q8L3RpdGxlPgogICAgIDxz Y3JpcHQgc3JjPXZpZGVvLXRlc3QuanM+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdD4KLQotICAgICAg ICBmdW5jdGlvbiBzZXR1cCgpCi0gICAgICAgIHsKLSAgICAgICAgICAgIGZpbmRNZWRpYUVsZW1l bnQoKTsKLSAgICAgICAgICAgIGRvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoImVycm9yIiwgZXJy b3JFdmVudCwgdHJ1ZSk7Ci0gICAgICAgIH0KKyAgICAgICAgZG9jdW1lbnQuYWRkRXZlbnRMaXN0 ZW5lcigiZXJyb3IiLCBlcnJvckV2ZW50LCB0cnVlKTsKIAogICAgICAgICBmdW5jdGlvbiBlcnJv ckV2ZW50KGV2dCkKICAgICAgICAgeworICAgICAgICAgICAgZmluZE1lZGlhRWxlbWVudCgpOwog ICAgICAgICAgICAgY29uc29sZVdyaXRlKCIrKyBFUlJPUiwgc3JjID0gIiArIHJlbGF0aXZlVVJM KGV2ZW50LnRhcmdldC5zcmMpICsgIiwgdHlwZSA9IFwiIiArIGV2ZW50LnRhcmdldC50eXBlICsg IlwiIik7CiAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoImV2ZW50LnRhcmdldC50YWdOYW1lIiwg IlNPVVJDRSIsICI9PSIpOwogICAgICAgICAgICAgCkBAIC00OCw3ICs0NCw1IEBACiAKICAgICA8 cD4xLiBUZXN0IHRoYXQgbm8gdXNhYmxlICZsdDtzb3VyY2UmZ3Q7IGVsZW1lbnQgbGVhdmVzIHRo ZSBtZWRpYSBlbGVtZW50IHdpdGggCiAgICAgbmV0d29ya1N0YXRlID09IE5FVFdPUktfTk9fU09V UkNFPC9wPgotCi0gICAgPHNjcmlwdD5zZXR1cCgpOzwvc2NyaXB0PgogPC9ib2R5PgogPC9odG1s PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tc291cmNlLXR5cGUtcGFyYW1z Lmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1zb3VyY2UtdHlwZS1wYXJhbXMuaHRtbApp bmRleCA0NTVhNDc5NTRkNGJkNDg5MmE0YzY4ZDRiZWVlNTc4NzFhZDdjODZmLi42ZGQ5YmJjMmJk MTJjZWMwNjViYTk0ZWViZmQ4YjAyYjRkZjVmNjc3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9t ZWRpYS92aWRlby1zb3VyY2UtdHlwZS1wYXJhbXMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9tZWRp YS92aWRlby1zb3VyY2UtdHlwZS1wYXJhbXMuaHRtbApAQCAtMSwxNiArMSwxNiBAQAogPGJvZHk+ CiA8c2NyaXB0IHNyYz1tZWRpYS1maWxlLmpzPjwvc2NyaXB0PgogPHNjcmlwdCBzcmM9dmlkZW8t dGVzdC5qcz48L3NjcmlwdD4KLTx2aWRlbyBjb250cm9scz4KLSAgICA8c291cmNlIHNyYz1jb250 ZW50L2JvZ3VzLm1wZWcgdHlwZT0idmlkZW8vYmxhaGJsYWgiPgotICAgIDxzb3VyY2Ugc3JjPWNv bnRlbnQvdGVzdC5tcDQgdHlwZT0idmlkZW8vbXBlZzsgY29kZWNzPSZxdW90O2F2YzEuNEQ0MDBD JnF1b3Q7Ij4KLSAgICA8c291cmNlIHNyYz1jb250ZW50L3Rlc3Qub2d2IHR5cGU9InZpZGVvL29n ZzsgY29kZWNzPSZxdW90O3RoZW9yYSx2b3JiaXMmcXVvdDsiPgotICAgIDxzb3VyY2Ugc3JjPWNv bnRlbnQvZXJyb3IyLm1wZWcgdHlwZT12aWRlby9tcGVnPgotPC92aWRlbz4KIDxzY3JpcHQ+Ci0g ICAgdmlkZW8gPSBtZWRpYUVsZW1lbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgn dmlkZW8nKVswXTsKICAgICB3YWl0Rm9yRXZlbnQoJ2xvYWRzdGFydCcsIGZ1bmN0aW9uICgpIHsg CisgICAgICAgIHZpZGVvID0gbWVkaWFFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRh Z05hbWUoJ3ZpZGVvJylbMF07CiAgICAgICAgIHRlc3RFeHBlY3RlZCgic3RyaXBFeHRlbnNpb24o cmVsYXRpdmVVUkwodmlkZW8uY3VycmVudFNyYykpIiwgc3RyaXBFeHRlbnNpb24oZmluZE1lZGlh RmlsZSgidmlkZW8iLCAiY29udGVudC90ZXN0IikpKTsKICAgICAgICAgZW5kVGVzdCgpOwogICAg IH0gKTsKIDwvc2NyaXB0PgorPHZpZGVvIGNvbnRyb2xzPgorICAgIDxzb3VyY2Ugc3JjPWNvbnRl bnQvYm9ndXMubXBlZyB0eXBlPSJ2aWRlby9ibGFoYmxhaCI+CisgICAgPHNvdXJjZSBzcmM9Y29u dGVudC90ZXN0Lm1wNCB0eXBlPSJ2aWRlby9tcGVnOyBjb2RlY3M9JnF1b3Q7YXZjMS40RDQwMEMm cXVvdDsiPgorICAgIDxzb3VyY2Ugc3JjPWNvbnRlbnQvdGVzdC5vZ3YgdHlwZT0idmlkZW8vb2dn OyBjb2RlY3M9JnF1b3Q7dGhlb3JhLHZvcmJpcyZxdW90OyI+CisgICAgPHNvdXJjZSBzcmM9Y29u dGVudC9lcnJvcjIubXBlZyB0eXBlPXZpZGVvL21wZWc+Cis8L3ZpZGVvPgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tc291cmNlLXR5cGUuaHRtbCBiL0xheW91dFRlc3RzL21l ZGlhL3ZpZGVvLXNvdXJjZS10eXBlLmh0bWwKaW5kZXggMzQ4OGY1NDBlYzNmNjUwZmNlZWFkMGUx ZjNhODM2MGFlMDEyZWEyNi4uNWFjODAwODg0MTY1YTRjM2U2NGM0ODkyZmJiOTc2YWQ1YTEzMTA4 MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tc291cmNlLXR5cGUuaHRtbAor KysgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1zb3VyY2UtdHlwZS5odG1sCkBAIC02LDE1ICs2 LDExIEBACiAgICAgPHNjcmlwdCBzcmM9bWVkaWEtZmlsZS5qcz48L3NjcmlwdD4KICAgICA8c2Ny aXB0IHNyYz12aWRlby10ZXN0LmpzPjwvc2NyaXB0PgogICAgIDxzY3JpcHQ+Ci0gICAgICAgIGZ1 bmN0aW9uIHNldHVwKCkKLSAgICAgICAgeworICAgICAgICB3YWl0Rm9yRXZlbnQoImxvYWRzdGFy dCIsIGZ1bmN0aW9uICgpIHsKICAgICAgICAgICAgIHZpZGVvID0gbWVkaWFFbGVtZW50ID0gZG9j dW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ3ZpZGVvJylbMF07Ci0gICAgICAgIAotICAgICAg ICAgICAgd2FpdEZvckV2ZW50KCJsb2Fkc3RhcnQiLCBmdW5jdGlvbiAoKSB7Ci0gICAgICAgICAg ICAgICAgdGVzdEV4cGVjdGVkKCJzdHJpcEV4dGVuc2lvbihyZWxhdGl2ZVVSTCh2aWRlby5jdXJy ZW50U3JjKSkiLCBzdHJpcEV4dGVuc2lvbihmaW5kTWVkaWFGaWxlKCJ2aWRlbyIsICJjb250ZW50 L3Rlc3QiKSkpOwotICAgICAgICAgICAgICAgIGVuZFRlc3QoKTsKLSAgICAgICAgICAgIH0pOwot ICAgICAgICB9CisgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoInN0cmlwRXh0ZW5zaW9uKHJlbGF0 aXZlVVJMKHZpZGVvLmN1cnJlbnRTcmMpKSIsIHN0cmlwRXh0ZW5zaW9uKGZpbmRNZWRpYUZpbGUo InZpZGVvIiwgImNvbnRlbnQvdGVzdCIpKSk7CisgICAgICAgICAgICBlbmRUZXN0KCk7CisgICAg ICAgIH0pOwogICAgIDwvc2NyaXB0PgogPC9oZWFkPgogPGJvZHk+CkBAIC0yNiw2ICsyMiw1IEBA CiAgICAgICAgIDxzb3VyY2Ugc3JjPWNvbnRlbnQvdGVzdC5vZ3YgdHlwZT12aWRlby9vZ2c+CiAg ICAgICAgIDxzb3VyY2Ugc3JjPWNvbnRlbnQvZXJyb3IyLm1wZWcgdHlwZT12aWRlby9tcGVnPgog ICAgIDwvdmlkZW8+Ci0gICAgPHNjcmlwdD5zZXR1cCgpOzwvc2NyaXB0PgogPC9ib2R5PgogPC9o dG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tdGVzdC5qcyBiL0xheW91 dFRlc3RzL21lZGlhL3ZpZGVvLXRlc3QuanMKaW5kZXggMmZlNjY1NGQxYmQ2ZjUxZDgxYzYwNDZj NmY0ZTU2MjYzM2RjNWUxYi4uMDRjNTZiYjU1MWY2Y2M0ZmQ1MzM5ZTUyNWVlZDExNjlhMjA2Mjlh MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tdGVzdC5qcworKysgYi9MYXlv dXRUZXN0cy9tZWRpYS92aWRlby10ZXN0LmpzCkBAIC0xLDYgKzEsNiBAQAogCiB2YXIgdmlkZW8g PSBudWxsOwotdmFyIG1lZGlhRWxlbWVudCA9IG51bGw7Cit2YXIgbWVkaWFFbGVtZW50ID0gZG9j dW1lbnQ7CiB2YXIgY29uc29sZSA9IG51bGw7CiB2YXIgcHJpbnRGdWxsVGVzdERldGFpbHMgPSB0 cnVlOyAvLyBUaGlzIGlzIG9wdGlvbmFseSBzd2l0Y2hlZCBvZiBieSB0ZXN0IHdob3NlIHRlc3Rl ZCB2YWx1ZXMgY2FuIGRpZmZlci4gKHNlZSBkaXNhYmxlRnVsbFRlc3REZXRhaWxzUHJpbnRpbmco KSkKIHZhciBGYWlsZWQgPSBmYWxzZTsKQEAgLTE0MCw3ICsxNDAsNyBAQCBmdW5jdGlvbiB3YWl0 Rm9yRXZlbnQoZXZlbnROYW1lLCBmdW5jLCBlbmRpdCkKICAgICAgICAgICAgIGVuZFRlc3QoKTsK ICAgICB9CiAKLSAgICBtZWRpYUVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcihldmVudE5hbWUsIF9l dmVudENhbGxiYWNrKTsKKyAgICBtZWRpYUVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcihldmVudE5h bWUsIF9ldmVudENhbGxiYWNrLCB0cnVlKTsKIH0KIAogZnVuY3Rpb24gd2FpdEZvckV2ZW50VGVz dEFuZEVuZChldmVudE5hbWUsIHRlc3RGdW5jU3RyaW5nKQpAQCAtMTYyLDcgKzE2Miw3IEBAIGZ1 bmN0aW9uIHdhaXRGb3JFdmVudEFuZFRlc3QoZXZlbnROYW1lLCB0ZXN0RnVuY1N0cmluZywgZW5k aXQpCiAgICAgICAgICAgICBlbmRUZXN0KCk7CiAgICAgfQogCi0gICAgbWVkaWFFbGVtZW50LmFk ZEV2ZW50TGlzdGVuZXIoZXZlbnROYW1lLCBfZXZlbnRDYWxsYmFjayk7CisgICAgbWVkaWFFbGVt ZW50LmFkZEV2ZW50TGlzdGVuZXIoZXZlbnROYW1lLCBfZXZlbnRDYWxsYmFjaywgdHJ1ZSk7CiB9 CiAKIGZ1bmN0aW9uIHRlc3RFeGNlcHRpb24odGVzdFN0cmluZywgZXhjZXB0aW9uU3RyaW5nKQo= 84136 2011-02-28 15:46:56 -0800 2011-02-28 17:31:52 -0800 Patch for landing bug-55414-20110228154654.patch text/plain 7601 tonyg U3VidmVyc2lvbiBSZXZpc2lvbjogNzk5MjUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA3MjRlN2RkMDMyNmU1NDhjODcxNzlh Njk3ZjRiYThiMDU1OTJmODFmLi43YjQ3NTU2NmRiMTM4MzU4NzZiMTUzODU1YTUzNDYxZTBhZTVl ZGQ2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTEtMDItMjggIFRvbnkgR2VudGlsY29yZSAg PHRvbnlnQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4K KworICAgICAgICBGaXggcmFjZSBjb25kaXRpb24gaW4gNCBtZWRpYSB0ZXN0cworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU0MTQKKworICAgICAgICBU aGUgcGFyc2VyIG1heSB5aWVsZCBhbmQgZ2l2ZSBldmVudHMgYSBjaGFuY2UgdG8gZGlzcGF0Y2gg YmV0d2VlbiBhbnkgdHdvIHRva2Vucy4gU28KKyAgICAgICAgaXQgaXMgcG9zc2libGUgdGhhdCB0 aGUgbG9hZHN0YXJ0IGV2ZW50IGZpcmVzIGltbWVkaWF0ZWx5IGFmdGVyIHRoZSB2aWRlbyB0YWcg aXMKKyAgICAgICAgaW5zZXJ0ZWQgaW50byB0aGUgZG9jdW1lbnQgYnV0IGJlZm9yZSB0aGUgc3Vi c2VxdWVudCBzY3JpcHQgaXMgcGFyc2VkLiBUaGlzIGlzIHZlcnkKKyAgICAgICAgcmFyZSBpbiB0 aGUgbGF5b3V0IHRlc3QgZW52aXJvbm1lbnQgc2luY2UgdGhlc2Ugc21hbGwgZmlsZXMgYXJlIGxv YWRlZCBmcm9tIGRpc2suCisKKyAgICAgICAgVGhpcyBwYXRjaCBlbGltaW5hdGVzIHRoYXQgcmFj ZSBjb25kaXRpb24gYnkgYWxsb3dpbmcgd2FpdEZvckV2ZW50IHRvIHJlZ2lzdGVyIGZvcgorICAg ICAgICBldmVudHMgdGhhdCBidWJibGUgdXAgdG8gdGhlIGRvY3VtZW50IGZyb20gYW55IGVsZW1l bnQuIFRoZW4gdGhlIHJlZ2lzdHJhdGlvbiBjYW4KKyAgICAgICAgaGFwcGVuIGJlZm9yZSBiZWZv cmUgdGhlIGVsZW1lbnQgaXMgaW5zZXJ0ZWQgaW50byB0aGUgZG9jdW1lbnQuCisKKyAgICAgICAg KiBtZWRpYS92aWRlby1zb3VyY2UtbWVkaWEuaHRtbDoKKyAgICAgICAgKiBtZWRpYS92aWRlby1z b3VyY2Utbm9uZS1zdXBwb3J0ZWQuaHRtbDoKKyAgICAgICAgKiBtZWRpYS92aWRlby1zb3VyY2Ut dHlwZS1wYXJhbXMuaHRtbDoKKyAgICAgICAgKiBtZWRpYS92aWRlby1zb3VyY2UtdHlwZS5odG1s OgorICAgICAgICAqIG1lZGlhL3ZpZGVvLXRlc3QuanM6CisgICAgICAgICh3YWl0Rm9yRXZlbnQp OgorICAgICAgICAod2FpdEZvckV2ZW50QW5kVGVzdCk6CisKIDIwMTEtMDItMjggIEp1bmdzaGlr IFNoaW4gIDxqc2hpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU1MTIxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRp YS92aWRlby1zb3VyY2UtbWVkaWEuaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXNvdXJj ZS1tZWRpYS5odG1sCmluZGV4IGE4NjYyNWI4ZGZmMDg0OWEwMTFmYWFhNGFlMmI5NmNhYjAwMzFj NDguLjJkNjg1ZmMyNDE1MGQ3Y2Y5MGRkOTI1ZjYwZjE5YTgwMWMwZGE5ZGQgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXNvdXJjZS1tZWRpYS5odG1sCisrKyBiL0xheW91dFRl c3RzL21lZGlhL3ZpZGVvLXNvdXJjZS1tZWRpYS5odG1sCkBAIC0xLDE1ICsxLDE0IEBACiA8Ym9k eT4KIDxzY3JpcHQgc3JjPXZpZGVvLXRlc3QuanM+PC9zY3JpcHQ+Ci08dmlkZW8gY29udHJvbHM+ Ci0gICAgPHNvdXJjZSBzcmM9Y29udGVudC9lcnJvci5tcGVnIG1lZGlhPSJwcmludCI+Ci0gICAg PHNvdXJjZSBzcmM9Y29udGVudC9lcnJvcjIubXBlZyBtZWRpYT0ic2NyZWVuIGFuZCAobWluLWRl dmljZS13aWR0aDogODAwMDBweCkiPgotICAgIDxzb3VyY2Ugc3JjPWNvbnRlbnQvdGVzdC5tcDQg bWVkaWE9InNjcmVlbiBhbmQgKG1pbi1kZXZpY2Utd2lkdGg6IDEwMHB4KSI+Ci08L3ZpZGVvPgog PHNjcmlwdD4KLSAgICB2aWRlbyA9IG1lZGlhRWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRz QnlUYWdOYW1lKCd2aWRlbycpWzBdOwogICAgIHdhaXRGb3JFdmVudCgnbG9hZHN0YXJ0JywgZnVu Y3Rpb24gKCkgeyAKKyAgICAgICAgdmlkZW8gPSBtZWRpYUVsZW1lbnQgPSBkb2N1bWVudC5nZXRF bGVtZW50c0J5VGFnTmFtZSgndmlkZW8nKVswXTsKICAgICAgICAgdGVzdEV4cGVjdGVkKCJyZWxh dGl2ZVVSTCh2aWRlby5jdXJyZW50U3JjKSIsICJjb250ZW50L3Rlc3QubXA0Iik7CiAgICAgICAg IGVuZFRlc3QoKTsKICAgICB9ICk7Ci0KIDwvc2NyaXB0PgorPHZpZGVvIGNvbnRyb2xzPgorICAg IDxzb3VyY2Ugc3JjPWNvbnRlbnQvZXJyb3IubXBlZyBtZWRpYT0icHJpbnQiPgorICAgIDxzb3Vy Y2Ugc3JjPWNvbnRlbnQvZXJyb3IyLm1wZWcgbWVkaWE9InNjcmVlbiBhbmQgKG1pbi1kZXZpY2Ut d2lkdGg6IDgwMDAwcHgpIj4KKyAgICA8c291cmNlIHNyYz1jb250ZW50L3Rlc3QubXA0IG1lZGlh PSJzY3JlZW4gYW5kIChtaW4tZGV2aWNlLXdpZHRoOiAxMDBweCkiPgorPC92aWRlbz4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXNvdXJjZS1ub25lLXN1cHBvcnRlZC5odG1s IGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tc291cmNlLW5vbmUtc3VwcG9ydGVkLmh0bWwKaW5k ZXggYTNmM2I5ZTI2ZWNiNThmYTFlZWEyN2Q4NTg5N2RkNjFkYWIxYWViMy4uZGVjODk0Y2UwNzcy Zjc3YzU5ZTExZjhjMzE3Y2M4ZTlkYTlkZWQyYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVk aWEvdmlkZW8tc291cmNlLW5vbmUtc3VwcG9ydGVkLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvbWVk aWEvdmlkZW8tc291cmNlLW5vbmUtc3VwcG9ydGVkLmh0bWwKQEAgLTQsMTUgKzQsMTEgQEAKICAg ICA8dGl0bGU+bm8gdXNhYmxlICZsdDtzb3VyY2UmZ3Q7IHRlc3Q8L3RpdGxlPgogICAgIDxzY3Jp cHQgc3JjPXZpZGVvLXRlc3QuanM+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdD4KLQotICAgICAgICBm dW5jdGlvbiBzZXR1cCgpCi0gICAgICAgIHsKLSAgICAgICAgICAgIGZpbmRNZWRpYUVsZW1lbnQo KTsKLSAgICAgICAgICAgIGRvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoImVycm9yIiwgZXJyb3JF dmVudCwgdHJ1ZSk7Ci0gICAgICAgIH0KKyAgICAgICAgZG9jdW1lbnQuYWRkRXZlbnRMaXN0ZW5l cigiZXJyb3IiLCBlcnJvckV2ZW50LCB0cnVlKTsKIAogICAgICAgICBmdW5jdGlvbiBlcnJvckV2 ZW50KGV2dCkKICAgICAgICAgeworICAgICAgICAgICAgZmluZE1lZGlhRWxlbWVudCgpOwogICAg ICAgICAgICAgY29uc29sZVdyaXRlKCIrKyBFUlJPUiwgc3JjID0gIiArIHJlbGF0aXZlVVJMKGV2 ZW50LnRhcmdldC5zcmMpICsgIiwgdHlwZSA9IFwiIiArIGV2ZW50LnRhcmdldC50eXBlICsgIlwi Iik7CiAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoImV2ZW50LnRhcmdldC50YWdOYW1lIiwgIlNP VVJDRSIsICI9PSIpOwogICAgICAgICAgICAgCkBAIC00OCw3ICs0NCw1IEBACiAKICAgICA8cD4x LiBUZXN0IHRoYXQgbm8gdXNhYmxlICZsdDtzb3VyY2UmZ3Q7IGVsZW1lbnQgbGVhdmVzIHRoZSBt ZWRpYSBlbGVtZW50IHdpdGggCiAgICAgbmV0d29ya1N0YXRlID09IE5FVFdPUktfTk9fU09VUkNF PC9wPgotCi0gICAgPHNjcmlwdD5zZXR1cCgpOzwvc2NyaXB0PgogPC9ib2R5PgogPC9odG1sPgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tc291cmNlLXR5cGUtcGFyYW1zLmh0 bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1zb3VyY2UtdHlwZS1wYXJhbXMuaHRtbAppbmRl eCA0NTVhNDc5NTRkNGJkNDg5MmE0YzY4ZDRiZWVlNTc4NzFhZDdjODZmLi42ZGQ5YmJjMmJkMTJj ZWMwNjViYTk0ZWViZmQ4YjAyYjRkZjVmNjc3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9tZWRp YS92aWRlby1zb3VyY2UtdHlwZS1wYXJhbXMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS92 aWRlby1zb3VyY2UtdHlwZS1wYXJhbXMuaHRtbApAQCAtMSwxNiArMSwxNiBAQAogPGJvZHk+CiA8 c2NyaXB0IHNyYz1tZWRpYS1maWxlLmpzPjwvc2NyaXB0PgogPHNjcmlwdCBzcmM9dmlkZW8tdGVz dC5qcz48L3NjcmlwdD4KLTx2aWRlbyBjb250cm9scz4KLSAgICA8c291cmNlIHNyYz1jb250ZW50 L2JvZ3VzLm1wZWcgdHlwZT0idmlkZW8vYmxhaGJsYWgiPgotICAgIDxzb3VyY2Ugc3JjPWNvbnRl bnQvdGVzdC5tcDQgdHlwZT0idmlkZW8vbXBlZzsgY29kZWNzPSZxdW90O2F2YzEuNEQ0MDBDJnF1 b3Q7Ij4KLSAgICA8c291cmNlIHNyYz1jb250ZW50L3Rlc3Qub2d2IHR5cGU9InZpZGVvL29nZzsg Y29kZWNzPSZxdW90O3RoZW9yYSx2b3JiaXMmcXVvdDsiPgotICAgIDxzb3VyY2Ugc3JjPWNvbnRl bnQvZXJyb3IyLm1wZWcgdHlwZT12aWRlby9tcGVnPgotPC92aWRlbz4KIDxzY3JpcHQ+Ci0gICAg dmlkZW8gPSBtZWRpYUVsZW1lbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgndmlk ZW8nKVswXTsKICAgICB3YWl0Rm9yRXZlbnQoJ2xvYWRzdGFydCcsIGZ1bmN0aW9uICgpIHsgCisg ICAgICAgIHZpZGVvID0gbWVkaWFFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05h bWUoJ3ZpZGVvJylbMF07CiAgICAgICAgIHRlc3RFeHBlY3RlZCgic3RyaXBFeHRlbnNpb24ocmVs YXRpdmVVUkwodmlkZW8uY3VycmVudFNyYykpIiwgc3RyaXBFeHRlbnNpb24oZmluZE1lZGlhRmls ZSgidmlkZW8iLCAiY29udGVudC90ZXN0IikpKTsKICAgICAgICAgZW5kVGVzdCgpOwogICAgIH0g KTsKIDwvc2NyaXB0PgorPHZpZGVvIGNvbnRyb2xzPgorICAgIDxzb3VyY2Ugc3JjPWNvbnRlbnQv Ym9ndXMubXBlZyB0eXBlPSJ2aWRlby9ibGFoYmxhaCI+CisgICAgPHNvdXJjZSBzcmM9Y29udGVu dC90ZXN0Lm1wNCB0eXBlPSJ2aWRlby9tcGVnOyBjb2RlY3M9JnF1b3Q7YXZjMS40RDQwMEMmcXVv dDsiPgorICAgIDxzb3VyY2Ugc3JjPWNvbnRlbnQvdGVzdC5vZ3YgdHlwZT0idmlkZW8vb2dnOyBj b2RlY3M9JnF1b3Q7dGhlb3JhLHZvcmJpcyZxdW90OyI+CisgICAgPHNvdXJjZSBzcmM9Y29udGVu dC9lcnJvcjIubXBlZyB0eXBlPXZpZGVvL21wZWc+Cis8L3ZpZGVvPgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvbWVkaWEvdmlkZW8tc291cmNlLXR5cGUuaHRtbCBiL0xheW91dFRlc3RzL21lZGlh L3ZpZGVvLXNvdXJjZS10eXBlLmh0bWwKaW5kZXggMzQ4OGY1NDBlYzNmNjUwZmNlZWFkMGUxZjNh ODM2MGFlMDEyZWEyNi4uNWFjODAwODg0MTY1YTRjM2U2NGM0ODkyZmJiOTc2YWQ1YTEzMTA4MyAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tc291cmNlLXR5cGUuaHRtbAorKysg Yi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1zb3VyY2UtdHlwZS5odG1sCkBAIC02LDE1ICs2LDEx IEBACiAgICAgPHNjcmlwdCBzcmM9bWVkaWEtZmlsZS5qcz48L3NjcmlwdD4KICAgICA8c2NyaXB0 IHNyYz12aWRlby10ZXN0LmpzPjwvc2NyaXB0PgogICAgIDxzY3JpcHQ+Ci0gICAgICAgIGZ1bmN0 aW9uIHNldHVwKCkKLSAgICAgICAgeworICAgICAgICB3YWl0Rm9yRXZlbnQoImxvYWRzdGFydCIs IGZ1bmN0aW9uICgpIHsKICAgICAgICAgICAgIHZpZGVvID0gbWVkaWFFbGVtZW50ID0gZG9jdW1l bnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ3ZpZGVvJylbMF07Ci0gICAgICAgIAotICAgICAgICAg ICAgd2FpdEZvckV2ZW50KCJsb2Fkc3RhcnQiLCBmdW5jdGlvbiAoKSB7Ci0gICAgICAgICAgICAg ICAgdGVzdEV4cGVjdGVkKCJzdHJpcEV4dGVuc2lvbihyZWxhdGl2ZVVSTCh2aWRlby5jdXJyZW50 U3JjKSkiLCBzdHJpcEV4dGVuc2lvbihmaW5kTWVkaWFGaWxlKCJ2aWRlbyIsICJjb250ZW50L3Rl c3QiKSkpOwotICAgICAgICAgICAgICAgIGVuZFRlc3QoKTsKLSAgICAgICAgICAgIH0pOwotICAg ICAgICB9CisgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoInN0cmlwRXh0ZW5zaW9uKHJlbGF0aXZl VVJMKHZpZGVvLmN1cnJlbnRTcmMpKSIsIHN0cmlwRXh0ZW5zaW9uKGZpbmRNZWRpYUZpbGUoInZp ZGVvIiwgImNvbnRlbnQvdGVzdCIpKSk7CisgICAgICAgICAgICBlbmRUZXN0KCk7CisgICAgICAg IH0pOwogICAgIDwvc2NyaXB0PgogPC9oZWFkPgogPGJvZHk+CkBAIC0yNiw2ICsyMiw1IEBACiAg ICAgICAgIDxzb3VyY2Ugc3JjPWNvbnRlbnQvdGVzdC5vZ3YgdHlwZT12aWRlby9vZ2c+CiAgICAg ICAgIDxzb3VyY2Ugc3JjPWNvbnRlbnQvZXJyb3IyLm1wZWcgdHlwZT12aWRlby9tcGVnPgogICAg IDwvdmlkZW8+Ci0gICAgPHNjcmlwdD5zZXR1cCgpOzwvc2NyaXB0PgogPC9ib2R5PgogPC9odG1s PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tdGVzdC5qcyBiL0xheW91dFRl c3RzL21lZGlhL3ZpZGVvLXRlc3QuanMKaW5kZXggMmZlNjY1NGQxYmQ2ZjUxZDgxYzYwNDZjNmY0 ZTU2MjYzM2RjNWUxYi4uNDAxZjJjZjE2ODQzMzY5NDg4YzJkMjRkNDVjZGUzMmYxN2MwMWMyZSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tdGVzdC5qcworKysgYi9MYXlvdXRU ZXN0cy9tZWRpYS92aWRlby10ZXN0LmpzCkBAIC0xLDYgKzEsNiBAQAogCiB2YXIgdmlkZW8gPSBu dWxsOwotdmFyIG1lZGlhRWxlbWVudCA9IG51bGw7Cit2YXIgbWVkaWFFbGVtZW50ID0gZG9jdW1l bnQ7IC8vIElmIG5vdCBzZXQsIGFuIGV2ZW50IGZyb20gYW55IGVsZW1lbnQgd2lsbCB0cmlnZ2Vy IGEgd2FpdEZvckV2ZW50KCkgY2FsbGJhY2suCiB2YXIgY29uc29sZSA9IG51bGw7CiB2YXIgcHJp bnRGdWxsVGVzdERldGFpbHMgPSB0cnVlOyAvLyBUaGlzIGlzIG9wdGlvbmFseSBzd2l0Y2hlZCBv ZiBieSB0ZXN0IHdob3NlIHRlc3RlZCB2YWx1ZXMgY2FuIGRpZmZlci4gKHNlZSBkaXNhYmxlRnVs bFRlc3REZXRhaWxzUHJpbnRpbmcoKSkKIHZhciBGYWlsZWQgPSBmYWxzZTsKQEAgLTE0MCw3ICsx NDAsNyBAQCBmdW5jdGlvbiB3YWl0Rm9yRXZlbnQoZXZlbnROYW1lLCBmdW5jLCBlbmRpdCkKICAg ICAgICAgICAgIGVuZFRlc3QoKTsKICAgICB9CiAKLSAgICBtZWRpYUVsZW1lbnQuYWRkRXZlbnRM aXN0ZW5lcihldmVudE5hbWUsIF9ldmVudENhbGxiYWNrKTsKKyAgICBtZWRpYUVsZW1lbnQuYWRk RXZlbnRMaXN0ZW5lcihldmVudE5hbWUsIF9ldmVudENhbGxiYWNrLCB0cnVlKTsKIH0KIAogZnVu Y3Rpb24gd2FpdEZvckV2ZW50VGVzdEFuZEVuZChldmVudE5hbWUsIHRlc3RGdW5jU3RyaW5nKQpA QCAtMTYyLDcgKzE2Miw3IEBAIGZ1bmN0aW9uIHdhaXRGb3JFdmVudEFuZFRlc3QoZXZlbnROYW1l LCB0ZXN0RnVuY1N0cmluZywgZW5kaXQpCiAgICAgICAgICAgICBlbmRUZXN0KCk7CiAgICAgfQog Ci0gICAgbWVkaWFFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoZXZlbnROYW1lLCBfZXZlbnRDYWxs YmFjayk7CisgICAgbWVkaWFFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoZXZlbnROYW1lLCBfZXZl bnRDYWxsYmFjaywgdHJ1ZSk7CiB9CiAKIGZ1bmN0aW9uIHRlc3RFeGNlcHRpb24odGVzdFN0cmlu ZywgZXhjZXB0aW9uU3RyaW5nKQo=