<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>55339</bug_id>
          
          <creation_ts>2011-02-27 17:54:52 -0800</creation_ts>
          <short_desc>applyInlineStyleToPushDown may apply style with CSS when pushing down styles even if styleWithCSS is false</short_desc>
          <delta_ts>2023-01-10 05:02:06 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>HTML Editing</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P3</priority>
          <bug_severity>Enhancement</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>55338</dependson>
    
    <dependson>55349</dependson>
    
    <dependson>55452</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryosuke Niwa">rniwa</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ahmad.saleem792</cc>
    
    <cc>bradavogel</cc>
    
    <cc>darin</cc>
    
    <cc>enrica</cc>
    
    <cc>eric</cc>
    
    <cc>tony</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>358830</commentid>
    <comment_count>0</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-02-27 17:54:52 -0800</bug_when>
    <thetext>Currently, ApplyStyleCommand::applyInlineStyleToPushDown sets style attribute to push down styles if the node has block flow style or has children.  The following fix me corresponds to this bug:

// FIXME: applyInlineStyleToRange should be used here instead.
if ((node-&gt;renderer()-&gt;isBlockFlow() || node-&gt;childNodeCount()) &amp;&amp; node-&gt;isHTMLElement()) {
    setNodeAttribute(toHTMLElement(node), styleAttr, newInlineStyle-&gt;style()-&gt;cssText());
    return;
}</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>729963</commentid>
    <comment_count>1</comment_count>
    <who name="Brad Vogel">bradavogel</who>
    <bug_when>2012-09-27 16:00:46 -0700</bug_when>
    <thetext>My company&apos;s product - Inkling Habitat (inkling.com/habitat) - is blocked on this and would love to have it fixed!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1924375</commentid>
    <comment_count>2</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2023-01-10 05:02:06 -0800</bug_when>
    <thetext>This FIXME is still present: https://github.com/WebKit/WebKit/blob/b48ba57fb5ed3acdd4f752c85fdf4f0f9fcd8e8d/Source/WebCore/editing/ApplyStyleCommand.cpp#L1022

Although all dependent bugs have been fixed.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>